[INFO] cloning repository https://github.com/noreplydev/suiro-rs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/noreplydev/suiro-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoreplydev%2Fsuiro-rs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoreplydev%2Fsuiro-rs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 3f1ca96d1856929177b67e1c57884605d559bcbc
[INFO] linting noreplydev/suiro-rs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnoreplydev%2Fsuiro-rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/noreplydev/suiro-rs
[INFO] finished tweaking git repo https://github.com/noreplydev/suiro-rs
[INFO] tweaked toml for git repo https://github.com/noreplydev/suiro-rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/noreplydev/suiro-rs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]      Locking 111 packages to latest compatible versions
[INFO] [stderr]       Adding base64 v0.21.7 (available: v0.22.1)
[INFO] [stderr]       Adding hyper v0.14.32 (available: v1.8.1)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded uuid v1.22.0
[INFO] [stderr]   Downloaded blob-uuid v0.5.0
[INFO] [stderr]   Downloaded unique_id v0.1.7
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 5c13e1008e4b56ff25fcba5e62b84cd784553c0e5a320159672d30f20c0ea13f
[INFO] running `Command { std: "docker" "start" "-a" "5c13e1008e4b56ff25fcba5e62b84cd784553c0e5a320159672d30f20c0ea13f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "5c13e1008e4b56ff25fcba5e62b84cd784553c0e5a320159672d30f20c0ea13f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5c13e1008e4b56ff25fcba5e62b84cd784553c0e5a320159672d30f20c0ea13f", kill_on_drop: false }`
[INFO] [stdout] 5c13e1008e4b56ff25fcba5e62b84cd784553c0e5a320159672d30f20c0ea13f
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c0b1ad1b1245810eee4b7a0af3cec03c4a2c1c5318f6eecba93a0931d81cfcda
[INFO] running `Command { std: "docker" "start" "-a" "c0b1ad1b1245810eee4b7a0af3cec03c4a2c1c5318f6eecba93a0931d81cfcda", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.183
[INFO] [stderr]    Compiling proc-macro2 v1.0.106
[INFO] [stderr]    Compiling quote v1.0.45
[INFO] [stderr]    Compiling unicode-ident v1.0.24
[INFO] [stderr]     Checking pin-project-lite v0.2.17
[INFO] [stderr]     Checking futures-core v0.3.32
[INFO] [stderr]     Checking futures-sink v0.3.32
[INFO] [stderr]     Checking memchr v2.8.0
[INFO] [stderr]     Checking futures-io v0.3.32
[INFO] [stderr]    Compiling getrandom v0.4.2
[INFO] [stderr]     Checking slab v0.4.12
[INFO] [stderr]     Checking futures-channel v0.3.32
[INFO] [stderr]     Checking futures-task v0.3.32
[INFO] [stderr]     Checking once_cell v1.21.4
[INFO] [stderr]    Compiling nix v0.31.2
[INFO] [stderr]     Checking http v0.2.12
[INFO] [stderr]    Compiling zmij v1.0.21
[INFO] [stderr]    Compiling serde_core v1.0.228
[INFO] [stderr]     Checking tracing-core v0.1.36
[INFO] [stderr]     Checking base64 v0.13.1
[INFO] [stderr]     Checking bitflags v2.11.0
[INFO] [stderr]     Checking http-body v0.4.6
[INFO] [stderr]     Checking tracing v0.1.44
[INFO] [stderr]    Compiling syn v2.0.117
[INFO] [stderr]     Checking parking_lot_core v0.9.12
[INFO] [stderr]     Checking errno v0.3.14
[INFO] [stderr]     Checking socket2 v0.6.3
[INFO] [stderr]     Checking mio v1.1.1
[INFO] [stderr]     Checking signal-hook-registry v1.4.8
[INFO] [stderr]     Checking socket2 v0.5.10
[INFO] [stderr]     Checking uuid v1.22.0
[INFO] [stderr]     Checking blob-uuid v0.5.0
[INFO] [stderr]     Checking parking_lot v0.12.5
[INFO] [stderr]     Checking unique_id v0.1.7
[INFO] [stderr]     Checking ctrlc v3.5.2
[INFO] [stderr]     Checking serde_json v1.0.149
[INFO] [stderr]    Compiling futures-macro v0.3.32
[INFO] [stderr]    Compiling tokio-macros v2.6.1
[INFO] [stderr]     Checking tokio v1.50.0
[INFO] [stderr]     Checking futures-util v0.3.32
[INFO] [stderr]     Checking futures-executor v0.3.32
[INFO] [stderr]     Checking futures v0.3.32
[INFO] [stderr]     Checking tokio-util v0.7.18
[INFO] [stderr]     Checking h2 v0.3.27
[INFO] [stderr]     Checking hyper v0.14.32
[INFO] [stderr]     Checking suiro v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/core/http.rs:103:20
[INFO] [stdout]     |
[INFO] [stdout] 102 |     if body.is_ok() {
[INFO] [stdout]     |     --------------- help: try: `if let Ok(<item>) = body`
[INFO] [stdout] 103 |         let body = body.unwrap();
[INFO] [stdout]     |                    ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_some`
[INFO] [stdout]    --> src/core/http.rs:219:21
[INFO] [stdout]     |
[INFO] [stdout] 218 |     if body.is_some() {
[INFO] [stdout]     |     ----------------- help: try: `if let Some(<item>) = body`
[INFO] [stdout] 219 |         let _body = body.unwrap().to_string();
[INFO] [stdout]     |                     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/http.rs:251:5
[INFO] [stdout]     |
[INFO] [stdout] 251 |     return Ok(response);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 251 -     return Ok(response);
[INFO] [stdout] 251 +     Ok(response)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/core/http.rs:59:44
[INFO] [stdout]    |
[INFO] [stdout] 59 |     if request_path.to_string().clone() == "/".to_string() {
[INFO] [stdout]    |                                            ^^^^^^^^^^^^^^^ help: try: `"/"`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `default` to create a unit struct
[INFO] [stdout]   --> src/core/http.rs:83:22
[INFO] [stdout]    |
[INFO] [stdout] 83 |     let request_id = StringGenerator::default().next_id();
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
[INFO] [stdout]    = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
[INFO] [stdout] help: remove this call to `default`
[INFO] [stdout]    |
[INFO] [stdout] 83 -     let request_id = StringGenerator::default().next_id();
[INFO] [stdout] 83 +     let request_id = StringGenerator.next_id();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/core/http.rs:104:12
[INFO] [stdout]     |
[INFO] [stdout] 104 |         if body.len() > 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!body.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/core/http.rs:126:12
[INFO] [stdout]     |
[INFO] [stdout] 126 |     if let Err(_) = sent {
[INFO] [stdout]     |     -------^^^^^^------- help: try: `if sent.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/core/http.rs:162:29
[INFO] [stdout]     |
[INFO] [stdout] 162 |     if http_raw_response == "EPACKFRAG".to_string() {
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"EPACKFRAG"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/core/http.rs:217:5
[INFO] [stdout]     |
[INFO] [stdout] 217 |     let response: Response<Body>;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `response` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 217 ~     
[INFO] [stdout] 218 ~     let response: Response<Body> = if body.is_some() {
[INFO] [stdout] 219 |         let _body = body.unwrap().to_string();
[INFO] [stdout] ...
[INFO] [stdout] 244 |         let hyper_body = Body::from(_body);
[INFO] [stdout] 245 ~         response_builder.body(hyper_body).unwrap()
[INFO] [stdout] 246 |     } else {
[INFO] [stdout] 247 ~         response_builder.body(Body::empty()).unwrap()
[INFO] [stdout] 248 ~     };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/core/http.rs:258:8
[INFO] [stdout]     |
[INFO] [stdout] 258 |     if !referer.is_some() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^ help: try: `referer.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/http.rs:287:5
[INFO] [stdout]     |
[INFO] [stdout] 287 |     return (referer[0].clone(), "/".to_string() + &url.join("/"));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 287 -     return (referer[0].clone(), "/".to_string() + &url.join("/"));
[INFO] [stdout] 287 +     (referer[0].clone(), "/".to_string() + &url.join("/"))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/core/http.rs:277:21
[INFO] [stdout]     |
[INFO] [stdout] 277 |         .filter(|r| r != "")
[INFO] [stdout]     |                     ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!r.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]     = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/http.rs:300:5
[INFO] [stdout]     |
[INFO] [stdout] 300 | /     return match sent {
[INFO] [stdout] 301 | |         Ok(_) => Ok(()),
[INFO] [stdout] 302 | |         Err(e) => Err(e),
[INFO] [stdout] 303 | |     };
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 300 ~     match sent {
[INFO] [stdout] 301 +         Ok(_) => Ok(()),
[INFO] [stdout] 302 +         Err(e) => Err(e),
[INFO] [stdout] 303 ~     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/http.rs:332:5
[INFO] [stdout]     |
[INFO] [stdout] 332 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 332 -     return None;
[INFO] [stdout] 332 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `default` to create a unit struct
[INFO] [stdout]   --> src/core/tcp.rs:28:22
[INFO] [stdout]    |
[INFO] [stdout] 28 |     let session_id = StringGenerator::default().next_id();
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
[INFO] [stdout] help: remove this call to `default`
[INFO] [stdout]    |
[INFO] [stdout] 28 -     let session_id = StringGenerator::default().next_id();
[INFO] [stdout] 28 +     let session_id = StringGenerator.next_id();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `default` to create a unit struct
[INFO] [stdout]   --> src/core/tcp.rs:29:28
[INFO] [stdout]    |
[INFO] [stdout] 29 |     let session_endpoint = StringGenerator::default().next_id();
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
[INFO] [stdout] help: remove this call to `default`
[INFO] [stdout]    |
[INFO] [stdout] 29 -     let session_endpoint = StringGenerator::default().next_id();
[INFO] [stdout] 29 +     let session_endpoint = StringGenerator.next_id();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/core/tcp.rs:92:24
[INFO] [stdout]    |
[INFO] [stdout] 92 |                     if packet_request_id != "" {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!packet_request_id.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/core/tcp.rs:94:25
[INFO] [stdout]    |
[INFO] [stdout] 94 |                         packet_acc_size = packet_acc_size + cur_packet_data.as_bytes().len();
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_acc_size += cur_packet_data.as_bytes().len()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless call to `as_bytes`
[INFO] [stdout]   --> src/core/tcp.rs:94:61
[INFO] [stdout]    |
[INFO] [stdout] 94 |                         packet_acc_size = packet_acc_size + cur_packet_data.as_bytes().len();
[INFO] [stdout]    |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `cur_packet_data.len()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
[INFO] [stdout]    = note: `#[warn(clippy::needless_as_bytes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless call to `as_bytes`
[INFO] [stdout]    --> src/core/tcp.rs:120:39
[INFO] [stdout]     |
[INFO] [stdout] 120 |                     if packet_size == packet_data.as_bytes().len() {
[INFO] [stdout]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `packet_data.len()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless call to `as_bytes`
[INFO] [stdout]    --> src/core/tcp.rs:129:43
[INFO] [stdout]     |
[INFO] [stdout] 129 |                         packet_acc_size = packet_data.as_bytes().len();
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `packet_data.len()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/core/http.rs:103:20
[INFO] [stdout]     |
[INFO] [stdout] 102 |     if body.is_ok() {
[INFO] [stdout]     |     --------------- help: try: `if let Ok(<item>) = body`
[INFO] [stdout] 103 |         let body = body.unwrap();
[INFO] [stdout]     |                    ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_some`
[INFO] [stdout]    --> src/core/http.rs:219:21
[INFO] [stdout]     |
[INFO] [stdout] 218 |     if body.is_some() {
[INFO] [stdout]     |     ----------------- help: try: `if let Some(<item>) = body`
[INFO] [stdout] 219 |         let _body = body.unwrap().to_string();
[INFO] [stdout]     |                     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/http.rs:251:5
[INFO] [stdout]     |
[INFO] [stdout] 251 |     return Ok(response);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 251 -     return Ok(response);
[INFO] [stdout] 251 +     Ok(response)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/core/http.rs:59:44
[INFO] [stdout]    |
[INFO] [stdout] 59 |     if request_path.to_string().clone() == "/".to_string() {
[INFO] [stdout]    |                                            ^^^^^^^^^^^^^^^ help: try: `"/"`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `default` to create a unit struct
[INFO] [stdout]   --> src/core/http.rs:83:22
[INFO] [stdout]    |
[INFO] [stdout] 83 |     let request_id = StringGenerator::default().next_id();
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
[INFO] [stdout]    = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
[INFO] [stdout] help: remove this call to `default`
[INFO] [stdout]    |
[INFO] [stdout] 83 -     let request_id = StringGenerator::default().next_id();
[INFO] [stdout] 83 +     let request_id = StringGenerator.next_id();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/core/http.rs:104:12
[INFO] [stdout]     |
[INFO] [stdout] 104 |         if body.len() > 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!body.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/core/http.rs:126:12
[INFO] [stdout]     |
[INFO] [stdout] 126 |     if let Err(_) = sent {
[INFO] [stdout]     |     -------^^^^^^------- help: try: `if sent.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/core/http.rs:162:29
[INFO] [stdout]     |
[INFO] [stdout] 162 |     if http_raw_response == "EPACKFRAG".to_string() {
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"EPACKFRAG"`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/core/http.rs:217:5
[INFO] [stdout]     |
[INFO] [stdout] 217 |     let response: Response<Body>;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `response` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 217 ~     
[INFO] [stdout] 218 ~     let response: Response<Body> = if body.is_some() {
[INFO] [stdout] 219 |         let _body = body.unwrap().to_string();
[INFO] [stdout] ...
[INFO] [stdout] 244 |         let hyper_body = Body::from(_body);
[INFO] [stdout] 245 ~         response_builder.body(hyper_body).unwrap()
[INFO] [stdout] 246 |     } else {
[INFO] [stdout] 247 ~         response_builder.body(Body::empty()).unwrap()
[INFO] [stdout] 248 ~     };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/core/http.rs:258:8
[INFO] [stdout]     |
[INFO] [stdout] 258 |     if !referer.is_some() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^ help: try: `referer.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/http.rs:287:5
[INFO] [stdout]     |
[INFO] [stdout] 287 |     return (referer[0].clone(), "/".to_string() + &url.join("/"));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 287 -     return (referer[0].clone(), "/".to_string() + &url.join("/"));
[INFO] [stdout] 287 +     (referer[0].clone(), "/".to_string() + &url.join("/"))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/core/http.rs:277:21
[INFO] [stdout]     |
[INFO] [stdout] 277 |         .filter(|r| r != "")
[INFO] [stdout]     |                     ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!r.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]     = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/http.rs:300:5
[INFO] [stdout]     |
[INFO] [stdout] 300 | /     return match sent {
[INFO] [stdout] 301 | |         Ok(_) => Ok(()),
[INFO] [stdout] 302 | |         Err(e) => Err(e),
[INFO] [stdout] 303 | |     };
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 300 ~     match sent {
[INFO] [stdout] 301 +         Ok(_) => Ok(()),
[INFO] [stdout] 302 +         Err(e) => Err(e),
[INFO] [stdout] 303 ~     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/http.rs:332:5
[INFO] [stdout]     |
[INFO] [stdout] 332 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 332 -     return None;
[INFO] [stdout] 332 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `default` to create a unit struct
[INFO] [stdout]   --> src/core/tcp.rs:28:22
[INFO] [stdout]    |
[INFO] [stdout] 28 |     let session_id = StringGenerator::default().next_id();
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
[INFO] [stdout] help: remove this call to `default`
[INFO] [stdout]    |
[INFO] [stdout] 28 -     let session_id = StringGenerator::default().next_id();
[INFO] [stdout] 28 +     let session_id = StringGenerator.next_id();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `default` to create a unit struct
[INFO] [stdout]   --> src/core/tcp.rs:29:28
[INFO] [stdout]    |
[INFO] [stdout] 29 |     let session_endpoint = StringGenerator::default().next_id();
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
[INFO] [stdout] help: remove this call to `default`
[INFO] [stdout]    |
[INFO] [stdout] 29 -     let session_endpoint = StringGenerator::default().next_id();
[INFO] [stdout] 29 +     let session_endpoint = StringGenerator.next_id();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/core/tcp.rs:92:24
[INFO] [stdout]    |
[INFO] [stdout] 92 |                     if packet_request_id != "" {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!packet_request_id.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/core/tcp.rs:94:25
[INFO] [stdout]    |
[INFO] [stdout] 94 |                         packet_acc_size = packet_acc_size + cur_packet_data.as_bytes().len();
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_acc_size += cur_packet_data.as_bytes().len()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless call to `as_bytes`
[INFO] [stdout]   --> src/core/tcp.rs:94:61
[INFO] [stdout]    |
[INFO] [stdout] 94 |                         packet_acc_size = packet_acc_size + cur_packet_data.as_bytes().len();
[INFO] [stdout]    |                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `cur_packet_data.len()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
[INFO] [stdout]    = note: `#[warn(clippy::needless_as_bytes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless call to `as_bytes`
[INFO] [stdout]    --> src/core/tcp.rs:120:39
[INFO] [stdout]     |
[INFO] [stdout] 120 |                     if packet_size == packet_data.as_bytes().len() {
[INFO] [stdout]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `packet_data.len()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless call to `as_bytes`
[INFO] [stdout]    --> src/core/tcp.rs:129:43
[INFO] [stdout]     |
[INFO] [stdout] 129 |                         packet_acc_size = packet_data.as_bytes().len();
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `packet_data.len()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.20s
[INFO] running `Command { std: "docker" "inspect" "c0b1ad1b1245810eee4b7a0af3cec03c4a2c1c5318f6eecba93a0931d81cfcda", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c0b1ad1b1245810eee4b7a0af3cec03c4a2c1c5318f6eecba93a0931d81cfcda", kill_on_drop: false }`
[INFO] [stdout] c0b1ad1b1245810eee4b7a0af3cec03c4a2c1c5318f6eecba93a0931d81cfcda