[INFO] cloning repository https://github.com/nooesc/youtube-terminal [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nooesc/youtube-terminal" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnooesc%2Fyoutube-terminal", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnooesc%2Fyoutube-terminal'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 74b2368d80b8fa7926331dfc5408ea100e8af571 [INFO] linting nooesc/youtube-terminal against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnooesc%2Fyoutube-terminal" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nooesc/youtube-terminal [INFO] finished tweaking git repo https://github.com/nooesc/youtube-terminal [INFO] tweaked toml for git repo https://github.com/nooesc/youtube-terminal written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nooesc/youtube-terminal on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nooesc/youtube-terminal already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded localzone v0.3.1 [INFO] [stderr] Downloaded rquickjs v0.9.0 [INFO] [stderr] Downloaded rquickjs-core v0.9.0 [INFO] [stderr] Downloaded ress v0.11.7 [INFO] [stderr] Downloaded rustypipe v0.11.4 [INFO] [stderr] Downloaded rquickjs-sys v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f5cadc8affaa38eea571ace68d4cf89766f8ae30f4b4ff5489c2e1a1c755dec [INFO] running `Command { std: "docker" "start" "-a" "6f5cadc8affaa38eea571ace68d4cf89766f8ae30f4b4ff5489c2e1a1c755dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f5cadc8affaa38eea571ace68d4cf89766f8ae30f4b4ff5489c2e1a1c755dec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f5cadc8affaa38eea571ace68d4cf89766f8ae30f4b4ff5489c2e1a1c755dec", kill_on_drop: false }` [INFO] [stdout] 6f5cadc8affaa38eea571ace68d4cf89766f8ae30f4b4ff5489c2e1a1c755dec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64d3242bb26de4a7bda50d31a1121ee930e7b27b7134e78f8bbdc04b50679a2d [INFO] running `Command { std: "docker" "start" "-a" "64d3242bb26de4a7bda50d31a1121ee930e7b27b7134e78f8bbdc04b50679a2d", kill_on_drop: false }` [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Compiling zerocopy-derive v0.8.40 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling rquickjs-sys v0.9.0 [INFO] [stderr] Checking compression-codecs v0.4.37 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking ring v0.17.14 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking rustls v0.23.37 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking phf_shared v0.11.3 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking avif-serialize v0.8.8 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking rgb v0.8.53 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling serde_with_macros v3.17.0 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking ress v0.11.7 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking fancy-regex v0.14.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking serde_plain v1.0.2 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Checking localzone v0.3.1 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking getrandom v0.4.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking serde_with v3.17.0 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking async-compression v0.4.41 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking rquickjs-core v0.9.0 [INFO] [stderr] Checking rquickjs v0.9.0 [INFO] [stderr] Checking rustypipe v0.11.4 [INFO] [stderr] Checking youtube-terminal v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:791:25 [INFO] [stdout] | [INFO] [stdout] 791 | / if *cursor > 0 { [INFO] [stdout] 792 | | let prev = input[..*cursor] [INFO] [stdout] 793 | | .chars() [INFO] [stdout] 794 | | .last() [INFO] [stdout] ... | [INFO] [stdout] 799 | | *cursor = start; [INFO] [stdout] 800 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 790 ~ Some(PopupState::SaveSearch { ref mut input, ref mut cursor }) [INFO] [stdout] 791 ~ if *cursor > 0 => { [INFO] [stdout] 792 | let prev = input[..*cursor] [INFO] [stdout] ... [INFO] [stdout] 799 | *cursor = start; [INFO] [stdout] 800 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:803:25 [INFO] [stdout] | [INFO] [stdout] 803 | / if *cursor > 0 { [INFO] [stdout] 804 | | let prev = input[..*cursor] [INFO] [stdout] 805 | | .chars() [INFO] [stdout] 806 | | .last() [INFO] [stdout] ... | [INFO] [stdout] 811 | | *cursor = start; [INFO] [stdout] 812 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 802 ~ Some(PopupState::Rename { ref mut input, ref mut cursor, .. }) [INFO] [stdout] 803 ~ if *cursor > 0 => { [INFO] [stdout] 804 | let prev = input[..*cursor] [INFO] [stdout] ... [INFO] [stdout] 811 | *cursor = start; [INFO] [stdout] 812 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:898:17 [INFO] [stdout] | [INFO] [stdout] 898 | / if self.cards.selected_row < total - 1 { [INFO] [stdout] 899 | | self.cards.selected_row += 1; [INFO] [stdout] 900 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 897 ~ Direction::Down [INFO] [stdout] 898 ~ if self.cards.selected_row < total - 1 => { [INFO] [stdout] 899 | self.cards.selected_row += 1; [INFO] [stdout] 900 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:916:17 [INFO] [stdout] | [INFO] [stdout] 916 | / if self.saved_searches.selected < total - 1 { [INFO] [stdout] 917 | | self.saved_searches.selected += 1; [INFO] [stdout] 918 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 915 ~ Direction::Down [INFO] [stdout] 916 ~ if self.saved_searches.selected < total - 1 => { [INFO] [stdout] 917 | self.saved_searches.selected += 1; [INFO] [stdout] 918 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:934:17 [INFO] [stdout] | [INFO] [stdout] 934 | / if self.video_list.selected < total - 1 { [INFO] [stdout] 935 | | self.video_list.selected += 1; [INFO] [stdout] 936 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 933 ~ Direction::Down [INFO] [stdout] 934 ~ if self.video_list.selected < total - 1 => { [INFO] [stdout] 935 | self.video_list.selected += 1; [INFO] [stdout] 936 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:950:21 [INFO] [stdout] | [INFO] [stdout] 950 | / if detail.selected_action < max_actions - 1 { [INFO] [stdout] 951 | | detail.selected_action += 1; [INFO] [stdout] 952 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 949 ~ Direction::Down [INFO] [stdout] 950 ~ if detail.selected_action < max_actions - 1 => { [INFO] [stdout] 951 | detail.selected_action += 1; [INFO] [stdout] 952 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:967:21 [INFO] [stdout] | [INFO] [stdout] 967 | / if detail.selected_action < max_actions - 1 { [INFO] [stdout] 968 | | detail.selected_action += 1; [INFO] [stdout] 969 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 966 ~ Direction::Down [INFO] [stdout] 967 ~ if detail.selected_action < max_actions - 1 => { [INFO] [stdout] 968 | detail.selected_action += 1; [INFO] [stdout] 969 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:791:25 [INFO] [stdout] | [INFO] [stdout] 791 | / if *cursor > 0 { [INFO] [stdout] 792 | | let prev = input[..*cursor] [INFO] [stdout] 793 | | .chars() [INFO] [stdout] 794 | | .last() [INFO] [stdout] ... | [INFO] [stdout] 799 | | *cursor = start; [INFO] [stdout] 800 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 790 ~ Some(PopupState::SaveSearch { ref mut input, ref mut cursor }) [INFO] [stdout] 791 ~ if *cursor > 0 => { [INFO] [stdout] 792 | let prev = input[..*cursor] [INFO] [stdout] ... [INFO] [stdout] 799 | *cursor = start; [INFO] [stdout] 800 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:803:25 [INFO] [stdout] | [INFO] [stdout] 803 | / if *cursor > 0 { [INFO] [stdout] 804 | | let prev = input[..*cursor] [INFO] [stdout] 805 | | .chars() [INFO] [stdout] 806 | | .last() [INFO] [stdout] ... | [INFO] [stdout] 811 | | *cursor = start; [INFO] [stdout] 812 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 802 ~ Some(PopupState::Rename { ref mut input, ref mut cursor, .. }) [INFO] [stdout] 803 ~ if *cursor > 0 => { [INFO] [stdout] 804 | let prev = input[..*cursor] [INFO] [stdout] ... [INFO] [stdout] 811 | *cursor = start; [INFO] [stdout] 812 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:898:17 [INFO] [stdout] | [INFO] [stdout] 898 | / if self.cards.selected_row < total - 1 { [INFO] [stdout] 899 | | self.cards.selected_row += 1; [INFO] [stdout] 900 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 897 ~ Direction::Down [INFO] [stdout] 898 ~ if self.cards.selected_row < total - 1 => { [INFO] [stdout] 899 | self.cards.selected_row += 1; [INFO] [stdout] 900 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:916:17 [INFO] [stdout] | [INFO] [stdout] 916 | / if self.saved_searches.selected < total - 1 { [INFO] [stdout] 917 | | self.saved_searches.selected += 1; [INFO] [stdout] 918 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 915 ~ Direction::Down [INFO] [stdout] 916 ~ if self.saved_searches.selected < total - 1 => { [INFO] [stdout] 917 | self.saved_searches.selected += 1; [INFO] [stdout] 918 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:934:17 [INFO] [stdout] | [INFO] [stdout] 934 | / if self.video_list.selected < total - 1 { [INFO] [stdout] 935 | | self.video_list.selected += 1; [INFO] [stdout] 936 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 933 ~ Direction::Down [INFO] [stdout] 934 ~ if self.video_list.selected < total - 1 => { [INFO] [stdout] 935 | self.video_list.selected += 1; [INFO] [stdout] 936 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:950:21 [INFO] [stdout] | [INFO] [stdout] 950 | / if detail.selected_action < max_actions - 1 { [INFO] [stdout] 951 | | detail.selected_action += 1; [INFO] [stdout] 952 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 949 ~ Direction::Down [INFO] [stdout] 950 ~ if detail.selected_action < max_actions - 1 => { [INFO] [stdout] 951 | detail.selected_action += 1; [INFO] [stdout] 952 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app.rs:967:21 [INFO] [stdout] | [INFO] [stdout] 967 | / if detail.selected_action < max_actions - 1 { [INFO] [stdout] 968 | | detail.selected_action += 1; [INFO] [stdout] 969 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 966 ~ Direction::Down [INFO] [stdout] 967 ~ if detail.selected_action < max_actions - 1 => { [INFO] [stdout] 968 | detail.selected_action += 1; [INFO] [stdout] 969 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/player/mpv.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | / fn build_launch_args( [INFO] [stdout] 36 | | socket_path: &Path, [INFO] [stdout] 37 | | url: &str, [INFO] [stdout] 38 | | mode: PlayMode, [INFO] [stdout] ... | [INFO] [stdout] 43 | | cookie_path: Option<&Path>, [INFO] [stdout] 44 | | ) -> Vec { [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/player/mpv.rs:35:1 [INFO] [stdout] | [INFO] [stdout] 35 | / fn build_launch_args( [INFO] [stdout] 36 | | socket_path: &Path, [INFO] [stdout] 37 | | url: &str, [INFO] [stdout] 38 | | mode: PlayMode, [INFO] [stdout] ... | [INFO] [stdout] 43 | | cookie_path: Option<&Path>, [INFO] [stdout] 44 | | ) -> Vec { [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:621:21 [INFO] [stdout] | [INFO] [stdout] 621 | / if !input.is_empty() { [INFO] [stdout] 622 | | let name = input.clone(); [INFO] [stdout] 623 | | let filter = &state.search.filter; [INFO] [stdout] 624 | | match db.save_search( [INFO] [stdout] ... | [INFO] [stdout] 643 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 620 ~ Some(PopupState::SaveSearch { ref input, .. }) [INFO] [stdout] 621 ~ if !input.is_empty() => { [INFO] [stdout] 622 | let name = input.clone(); [INFO] [stdout] ... [INFO] [stdout] 642 | } [INFO] [stdout] 643 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:662:21 [INFO] [stdout] | [INFO] [stdout] 662 | / if !input.is_empty() { [INFO] [stdout] 663 | | let new_name = input.clone(); [INFO] [stdout] 664 | | match db.rename_saved_search(id, &new_name) { [INFO] [stdout] 665 | | Ok(()) => { [INFO] [stdout] ... | [INFO] [stdout] 676 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 661 ~ Some(PopupState::Rename { id, ref input, .. }) [INFO] [stdout] 662 ~ if !input.is_empty() => { [INFO] [stdout] 663 | let new_name = input.clone(); [INFO] [stdout] ... [INFO] [stdout] 675 | } [INFO] [stdout] 676 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `options` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:858:47 [INFO] [stdout] | [INFO] [stdout] 857 | let result = if options.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = options` [INFO] [stdout] 858 | provider.search_filtered(&query, &options.unwrap()).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:904:1 [INFO] [stdout] | [INFO] [stdout] 904 | / fn start_playback( [INFO] [stdout] 905 | | state: &mut AppState, [INFO] [stdout] 906 | | player: &mut MpvPlayer, [INFO] [stdout] 907 | | config: &Config, [INFO] [stdout] ... | [INFO] [stdout] 912 | | label: String, [INFO] [stdout] 913 | | ) -> anyhow::Result<()> { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:621:21 [INFO] [stdout] | [INFO] [stdout] 621 | / if !input.is_empty() { [INFO] [stdout] 622 | | let name = input.clone(); [INFO] [stdout] 623 | | let filter = &state.search.filter; [INFO] [stdout] 624 | | match db.save_search( [INFO] [stdout] ... | [INFO] [stdout] 643 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 620 ~ Some(PopupState::SaveSearch { ref input, .. }) [INFO] [stdout] 621 ~ if !input.is_empty() => { [INFO] [stdout] 622 | let name = input.clone(); [INFO] [stdout] ... [INFO] [stdout] 642 | } [INFO] [stdout] 643 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:662:21 [INFO] [stdout] | [INFO] [stdout] 662 | / if !input.is_empty() { [INFO] [stdout] 663 | | let new_name = input.clone(); [INFO] [stdout] 664 | | match db.rename_saved_search(id, &new_name) { [INFO] [stdout] 665 | | Ok(()) => { [INFO] [stdout] ... | [INFO] [stdout] 676 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 661 ~ Some(PopupState::Rename { id, ref input, .. }) [INFO] [stdout] 662 ~ if !input.is_empty() => { [INFO] [stdout] 663 | let new_name = input.clone(); [INFO] [stdout] ... [INFO] [stdout] 675 | } [INFO] [stdout] 676 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:1070:13 [INFO] [stdout] | [INFO] [stdout] 1070 | all_videos.sort_by(|a, b| b.published.cmp(&a.published)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1070 - all_videos.sort_by(|a, b| b.published.cmp(&a.published)); [INFO] [stdout] 1070 + all_videos.sort_by_key(|b| std::cmp::Reverse(b.published)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `options` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:858:47 [INFO] [stdout] | [INFO] [stdout] 857 | let result = if options.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = options` [INFO] [stdout] 858 | provider.search_filtered(&query, &options.unwrap()).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:904:1 [INFO] [stdout] | [INFO] [stdout] 904 | / fn start_playback( [INFO] [stdout] 905 | | state: &mut AppState, [INFO] [stdout] 906 | | player: &mut MpvPlayer, [INFO] [stdout] 907 | | config: &Config, [INFO] [stdout] ... | [INFO] [stdout] 912 | | label: String, [INFO] [stdout] 913 | | ) -> anyhow::Result<()> { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:1070:13 [INFO] [stdout] | [INFO] [stdout] 1070 | all_videos.sort_by(|a, b| b.published.cmp(&a.published)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1070 - all_videos.sort_by(|a, b| b.published.cmp(&a.published)); [INFO] [stdout] 1070 + all_videos.sort_by_key(|b| std::cmp::Reverse(b.published)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `Command { std: "docker" "inspect" "64d3242bb26de4a7bda50d31a1121ee930e7b27b7134e78f8bbdc04b50679a2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64d3242bb26de4a7bda50d31a1121ee930e7b27b7134e78f8bbdc04b50679a2d", kill_on_drop: false }` [INFO] [stdout] 64d3242bb26de4a7bda50d31a1121ee930e7b27b7134e78f8bbdc04b50679a2d