[INFO] cloning repository https://github.com/nomadic4life/icp_assignment [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nomadic4life/icp_assignment" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnomadic4life%2Ficp_assignment", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnomadic4life%2Ficp_assignment'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6f91781aeff3a9aeca3bf4d631a40a769293c4e1 [INFO] linting nomadic4life/icp_assignment against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnomadic4life%2Ficp_assignment" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nomadic4life/icp_assignment [INFO] finished tweaking git repo https://github.com/nomadic4life/icp_assignment [INFO] tweaked toml for git repo https://github.com/nomadic4life/icp_assignment written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nomadic4life/icp_assignment on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nomadic4life/icp_assignment already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_bytes v0.11.15 [INFO] [stderr] Downloaded stacker v0.1.15 [INFO] [stderr] Downloaded ic-cdk v0.13.2 [INFO] [stderr] Downloaded ic_principal v0.1.1 [INFO] [stderr] Downloaded pretty v0.12.3 [INFO] [stderr] Downloaded candid_derive v0.6.6 [INFO] [stderr] Downloaded candid v0.10.9 [INFO] [stderr] Downloaded psm v0.1.21 [INFO] [stderr] Downloaded ic0 v0.21.1 [INFO] [stderr] Downloaded ic-cdk-macros v0.13.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 65d3b458a583a96b9c2bf5858fd33675b6b336537359256e0cac6ad1b40e93d9 [INFO] running `Command { std: "docker" "start" "-a" "65d3b458a583a96b9c2bf5858fd33675b6b336537359256e0cac6ad1b40e93d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "65d3b458a583a96b9c2bf5858fd33675b6b336537359256e0cac6ad1b40e93d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65d3b458a583a96b9c2bf5858fd33675b6b336537359256e0cac6ad1b40e93d9", kill_on_drop: false }` [INFO] [stdout] 65d3b458a583a96b9c2bf5858fd33675b6b336537359256e0cac6ad1b40e93d9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a0335eac36443ca093d1e2dddf98d7afae93fc06337ccfbd8394c35ed623c1d [INFO] running `Command { std: "docker" "start" "-a" "4a0335eac36443ca093d1e2dddf98d7afae93fc06337ccfbd8394c35ed623c1d", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling cc v1.0.104 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling cpufeatures v0.2.12 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Compiling typed-arena v2.0.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Compiling pretty v0.12.3 [INFO] [stderr] Checking ic0 v0.21.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling psm v0.1.21 [INFO] [stderr] Compiling stacker v0.1.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling candid_derive v0.6.6 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling binread v2.2.0 [INFO] [stderr] Compiling ic_principal v0.1.1 [INFO] [stderr] Compiling serde_bytes v0.11.15 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Compiling serde_tokenstream v0.1.7 [INFO] [stderr] Compiling candid v0.10.9 [INFO] [stderr] Compiling ic-cdk-macros v0.13.2 [INFO] [stderr] Checking ic-cdk v0.13.2 [INFO] [stderr] Checking assignment_backend v0.1.0 (/opt/rustwide/workdir/src/assignment_backend) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assignment_backend/src/state.rs:128:1 [INFO] [stdout] | [INFO] [stdout] 128 | / impl Default for JobStatus { [INFO] [stdout] 129 | | fn default() -> Self { [INFO] [stdout] 130 | | Self::Open [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 113 + #[derive(Default)] [INFO] [stdout] 114 | pub enum JobStatus { [INFO] [stdout] 115 ~ #[default] [INFO] [stdout] 116 ~ Open, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assignment_backend/src/state.rs:134:1 [INFO] [stdout] | [INFO] [stdout] 134 | / impl Default for ApplicationStatus { [INFO] [stdout] 135 | | fn default() -> Self { [INFO] [stdout] 136 | | Self::Applied [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 120 + #[derive(Default)] [INFO] [stdout] 121 | pub enum ApplicationStatus { [INFO] [stdout] 122 ~ #[default] [INFO] [stdout] 123 ~ Applied, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | static JOB_ID_STORE: Cell = Cell::new(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(0) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:29:46 [INFO] [stdout] | [INFO] [stdout] 29 | static APPLICATION_ID_STORE: Cell = Cell::new(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(0) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:32:40 [INFO] [stdout] | [INFO] [stdout] 32 | static SKILL_ID_STORE: Cell = Cell::new(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(0) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if !profile_store.borrow().get(&principal_id).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `profile_store.borrow().get(&principal_id).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if !profile_store.borrow().get(&principal_id).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `profile_store.borrow().get(&principal_id).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if !profile_store.borrow().get(&principal_id).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `profile_store.borrow().get(&principal_id).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if !profile_store.borrow().get(&principal_id).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `profile_store.borrow().get(&principal_id).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assignment_backend/src/lib.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | return updated_skills; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return updated_skills; [INFO] [stdout] 140 + updated_skills [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | if !skill.id.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `skill.id.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `skill.id` after checking its variant with `is_none` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:109:43 [INFO] [stdout] | [INFO] [stdout] 108 | if !skill.id.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 109 | updated_skills.insert(skill.id.unwrap(), skill.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:475:17 [INFO] [stdout] | [INFO] [stdout] 475 | for (_, &ref skill) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 475 - for (_, &ref skill) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] 475 + for (_, skill) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:480:8 [INFO] [stdout] | [INFO] [stdout] 480 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:505:17 [INFO] [stdout] | [INFO] [stdout] 505 | for (_, &ref job) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 505 - for (_, &ref job) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] 505 + for (_, job) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:518:8 [INFO] [stdout] | [INFO] [stdout] 518 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:543:17 [INFO] [stdout] | [INFO] [stdout] 543 | for (_, &ref value) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 543 - for (_, &ref value) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] 543 + for (_, value) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:548:8 [INFO] [stdout] | [INFO] [stdout] 548 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:581:8 [INFO] [stdout] | [INFO] [stdout] 581 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:622:8 [INFO] [stdout] | [INFO] [stdout] 622 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:642:17 [INFO] [stdout] | [INFO] [stdout] 642 | for (_, &ref value) in store.borrow().range(start..) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 642 - for (_, &ref value) in store.borrow().range(start..) { [INFO] [stdout] 642 + for (_, value) in store.borrow().range(start..) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:655:8 [INFO] [stdout] | [INFO] [stdout] 655 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_some` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:675:29 [INFO] [stdout] | [INFO] [stdout] 674 | if data.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = data` [INFO] [stdout] 675 | job_list = Some(data.unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/assignment_backend/src/lib.rs:679:5 [INFO] [stdout] | [INFO] [stdout] 679 | / if job_list.is_none() { [INFO] [stdout] 680 | | return None; [INFO] [stdout] 681 | | } [INFO] [stdout] | |_____^ help: replace it with: `job_list.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:691:17 [INFO] [stdout] | [INFO] [stdout] 691 | for (_, &ref value) in store.borrow().range(start..) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 691 - for (_, &ref value) in store.borrow().range(start..) { [INFO] [stdout] 691 + for (_, value) in store.borrow().range(start..) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/assignment_backend/src/lib.rs:702:20 [INFO] [stdout] | [INFO] [stdout] 702 | if job_id.clone() == value.job_id { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*job_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assignment_backend/src/state.rs:128:1 [INFO] [stdout] | [INFO] [stdout] 128 | / impl Default for JobStatus { [INFO] [stdout] 129 | | fn default() -> Self { [INFO] [stdout] 130 | | Self::Open [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 113 + #[derive(Default)] [INFO] [stdout] 114 | pub enum JobStatus { [INFO] [stdout] 115 ~ #[default] [INFO] [stdout] 116 ~ Open, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/assignment_backend/src/state.rs:134:1 [INFO] [stdout] | [INFO] [stdout] 134 | / impl Default for ApplicationStatus { [INFO] [stdout] 135 | | fn default() -> Self { [INFO] [stdout] 136 | | Self::Applied [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 120 + #[derive(Default)] [INFO] [stdout] 121 | pub enum ApplicationStatus { [INFO] [stdout] 122 ~ #[default] [INFO] [stdout] 123 ~ Applied, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | static JOB_ID_STORE: Cell = Cell::new(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(0) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:29:46 [INFO] [stdout] | [INFO] [stdout] 29 | static APPLICATION_ID_STORE: Cell = Cell::new(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(0) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:32:40 [INFO] [stdout] | [INFO] [stdout] 32 | static SKILL_ID_STORE: Cell = Cell::new(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `const { Cell::new(0) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if !profile_store.borrow().get(&principal_id).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `profile_store.borrow().get(&principal_id).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if !profile_store.borrow().get(&principal_id).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `profile_store.borrow().get(&principal_id).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 69 | if !profile_store.borrow().get(&principal_id).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `profile_store.borrow().get(&principal_id).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if !profile_store.borrow().get(&principal_id).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `profile_store.borrow().get(&principal_id).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assignment_backend/src/lib.rs:140:5 [INFO] [stdout] | [INFO] [stdout] 140 | return updated_skills; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return updated_skills; [INFO] [stdout] 140 + updated_skills [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assignment_backend/src/lib.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 108 | if !skill.id.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `skill.id.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `skill.id` after checking its variant with `is_none` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:109:43 [INFO] [stdout] | [INFO] [stdout] 108 | if !skill.id.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 109 | updated_skills.insert(skill.id.unwrap(), skill.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:475:17 [INFO] [stdout] | [INFO] [stdout] 475 | for (_, &ref skill) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 475 - for (_, &ref skill) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] 475 + for (_, skill) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:480:8 [INFO] [stdout] | [INFO] [stdout] 480 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:505:17 [INFO] [stdout] | [INFO] [stdout] 505 | for (_, &ref job) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 505 - for (_, &ref job) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] 505 + for (_, job) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:518:8 [INFO] [stdout] | [INFO] [stdout] 518 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:543:17 [INFO] [stdout] | [INFO] [stdout] 543 | for (_, &ref value) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 543 - for (_, &ref value) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] 543 + for (_, value) in store.borrow().range((Included(&start), Included(&end))) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:548:8 [INFO] [stdout] | [INFO] [stdout] 548 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:581:8 [INFO] [stdout] | [INFO] [stdout] 581 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:622:8 [INFO] [stdout] | [INFO] [stdout] 622 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:642:17 [INFO] [stdout] | [INFO] [stdout] 642 | for (_, &ref value) in store.borrow().range(start..) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 642 - for (_, &ref value) in store.borrow().range(start..) { [INFO] [stdout] 642 + for (_, value) in store.borrow().range(start..) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/assignment_backend/src/lib.rs:655:8 [INFO] [stdout] | [INFO] [stdout] 655 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_some` [INFO] [stdout] --> src/assignment_backend/src/lib.rs:675:29 [INFO] [stdout] | [INFO] [stdout] 674 | if data.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = data` [INFO] [stdout] 675 | job_list = Some(data.unwrap().to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/assignment_backend/src/lib.rs:679:5 [INFO] [stdout] | [INFO] [stdout] 679 | / if job_list.is_none() { [INFO] [stdout] 680 | | return None; [INFO] [stdout] 681 | | } [INFO] [stdout] | |_____^ help: replace it with: `job_list.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern takes a reference on something that is being dereferenced [INFO] [stdout] --> src/assignment_backend/src/lib.rs:691:17 [INFO] [stdout] | [INFO] [stdout] 691 | for (_, &ref value) in store.borrow().range(start..) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&ref` part [INFO] [stdout] | [INFO] [stdout] 691 - for (_, &ref value) in store.borrow().range(start..) { [INFO] [stdout] 691 + for (_, value) in store.borrow().range(start..) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/assignment_backend/src/lib.rs:702:20 [INFO] [stdout] | [INFO] [stdout] 702 | if job_id.clone() == value.job_id { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*job_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 29.86s [INFO] running `Command { std: "docker" "inspect" "4a0335eac36443ca093d1e2dddf98d7afae93fc06337ccfbd8394c35ed623c1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a0335eac36443ca093d1e2dddf98d7afae93fc06337ccfbd8394c35ed623c1d", kill_on_drop: false }` [INFO] [stdout] 4a0335eac36443ca093d1e2dddf98d7afae93fc06337ccfbd8394c35ed623c1d