[INFO] cloning repository https://github.com/nirattar1/x_framework
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nirattar1/x_framework" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnirattar1%2Fx_framework", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnirattar1%2Fx_framework'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] b774a8f46979ddec12fe9807bc8f94863959b0f3
[INFO] linting nirattar1/x_framework against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnirattar1%2Fx_framework" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/nirattar1/x_framework
[INFO] finished tweaking git repo https://github.com/nirattar1/x_framework
[INFO] tweaked toml for git repo https://github.com/nirattar1/x_framework written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/nirattar1/x_framework on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/nirattar1/x_framework already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3284f8cfdfe99f0fd52e7341560ea02655bd4f08a9361010964ad7f55252d01a
[INFO] running `Command { std: "docker" "start" "-a" "3284f8cfdfe99f0fd52e7341560ea02655bd4f08a9361010964ad7f55252d01a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3284f8cfdfe99f0fd52e7341560ea02655bd4f08a9361010964ad7f55252d01a", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3284f8cfdfe99f0fd52e7341560ea02655bd4f08a9361010964ad7f55252d01a", kill_on_drop: false }`
[INFO] [stdout] 3284f8cfdfe99f0fd52e7341560ea02655bd4f08a9361010964ad7f55252d01a
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c1aeed6862682bc2c0ab15ed8840a1be3401f21c9806a85e9444337c5b769ec4
[INFO] running `Command { std: "docker" "start" "-a" "c1aeed6862682bc2c0ab15ed8840a1be3401f21c9806a85e9444337c5b769ec4", kill_on_drop: false }`
[INFO] [stderr]     Checking app_fwk v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]  --> src/xscheduler.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | / /**
[INFO] [stdout] 3 | |  * In-process job scheduler library.
[INFO] [stdout] 4 | |  *
[INFO] [stdout] 5 | |  * The client app will use this scheduler to schedule jobs.
[INFO] [stdout] 6 | |  * Jobs run in a separate (single) job thread.
[INFO] [stdout] 7 | |  */
[INFO] [stdout] 8 | |
[INFO] [stdout]   | |_^
[INFO] [stdout] 9 |   use std::thread;
[INFO] [stdout]   |   - the comment documents this `use` import
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]   = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]   = help: if the empty line is unintentional, remove it
[INFO] [stdout] help: if the comment should document the parent module use an inner doc comment
[INFO] [stdout]   |
[INFO] [stdout] 2 - /**
[INFO] [stdout] 2 + /*!
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/xscheduler.rs:36:13
[INFO] [stdout]    |
[INFO] [stdout] 36 |             delay_secs: delay_secs,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delay_secs`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/xscheduler.rs:37:13
[INFO] [stdout]    |
[INFO] [stdout] 37 |             job_cmd: job_cmd,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `job_cmd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/xscheduler.rs:38:13
[INFO] [stdout]    |
[INFO] [stdout] 38 |             job_args: job_args,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `job_args`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `xstring::XString`
[INFO] [stdout]  --> src/main.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 | use xstring::XString;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `xfile::XFile`
[INFO] [stdout]   --> src/main.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | use xfile::XFile;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `XScheduler`
[INFO] [stdout]   --> src/main.rs:11:30
[INFO] [stdout]    |
[INFO] [stdout] 11 | use xscheduler::{ JobParams, XScheduler };
[INFO] [stdout]    |                              ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]  --> src/xscheduler.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | / /**
[INFO] [stdout] 3 | |  * In-process job scheduler library.
[INFO] [stdout] 4 | |  *
[INFO] [stdout] 5 | |  * The client app will use this scheduler to schedule jobs.
[INFO] [stdout] 6 | |  * Jobs run in a separate (single) job thread.
[INFO] [stdout] 7 | |  */
[INFO] [stdout] 8 | |
[INFO] [stdout]   | |_^
[INFO] [stdout] 9 |   use std::thread;
[INFO] [stdout]   |   - the comment documents this `use` import
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]   = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]   = help: if the empty line is unintentional, remove it
[INFO] [stdout] help: if the comment should document the parent module use an inner doc comment
[INFO] [stdout]   |
[INFO] [stdout] 2 - /**
[INFO] [stdout] 2 + /*!
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/xscheduler.rs:36:13
[INFO] [stdout]    |
[INFO] [stdout] 36 |             delay_secs: delay_secs,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delay_secs`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/xscheduler.rs:37:13
[INFO] [stdout]    |
[INFO] [stdout] 37 |             job_cmd: job_cmd,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `job_cmd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/xscheduler.rs:38:13
[INFO] [stdout]    |
[INFO] [stdout] 38 |             job_args: job_args,
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `job_args`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `XScheduler`
[INFO] [stdout]   --> src/main.rs:11:30
[INFO] [stdout]    |
[INFO] [stdout] 11 | use xscheduler::{ JobParams, XScheduler };
[INFO] [stdout]    |                              ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/xstring.rs:17:9
[INFO] [stdout]    |
[INFO] [stdout] 17 |         return XString {m_buff: buf};
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 17 -         return XString {m_buff: buf};
[INFO] [stdout] 17 +         XString {m_buff: buf}
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `xstring::XString`
[INFO] [stdout]   --> src/xstring.rs:20:5
[INFO] [stdout]    |
[INFO] [stdout] 20 | /     pub fn to_string(&self) -> String {
[INFO] [stdout] 21 | |         let mut ret = String::new();
[INFO] [stdout] 22 | |         for &c in self.m_buff.iter() {
[INFO] [stdout] 23 | |             ret.push(c);
[INFO] [stdout] 24 | |         }
[INFO] [stdout] 25 | |         return ret;
[INFO] [stdout] 26 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: implement trait `Display` for type `xstring::XString` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]    = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/xstring.rs:25:9
[INFO] [stdout]    |
[INFO] [stdout] 25 |         return ret;
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 25 -         return ret;
[INFO] [stdout] 25 +         ret
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/xfile.rs:37:44
[INFO] [stdout]    |
[INFO] [stdout] 37 |     pub fn write(filename: String, buffer: &Vec<u8>) -> Result<usize, Error> {
[INFO] [stdout]    |                                            ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 37 -     pub fn write(filename: String, buffer: &Vec<u8>) -> Result<usize, Error> {
[INFO] [stdout] 37 +     pub fn write(filename: String, buffer: &[u8]) -> Result<usize, Error> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/xscheduler.rs:35:9
[INFO] [stdout]    |
[INFO] [stdout] 35 | /         return JobParams {
[INFO] [stdout] 36 | |             delay_secs: delay_secs,
[INFO] [stdout] 37 | |             job_cmd: job_cmd,
[INFO] [stdout] 38 | |             job_args: job_args,
[INFO] [stdout] 39 | |             time_for_next_run: Instant::now(),
[INFO] [stdout] 40 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 35 ~         JobParams {
[INFO] [stdout] 36 +             delay_secs: delay_secs,
[INFO] [stdout] 37 +             job_cmd: job_cmd,
[INFO] [stdout] 38 +             job_args: job_args,
[INFO] [stdout] 39 +             time_for_next_run: Instant::now(),
[INFO] [stdout] 40 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/xscheduler.rs:95:5
[INFO] [stdout]    |
[INFO] [stdout] 95 |     return (child_thread, scheduler_ptr);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 95 -     return (child_thread, scheduler_ptr);
[INFO] [stdout] 95 +     (child_thread, scheduler_ptr)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/xscheduler.rs:100:9
[INFO] [stdout]     |
[INFO] [stdout] 100 | /         return XScheduler {
[INFO] [stdout] 101 | |             m_queued_jobs: Mutex::new(Vec::new()),
[INFO] [stdout] 102 | |             m_stop_running: false,
[INFO] [stdout] 103 | |             m_runnning_jobs: Mutex::new(vec![]),
[INFO] [stdout] 104 | |         };
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 100 ~         XScheduler {
[INFO] [stdout] 101 +             m_queued_jobs: Mutex::new(Vec::new()),
[INFO] [stdout] 102 +             m_stop_running: false,
[INFO] [stdout] 103 +             m_runnning_jobs: Mutex::new(vec![]),
[INFO] [stdout] 104 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]    --> src/xscheduler.rs:162:16
[INFO] [stdout]     |
[INFO] [stdout] 162 |             if self.m_stop_running == true {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.m_stop_running`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/xstring.rs:17:9
[INFO] [stdout]    |
[INFO] [stdout] 17 |         return XString {m_buff: buf};
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 17 -         return XString {m_buff: buf};
[INFO] [stdout] 17 +         XString {m_buff: buf}
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `xstring::XString`
[INFO] [stdout]   --> src/xstring.rs:20:5
[INFO] [stdout]    |
[INFO] [stdout] 20 | /     pub fn to_string(&self) -> String {
[INFO] [stdout] 21 | |         let mut ret = String::new();
[INFO] [stdout] 22 | |         for &c in self.m_buff.iter() {
[INFO] [stdout] 23 | |             ret.push(c);
[INFO] [stdout] 24 | |         }
[INFO] [stdout] 25 | |         return ret;
[INFO] [stdout] 26 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: implement trait `Display` for type `xstring::XString` instead
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
[INFO] [stdout]    = note: `#[warn(clippy::inherent_to_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/xstring.rs:25:9
[INFO] [stdout]    |
[INFO] [stdout] 25 |         return ret;
[INFO] [stdout]    |         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 25 -         return ret;
[INFO] [stdout] 25 +         ret
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/xfile.rs:37:44
[INFO] [stdout]    |
[INFO] [stdout] 37 |     pub fn write(filename: String, buffer: &Vec<u8>) -> Result<usize, Error> {
[INFO] [stdout]    |                                            ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 37 -     pub fn write(filename: String, buffer: &Vec<u8>) -> Result<usize, Error> {
[INFO] [stdout] 37 +     pub fn write(filename: String, buffer: &[u8]) -> Result<usize, Error> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/xscheduler.rs:35:9
[INFO] [stdout]    |
[INFO] [stdout] 35 | /         return JobParams {
[INFO] [stdout] 36 | |             delay_secs: delay_secs,
[INFO] [stdout] 37 | |             job_cmd: job_cmd,
[INFO] [stdout] 38 | |             job_args: job_args,
[INFO] [stdout] 39 | |             time_for_next_run: Instant::now(),
[INFO] [stdout] 40 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 35 ~         JobParams {
[INFO] [stdout] 36 +             delay_secs: delay_secs,
[INFO] [stdout] 37 +             job_cmd: job_cmd,
[INFO] [stdout] 38 +             job_args: job_args,
[INFO] [stdout] 39 +             time_for_next_run: Instant::now(),
[INFO] [stdout] 40 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/xscheduler.rs:95:5
[INFO] [stdout]    |
[INFO] [stdout] 95 |     return (child_thread, scheduler_ptr);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 95 -     return (child_thread, scheduler_ptr);
[INFO] [stdout] 95 +     (child_thread, scheduler_ptr)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/xscheduler.rs:100:9
[INFO] [stdout]     |
[INFO] [stdout] 100 | /         return XScheduler {
[INFO] [stdout] 101 | |             m_queued_jobs: Mutex::new(Vec::new()),
[INFO] [stdout] 102 | |             m_stop_running: false,
[INFO] [stdout] 103 | |             m_runnning_jobs: Mutex::new(vec![]),
[INFO] [stdout] 104 | |         };
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 100 ~         XScheduler {
[INFO] [stdout] 101 +             m_queued_jobs: Mutex::new(Vec::new()),
[INFO] [stdout] 102 +             m_stop_running: false,
[INFO] [stdout] 103 +             m_runnning_jobs: Mutex::new(vec![]),
[INFO] [stdout] 104 ~         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]    --> src/xscheduler.rs:162:16
[INFO] [stdout]     |
[INFO] [stdout] 162 |             if self.m_stop_running == true {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.m_stop_running`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:63:13
[INFO] [stdout]    |
[INFO] [stdout] 63 |     assert!(!XFile::write(String::from("test_files/tmp.txt"), &test_data).is_err());
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `XFile::write(String::from("test_files/tmp.txt"), &test_data).is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:69:9
[INFO] [stdout]    |
[INFO] [stdout] 69 |         !XFile::read(String::from("test_files/tmp.txt"), test_data.len(), &mut read_output).is_err()
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `XFile::read(String::from("test_files/tmp.txt"), test_data.len(), &mut read_output).is_ok()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/main.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 |     assert_eq!(true, XFile::exists(String::from("test_files/1.txt")));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]    = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 58 -     assert_eq!(true, XFile::exists(String::from("test_files/1.txt")));
[INFO] [stdout] 58 +     assert!(XFile::exists(String::from("test_files/1.txt")));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]   --> src/main.rs:60:5
[INFO] [stdout]    |
[INFO] [stdout] 60 |     assert_eq!(false, XFile::exists(String::from("test_files/nonexist.txt")));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]    |
[INFO] [stdout] 60 -     assert_eq!(false, XFile::exists(String::from("test_files/nonexist.txt")));
[INFO] [stdout] 60 +     assert!(!XFile::exists(String::from("test_files/nonexist.txt")));
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.17s
[INFO] running `Command { std: "docker" "inspect" "c1aeed6862682bc2c0ab15ed8840a1be3401f21c9806a85e9444337c5b769ec4", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c1aeed6862682bc2c0ab15ed8840a1be3401f21c9806a85e9444337c5b769ec4", kill_on_drop: false }`
[INFO] [stdout] c1aeed6862682bc2c0ab15ed8840a1be3401f21c9806a85e9444337c5b769ec4