[INFO] cloning repository https://github.com/ninjubaer/module-ff [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ninjubaer/module-ff" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fninjubaer%2Fmodule-ff", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fninjubaer%2Fmodule-ff'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3ea92b228898ac2738ce2df3c46fd05ba9df14dd [INFO] linting ninjubaer/module-ff against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fninjubaer%2Fmodule-ff" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ninjubaer/module-ff [INFO] finished tweaking git repo https://github.com/ninjubaer/module-ff [INFO] tweaked toml for git repo https://github.com/ninjubaer/module-ff written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ninjubaer/module-ff on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ninjubaer/module-ff already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded battery v0.7.8 [INFO] [stderr] Downloaded nix v0.19.1 [INFO] [stderr] Downloaded uom v0.30.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 72363fd6d6f9f37a121aae7244153ee5746bf9c90b87b0fe801d2a69bbde5fa5 [INFO] running `Command { std: "docker" "start" "-a" "72363fd6d6f9f37a121aae7244153ee5746bf9c90b87b0fe801d2a69bbde5fa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "72363fd6d6f9f37a121aae7244153ee5746bf9c90b87b0fe801d2a69bbde5fa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72363fd6d6f9f37a121aae7244153ee5746bf9c90b87b0fe801d2a69bbde5fa5", kill_on_drop: false }` [INFO] [stdout] 72363fd6d6f9f37a121aae7244153ee5746bf9c90b87b0fe801d2a69bbde5fa5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9aee3e3595aba49c82253ce2b31c5aa08fbcded4585f58d48f821395d2a770aa [INFO] running `Command { std: "docker" "start" "-a" "9aee3e3595aba49c82253ce2b31c5aa08fbcded4585f58d48f821395d2a770aa", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling battery v0.7.8 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Compiling serde_json v1.0.138 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking uom v0.30.0 [INFO] [stderr] Checking ff-module v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crossterm::style::PrintStyledContent` [INFO] [stdout] --> src/modules/disks.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crossterm::style::PrintStyledContent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crossterm::style::PrintStyledContent` [INFO] [stdout] --> src/modules/disks.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crossterm::style::PrintStyledContent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config/mod.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut localappdata: String; [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/config/mod.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut localappdata: String; [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/config/mod.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn open_config() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/config/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | / std::process::Command::new("xdg-open") [INFO] [stdout] 28 | | .arg(config_file) [INFO] [stdout] 29 | | .spawn() [INFO] [stdout] 30 | | .expect("failed to open config file"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |_____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/config/mod.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn open_config() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/config/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | / std::process::Command::new("xdg-open") [INFO] [stdout] 28 | | .arg(config_file) [INFO] [stdout] 29 | | .spawn() [INFO] [stdout] 30 | | .expect("failed to open config file"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |_____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/modules/module_trait.rs:4:34 [INFO] [stdout] | [INFO] [stdout] 4 | fn handle(&mut self, module: &Vec) -> Vec>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[serde_json::Value]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `modules::memory::MemoryUnit` [INFO] [stdout] --> src/modules/memory.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn to_string(&self) -> String { [INFO] [stdout] 12 | | match self { [INFO] [stdout] 13 | | MemoryUnit::B => "B".to_string(), [INFO] [stdout] 14 | | MemoryUnit::KB => "KB".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `modules::memory::MemoryUnit` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/modules/module_trait.rs:4:34 [INFO] [stdout] | [INFO] [stdout] 4 | fn handle(&mut self, module: &Vec) -> Vec>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[serde_json::Value]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `modules::memory::MemoryUnit` [INFO] [stdout] --> src/modules/memory.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn to_string(&self) -> String { [INFO] [stdout] 12 | | match self { [INFO] [stdout] 13 | | MemoryUnit::B => "B".to_string(), [INFO] [stdout] 14 | | MemoryUnit::KB => "KB".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `modules::memory::MemoryUnit` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/battery.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | if !(self.manager.batteries().unwrap().count() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.manager.batteries().unwrap().count() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/battery.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | if !(self.manager.batteries().unwrap().count() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.manager.batteries().unwrap().count() <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HDD` contains a capitalized acronym [INFO] [stdout] --> src/modules/disks.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | HDD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Hdd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SSD` contains a capitalized acronym [INFO] [stdout] --> src/modules/disks.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | SSD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ssd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NVME` contains a capitalized acronym [INFO] [stdout] --> src/modules/disks.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | NVME, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Nvme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `modules::disks::DiskUnit` [INFO] [stdout] --> src/modules/disks.rs:23:2 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn to_string(&self) -> String { [INFO] [stdout] 24 | | match self { [INFO] [stdout] 25 | | DiskUnit::B => "B".to_string(), [INFO] [stdout] 26 | | DiskUnit::KB => "KB".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `modules::disks::DiskUnit` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HDD` contains a capitalized acronym [INFO] [stdout] --> src/modules/disks.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | HDD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Hdd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SSD` contains a capitalized acronym [INFO] [stdout] --> src/modules/disks.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | SSD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ssd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NVME` contains a capitalized acronym [INFO] [stdout] --> src/modules/disks.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | NVME, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Nvme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `modules::disks::DiskUnit` [INFO] [stdout] --> src/modules/disks.rs:23:2 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn to_string(&self) -> String { [INFO] [stdout] 24 | | match self { [INFO] [stdout] 25 | | DiskUnit::B => "B".to_string(), [INFO] [stdout] 26 | | DiskUnit::KB => "KB".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `modules::disks::DiskUnit` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `modules::disks::DiskType` [INFO] [stdout] --> src/modules/disks.rs:44:2 [INFO] [stdout] | [INFO] [stdout] 44 | / pub fn to_string(&self) -> String { [INFO] [stdout] 45 | | match self { [INFO] [stdout] 46 | | DiskType::HDD => "HDD".to_string(), [INFO] [stdout] 47 | | DiskType::SSD => "SSD".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `modules::disks::DiskType` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `modules::disks::DiskState` [INFO] [stdout] --> src/modules/disks.rs:53:2 [INFO] [stdout] | [INFO] [stdout] 53 | / pub fn to_string(&self) -> String { [INFO] [stdout] 54 | | match self { [INFO] [stdout] 55 | | DiskState::Active => "Active".to_string(), [INFO] [stdout] 56 | | DiskState::Inactive => "Inactive".to_string(), [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `modules::disks::DiskState` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `modules::disks::DiskType` [INFO] [stdout] --> src/modules/disks.rs:44:2 [INFO] [stdout] | [INFO] [stdout] 44 | / pub fn to_string(&self) -> String { [INFO] [stdout] 45 | | match self { [INFO] [stdout] 46 | | DiskType::HDD => "HDD".to_string(), [INFO] [stdout] 47 | | DiskType::SSD => "SSD".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `modules::disks::DiskType` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `modules::disks::DiskState` [INFO] [stdout] --> src/modules/disks.rs:53:2 [INFO] [stdout] | [INFO] [stdout] 53 | / pub fn to_string(&self) -> String { [INFO] [stdout] 54 | | match self { [INFO] [stdout] 55 | | DiskState::Active => "Active".to_string(), [INFO] [stdout] 56 | | DiskState::Inactive => "Inactive".to_string(), [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `modules::disks::DiskState` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | string.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `string.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 91 | if args.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | string.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `string.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 91 | if args.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:170:29 [INFO] [stdout] | [INFO] [stdout] 170 | ... &key, [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:175:29 [INFO] [stdout] | [INFO] [stdout] 175 | ... &value, [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:170:29 [INFO] [stdout] | [INFO] [stdout] 170 | ... &key, [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:175:29 [INFO] [stdout] | [INFO] [stdout] 175 | ... &value, [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.96s [INFO] running `Command { std: "docker" "inspect" "9aee3e3595aba49c82253ce2b31c5aa08fbcded4585f58d48f821395d2a770aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9aee3e3595aba49c82253ce2b31c5aa08fbcded4585f58d48f821395d2a770aa", kill_on_drop: false }` [INFO] [stdout] 9aee3e3595aba49c82253ce2b31c5aa08fbcded4585f58d48f821395d2a770aa