[INFO] cloning repository https://github.com/nines75/ac-tools-public [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nines75/ac-tools-public" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnines75%2Fac-tools-public", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnines75%2Fac-tools-public'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] db58b90f065c3d3500793e2cc2b545552c75ce0f [INFO] linting nines75/ac-tools-public against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnines75%2Fac-tools-public" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nines75/ac-tools-public [INFO] finished tweaking git repo https://github.com/nines75/ac-tools-public [INFO] tweaked toml for git repo https://github.com/nines75/ac-tools-public written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nines75/ac-tools-public on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nines75/ac-tools-public already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded shellexpand v3.1.0 [INFO] [stderr] Downloaded markup5ever v0.12.1 [INFO] [stderr] Downloaded ego-tree v0.6.3 [INFO] [stderr] Downloaded string_cache v0.8.8 [INFO] [stderr] Downloaded scraper v0.19.1 [INFO] [stderr] Downloaded windows-link v0.1.0 [INFO] [stderr] Downloaded open v5.3.2 [INFO] [stderr] Downloaded derive_more v0.99.19 [INFO] [stderr] Downloaded html5ever v0.27.0 [INFO] [stderr] Downloaded rustix v1.0.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2087d7566ebb7dbfd435955e59cd5db2ee622751dfe4eb9db2b22743b0d6ffd4 [INFO] running `Command { std: "docker" "start" "-a" "2087d7566ebb7dbfd435955e59cd5db2ee622751dfe4eb9db2b22743b0d6ffd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2087d7566ebb7dbfd435955e59cd5db2ee622751dfe4eb9db2b22743b0d6ffd4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2087d7566ebb7dbfd435955e59cd5db2ee622751dfe4eb9db2b22743b0d6ffd4", kill_on_drop: false }` [INFO] [stdout] 2087d7566ebb7dbfd435955e59cd5db2ee622751dfe4eb9db2b22743b0d6ffd4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e0041354f52850d8f3e6b1a9152b732de809c2164025ff1f90db081afd046e58 [INFO] running `Command { std: "docker" "start" "-a" "e0041354f52850d8f3e6b1a9152b732de809c2164025ff1f90db081afd046e58", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Compiling zerocopy v0.8.23 [INFO] [stderr] Compiling cc v1.2.16 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking miniz_oxide v0.8.5 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling rustix v1.0.2 [INFO] [stderr] Compiling getrandom v0.3.1 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking dtoa v1.0.10 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking linux-raw-sys v0.9.3 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling rustls v0.23.23 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking flate2 v1.1.0 [INFO] [stderr] Checking bytemuck v1.22.0 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking ego-tree v0.6.3 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Checking open v5.3.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking glob v0.3.2 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Checking image v0.25.5 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking tempfile v3.19.0 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling derive_more v0.99.19 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking arboard v3.4.1 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking clap v4.5.32 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking string_cache v0.8.8 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking scraper v0.19.1 [INFO] [stderr] Checking ac-tools-rs v3.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return Ok(()); [INFO] [stdout] 134 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/judge.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | (cmd, args_cow) = base_commands(&file_name, "oj_nodebug_all", false)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/judge.rs:30:45 [INFO] [stdout] | [INFO] [stdout] 30 | (cmd, args_cow) = base_commands(&file_name, "oj_all", false)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/judge.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | (problem_url + "\n" + &file_name).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/judge.rs:64:43 [INFO] [stdout] | [INFO] [stdout] 64 | (problem_url + "\n" + &file_name).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/judge.rs:72:56 [INFO] [stdout] | [INFO] [stdout] 72 | let testcase_str_vec: Vec<&str> = testcase_str.trim().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `testcase_str_vec.get(0)` [INFO] [stdout] --> src/judge.rs:88:24 [INFO] [stdout] | [INFO] [stdout] 88 | if re.is_match(testcase_str_vec.get(0).ok_or(IndexError)?) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `testcase_str_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return Ok(()); [INFO] [stdout] 134 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `problem_data_vec.get(problem_data_vec.len() - 1)` [INFO] [stdout] --> src/judge.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | let mut problem_data = problem_data_vec [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 104 | | .get(problem_data_vec.len() - 1) [INFO] [stdout] | |________________________________________________^ help: try: `problem_data_vec.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/judge.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | (cmd, args_cow) = base_commands(&file_name, "oj_nodebug_all", false)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/judge.rs:30:45 [INFO] [stdout] | [INFO] [stdout] 30 | (cmd, args_cow) = base_commands(&file_name, "oj_all", false)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/judge.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | (problem_url + "\n" + &file_name).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/judge.rs:131:31 [INFO] [stdout] | [INFO] [stdout] 131 | (problem_url + "\n" + &file_name).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/judge.rs:141:6 [INFO] [stdout] | [INFO] [stdout] 141 | ) -> Result<(String, Vec>), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:177:5 [INFO] [stdout] | [INFO] [stdout] 177 | return Ok((res_cmd, res_vec)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return Ok((res_cmd, res_vec)); [INFO] [stdout] 177 + Ok((res_cmd, res_vec)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/judge.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | (problem_url + "\n" + &file_name).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/judge.rs:64:43 [INFO] [stdout] | [INFO] [stdout] 64 | (problem_url + "\n" + &file_name).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/judge.rs:72:56 [INFO] [stdout] | [INFO] [stdout] 72 | let testcase_str_vec: Vec<&str> = testcase_str.trim().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/judge.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 153 | let commands_file = fs::File::open(format!("{}/setting/cpp.txt", base_path()?)) [INFO] [stdout] | _________________________^ [INFO] [stdout] 154 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("cpp.txt")))))?; [INFO] [stdout] | |___________________________________________________________________________^ help: try: `fs::File::open(format!("{}/setting/cpp.txt", base_path()?)).map_err(|_| Box::new(FileNotfoundError(Borrowed("cpp.txt"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `testcase_str_vec.get(0)` [INFO] [stdout] --> src/judge.rs:88:24 [INFO] [stdout] | [INFO] [stdout] 88 | if re.is_match(testcase_str_vec.get(0).ok_or(IndexError)?) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `testcase_str_vec.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `problem_data_vec.get(problem_data_vec.len() - 1)` [INFO] [stdout] --> src/judge.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | let mut problem_data = problem_data_vec [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 104 | | .get(problem_data_vec.len() - 1) [INFO] [stdout] | |________________________________________________^ help: try: `problem_data_vec.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return Ok(res); [INFO] [stdout] 190 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/judge.rs:181:24 [INFO] [stdout] | [INFO] [stdout] 181 | let options_file = fs::File::open(format!("{}/setting/cpp_options.txt", base_path()?)) [INFO] [stdout] | ________________________^ [INFO] [stdout] 182 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("cpp_options.txt")))))?; [INFO] [stdout] | |___________________________________________________________________________________^ help: try: `fs::File::open(format!("{}/setting/cpp_options.txt", base_path()?)).map_err(|_| Box::new(FileNotfoundError(Borrowed("cpp_options.txt"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/judge.rs:196:6 [INFO] [stdout] | [INFO] [stdout] 196 | ) -> Result<(String, Vec>), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/judge.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | (problem_url + "\n" + &file_name).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^----------^ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | return Ok((res_cmd, res_vec)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return Ok((res_cmd, res_vec)); [INFO] [stdout] 229 + Ok((res_cmd, res_vec)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/judge.rs:131:31 [INFO] [stdout] | [INFO] [stdout] 131 | (problem_url + "\n" + &file_name).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/judge.rs:141:6 [INFO] [stdout] | [INFO] [stdout] 141 | ) -> Result<(String, Vec>), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:177:5 [INFO] [stdout] | [INFO] [stdout] 177 | return Ok((res_cmd, res_vec)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return Ok((res_cmd, res_vec)); [INFO] [stdout] 177 + Ok((res_cmd, res_vec)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/judge.rs:206:23 [INFO] [stdout] | [INFO] [stdout] 206 | let header_file = fs::File::open(format!("{}/setting/cpp_header.txt", base_path()?)) [INFO] [stdout] | _______________________^ [INFO] [stdout] 207 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("cpp_header.txt")))))?; [INFO] [stdout] | |__________________________________________________________________________________^ help: try: `fs::File::open(format!("{}/setting/cpp_header.txt", base_path()?)).map_err(|_| Box::new(FileNotfoundError(Borrowed("cpp_header.txt"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/judge.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 153 | let commands_file = fs::File::open(format!("{}/setting/cpp.txt", base_path()?)) [INFO] [stdout] | _________________________^ [INFO] [stdout] 154 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("cpp.txt")))))?; [INFO] [stdout] | |___________________________________________________________________________^ help: try: `fs::File::open(format!("{}/setting/cpp.txt", base_path()?)).map_err(|_| Box::new(FileNotfoundError(Borrowed("cpp.txt"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return Ok(res); [INFO] [stdout] 190 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:249:5 [INFO] [stdout] | [INFO] [stdout] 249 | return Ok((testcase_path_str, problem_url)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 249 - return Ok((testcase_path_str, problem_url)); [INFO] [stdout] 249 + Ok((testcase_path_str, problem_url)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/judge.rs:181:24 [INFO] [stdout] | [INFO] [stdout] 181 | let options_file = fs::File::open(format!("{}/setting/cpp_options.txt", base_path()?)) [INFO] [stdout] | ________________________^ [INFO] [stdout] 182 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("cpp_options.txt")))))?; [INFO] [stdout] | |___________________________________________________________________________________^ help: try: `fs::File::open(format!("{}/setting/cpp_options.txt", base_path()?)).map_err(|_| Box::new(FileNotfoundError(Borrowed("cpp_options.txt"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | return Ok((testcase_path_str, problem_url)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return Ok((testcase_path_str, problem_url)); [INFO] [stdout] 268 + Ok((testcase_path_str, problem_url)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/judge.rs:196:6 [INFO] [stdout] | [INFO] [stdout] 196 | ) -> Result<(String, Vec>), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | return Ok((res_cmd, res_vec)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return Ok((res_cmd, res_vec)); [INFO] [stdout] 229 + Ok((res_cmd, res_vec)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/judge.rs:206:23 [INFO] [stdout] | [INFO] [stdout] 206 | let header_file = fs::File::open(format!("{}/setting/cpp_header.txt", base_path()?)) [INFO] [stdout] | _______________________^ [INFO] [stdout] 207 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("cpp_header.txt")))))?; [INFO] [stdout] | |__________________________________________________________________________________^ help: try: `fs::File::open(format!("{}/setting/cpp_header.txt", base_path()?)).map_err(|_| Box::new(FileNotfoundError(Borrowed("cpp_header.txt"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:284:5 [INFO] [stdout] | [INFO] [stdout] 284 | return Ok((testcase_path_str, problem_url)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - return Ok((testcase_path_str, problem_url)); [INFO] [stdout] 284 + Ok((testcase_path_str, problem_url)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/judge.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | let problem_url; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `problem_url` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 277 ~ [INFO] [stdout] 278 ~ let problem_url = if is_contest { [INFO] [stdout] 279 ~ format!("https://yukicoder.me/problems/{}", problem_id) [INFO] [stdout] 280 | } else { [INFO] [stdout] 281 ~ format!("https://yukicoder.me/problems/no/{}", problem_id) [INFO] [stdout] 282 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:249:5 [INFO] [stdout] | [INFO] [stdout] 249 | return Ok((testcase_path_str, problem_url)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 249 - return Ok((testcase_path_str, problem_url)); [INFO] [stdout] 249 + Ok((testcase_path_str, problem_url)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:288:5 [INFO] [stdout] | [INFO] [stdout] 288 | / return Ok(Command::new(command) [INFO] [stdout] 289 | | .args(args) [INFO] [stdout] 290 | | .stdin(Stdio::inherit()) [INFO] [stdout] 291 | | .stdout(Stdio::inherit()) [INFO] [stdout] 292 | | .stderr(Stdio::inherit()) [INFO] [stdout] 293 | | .output()?); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 ~ Ok(Command::new(command) [INFO] [stdout] 289 + .args(args) [INFO] [stdout] 290 + .stdin(Stdio::inherit()) [INFO] [stdout] 291 + .stdout(Stdio::inherit()) [INFO] [stdout] 292 + .stderr(Stdio::inherit()) [INFO] [stdout] 293 ~ .output()?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | return Ok((testcase_path_str, problem_url)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return Ok((testcase_path_str, problem_url)); [INFO] [stdout] 268 + Ok((testcase_path_str, problem_url)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:284:5 [INFO] [stdout] | [INFO] [stdout] 284 | return Ok((testcase_path_str, problem_url)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - return Ok((testcase_path_str, problem_url)); [INFO] [stdout] 284 + Ok((testcase_path_str, problem_url)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submission.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return Ok(()); [INFO] [stdout] 131 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/judge.rs:277:5 [INFO] [stdout] | [INFO] [stdout] 277 | let problem_url; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `problem_url` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 277 ~ [INFO] [stdout] 278 ~ let problem_url = if is_contest { [INFO] [stdout] 279 ~ format!("https://yukicoder.me/problems/{}", problem_id) [INFO] [stdout] 280 | } else { [INFO] [stdout] 281 ~ format!("https://yukicoder.me/problems/no/{}", problem_id) [INFO] [stdout] 282 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/judge.rs:288:5 [INFO] [stdout] | [INFO] [stdout] 288 | / return Ok(Command::new(command) [INFO] [stdout] 289 | | .args(args) [INFO] [stdout] 290 | | .stdin(Stdio::inherit()) [INFO] [stdout] 291 | | .stdout(Stdio::inherit()) [INFO] [stdout] 292 | | .stderr(Stdio::inherit()) [INFO] [stdout] 293 | | .output()?); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 ~ Ok(Command::new(command) [INFO] [stdout] 289 + .args(args) [INFO] [stdout] 290 + .stdin(Stdio::inherit()) [INFO] [stdout] 291 + .stdout(Stdio::inherit()) [INFO] [stdout] 292 + .stderr(Stdio::inherit()) [INFO] [stdout] 293 ~ .output()?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submission.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return Ok(()); [INFO] [stdout] 131 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/submission.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | / match &error { [INFO] [stdout] 74 | | ureq::Error::Status(code, res) => { [INFO] [stdout] 75 | | // issue #24: logging [INFO] [stdout] 76 | | let mut log_file = OpenOptions::new() [INFO] [stdout] ... | [INFO] [stdout] 88 | | _ => {} [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 ~ if let ureq::Error::Status(code, res) = &error { [INFO] [stdout] 74 + // issue #24: logging [INFO] [stdout] 75 + let mut log_file = OpenOptions::new() [INFO] [stdout] 76 + .append(true) [INFO] [stdout] 77 + .create(true) [INFO] [stdout] 78 + .open(format!("{}/log.txt", base_path()?))?; [INFO] [stdout] 79 + log_file.write_all((Local::now().to_string() + "\n").as_bytes())?; [INFO] [stdout] 80 + log_file.write_all((submit_url + "\n").as_bytes())?; [INFO] [stdout] 81 + log_file.write_all(token.ok_or(InvalidCookieError)?.as_bytes())?; [INFO] [stdout] 82 + log_file.write_all( [INFO] [stdout] 83 + format!("\nstatus code:{}\n{:?}\n\n", code, res).as_bytes(), [INFO] [stdout] 84 + )?; [INFO] [stdout] 85 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/submission.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | / match &error { [INFO] [stdout] 74 | | ureq::Error::Status(code, res) => { [INFO] [stdout] 75 | | // issue #24: logging [INFO] [stdout] 76 | | let mut log_file = OpenOptions::new() [INFO] [stdout] ... | [INFO] [stdout] 88 | | _ => {} [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 ~ if let ureq::Error::Status(code, res) = &error { [INFO] [stdout] 74 + // issue #24: logging [INFO] [stdout] 75 + let mut log_file = OpenOptions::new() [INFO] [stdout] 76 + .append(true) [INFO] [stdout] 77 + .create(true) [INFO] [stdout] 78 + .open(format!("{}/log.txt", base_path()?))?; [INFO] [stdout] 79 + log_file.write_all((Local::now().to_string() + "\n").as_bytes())?; [INFO] [stdout] 80 + log_file.write_all((submit_url + "\n").as_bytes())?; [INFO] [stdout] 81 + log_file.write_all(token.ok_or(InvalidCookieError)?.as_bytes())?; [INFO] [stdout] 82 + log_file.write_all( [INFO] [stdout] 83 + format!("\nstatus code:{}\n{:?}\n\n", code, res).as_bytes(), [INFO] [stdout] 84 + )?; [INFO] [stdout] 85 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submission.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | return Ok(res.ok_or(InvalidCookieError)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return Ok(res.ok_or(InvalidCookieError)?); [INFO] [stdout] 164 + Ok(res.ok_or(InvalidCookieError)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/submission.rs:135:19 [INFO] [stdout] | [INFO] [stdout] 135 | let cookies = fs::read_to_string(format!( [INFO] [stdout] | ___________________^ [INFO] [stdout] 136 | | "{}/.local/share/online-judge-tools/cookie.jar", [INFO] [stdout] 137 | | shellexpand::tilde("~") [INFO] [stdout] 138 | | )) [INFO] [stdout] 139 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("cookie.jar")))))?; [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 135 ~ let cookies = fs::read_to_string(format!( [INFO] [stdout] 136 + "{}/.local/share/online-judge-tools/cookie.jar", [INFO] [stdout] 137 + shellexpand::tilde("~") [INFO] [stdout] 138 ~ )).map_err(|_| Box::new(FileNotfoundError(Borrowed("cookie.jar"))))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submission.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | return Ok(res.ok_or(InvalidCookieError)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return Ok(res.ok_or(InvalidCookieError)?); [INFO] [stdout] 164 + Ok(res.ok_or(InvalidCookieError)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return Ok(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(path); [INFO] [stdout] 30 + Ok(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/submission.rs:135:19 [INFO] [stdout] | [INFO] [stdout] 135 | let cookies = fs::read_to_string(format!( [INFO] [stdout] | ___________________^ [INFO] [stdout] 136 | | "{}/.local/share/online-judge-tools/cookie.jar", [INFO] [stdout] 137 | | shellexpand::tilde("~") [INFO] [stdout] 138 | | )) [INFO] [stdout] 139 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("cookie.jar")))))?; [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 135 ~ let cookies = fs::read_to_string(format!( [INFO] [stdout] 136 + "{}/.local/share/online-judge-tools/cookie.jar", [INFO] [stdout] 137 + shellexpand::tilde("~") [INFO] [stdout] 138 ~ )).map_err(|_| Box::new(FileNotfoundError(Borrowed("cookie.jar"))))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / return Ok(( [INFO] [stdout] 45 | | current_dir_name [INFO] [stdout] 46 | | .to_str() [INFO] [stdout] 47 | | .ok_or(InvalidUnicodeError)? [INFO] [stdout] ... | [INFO] [stdout] 52 | | .to_string(), [INFO] [stdout] 53 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ Ok(( [INFO] [stdout] 45 + current_dir_name [INFO] [stdout] 46 + .to_str() [INFO] [stdout] 47 + .ok_or(InvalidUnicodeError)? [INFO] [stdout] 48 + .to_string(), [INFO] [stdout] 49 + parent_dir_name [INFO] [stdout] 50 + .to_str() [INFO] [stdout] 51 + .ok_or(InvalidUnicodeError)? [INFO] [stdout] 52 + .to_string(), [INFO] [stdout] 53 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return Ok(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(path); [INFO] [stdout] 30 + Ok(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return Ok(path.to_str().ok_or(InvalidUnicodeError)?.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return Ok(path.to_str().ok_or(InvalidUnicodeError)?.to_string()); [INFO] [stdout] 58 + Ok(path.to_str().ok_or(InvalidUnicodeError)?.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | Ok(val) => return Ok(val.replace("~", shellexpand::tilde("~").as_ref())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - Ok(val) => return Ok(val.replace("~", shellexpand::tilde("~").as_ref())), [INFO] [stdout] 63 + Ok(val) => Ok(val.replace("~", shellexpand::tilde("~").as_ref())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / return Ok(( [INFO] [stdout] 45 | | current_dir_name [INFO] [stdout] 46 | | .to_str() [INFO] [stdout] 47 | | .ok_or(InvalidUnicodeError)? [INFO] [stdout] ... | [INFO] [stdout] 52 | | .to_string(), [INFO] [stdout] 53 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ Ok(( [INFO] [stdout] 45 + current_dir_name [INFO] [stdout] 46 + .to_str() [INFO] [stdout] 47 + .ok_or(InvalidUnicodeError)? [INFO] [stdout] 48 + .to_string(), [INFO] [stdout] 49 + parent_dir_name [INFO] [stdout] 50 + .to_str() [INFO] [stdout] 51 + .ok_or(InvalidUnicodeError)? [INFO] [stdout] 52 + .to_string(), [INFO] [stdout] 53 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | return Err(Box::new(EnvVarError(Borrowed("AC_BASE_PATH")))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Err(Box::new(EnvVarError(Borrowed("AC_BASE_PATH")))); [INFO] [stdout] 65 + Err(Box::new(EnvVarError(Borrowed("AC_BASE_PATH")))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return Ok(path.to_str().ok_or(InvalidUnicodeError)?.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return Ok(path.to_str().ok_or(InvalidUnicodeError)?.to_string()); [INFO] [stdout] 58 + Ok(path.to_str().ok_or(InvalidUnicodeError)?.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | Ok(val) => return Ok(val.replace("~", shellexpand::tilde("~").as_ref())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - Ok(val) => return Ok(val.replace("~", shellexpand::tilde("~").as_ref())), [INFO] [stdout] 63 + Ok(val) => Ok(val.replace("~", shellexpand::tilde("~").as_ref())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | return Err(Box::new(EnvVarError(Borrowed("AC_BASE_PATH")))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return Err(Box::new(EnvVarError(Borrowed("AC_BASE_PATH")))); [INFO] [stdout] 65 + Err(Box::new(EnvVarError(Borrowed("AC_BASE_PATH")))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return Ok(res); [INFO] [stdout] 124 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return Ok(res); [INFO] [stdout] 124 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | return write!(f, "{}", res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return write!(f, "{}", res); [INFO] [stdout] 184 + write!(f, "{}", res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | return write!(f, "{}", res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 - return write!(f, "{}", res); [INFO] [stdout] 184 + write!(f, "{}", res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/judge.rs:194:16 [INFO] [stdout] | [INFO] [stdout] 194 | file_name: &str, [INFO] [stdout] | ^^^^ the lifetime is elided here [INFO] [stdout] 195 | local: bool, [INFO] [stdout] 196 | ) -> Result<(String, Vec>), Box> { [INFO] [stdout] | ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 196 | ) -> Result<(String, Vec>), Box> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/judge.rs:194:16 [INFO] [stdout] | [INFO] [stdout] 194 | file_name: &str, [INFO] [stdout] | ^^^^ the lifetime is elided here [INFO] [stdout] 195 | local: bool, [INFO] [stdout] 196 | ) -> Result<(String, Vec>), Box> { [INFO] [stdout] | ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 196 | ) -> Result<(String, Vec>), Box> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/debug.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Ok(()); [INFO] [stdout] 68 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Ok(()); [INFO] [stdout] 76 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Ok(true); [INFO] [stdout] 83 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/ac/gen.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok( [INFO] [stdout] | ________________^ [INFO] [stdout] 88 | | Warning::Overwrite(format!("{}/{}", parent_dir_name, current_dir_name)).start()?, [INFO] [stdout] 89 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 87 - return Ok( [INFO] [stdout] 88 - Warning::Overwrite(format!("{}/{}", parent_dir_name, current_dir_name)).start()?, [INFO] [stdout] 89 - ); [INFO] [stdout] 87 + return Warning::Overwrite(format!("{}/{}", parent_dir_name, current_dir_name)).start(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return Ok(()); [INFO] [stdout] 107 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ac/gen.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | for i in 'a'..('a' as u8 + num) as char { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return Ok(()); [INFO] [stdout] 160 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Ok(()); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - return Ok(()); [INFO] [stdout] 245 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:411:5 [INFO] [stdout] | [INFO] [stdout] 411 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return Ok(()); [INFO] [stdout] 411 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/debug.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Ok(()); [INFO] [stdout] 68 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `problem_data.get(0)` [INFO] [stdout] --> src/ac/gen.rs:382:37 [INFO] [stdout] | [INFO] [stdout] 382 | let contest_name_id: &str = problem_data.get(0).ok_or(IndexError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `problem_data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ac/gen.rs:414:30 [INFO] [stdout] | [INFO] [stdout] 414 | fn get_request(url: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ureq::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:418:5 [INFO] [stdout] | [INFO] [stdout] 418 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 418 - return Ok(res); [INFO] [stdout] 418 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ac/gen.rs:415:30 [INFO] [stdout] | [INFO] [stdout] 415 | let response = ureq::get(&url).call()?; [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:433:5 [INFO] [stdout] | [INFO] [stdout] 433 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - return Ok(()); [INFO] [stdout] 433 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:447:5 [INFO] [stdout] | [INFO] [stdout] 447 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - return Ok(()); [INFO] [stdout] 447 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/init.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return Ok(()); [INFO] [stdout] 23 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/nodebug.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return Ok(()); [INFO] [stdout] 16 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/precompile.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return Ok(()); [INFO] [stdout] 70 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Ok(()); [INFO] [stdout] 76 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/precompile.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Ok(()); [INFO] [stdout] 98 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Ok(true); [INFO] [stdout] 83 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/ac/gen.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 87 | return Ok( [INFO] [stdout] | ________________^ [INFO] [stdout] 88 | | Warning::Overwrite(format!("{}/{}", parent_dir_name, current_dir_name)).start()?, [INFO] [stdout] 89 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 87 - return Ok( [INFO] [stdout] 88 - Warning::Overwrite(format!("{}/{}", parent_dir_name, current_dir_name)).start()?, [INFO] [stdout] 89 - ); [INFO] [stdout] 87 + return Warning::Overwrite(format!("{}/{}", parent_dir_name, current_dir_name)).start(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/atcoder.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return Ok(()); [INFO] [stdout] 16 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return Ok(()); [INFO] [stdout] 107 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ac/gen.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | for i in 'a'..('a' as u8 + num) as char { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/codeforces.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return Ok(()); [INFO] [stdout] 15 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(()); [INFO] [stdout] 29 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Ok(()); [INFO] [stdout] 44 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return Ok(()); [INFO] [stdout] 160 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return Ok(()); [INFO] [stdout] 54 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Ok(()); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return Ok(()); [INFO] [stdout] 86 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/ac/service/contest.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 60 | let problem_file = File::open(current_dir.join("problems.txt")) [INFO] [stdout] | ________________________^ [INFO] [stdout] 61 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("problems.txt")))))?; [INFO] [stdout] | |________________________________________________________________________________^ help: try: `File::open(current_dir.join("problems.txt")).map_err(|_| Box::new(FileNotfoundError(Borrowed("problems.txt"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/ac/service/contest.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | let index = problem_alphabet [INFO] [stdout] | _________________^ [INFO] [stdout] 70 | | .chars() [INFO] [stdout] 71 | | .nth(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 69 ~ let index = problem_alphabet [INFO] [stdout] 70 + .chars().next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - return Ok(()); [INFO] [stdout] 245 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return Ok(()); [INFO] [stdout] 127 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/ac/service/contest.rs:96:24 [INFO] [stdout] | [INFO] [stdout] 96 | let problem_file = File::open(current_dir.join("virtual_problems.txt")).or_else(|_| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 97 | | Err(Box::new(FileNotfoundError(Borrowed( [INFO] [stdout] 98 | | "virtual_problems.txt", [INFO] [stdout] 99 | | )))) [INFO] [stdout] 100 | | })?; [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 96 ~ let problem_file = File::open(current_dir.join("virtual_problems.txt")).map_err(|_| Box::new(FileNotfoundError(Borrowed( [INFO] [stdout] 97 + "virtual_problems.txt", [INFO] [stdout] 98 ~ ))))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/ac/service/contest.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | let index = problem_alphabet [INFO] [stdout] | _________________^ [INFO] [stdout] 109 | | .chars() [INFO] [stdout] 110 | | .nth(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 108 ~ let index = problem_alphabet [INFO] [stdout] 109 + .chars().next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/yukicoder.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return Ok(()); [INFO] [stdout] 10 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:411:5 [INFO] [stdout] | [INFO] [stdout] 411 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return Ok(()); [INFO] [stdout] 411 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/submit.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Ok(()); [INFO] [stdout] 56 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/ac/submit.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | let problem_url; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `problem_url` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 16 ~ [INFO] [stdout] 17 | let file_name; [INFO] [stdout] 18 | // get index 0 [INFO] [stdout] 19 ~ let problem_url = match problem_file_buf.next() { [INFO] [stdout] 20 ~ Some(val) => val?, [INFO] [stdout] 21 | None => return Err(Box::new(IndexError)), [INFO] [stdout] 22 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/ac/submit.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | let file_name; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `file_name` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 17 ~ [INFO] [stdout] 18 | // get index 0 [INFO] [stdout] ... [INFO] [stdout] 23 | // get index 1 [INFO] [stdout] 24 ~ let file_name = match problem_file_buf.next() { [INFO] [stdout] 25 ~ Some(val) => val?, [INFO] [stdout] 26 | None => return Err(Box::new(IndexError)), [INFO] [stdout] 27 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `problem_data_vec.get(problem_data_vec.len() - 1)` [INFO] [stdout] --> src/ac/submit.rs:39:32 [INFO] [stdout] | [INFO] [stdout] 39 | let mut problem_data = problem_data_vec [INFO] [stdout] | ________________________________^ [INFO] [stdout] 40 | | .get(problem_data_vec.len() - 1) [INFO] [stdout] | |____________________________________________^ help: try: `problem_data_vec.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/test.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Ok(()); [INFO] [stdout] 46 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `problem_data.get(0)` [INFO] [stdout] --> src/ac/gen.rs:382:37 [INFO] [stdout] | [INFO] [stdout] 382 | let contest_name_id: &str = problem_data.get(0).ok_or(IndexError)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `problem_data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ac/testcase.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if !(parent_dir_name == "codeforces") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(parent_dir_name != "codeforces")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/testcase.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return Ok(()); [INFO] [stdout] 114 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ac/testcase.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | let cnt = fs::read_dir(&testcase_path)?.count(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `testcase_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/ac/testcase.rs:65:28 [INFO] [stdout] | [INFO] [stdout] 65 | println!("{}", "標準入力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 - println!("{}", "標準入力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] 65 + println!("標準入力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/ac/testcase.rs:74:28 [INFO] [stdout] | [INFO] [stdout] 74 | println!("{}", "標準出力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - println!("{}", "標準出力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] 74 + println!("標準出力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ac/testcase.rs:94:52 [INFO] [stdout] | [INFO] [stdout] 94 | if !testcase_path.is_dir() || fs::read_dir(&testcase_path)?.count() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `testcase_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ac/testcase.rs:98:43 [INFO] [stdout] | [INFO] [stdout] 98 | let testcase_files = fs::read_dir(&testcase_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `testcase_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ac/testcase.rs:99:37 [INFO] [stdout] | [INFO] [stdout] 99 | let cnt_str = (fs::read_dir(&testcase_path)?.count() / 2).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `testcase_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/ac/gen.rs:414:30 [INFO] [stdout] | [INFO] [stdout] 414 | fn get_request(url: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `ureq::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:418:5 [INFO] [stdout] | [INFO] [stdout] 418 | return Ok(res); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 418 - return Ok(res); [INFO] [stdout] 418 + Ok(res) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ac/gen.rs:415:30 [INFO] [stdout] | [INFO] [stdout] 415 | let response = ureq::get(&url).call()?; [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:433:5 [INFO] [stdout] | [INFO] [stdout] 433 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - return Ok(()); [INFO] [stdout] 433 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/gen.rs:447:5 [INFO] [stdout] | [INFO] [stdout] 447 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 447 - return Ok(()); [INFO] [stdout] 447 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/init.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return Ok(()); [INFO] [stdout] 23 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/nodebug.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return Ok(()); [INFO] [stdout] 16 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/precompile.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return Ok(()); [INFO] [stdout] 70 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/precompile.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Ok(()); [INFO] [stdout] 98 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/atcoder.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return Ok(()); [INFO] [stdout] 16 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/codeforces.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return Ok(()); [INFO] [stdout] 15 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(()); [INFO] [stdout] 29 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return Ok(()); [INFO] [stdout] 44 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return Ok(()); [INFO] [stdout] 54 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return Ok(()); [INFO] [stdout] 86 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/ac/service/contest.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 60 | let problem_file = File::open(current_dir.join("problems.txt")) [INFO] [stdout] | ________________________^ [INFO] [stdout] 61 | | .or_else(|_| Err(Box::new(FileNotfoundError(Borrowed("problems.txt")))))?; [INFO] [stdout] | |________________________________________________________________________________^ help: try: `File::open(current_dir.join("problems.txt")).map_err(|_| Box::new(FileNotfoundError(Borrowed("problems.txt"))))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/ac/service/contest.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | let index = problem_alphabet [INFO] [stdout] | _________________^ [INFO] [stdout] 70 | | .chars() [INFO] [stdout] 71 | | .nth(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 69 ~ let index = problem_alphabet [INFO] [stdout] 70 + .chars().next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/contest.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return Ok(()); [INFO] [stdout] 127 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/ac/service/contest.rs:96:24 [INFO] [stdout] | [INFO] [stdout] 96 | let problem_file = File::open(current_dir.join("virtual_problems.txt")).or_else(|_| { [INFO] [stdout] | ________________________^ [INFO] [stdout] 97 | | Err(Box::new(FileNotfoundError(Borrowed( [INFO] [stdout] 98 | | "virtual_problems.txt", [INFO] [stdout] 99 | | )))) [INFO] [stdout] 100 | | })?; [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 96 ~ let problem_file = File::open(current_dir.join("virtual_problems.txt")).map_err(|_| Box::new(FileNotfoundError(Borrowed( [INFO] [stdout] 97 + "virtual_problems.txt", [INFO] [stdout] 98 ~ ))))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/ac/service/contest.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | let index = problem_alphabet [INFO] [stdout] | _________________^ [INFO] [stdout] 109 | | .chars() [INFO] [stdout] 110 | | .nth(0) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 108 ~ let index = problem_alphabet [INFO] [stdout] 109 + .chars().next() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/service/yukicoder.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return Ok(()); [INFO] [stdout] 10 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/submit.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Ok(()); [INFO] [stdout] 56 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/ac/submit.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | let problem_url; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `problem_url` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 16 ~ [INFO] [stdout] 17 | let file_name; [INFO] [stdout] 18 | // get index 0 [INFO] [stdout] 19 ~ let problem_url = match problem_file_buf.next() { [INFO] [stdout] 20 ~ Some(val) => val?, [INFO] [stdout] 21 | None => return Err(Box::new(IndexError)), [INFO] [stdout] 22 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/ac/submit.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | let file_name; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `file_name` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 17 ~ [INFO] [stdout] 18 | // get index 0 [INFO] [stdout] ... [INFO] [stdout] 23 | // get index 1 [INFO] [stdout] 24 ~ let file_name = match problem_file_buf.next() { [INFO] [stdout] 25 ~ Some(val) => val?, [INFO] [stdout] 26 | None => return Err(Box::new(IndexError)), [INFO] [stdout] 27 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `problem_data_vec.get(problem_data_vec.len() - 1)` [INFO] [stdout] --> src/ac/submit.rs:39:32 [INFO] [stdout] | [INFO] [stdout] 39 | let mut problem_data = problem_data_vec [INFO] [stdout] | ________________________________^ [INFO] [stdout] 40 | | .get(problem_data_vec.len() - 1) [INFO] [stdout] | |____________________________________________^ help: try: `problem_data_vec.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/test.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Ok(()); [INFO] [stdout] 46 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ac/testcase.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if !(parent_dir_name == "codeforces") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(parent_dir_name != "codeforces")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ac/testcase.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return Ok(()); [INFO] [stdout] 114 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ac/testcase.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | let cnt = fs::read_dir(&testcase_path)?.count(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `testcase_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/ac/testcase.rs:65:28 [INFO] [stdout] | [INFO] [stdout] 65 | println!("{}", "標準入力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 - println!("{}", "標準入力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] 65 + println!("標準入力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/ac/testcase.rs:74:28 [INFO] [stdout] | [INFO] [stdout] 74 | println!("{}", "標準出力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - println!("{}", "標準出力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] 74 + println!("標準出力を入力してください(Ctrl+Dで終了)"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ac/testcase.rs:94:52 [INFO] [stdout] | [INFO] [stdout] 94 | if !testcase_path.is_dir() || fs::read_dir(&testcase_path)?.count() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `testcase_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ac/testcase.rs:98:43 [INFO] [stdout] | [INFO] [stdout] 98 | let testcase_files = fs::read_dir(&testcase_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `testcase_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ac/testcase.rs:99:37 [INFO] [stdout] | [INFO] [stdout] 99 | let cnt_str = (fs::read_dir(&testcase_path)?.count() / 2).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `testcase_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ac/ac.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | / match err { [INFO] [stdout] 238 | | Some(error) => { [INFO] [stdout] 239 | | println!("{} {:?}", Message::Error, error); [INFO] [stdout] ... | [INFO] [stdout] 242 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 ~ if let Some(error) = err { [INFO] [stdout] 238 + println!("{} {:?}", Message::Error, error); [INFO] [stdout] 239 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ac/precompile.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | let headers = vec![ [INFO] [stdout] | ___________________^ [INFO] [stdout] 21 | | "all", [INFO] [stdout] 22 | | "debug_all", [INFO] [stdout] 23 | | "nodebug_all", [INFO] [stdout] 24 | | "oj_all", [INFO] [stdout] 25 | | "oj_nodebug_all", [INFO] [stdout] 26 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 20 ~ let headers = ["all", [INFO] [stdout] 21 + "debug_all", [INFO] [stdout] 22 + "nodebug_all", [INFO] [stdout] 23 + "oj_all", [INFO] [stdout] 24 ~ "oj_nodebug_all"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ac/ac.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | / match err { [INFO] [stdout] 238 | | Some(error) => { [INFO] [stdout] 239 | | println!("{} {:?}", Message::Error, error); [INFO] [stdout] ... | [INFO] [stdout] 242 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 237 ~ if let Some(error) = err { [INFO] [stdout] 238 + println!("{} {:?}", Message::Error, error); [INFO] [stdout] 239 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/ac/precompile.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | let headers = vec![ [INFO] [stdout] | ___________________^ [INFO] [stdout] 21 | | "all", [INFO] [stdout] 22 | | "debug_all", [INFO] [stdout] 23 | | "nodebug_all", [INFO] [stdout] 24 | | "oj_all", [INFO] [stdout] 25 | | "oj_nodebug_all", [INFO] [stdout] 26 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 20 ~ let headers = ["all", [INFO] [stdout] 21 + "debug_all", [INFO] [stdout] 22 + "nodebug_all", [INFO] [stdout] 23 + "oj_all", [INFO] [stdout] 24 ~ "oj_nodebug_all"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 41.73s [INFO] running `Command { std: "docker" "inspect" "e0041354f52850d8f3e6b1a9152b732de809c2164025ff1f90db081afd046e58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0041354f52850d8f3e6b1a9152b732de809c2164025ff1f90db081afd046e58", kill_on_drop: false }` [INFO] [stdout] e0041354f52850d8f3e6b1a9152b732de809c2164025ff1f90db081afd046e58