[INFO] cloning repository https://github.com/nikolabr/tetrust
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nikolabr/tetrust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnikolabr%2Ftetrust", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnikolabr%2Ftetrust'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 7aca2ef77f36bef3d618b33fd6800cd6fb27b8f1
[INFO] linting nikolabr/tetrust against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnikolabr%2Ftetrust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/nikolabr/tetrust
[INFO] finished tweaking git repo https://github.com/nikolabr/tetrust
[INFO] tweaked toml for git repo https://github.com/nikolabr/tetrust written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/nikolabr/tetrust on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/nikolabr/tetrust already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded sdl2 v0.35.1
[INFO] [stderr]   Downloaded sdl2-sys v0.35.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 162c7e665628a6ba3df115bda19e75dde56175c7ede17605ab6617d9b755d0d3
[INFO] running `Command { std: "docker" "start" "-a" "162c7e665628a6ba3df115bda19e75dde56175c7ede17605ab6617d9b755d0d3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "162c7e665628a6ba3df115bda19e75dde56175c7ede17605ab6617d9b755d0d3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "162c7e665628a6ba3df115bda19e75dde56175c7ede17605ab6617d9b755d0d3", kill_on_drop: false }`
[INFO] [stdout] 162c7e665628a6ba3df115bda19e75dde56175c7ede17605ab6617d9b755d0d3
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 02a463008bedc20ddc05229ccaef64bfde5f6102eab70641ab900d70ce372aa4
[INFO] running `Command { std: "docker" "start" "-a" "02a463008bedc20ddc05229ccaef64bfde5f6102eab70641ab900d70ce372aa4", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.106
[INFO] [stderr]    Compiling version-compare v0.1.0
[INFO] [stderr]    Compiling sdl2 v0.35.1
[INFO] [stderr]     Checking ppv-lite86 v0.2.15
[INFO] [stderr]    Compiling sdl2-sys v0.35.1
[INFO] [stderr]     Checking getrandom v0.2.3
[INFO] [stderr]     Checking rand_core v0.6.3
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.4
[INFO] [stderr]     Checking tetrust v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused imports: `Distribution` and `Standard`
[INFO] [stdout]  --> src/main.rs:4:27
[INFO] [stdout]   |
[INFO] [stdout] 4 | use rand::distributions::{Distribution, Standard};
[INFO] [stdout]   |                           ^^^^^^^^^^^^  ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused imports: `Distribution` and `Standard`
[INFO] [stdout]  --> src/main.rs:4:27
[INFO] [stdout]   |
[INFO] [stdout] 4 | use rand::distributions::{Distribution, Standard};
[INFO] [stdout]   |                           ^^^^^^^^^^^^  ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: module has the same name as its containing module
[INFO] [stdout]    --> src/tetrust.rs:1:1
[INFO] [stdout]     |
[INFO] [stdout]   1 | / pub mod tetrust {
[INFO] [stdout]   2 | |     use rand::{
[INFO] [stdout]   3 | |         distributions::{Distribution, Standard},
[INFO] [stdout]   4 | |         Rng,
[INFO] [stdout] ...   |
[INFO] [stdout] 493 | | }
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stdout]     = note: `#[warn(clippy::module_inception)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/tetrust.rs:131:53
[INFO] [stdout]     |
[INFO] [stdout] 131 |         pub fn rot(state: u8, piece: &PieceEnum) -> (Vec<(u8, u8)>, Vec<(u8, u8)>) {
[INFO] [stdout]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]     = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: module has the same name as its containing module
[INFO] [stdout]    --> src/tetrust.rs:1:1
[INFO] [stdout]     |
[INFO] [stdout]   1 | / pub mod tetrust {
[INFO] [stdout]   2 | |     use rand::{
[INFO] [stdout]   3 | |         distributions::{Distribution, Standard},
[INFO] [stdout]   4 | |         Rng,
[INFO] [stdout] ...   |
[INFO] [stdout] 493 | | }
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stdout]     = note: `#[warn(clippy::module_inception)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]    --> src/tetrust.rs:245:16
[INFO] [stdout]     |
[INFO] [stdout] 245 |             if self.tiles[x_c][y_c].1 == true {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.tiles[x_c][y_c].1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]    --> src/tetrust.rs:351:13
[INFO] [stdout]     |
[INFO] [stdout] 351 | /             if tile.is_some() && tile.unwrap().0 != TileColor::Empty && o_tile.is_some() && o_tile.unwrap().0 == TileColor::Empty {
[INFO] [stdout] 352 | |                 true 
[INFO] [stdout] 353 | |             }
[INFO] [stdout] 354 | |             else {
[INFO] [stdout] 355 | |                 false
[INFO] [stdout] 356 | |             }
[INFO] [stdout]     | |_____________^ help: you can reduce it to: `tile.is_some() && tile.unwrap().0 != TileColor::Empty && o_tile.is_some() && o_tile.unwrap().0 == TileColor::Empty`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stdout]    --> src/tetrust.rs:131:53
[INFO] [stdout]     |
[INFO] [stdout] 131 |         pub fn rot(state: u8, piece: &PieceEnum) -> (Vec<(u8, u8)>, Vec<(u8, u8)>) {
[INFO] [stdout]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stdout]     = note: `#[warn(clippy::type_complexity)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/tetrust.rs:394:16
[INFO] [stdout]     |
[INFO] [stdout] 394 |             if !(x > 0 && p.x + (4 - p.buf.1) > TILE_CANVAS_WIDTH - 3) && !(x < 0 && p.x + p.buf.0 < 3) && !(self.check_horizontal_...
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(x > 0 && p.x + (4 - p.buf.1) > TILE_CANVAS_WIDTH - 3 || x < 0 && p.x + p.buf.0 < 3)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/tetrust.rs:451:28
[INFO] [stdout]     |
[INFO] [stdout] 451 |                     if let Some(..) = self.tile_canvas.get_tile(p.x + i, p.y + j) {
[INFO] [stdout]     |                     -------^^^^^^^^---------------------------------------------- help: try: `if self.tile_canvas.get_tile(p.x + i, p.y + j).is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/tetrust.rs:474:13
[INFO] [stdout]     |
[INFO] [stdout] 474 |             Ok(self.move_piece(0, 1)?)
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]     = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 474 -             Ok(self.move_piece(0, 1)?)
[INFO] [stdout] 474 +             self.move_piece(0, 1)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]    --> src/tetrust.rs:245:16
[INFO] [stdout]     |
[INFO] [stdout] 245 |             if self.tiles[x_c][y_c].1 == true {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.tiles[x_c][y_c].1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/main.rs:64:21
[INFO] [stdout]    |
[INFO] [stdout] 64 | /                     if tetris.rotate_piece()? == true {
[INFO] [stdout] 65 | |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 66 | |                     }
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 63 ~                 Event::KeyDown{keycode: Some(Keycode::Up), ..} 
[INFO] [stdout] 64 ~                     if tetris.rotate_piece()? == true => {
[INFO] [stdout] 65 |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 66 ~                     },
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/main.rs:69:21
[INFO] [stdout]    |
[INFO] [stdout] 69 | /                     if tetris.update_screen()? == true {
[INFO] [stdout] 70 | |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 71 | |                     };
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 68 ~                 Event::KeyDown{keycode: Some(Keycode::Down), ..}
[INFO] [stdout] 69 ~                     if tetris.update_screen()? == true => {
[INFO] [stdout] 70 |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 71 ~                     };,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/main.rs:74:21
[INFO] [stdout]    |
[INFO] [stdout] 74 | /                     if tetris.move_piece(1, 0)? == true {
[INFO] [stdout] 75 | |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 76 | |                     };
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 73 ~                 Event::KeyDown{keycode: Some(Keycode::Right), ..}
[INFO] [stdout] 74 ~                     if tetris.move_piece(1, 0)? == true => {
[INFO] [stdout] 75 |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 76 ~                     };,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/main.rs:80:21
[INFO] [stdout]    |
[INFO] [stdout] 80 | /                     if tetris.move_piece(-1, 0)? == true {
[INFO] [stdout] 81 | |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 82 | |                     };
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 79 ~                 Event::KeyDown{keycode: Some(Keycode::Left), ..}
[INFO] [stdout] 80 ~                     if tetris.move_piece(-1, 0)? == true => {
[INFO] [stdout] 81 |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 82 ~                     };,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:64:24
[INFO] [stdout]    |
[INFO] [stdout] 64 |                     if tetris.rotate_piece()? == true {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.rotate_piece()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:69:24
[INFO] [stdout]    |
[INFO] [stdout] 69 |                     if tetris.update_screen()? == true {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.update_screen()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression returns a bool literal
[INFO] [stdout]    --> src/tetrust.rs:351:13
[INFO] [stdout]     |
[INFO] [stdout] 351 | /             if tile.is_some() && tile.unwrap().0 != TileColor::Empty && o_tile.is_some() && o_tile.unwrap().0 == TileColor::Empty {
[INFO] [stdout] 352 | |                 true 
[INFO] [stdout] 353 | |             }
[INFO] [stdout] 354 | |             else {
[INFO] [stdout] 355 | |                 false
[INFO] [stdout] 356 | |             }
[INFO] [stdout]     | |_____________^ help: you can reduce it to: `tile.is_some() && tile.unwrap().0 != TileColor::Empty && o_tile.is_some() && o_tile.unwrap().0 == TileColor::Empty`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:74:24
[INFO] [stdout]    |
[INFO] [stdout] 74 |                     if tetris.move_piece(1, 0)? == true {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.move_piece(1, 0)?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:80:24
[INFO] [stdout]    |
[INFO] [stdout] 80 |                     if tetris.move_piece(-1, 0)? == true {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.move_piece(-1, 0)?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:94:16
[INFO] [stdout]    |
[INFO] [stdout] 94 |             if tetris.check_loss() == true { 
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.check_loss()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:98:16
[INFO] [stdout]    |
[INFO] [stdout] 98 |             if tetris.update_screen()? == true {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.update_screen()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/tetrust.rs:394:16
[INFO] [stdout]     |
[INFO] [stdout] 394 |             if !(x > 0 && p.x + (4 - p.buf.1) > TILE_CANVAS_WIDTH - 3) && !(x < 0 && p.x + p.buf.0 < 3) && !(self.check_horizontal_...
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(x > 0 && p.x + (4 - p.buf.1) > TILE_CANVAS_WIDTH - 3 || x < 0 && p.x + p.buf.0 < 3)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing
[INFO] [stdout]    --> src/tetrust.rs:229:98
[INFO] [stdout]     |
[INFO] [stdout] 229 |         pub fn new(tile_canvas: sdl2::render::Canvas<Window>, tile_textures: TileTexture<'t>) -> TileCanvas {
[INFO] [stdout]     |                                                                                          --      ^^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                                                                                          |
[INFO] [stdout]     |                                                                                          the lifetime is named here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: consistently use `'t`
[INFO] [stdout]     |
[INFO] [stdout] 229 |         pub fn new(tile_canvas: sdl2::render::Canvas<Window>, tile_textures: TileTexture<'t>) -> TileCanvas<'t> {
[INFO] [stdout]     |                                                                                                            ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/tetrust.rs:451:28
[INFO] [stdout]     |
[INFO] [stdout] 451 |                     if let Some(..) = self.tile_canvas.get_tile(p.x + i, p.y + j) {
[INFO] [stdout]     |                     -------^^^^^^^^---------------------------------------------- help: try: `if self.tile_canvas.get_tile(p.x + i, p.y + j).is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/tetrust.rs:474:13
[INFO] [stdout]     |
[INFO] [stdout] 474 |             Ok(self.move_piece(0, 1)?)
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]     = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 474 -             Ok(self.move_piece(0, 1)?)
[INFO] [stdout] 474 +             self.move_piece(0, 1)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/main.rs:64:21
[INFO] [stdout]    |
[INFO] [stdout] 64 | /                     if tetris.rotate_piece()? == true {
[INFO] [stdout] 65 | |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 66 | |                     }
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 63 ~                 Event::KeyDown{keycode: Some(Keycode::Up), ..} 
[INFO] [stdout] 64 ~                     if tetris.rotate_piece()? == true => {
[INFO] [stdout] 65 |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 66 ~                     },
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/main.rs:69:21
[INFO] [stdout]    |
[INFO] [stdout] 69 | /                     if tetris.update_screen()? == true {
[INFO] [stdout] 70 | |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 71 | |                     };
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 68 ~                 Event::KeyDown{keycode: Some(Keycode::Down), ..}
[INFO] [stdout] 69 ~                     if tetris.update_screen()? == true => {
[INFO] [stdout] 70 |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 71 ~                     };,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/main.rs:74:21
[INFO] [stdout]    |
[INFO] [stdout] 74 | /                     if tetris.move_piece(1, 0)? == true {
[INFO] [stdout] 75 | |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 76 | |                     };
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 73 ~                 Event::KeyDown{keycode: Some(Keycode::Right), ..}
[INFO] [stdout] 74 ~                     if tetris.move_piece(1, 0)? == true => {
[INFO] [stdout] 75 |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 76 ~                     };,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]   --> src/main.rs:80:21
[INFO] [stdout]    |
[INFO] [stdout] 80 | /                     if tetris.move_piece(-1, 0)? == true {
[INFO] [stdout] 81 | |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 82 | |                     };
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 79 ~                 Event::KeyDown{keycode: Some(Keycode::Left), ..}
[INFO] [stdout] 80 ~                     if tetris.move_piece(-1, 0)? == true => {
[INFO] [stdout] 81 |                         tetris_collision(&mut tetris, rng.gen_range(2..TILE_CANVAS_WIDTH - 5))?;
[INFO] [stdout] 82 ~                     };,
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:64:24
[INFO] [stdout]    |
[INFO] [stdout] 64 |                     if tetris.rotate_piece()? == true {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.rotate_piece()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:69:24
[INFO] [stdout]    |
[INFO] [stdout] 69 |                     if tetris.update_screen()? == true {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.update_screen()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:74:24
[INFO] [stdout]    |
[INFO] [stdout] 74 |                     if tetris.move_piece(1, 0)? == true {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.move_piece(1, 0)?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:80:24
[INFO] [stdout]    |
[INFO] [stdout] 80 |                     if tetris.move_piece(-1, 0)? == true {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.move_piece(-1, 0)?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:94:16
[INFO] [stdout]    |
[INFO] [stdout] 94 |             if tetris.check_loss() == true { 
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.check_loss()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]   --> src/main.rs:98:16
[INFO] [stdout]    |
[INFO] [stdout] 98 |             if tetris.update_screen()? == true {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tetris.update_screen()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing
[INFO] [stdout]    --> src/tetrust.rs:229:98
[INFO] [stdout]     |
[INFO] [stdout] 229 |         pub fn new(tile_canvas: sdl2::render::Canvas<Window>, tile_textures: TileTexture<'t>) -> TileCanvas {
[INFO] [stdout]     |                                                                                          --      ^^^^^^^^^^ the same lifetime is hidden here
[INFO] [stdout]     |                                                                                          |
[INFO] [stdout]     |                                                                                          the lifetime is named here
[INFO] [stdout]     |
[INFO] [stdout]     = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
[INFO] [stdout]     = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
[INFO] [stdout] help: consistently use `'t`
[INFO] [stdout]     |
[INFO] [stdout] 229 |         pub fn new(tile_canvas: sdl2::render::Canvas<Window>, tile_textures: TileTexture<'t>) -> TileCanvas<'t> {
[INFO] [stdout]     |                                                                                                            ++++
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.47s
[INFO] running `Command { std: "docker" "inspect" "02a463008bedc20ddc05229ccaef64bfde5f6102eab70641ab900d70ce372aa4", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "02a463008bedc20ddc05229ccaef64bfde5f6102eab70641ab900d70ce372aa4", kill_on_drop: false }`
[INFO] [stdout] 02a463008bedc20ddc05229ccaef64bfde5f6102eab70641ab900d70ce372aa4