[INFO] cloning repository https://github.com/nikolaanicic/pidaj_tsp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nikolaanicic/pidaj_tsp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnikolaanicic%2Fpidaj_tsp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnikolaanicic%2Fpidaj_tsp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e5ba6f955c9e081da5c08708594ecf3c6bc098d8 [INFO] linting nikolaanicic/pidaj_tsp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnikolaanicic%2Fpidaj_tsp" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nikolaanicic/pidaj_tsp [INFO] finished tweaking git repo https://github.com/nikolaanicic/pidaj_tsp [INFO] tweaked toml for git repo https://github.com/nikolaanicic/pidaj_tsp written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nikolaanicic/pidaj_tsp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nikolaanicic/pidaj_tsp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c5b67cec810842be21f923dd5619d6f45879e55ba6ae32a646e6239ab0f713a [INFO] running `Command { std: "docker" "start" "-a" "6c5b67cec810842be21f923dd5619d6f45879e55ba6ae32a646e6239ab0f713a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c5b67cec810842be21f923dd5619d6f45879e55ba6ae32a646e6239ab0f713a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c5b67cec810842be21f923dd5619d6f45879e55ba6ae32a646e6239ab0f713a", kill_on_drop: false }` [INFO] [stdout] 6c5b67cec810842be21f923dd5619d6f45879e55ba6ae32a646e6239ab0f713a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1487fc840db65b9184aeef7c2322f97be50a675ea713925f41da289c0179bc3 [INFO] running `Command { std: "docker" "start" "-a" "c1487fc840db65b9184aeef7c2322f97be50a675ea713925f41da289c0179bc3", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking csv-core v0.1.12 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking projekat_2025 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graph.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | graph.entry(start_location.clone()).or_insert(HashMap::new()).insert(end_location.clone(), distance); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graph.rs:43:39 [INFO] [stdout] | [INFO] [stdout] 43 | graph.entry(end_location.clone()).or_insert(HashMap::new()).insert(start_location.clone(), distance); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | while !g.get(&route[route.len() - 1]) [INFO] [stdout] | ___________^ [INFO] [stdout] 13 | | .and_then(|neighbors| neighbors.get(&route[0])) [INFO] [stdout] 14 | | .is_some() { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 12 ~ while g.get(&route[route.len() - 1]) [INFO] [stdout] 13 ~ .and_then(|neighbors| neighbors.get(&route[0])).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !g.get(&route[prev(i)]) [INFO] [stdout] | ________^ [INFO] [stdout] 35 | | .and_then(|nbrs| nbrs.get(city_i)) [INFO] [stdout] 36 | | .is_some() { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 ~ if g.get(&route[prev(i)]) [INFO] [stdout] 35 ~ .and_then(|nbrs| nbrs.get(city_i)).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if !g.get(city_i) [INFO] [stdout] | ________^ [INFO] [stdout] 40 | | .and_then(|nbrs| nbrs.get(&route[next(i)])) [INFO] [stdout] 41 | | .is_some() { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 ~ if g.get(city_i) [INFO] [stdout] 40 ~ .and_then(|nbrs| nbrs.get(&route[next(i)])).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if !g.get(&route[prev(j)]) [INFO] [stdout] | ________^ [INFO] [stdout] 47 | | .and_then(|nbrs| nbrs.get(city_j)) [INFO] [stdout] 48 | | .is_some() { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ if g.get(&route[prev(j)]) [INFO] [stdout] 47 ~ .and_then(|nbrs| nbrs.get(city_j)).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | if !g.get(city_j) [INFO] [stdout] | ________^ [INFO] [stdout] 52 | | .and_then(|nbrs| nbrs.get(&route[next(j)])) [INFO] [stdout] 53 | | .is_some() { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ if g.get(city_j) [INFO] [stdout] 52 ~ .and_then(|nbrs| nbrs.get(&route[next(j)])).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tsp.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 22 | fn is_swap_valid(route: &Vec>, g: &Graph, i: usize, j: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - fn is_swap_valid(route: &Vec>, g: &Graph, i: usize, j: usize) -> bool { [INFO] [stdout] 22 + fn is_swap_valid(route: &[Arc], g: &Graph, i: usize, j: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tsp.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | fn distance(route: &Vec>, g: &Graph) -> i32{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 97 - fn distance(route: &Vec>, g: &Graph) -> i32{ [INFO] [stdout] 97 + fn distance(route: &[Arc], g: &Graph) -> i32{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | let mut best_distance = std::i32::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 40 - let mut best_distance = std::i32::MAX; [INFO] [stdout] 40 + let mut best_distance = i32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graph.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | graph.entry(start_location.clone()).or_insert(HashMap::new()).insert(end_location.clone(), distance); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graph.rs:43:39 [INFO] [stdout] | [INFO] [stdout] 43 | graph.entry(end_location.clone()).or_insert(HashMap::new()).insert(start_location.clone(), distance); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:12:11 [INFO] [stdout] | [INFO] [stdout] 12 | while !g.get(&route[route.len() - 1]) [INFO] [stdout] | ___________^ [INFO] [stdout] 13 | | .and_then(|neighbors| neighbors.get(&route[0])) [INFO] [stdout] 14 | | .is_some() { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 12 ~ while g.get(&route[route.len() - 1]) [INFO] [stdout] 13 ~ .and_then(|neighbors| neighbors.get(&route[0])).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !g.get(&route[prev(i)]) [INFO] [stdout] | ________^ [INFO] [stdout] 35 | | .and_then(|nbrs| nbrs.get(city_i)) [INFO] [stdout] 36 | | .is_some() { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 ~ if g.get(&route[prev(i)]) [INFO] [stdout] 35 ~ .and_then(|nbrs| nbrs.get(city_i)).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if !g.get(city_i) [INFO] [stdout] | ________^ [INFO] [stdout] 40 | | .and_then(|nbrs| nbrs.get(&route[next(i)])) [INFO] [stdout] 41 | | .is_some() { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 ~ if g.get(city_i) [INFO] [stdout] 40 ~ .and_then(|nbrs| nbrs.get(&route[next(i)])).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if !g.get(&route[prev(j)]) [INFO] [stdout] | ________^ [INFO] [stdout] 47 | | .and_then(|nbrs| nbrs.get(city_j)) [INFO] [stdout] 48 | | .is_some() { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ if g.get(&route[prev(j)]) [INFO] [stdout] 47 ~ .and_then(|nbrs| nbrs.get(city_j)).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsp.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | if !g.get(city_j) [INFO] [stdout] | ________^ [INFO] [stdout] 52 | | .and_then(|nbrs| nbrs.get(&route[next(j)])) [INFO] [stdout] 53 | | .is_some() { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 51 ~ if g.get(city_j) [INFO] [stdout] 52 ~ .and_then(|nbrs| nbrs.get(&route[next(j)])).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tsp.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 22 | fn is_swap_valid(route: &Vec>, g: &Graph, i: usize, j: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - fn is_swap_valid(route: &Vec>, g: &Graph, i: usize, j: usize) -> bool { [INFO] [stdout] 22 + fn is_swap_valid(route: &[Arc], g: &Graph, i: usize, j: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/tsp.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | fn distance(route: &Vec>, g: &Graph) -> i32{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 97 - fn distance(route: &Vec>, g: &Graph) -> i32{ [INFO] [stdout] 97 + fn distance(route: &[Arc], g: &Graph) -> i32{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | let mut best_distance = std::i32::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 40 - let mut best_distance = std::i32::MAX; [INFO] [stdout] 40 + let mut best_distance = i32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.16s [INFO] running `Command { std: "docker" "inspect" "c1487fc840db65b9184aeef7c2322f97be50a675ea713925f41da289c0179bc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1487fc840db65b9184aeef7c2322f97be50a675ea713925f41da289c0179bc3", kill_on_drop: false }` [INFO] [stdout] c1487fc840db65b9184aeef7c2322f97be50a675ea713925f41da289c0179bc3