[INFO] cloning repository https://github.com/nicolascrop/aoc2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nicolascrop/aoc2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnicolascrop%2Faoc2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnicolascrop%2Faoc2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5eedd048d3f8f2a529d801b18187fde9b4423f64 [INFO] linting nicolascrop/aoc2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnicolascrop%2Faoc2023" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nicolascrop/aoc2023 [INFO] finished tweaking git repo https://github.com/nicolascrop/aoc2023 [INFO] tweaked toml for git repo https://github.com/nicolascrop/aoc2023 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nicolascrop/aoc2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nicolascrop/aoc2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror v1.0.51 [INFO] [stderr] Downloaded terminfo v0.8.0 [INFO] [stderr] Downloaded thiserror-impl v1.0.51 [INFO] [stderr] Downloaded clearscreen v2.0.1 [INFO] [stderr] Downloaded syn v2.0.41 [INFO] [stderr] Downloaded libc v0.2.151 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 70aa39bf1e101d5d321768ac1d74faff04b671a93f19b413696c1bb7e4240883 [INFO] running `Command { std: "docker" "start" "-a" "70aa39bf1e101d5d321768ac1d74faff04b671a93f19b413696c1bb7e4240883", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "70aa39bf1e101d5d321768ac1d74faff04b671a93f19b413696c1bb7e4240883", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70aa39bf1e101d5d321768ac1d74faff04b671a93f19b413696c1bb7e4240883", kill_on_drop: false }` [INFO] [stdout] 70aa39bf1e101d5d321768ac1d74faff04b671a93f19b413696c1bb7e4240883 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3bb906b0e14511efb5413e8e39de8a7f64bce88aa993771f6fef3202d65c57dd [INFO] running `Command { std: "docker" "start" "-a" "3bb906b0e14511efb5413e8e39de8a7f64bce88aa993771f6fef3202d65c57dd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling thiserror v1.0.51 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling terminfo v0.8.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.51 [INFO] [stderr] Checking clearscreen v2.0.1 [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/resolvers/advent_17.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | currents[i].previous_movements_in_same_direction + 1 <= MAX_MOVE_BEFORE_TURN { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `currents[i].previous_movements_in_same_direction < MAX_MOVE_BEFORE_TURN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/resolvers/advent_17.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | currents[i].previous_movements_in_same_direction + 1 <= MAX_MOVE_BEFORE_TURN { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `currents[i].previous_movements_in_same_direction < MAX_MOVE_BEFORE_TURN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `colored::Color::Black` [INFO] [stdout] --> src/resolvers/advent_24.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use colored::Color::Black; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `colored::Color::Black` [INFO] [stdout] --> src/resolvers/advent_24.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use colored::Color::Black; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/resolvers/advent_20.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | let mut conjunction_module = modules[i].deref_mut().as_conjunction_module().unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/resolvers/advent_21.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/resolvers/advent_22.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/resolvers/advent_23.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `color` is never read [INFO] [stdout] --> src/resolvers/advent_18.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct Point { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 13 | color: String [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Point` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `RANGE_MIN` is never used [INFO] [stdout] --> src/resolvers/advent_19.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | const RANGE_MIN: usize = 1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `RANGE_MAX` is never used [INFO] [stdout] --> src/resolvers/advent_19.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const RANGE_MAX: usize = 4000; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_range_from_operator` is never used [INFO] [stdout] --> src/resolvers/advent_19.rs:45:4 [INFO] [stdout] | [INFO] [stdout] 45 | fn get_range_from_operator(value: usize, op: &Operator) -> (usize, usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `has_destination` is never used [INFO] [stdout] --> src/resolvers/advent_20.rs:114:8 [INFO] [stdout] | [INFO] [stdout] 101 | impl ConjunctionModule { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 114 | fn has_destination(&self, destination: &String) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `z` is never read [INFO] [stdout] --> src/resolvers/advent_24.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 4 | struct Hailstone { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | z: (i64, i64), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Hailstone` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_01.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return to_return; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return to_return; [INFO] [stdout] 49 + to_return [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_01.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/resolvers/advent_20.rs:270:17 [INFO] [stdout] | [INFO] [stdout] 270 | let mut conjunction_module = modules[i].deref_mut().as_conjunction_module().unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/resolvers/advent_21.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `digit` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_01.rs:64:30 [INFO] [stdout] | [INFO] [stdout] 62 | if digit.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = digit` [INFO] [stdout] 63 | if str.len() == 0 { [INFO] [stdout] 64 | str.push(digit.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `digit_b` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_01.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 70 | if digit_b.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = digit_b` [INFO] [stdout] 71 | str.push(digit_b.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/resolvers/advent_22.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_01.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - pub fn resolve(input: &String) { [INFO] [stdout] 53 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/resolvers/advent_23.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_01.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | if str.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `str.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/resolvers/advent_01.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | str.push(str.chars().nth(0).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `str.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_02.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return parts[1].parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return parts[1].parse().unwrap(); [INFO] [stdout] 22 + parts[1].parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_02.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return (r, g, b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return (r, g, b); [INFO] [stdout] 44 + (r, g, b) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `color` is never read [INFO] [stdout] --> src/resolvers/advent_18.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct Point { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 13 | color: String [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Point` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `RANGE_MIN` is never used [INFO] [stdout] --> src/resolvers/advent_19.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | const RANGE_MIN: usize = 1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_02.rs:85:23 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - pub fn resolve(input: &String) { [INFO] [stdout] 85 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `RANGE_MAX` is never used [INFO] [stdout] --> src/resolvers/advent_19.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const RANGE_MAX: usize = 4000; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_range_from_operator` is never used [INFO] [stdout] --> src/resolvers/advent_19.rs:45:4 [INFO] [stdout] | [INFO] [stdout] 45 | fn get_range_from_operator(value: usize, op: &Operator) -> (usize, usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `has_destination` is never used [INFO] [stdout] --> src/resolvers/advent_20.rs:114:8 [INFO] [stdout] | [INFO] [stdout] 101 | impl ConjunctionModule { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 114 | fn has_destination(&self, destination: &String) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `z` is never read [INFO] [stdout] --> src/resolvers/advent_24.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 4 | struct Hailstone { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 7 | z: (i64, i64), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Hailstone` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_03.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return !DIGITS.contains(&str) && str != '.'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return !DIGITS.contains(&str) && str != '.'; [INFO] [stdout] 4 + !DIGITS.contains(&str) && str != '.' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_03.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return false; [INFO] [stdout] 49 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_03.rs:6:20 [INFO] [stdout] | [INFO] [stdout] 6 | fn has_symbol(map: &Vec>, row_index: usize, start: i32, end: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - fn has_symbol(map: &Vec>, row_index: usize, start: i32, end: usize) -> bool { [INFO] [stdout] 6 + fn has_symbol(map: &[Vec], row_index: usize, start: i32, end: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/resolvers/advent_03.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | let range_start: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `range_start` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 8 ~ [INFO] [stdout] 9 ~ let range_start: usize = if start < 0 { [INFO] [stdout] 10 ~ 0 [INFO] [stdout] 11 | } else { [INFO] [stdout] 12 ~ start as usize [INFO] [stdout] 13 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolvers/advent_03.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / if start >= 0 { [INFO] [stdout] 26 | | if is_symbol(map[row_index][start as usize]) { [INFO] [stdout] 27 | | return true; [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if start >= 0 [INFO] [stdout] 26 ~ && is_symbol(map[row_index][start as usize]) { [INFO] [stdout] 27 | return true; [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolvers/advent_03.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / if end < map[row_index].len() - 1 { [INFO] [stdout] 33 | | if is_symbol(map[row_index][end]) { [INFO] [stdout] 34 | | return true; [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 32 ~ if end < map[row_index].len() - 1 [INFO] [stdout] 33 ~ && is_symbol(map[row_index][end]) { [INFO] [stdout] 34 | return true; [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_01.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return to_return; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return to_return; [INFO] [stdout] 49 + to_return [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_03.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return None; [INFO] [stdout] 80 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_01.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/resolvers/advent_03.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | let start: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `start` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 ~ let start: usize = if part_number.start_x > 0 { [INFO] [stdout] 67 ~ part_number.start_x - 1 [INFO] [stdout] 68 | } else { [INFO] [stdout] 69 ~ 0 [INFO] [stdout] 70 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `digit` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_01.rs:64:30 [INFO] [stdout] | [INFO] [stdout] 62 | if digit.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = digit` [INFO] [stdout] 63 | if str.len() == 0 { [INFO] [stdout] 64 | str.push(digit.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `digit_b` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_01.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 70 | if digit_b.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = digit_b` [INFO] [stdout] 71 | str.push(digit_b.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_01.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - pub fn resolve(input: &String) { [INFO] [stdout] 53 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_01.rs:63:20 [INFO] [stdout] | [INFO] [stdout] 63 | if str.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `str.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_03.rs:131:50 [INFO] [stdout] | [INFO] [stdout] 130 | if result.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = result` [INFO] [stdout] 131 | println!("Gear is valid {}", result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_03.rs:132:59 [INFO] [stdout] | [INFO] [stdout] 130 | if result.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = result` [INFO] [stdout] 131 | println!("Gear is valid {}", result.unwrap()); [INFO] [stdout] 132 | result_sum_gears = result_sum_gears + result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_03.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 83 - pub fn resolve(input: &String) { [INFO] [stdout] 83 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/resolvers/advent_01.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | str.push(str.chars().nth(0).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `str.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_02.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return parts[1].parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return parts[1].parse().unwrap(); [INFO] [stdout] 22 + parts[1].parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_02.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return (r, g, b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return (r, g, b); [INFO] [stdout] 44 + (r, g, b) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_03.rs:95:32 [INFO] [stdout] | [INFO] [stdout] 95 | if DIGITS.contains(&col) { [INFO] [stdout] | ^^^^ help: change this to: `col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/resolvers/advent_03.rs:96:37 [INFO] [stdout] | [INFO] [stdout] 96 | current_number.push(col.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_03.rs:98:63 [INFO] [stdout] | [INFO] [stdout] 98 | if col_index == row.len() - 1 || !DIGITS.contains(&col) { [INFO] [stdout] | ^^^^ help: change this to: `col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_03.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | if current_number.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current_number.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:105:25 [INFO] [stdout] | [INFO] [stdout] 105 | result = result + current_number_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += current_number_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | col_index = col_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `col_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | row_index = row_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 132 | result_sum_gears = result_sum_gears + result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result_sum_gears += result.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | col_index = col_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `col_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | row_index = row_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_04.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn resolve(input: &String) { [INFO] [stdout] 1 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/resolvers/advent_04.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | next_winning_card.push(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![1;SIZE]` [INFO] [stdout] = help: or `next_winning_card.extend(std::iter::repeat_n(1, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/resolvers/advent_04.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | if played_number == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `played_number.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_02.rs:85:23 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - pub fn resolve(input: &String) { [INFO] [stdout] 85 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | nb_valid = nb_valid + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nb_valid += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | sum = sum + nb_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += nb_valid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_03.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | return !DIGITS.contains(&str) && str != '.'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - return !DIGITS.contains(&str) && str != '.'; [INFO] [stdout] 4 + !DIGITS.contains(&str) && str != '.' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_03.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return false; [INFO] [stdout] 49 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_03.rs:6:20 [INFO] [stdout] | [INFO] [stdout] 6 | fn has_symbol(map: &Vec>, row_index: usize, start: i32, end: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 6 - fn has_symbol(map: &Vec>, row_index: usize, start: i32, end: usize) -> bool { [INFO] [stdout] 6 + fn has_symbol(map: &[Vec], row_index: usize, start: i32, end: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/resolvers/advent_03.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | let range_start: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `range_start` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 8 ~ [INFO] [stdout] 9 ~ let range_start: usize = if start < 0 { [INFO] [stdout] 10 ~ 0 [INFO] [stdout] 11 | } else { [INFO] [stdout] 12 ~ start as usize [INFO] [stdout] 13 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolvers/advent_03.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / if start >= 0 { [INFO] [stdout] 26 | | if is_symbol(map[row_index][start as usize]) { [INFO] [stdout] 27 | | return true; [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if start >= 0 [INFO] [stdout] 26 ~ && is_symbol(map[row_index][start as usize]) { [INFO] [stdout] 27 | return true; [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolvers/advent_03.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / if end < map[row_index].len() - 1 { [INFO] [stdout] 33 | | if is_symbol(map[row_index][end]) { [INFO] [stdout] 34 | | return true; [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 32 ~ if end < map[row_index].len() - 1 [INFO] [stdout] 33 ~ && is_symbol(map[row_index][end]) { [INFO] [stdout] 34 | return true; [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | sum = sum + 2usize.pow((nb_valid - 1) as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += 2usize.pow((nb_valid - 1) as u32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/resolvers/advent_04.rs:32:66 [INFO] [stdout] | [INFO] [stdout] 32 | println!("adding to row {} value {}", row_index + i, 1 * next_winning_card[row_index]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `next_winning_card[row_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | next_winning_card[row_index + i + 1] = next_winning_card[row_index + i + 1] + 1 * next_winning_card[row_index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_winning_card[row_index + i + 1] += 1 * next_winning_card[row_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/resolvers/advent_04.rs:33:91 [INFO] [stdout] | [INFO] [stdout] 33 | next_winning_card[row_index + i + 1] = next_winning_card[row_index + i + 1] + 1 * next_winning_card[row_index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `next_winning_card[row_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | total_scratchcards = total_scratchcards + next_winning_card[row_index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_scratchcards += next_winning_card[row_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_03.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return None; [INFO] [stdout] 80 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | row_index = row_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_05.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return current; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return current; [INFO] [stdout] 25 + current [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/resolvers/advent_03.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | let start: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `start` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 ~ let start: usize = if part_number.start_x > 0 { [INFO] [stdout] 67 ~ part_number.start_x - 1 [INFO] [stdout] 68 | } else { [INFO] [stdout] 69 ~ 0 [INFO] [stdout] 70 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/resolvers/advent_05.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | let range_length: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `range_length` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 13 ~ [INFO] [stdout] 14 ~ let range_length: u32 = if destination.range_length == 0 { [INFO] [stdout] 15 ~ 0 [INFO] [stdout] 16 | } else { [INFO] [stdout] 17 ~ destination.range_length -1 [INFO] [stdout] 18 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_05.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - pub fn resolve(input: &String) { [INFO] [stdout] 28 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_03.rs:131:50 [INFO] [stdout] | [INFO] [stdout] 130 | if result.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = result` [INFO] [stdout] 131 | println!("Gear is valid {}", result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_03.rs:132:59 [INFO] [stdout] | [INFO] [stdout] 130 | if result.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = result` [INFO] [stdout] 131 | println!("Gear is valid {}", result.unwrap()); [INFO] [stdout] 132 | result_sum_gears = result_sum_gears + result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_03.rs:83:23 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 83 - pub fn resolve(input: &String) { [INFO] [stdout] 83 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_05.rs:31:104 [INFO] [stdout] | [INFO] [stdout] 31 | let seeds_list: Vec<&str> = lines[0].split(":").collect::>()[1].split(" ").filter(|seed| seed.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!seed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/resolvers/advent_05.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if seeds_list.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!seeds_list.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_03.rs:95:32 [INFO] [stdout] | [INFO] [stdout] 95 | if DIGITS.contains(&col) { [INFO] [stdout] | ^^^^ help: change this to: `col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/resolvers/advent_03.rs:96:37 [INFO] [stdout] | [INFO] [stdout] 96 | current_number.push(col.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_03.rs:98:63 [INFO] [stdout] | [INFO] [stdout] 98 | if col_index == row.len() - 1 || !DIGITS.contains(&col) { [INFO] [stdout] | ^^^^ help: change this to: `col` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_03.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | if current_number.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current_number.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_05.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 76 | if target.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `target.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_05.rs:79:72 [INFO] [stdout] | [INFO] [stdout] 79 | let numbers: Vec<&str> = line.split(" ").filter(|seed| seed.trim().len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!seed.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:105:25 [INFO] [stdout] | [INFO] [stdout] 105 | result = result + current_number_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += current_number_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | col_index = col_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `col_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | row_index = row_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_05.rs:116:59 [INFO] [stdout] | [INFO] [stdout] 116 | current_value = get_next_value(current_value, &destination_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `destination_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_05.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | return current_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return current_value; [INFO] [stdout] 130 + current_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_05.rs:128:59 [INFO] [stdout] | [INFO] [stdout] 128 | current_value = get_next_value(current_value, &destination_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `destination_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 132 | result_sum_gears = result_sum_gears + result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result_sum_gears += result.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | col_index = col_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `col_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_03.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | row_index = row_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_06.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / return line [INFO] [stdout] 9 | | .split(':').nth(1).unwrap() [INFO] [stdout] 10 | | .split(' ') [INFO] [stdout] 11 | | .map(|v| v.trim()) [INFO] [stdout] 12 | | .filter(|v| v.len() > 0) [INFO] [stdout] 13 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 ~ line [INFO] [stdout] 9 + .split(':').nth(1).unwrap() [INFO] [stdout] 10 + .split(' ') [INFO] [stdout] 11 + .map(|v| v.trim()) [INFO] [stdout] 12 + .filter(|v| v.len() > 0) [INFO] [stdout] 13 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_04.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn resolve(input: &String) { [INFO] [stdout] 1 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_06.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | .filter(|v| v.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/resolvers/advent_04.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | next_winning_card.push(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![1;SIZE]` [INFO] [stdout] = help: or `next_winning_card.extend(std::iter::repeat_n(1, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_06.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - pub fn resolve(input: &String) { [INFO] [stdout] 16 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/resolvers/advent_04.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | if played_number == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `played_number.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | nb_valid = nb_valid + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nb_valid += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | sum = sum + nb_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += nb_valid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | sum = sum + 2usize.pow((nb_valid - 1) as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum += 2usize.pow((nb_valid - 1) as u32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/resolvers/advent_04.rs:32:66 [INFO] [stdout] | [INFO] [stdout] 32 | println!("adding to row {} value {}", row_index + i, 1 * next_winning_card[row_index]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `next_winning_card[row_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | next_winning_card[row_index + i + 1] = next_winning_card[row_index + i + 1] + 1 * next_winning_card[row_index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_winning_card[row_index + i + 1] += 1 * next_winning_card[row_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/resolvers/advent_04.rs:33:91 [INFO] [stdout] | [INFO] [stdout] 33 | next_winning_card[row_index + i + 1] = next_winning_card[row_index + i + 1] + 1 * next_winning_card[row_index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `next_winning_card[row_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | total_scratchcards = total_scratchcards + next_winning_card[row_index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_scratchcards += next_winning_card[row_index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_04.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | row_index = row_index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `row_index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/resolvers/advent_06.rs:53:33 [INFO] [stdout] | [INFO] [stdout] 53 | let boat_distance = usize::from(i * (race.race_duration - i)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `usize::from()`: `(i * (race.race_duration - i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_06.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | race_winnable = race_winnable + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `race_winnable += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_06.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | result = result * race_winnable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result *= race_winnable` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return map; [INFO] [stdout] 22 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/resolvers/advent_07.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | map.entry(card.clone()).and_modify(|nb_card| *nb_card += 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*card` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / return Hand { [INFO] [stdout] 70 | | raw_cards: hand.to_string(), [INFO] [stdout] 71 | | cards: cards_value, [INFO] [stdout] 72 | | hand_by_frequency_and_value: hand_sort_by_frequency_and_value, [INFO] [stdout] 73 | | map: hand_map [INFO] [stdout] 74 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ Hand { [INFO] [stdout] 70 + raw_cards: hand.to_string(), [INFO] [stdout] 71 + cards: cards_value, [INFO] [stdout] 72 + hand_by_frequency_and_value: hand_sort_by_frequency_and_value, [INFO] [stdout] 73 + map: hand_map [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_07.rs:26:58 [INFO] [stdout] | [INFO] [stdout] 26 | let cards: Vec<&str> = hand.split("").filter(|value| value.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / return match value { [INFO] [stdout] 30 | | "A" => 14, [INFO] [stdout] 31 | | "K" => 13, [INFO] [stdout] 32 | | "Q" => 12, [INFO] [stdout] ... | [INFO] [stdout] 35 | | _ => value.parse().unwrap(), [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ match value { [INFO] [stdout] 30 + "A" => 14, [INFO] [stdout] 31 + "K" => 13, [INFO] [stdout] 32 + "Q" => 12, [INFO] [stdout] 33 + "J" => if part == Part::One { 11 } else { 1 }, [INFO] [stdout] 34 + "T" => 10, [INFO] [stdout] 35 + _ => value.parse().unwrap(), [INFO] [stdout] 36 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_05.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return current; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return current; [INFO] [stdout] 25 + current [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return result_first; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return result_first; [INFO] [stdout] 63 + result_first [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/resolvers/advent_05.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | let range_length: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `range_length` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 13 ~ [INFO] [stdout] 14 ~ let range_length: u32 = if destination.range_length == 0 { [INFO] [stdout] 15 ~ 0 [INFO] [stdout] 16 | } else { [INFO] [stdout] 17 ~ destination.range_length -1 [INFO] [stdout] 18 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_05.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - pub fn resolve(input: &String) { [INFO] [stdout] 28 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_05.rs:31:104 [INFO] [stdout] | [INFO] [stdout] 31 | let seeds_list: Vec<&str> = lines[0].split(":").collect::>()[1].split(" ").filter(|seed| seed.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!seed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/resolvers/advent_05.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if seeds_list.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!seeds_list.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top_2` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_07.rs:93:31 [INFO] [stdout] | [INFO] [stdout] 93 | if top_2.is_some() { *top_2.unwrap() } else { 0 } [INFO] [stdout] | ------------------ ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = top_2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | / return ( [INFO] [stdout] 92 | | top_1, [INFO] [stdout] 93 | | if top_2.is_some() { *top_2.unwrap() } else { 0 } [INFO] [stdout] 94 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 ~ ( [INFO] [stdout] 92 + top_1, [INFO] [stdout] 93 + if top_2.is_some() { *top_2.unwrap() } else { 0 } [INFO] [stdout] 94 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_07.rs:83:36 [INFO] [stdout] | [INFO] [stdout] 83 | top_1 = *hand.hand.map.get(&value_and_frequency_without_jokers[0]).unwrap() + nb_joker as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `value_and_frequency_without_jokers[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_07.rs:85:39 [INFO] [stdout] | [INFO] [stdout] 85 | top_2 = hand.hand.map.get(&value_and_frequency_without_jokers[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `value_and_frequency_without_jokers[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_07.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 97 - pub fn resolve(input: &String) { [INFO] [stdout] 97 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_05.rs:76:20 [INFO] [stdout] | [INFO] [stdout] 76 | if target.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `target.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return Ordering::Equal; [INFO] [stdout] 129 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_05.rs:79:72 [INFO] [stdout] | [INFO] [stdout] 79 | let numbers: Vec<&str> = line.split(" ").filter(|seed| seed.trim().len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!seed.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_05.rs:116:59 [INFO] [stdout] | [INFO] [stdout] 116 | current_value = get_next_value(current_value, &destination_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `destination_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_05.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | return current_value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return current_value; [INFO] [stdout] 130 + current_value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_05.rs:128:59 [INFO] [stdout] | [INFO] [stdout] 128 | current_value = get_next_value(current_value, &destination_map); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `destination_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_07.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | result = result + (i * hand.bid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += (i * hand.bid)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_06.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / return line [INFO] [stdout] 9 | | .split(':').nth(1).unwrap() [INFO] [stdout] 10 | | .split(' ') [INFO] [stdout] 11 | | .map(|v| v.trim()) [INFO] [stdout] 12 | | .filter(|v| v.len() > 0) [INFO] [stdout] 13 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 ~ line [INFO] [stdout] 9 + .split(':').nth(1).unwrap() [INFO] [stdout] 10 + .split(' ') [INFO] [stdout] 11 + .map(|v| v.trim()) [INFO] [stdout] 12 + .filter(|v| v.len() > 0) [INFO] [stdout] 13 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_08.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if !map_value.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `map_value.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_08.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return current_position.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return current_position.to_string(); [INFO] [stdout] 25 + current_position.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_06.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | .filter(|v| v.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_06.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 16 - pub fn resolve(input: &String) { [INFO] [stdout] 16 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_08.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 28 | fn browse_map_part_one(path: &String, map: &CamelMap, start: String, end: String) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - fn browse_map_part_one(path: &String, map: &CamelMap, start: String, end: String) -> usize { [INFO] [stdout] 28 + fn browse_map_part_one(path: &str, map: &CamelMap, start: String, end: String) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_08.rs:33:44 [INFO] [stdout] | [INFO] [stdout] 33 | let _end = browse_map(&path_chars, &map, &start.to_string()); [INFO] [stdout] | ^^^^ help: change this to: `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_08.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return steps * path_chars.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return steps * path_chars.len(); [INFO] [stdout] 74 + steps * path_chars.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_08.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | fn browse_map_part_two(path: &String, map: &CamelMap) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn browse_map_part_two(path: &String, map: &CamelMap) -> usize { [INFO] [stdout] 41 + fn browse_map_part_two(path: &str, map: &CamelMap) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/resolvers/advent_06.rs:53:33 [INFO] [stdout] | [INFO] [stdout] 53 | let boat_distance = usize::from(i * (race.race_duration - i)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `usize::from()`: `(i * (race.race_duration - i))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_06.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | race_winnable = race_winnable + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `race_winnable += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_08.rs:61:60 [INFO] [stdout] | [INFO] [stdout] 61 | current_positions[i] = browse_map(&path_chars, &map, ¤t_positions[i]); [INFO] [stdout] | ^^^^ help: change this to: `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_06.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | result = result * race_winnable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result *= race_winnable` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_08.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | steps = steps * (nb_loop / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `steps *= (nb_loop / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return map; [INFO] [stdout] 22 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_08.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - pub fn resolve(input: &String) { [INFO] [stdout] 78 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/resolvers/advent_07.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | map.entry(card.clone()).and_modify(|nb_card| *nb_card += 1).or_insert(1); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*card` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/resolvers/advent_08.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / return Hand { [INFO] [stdout] 70 | | raw_cards: hand.to_string(), [INFO] [stdout] 71 | | cards: cards_value, [INFO] [stdout] 72 | | hand_by_frequency_and_value: hand_sort_by_frequency_and_value, [INFO] [stdout] 73 | | map: hand_map [INFO] [stdout] 74 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 ~ Hand { [INFO] [stdout] 70 + raw_cards: hand.to_string(), [INFO] [stdout] 71 + cards: cards_value, [INFO] [stdout] 72 + hand_by_frequency_and_value: hand_sort_by_frequency_and_value, [INFO] [stdout] 73 + map: hand_map [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/resolvers/advent_08.rs:89:27 [INFO] [stdout] | [INFO] [stdout] 89 | path = path + &line.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_07.rs:26:58 [INFO] [stdout] | [INFO] [stdout] 26 | let cards: Vec<&str> = hand.split("").filter(|value| value.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / return match value { [INFO] [stdout] 30 | | "A" => 14, [INFO] [stdout] 31 | | "K" => 13, [INFO] [stdout] 32 | | "Q" => 12, [INFO] [stdout] ... | [INFO] [stdout] 35 | | _ => value.parse().unwrap(), [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ match value { [INFO] [stdout] 30 + "A" => 14, [INFO] [stdout] 31 + "K" => 13, [INFO] [stdout] 32 + "Q" => 12, [INFO] [stdout] 33 + "J" => if part == Part::One { 11 } else { 1 }, [INFO] [stdout] 34 + "T" => 10, [INFO] [stdout] 35 + _ => value.parse().unwrap(), [INFO] [stdout] 36 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_09.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return sequence.last().unwrap() + previous_value_to_add; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return sequence.last().unwrap() + previous_value_to_add; [INFO] [stdout] 29 + sequence.last().unwrap() + previous_value_to_add [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return result_first; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return result_first; [INFO] [stdout] 63 + result_first [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_09.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | if sequence_of_differences.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sequence_of_differences.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `sequence_of_differences` [INFO] [stdout] --> src/resolvers/advent_09.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | for i in 1..sequence_of_differences.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 26 - for i in 1..sequence_of_differences.len() { [INFO] [stdout] 26 + for in sequence_of_differences.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_09.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | previous_value_to_add = sequence_of_differences[i].last().unwrap() + previous_value_to_add; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_value_to_add += sequence_of_differences[i].last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `top_2` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_07.rs:93:31 [INFO] [stdout] | [INFO] [stdout] 93 | if top_2.is_some() { *top_2.unwrap() } else { 0 } [INFO] [stdout] | ------------------ ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Some() = top_2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | / return ( [INFO] [stdout] 92 | | top_1, [INFO] [stdout] 93 | | if top_2.is_some() { *top_2.unwrap() } else { 0 } [INFO] [stdout] 94 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 ~ ( [INFO] [stdout] 92 + top_1, [INFO] [stdout] 93 + if top_2.is_some() { *top_2.unwrap() } else { 0 } [INFO] [stdout] 94 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_09.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - pub fn resolve(input: &String) { [INFO] [stdout] 32 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_09.rs:39:25 [INFO] [stdout] | [INFO] [stdout] 39 | .filter(|v| v.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_07.rs:83:36 [INFO] [stdout] | [INFO] [stdout] 83 | top_1 = *hand.hand.map.get(&value_and_frequency_without_jokers[0]).unwrap() + nb_joker as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `value_and_frequency_without_jokers[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_07.rs:85:39 [INFO] [stdout] | [INFO] [stdout] 85 | top_2 = hand.hand.map.get(&value_and_frequency_without_jokers[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `value_and_frequency_without_jokers[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_10.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | LEFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_10.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | RIGHT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TOP` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_10.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | TOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Top` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_07.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 97 - pub fn resolve(input: &String) { [INFO] [stdout] 97 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BOTTOM` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_10.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | BOTTOM [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Bottom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_07.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 - return Ordering::Equal; [INFO] [stdout] 129 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_10.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 24 - print!("\n"); [INFO] [stdout] 24 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_10.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return true; [INFO] [stdout] 117 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_07.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | result = result + (i * hand.bid); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += (i * hand.bid)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_08.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if !map_value.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `map_value.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_08.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return current_position.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return current_position.to_string(); [INFO] [stdout] 25 + current_position.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_10.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return min(down, up) % 2 != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return min(down, up) % 2 != 0; [INFO] [stdout] 144 + min(down, up) % 2 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_10.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 134 | for i in col_index+1..map[row_index].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 134 - for i in col_index+1..map[row_index].len() { [INFO] [stdout] 134 + for (i, ) in map.iter().enumerate().take(map[row_index].len()).skip(col_index+1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_08.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 28 | fn browse_map_part_one(path: &String, map: &CamelMap, start: String, end: String) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - fn browse_map_part_one(path: &String, map: &CamelMap, start: String, end: String) -> usize { [INFO] [stdout] 28 + fn browse_map_part_one(path: &str, map: &CamelMap, start: String, end: String) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_08.rs:33:44 [INFO] [stdout] | [INFO] [stdout] 33 | let _end = browse_map(&path_chars, &map, &start.to_string()); [INFO] [stdout] | ^^^^ help: change this to: `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/resolvers/advent_10.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 144 | return min(down, up) % 2 != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!min(down, up).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_08.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | return steps * path_chars.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return steps * path_chars.len(); [INFO] [stdout] 74 + steps * path_chars.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_08.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | fn browse_map_part_two(path: &String, map: &CamelMap) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn browse_map_part_two(path: &String, map: &CamelMap) -> usize { [INFO] [stdout] 41 + fn browse_map_part_two(path: &str, map: &CamelMap) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_10.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | return loop_parts.len() / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return loop_parts.len() / 2; [INFO] [stdout] 212 + loop_parts.len() / 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_08.rs:61:60 [INFO] [stdout] | [INFO] [stdout] 61 | current_positions[i] = browse_map(&path_chars, &map, ¤t_positions[i]); [INFO] [stdout] | ^^^^ help: change this to: `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_08.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | steps = steps * (nb_loop / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `steps *= (nb_loop / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_08.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - pub fn resolve(input: &String) { [INFO] [stdout] 78 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_index` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_10.rs:180:22 [INFO] [stdout] | [INFO] [stdout] 180 | for row_index in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 180 - for row_index in 0..map.len() { [INFO] [stdout] 180 + for (row_index, ) in map.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col_index` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_10.rs:181:26 [INFO] [stdout] | [INFO] [stdout] 181 | for col_index in 0..map[row_index].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 181 - for col_index in 0..map[row_index].len() { [INFO] [stdout] 181 + for (col_index, ) in map.iter().enumerate().take(map[row_index].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/resolvers/advent_08.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/resolvers/advent_08.rs:89:27 [INFO] [stdout] | [INFO] [stdout] 89 | path = path + &line.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_10.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 188 - print!("\n"); [INFO] [stdout] 188 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_09.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return sequence.last().unwrap() + previous_value_to_add; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return sequence.last().unwrap() + previous_value_to_add; [INFO] [stdout] 29 + sequence.last().unwrap() + previous_value_to_add [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_09.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | if sequence_of_differences.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!sequence_of_differences.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_10.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 207 - print!("\n"); [INFO] [stdout] 207 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `sequence_of_differences` [INFO] [stdout] --> src/resolvers/advent_09.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | for i in 1..sequence_of_differences.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 26 - for i in 1..sequence_of_differences.len() { [INFO] [stdout] 26 + for in sequence_of_differences.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_10.rs:237:8 [INFO] [stdout] | [INFO] [stdout] 237 | if !start.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `start.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_09.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | previous_value_to_add = sequence_of_differences[i].last().unwrap() + previous_value_to_add; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `previous_value_to_add += sequence_of_differences[i].last().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_10.rs:215:23 [INFO] [stdout] | [INFO] [stdout] 215 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 215 - pub fn resolve(input: &String) { [INFO] [stdout] 215 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_09.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - pub fn resolve(input: &String) { [INFO] [stdout] 32 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/resolvers/advent_10.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | for line in input.lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, line) in input.lines().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `j` is used as a loop counter [INFO] [stdout] --> src/resolvers/advent_10.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | for _char in line.chars() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, _char) in line.chars().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_09.rs:39:25 [INFO] [stdout] | [INFO] [stdout] 39 | .filter(|v| v.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_10.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | LEFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_10.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | RIGHT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TOP` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_10.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | TOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Top` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BOTTOM` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_10.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | BOTTOM [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Bottom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_11.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(input: &String, expansion_size: usize) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - pub fn new(input: &String, expansion_size: usize) -> Self { [INFO] [stdout] 25 + pub fn new(input: &str, expansion_size: usize) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_11.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if lines.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_10.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 24 - print!("\n"); [INFO] [stdout] 24 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/resolvers/advent_11.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | for i in 0..lines.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 37 - for i in 0..lines.len() { [INFO] [stdout] 37 + for in &lines { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `lines` [INFO] [stdout] --> src/resolvers/advent_11.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | for i in 0..lines.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 48 - for i in 0..lines.len() { [INFO] [stdout] 48 + for (i, ) in lines.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_11.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 60 - for i in 0..map.len() { [INFO] [stdout] 60 + for (i, ) in map.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_11.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 61 | for j in 0..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 61 - for j in 0..map[i].len() { [INFO] [stdout] 61 + for (j, ) in map.iter().enumerate().take(map[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_10.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return true; [INFO] [stdout] 117 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_11.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 97 - print!("\n"); [INFO] [stdout] 97 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_11.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return search_galaxy.smart_search(point_a, point_b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return search_galaxy.smart_search(point_a, point_b); [INFO] [stdout] 106 + search_galaxy.smart_search(point_a, point_b) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_11.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | return distance; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return distance; [INFO] [stdout] 146 + distance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_10.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return min(down, up) % 2 != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return min(down, up) % 2 != 0; [INFO] [stdout] 144 + min(down, up) % 2 != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_10.rs:134:14 [INFO] [stdout] | [INFO] [stdout] 134 | for i in col_index+1..map[row_index].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 134 - for i in col_index+1..map[row_index].len() { [INFO] [stdout] 134 + for (i, ) in map.iter().enumerate().take(map[row_index].len()).skip(col_index+1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/resolvers/advent_10.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 144 | return min(down, up) % 2 != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!min(down, up).is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_10.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | return loop_parts.len() / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return loop_parts.len() / 2; [INFO] [stdout] 212 + loop_parts.len() / 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_index` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_10.rs:180:22 [INFO] [stdout] | [INFO] [stdout] 180 | for row_index in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 180 - for row_index in 0..map.len() { [INFO] [stdout] 180 + for (row_index, ) in map.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `col_index` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_10.rs:181:26 [INFO] [stdout] | [INFO] [stdout] 181 | for col_index in 0..map[row_index].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 181 - for col_index in 0..map[row_index].len() { [INFO] [stdout] 181 + for (col_index, ) in map.iter().enumerate().take(map[row_index].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_10.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 188 - print!("\n"); [INFO] [stdout] 188 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_11.rs:209:30 [INFO] [stdout] | [INFO] [stdout] 209 | let galaxy = Galaxy::new(&input, 1000000 - 1); [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_11.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | return galaxy.get_distance_between_2_galaxy_points(galaxy_points_pair.0, galaxy_points_pair.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return galaxy.get_distance_between_2_galaxy_points(galaxy_points_pair.0, galaxy_points_pair.1); [INFO] [stdout] 223 + galaxy.get_distance_between_2_galaxy_points(galaxy_points_pair.0, galaxy_points_pair.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return true; [INFO] [stdout] 39 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_12.rs:3:41 [INFO] [stdout] | [INFO] [stdout] 3 | fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] 3 + fn sequence_is_valid_for_spring(spring: &[char], is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_12.rs:3:79 [INFO] [stdout] | [INFO] [stdout] 3 | fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] 3 + fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &[usize]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return current_slice; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return current_slice; [INFO] [stdout] 48 + current_slice [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `found_in_map` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_12.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 55 | if found_in_map.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = found_in_map` [INFO] [stdout] 56 | return *found_in_map.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return result; [INFO] [stdout] 88 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_12.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | if current.len() > 0 && !sequence_is_valid_for_spring(current, rest.len() == 0, sequences) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_12.rs:59:68 [INFO] [stdout] | [INFO] [stdout] 59 | if current.len() > 0 && !sequence_is_valid_for_spring(current, rest.len() == 0, sequences) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_12.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | if rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `rest` [INFO] [stdout] --> src/resolvers/advent_12.rs:78:14 [INFO] [stdout] | [INFO] [stdout] 78 | for i in 1..rest.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 78 - for i in 1..rest.len() { [INFO] [stdout] 78 + for in rest.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | return explore(&Vec::new(), &springs[0..], sequences, &mut HashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return explore(&Vec::new(), &springs[0..], sequences, &mut HashMap::new()); [INFO] [stdout] 92 + explore(&Vec::new(), &springs[0..], sequences, &mut HashMap::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_12.rs:91:35 [INFO] [stdout] | [INFO] [stdout] 91 | fn compute_possibilities(springs: &Vec, sequences: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - fn compute_possibilities(springs: &Vec, sequences: &Vec) -> usize { [INFO] [stdout] 91 + fn compute_possibilities(springs: &[char], sequences: &Vec) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_12.rs:95:23 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 95 - pub fn resolve(input: &String) { [INFO] [stdout] 95 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/resolvers/advent_12.rs:99:104 [INFO] [stdout] | [INFO] [stdout] 99 | ...c.len() == 1).map(|c| c.chars().nth(0).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `c.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | return seq.trim().parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return seq.trim().parse().unwrap(); [INFO] [stdout] 101 + seq.trim().parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_13.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return x; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return x; [INFO] [stdout] 49 + x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_13.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return nb_diff; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return nb_diff; [INFO] [stdout] 63 + nb_diff [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_13.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | fn nb_diff(p_1: &Vec, p_2: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 - fn nb_diff(p_1: &Vec, p_2: &Vec) -> usize { [INFO] [stdout] 52 + fn nb_diff(p_1: &[char], p_2: &Vec) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_13.rs:52:38 [INFO] [stdout] | [INFO] [stdout] 52 | fn nb_diff(p_1: &Vec, p_2: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 - fn nb_diff(p_1: &Vec, p_2: &Vec) -> usize { [INFO] [stdout] 52 + fn nb_diff(p_1: &Vec, p_2: &[char]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_13.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return matching_reflection; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return matching_reflection; [INFO] [stdout] 97 + matching_reflection [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_13.rs:66:47 [INFO] [stdout] | [INFO] [stdout] 66 | fn get_reflection_from_patterns(patterns: &Vec>, max_smudges: usize) -> (usize, usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - fn get_reflection_from_patterns(patterns: &Vec>, max_smudges: usize) -> (usize, usize) { [INFO] [stdout] 66 + fn get_reflection_from_patterns(patterns: &[Vec], max_smudges: usize) -> (usize, usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_10.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 207 - print!("\n"); [INFO] [stdout] 207 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_10.rs:237:8 [INFO] [stdout] | [INFO] [stdout] 237 | if !start.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `start.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_10.rs:215:23 [INFO] [stdout] | [INFO] [stdout] 215 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 215 - pub fn resolve(input: &String) { [INFO] [stdout] 215 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/resolvers/advent_10.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | for line in input.lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, line) in input.lines().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `j` is used as a loop counter [INFO] [stdout] --> src/resolvers/advent_10.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | for _char in line.chars() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, _char) in line.chars().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_11.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(input: &String, expansion_size: usize) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 - pub fn new(input: &String, expansion_size: usize) -> Self { [INFO] [stdout] 25 + pub fn new(input: &str, expansion_size: usize) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_13.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 105 - print!("\n"); [INFO] [stdout] 105 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_13.rs:110:23 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - pub fn resolve(input: &String) { [INFO] [stdout] 110 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_13.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WEST` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_14.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | WEST, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `West` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EAST` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_14.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | EAST, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `East` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NORTH` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_14.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | NORTH, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `North` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SOUTH` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_14.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | SOUTH [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `South` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_11.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if lines.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/resolvers/advent_11.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 37 | for i in 0..lines.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 37 - for i in 0..lines.len() { [INFO] [stdout] 37 + for in &lines { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `lines` [INFO] [stdout] --> src/resolvers/advent_11.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | for i in 0..lines.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 48 - for i in 0..lines.len() { [INFO] [stdout] 48 + for (i, ) in lines.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_11.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 60 - for i in 0..map.len() { [INFO] [stdout] 60 + for (i, ) in map.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `map` [INFO] [stdout] --> src/resolvers/advent_11.rs:61:22 [INFO] [stdout] | [INFO] [stdout] 61 | for j in 0..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 61 - for j in 0..map[i].len() { [INFO] [stdout] 61 + for (j, ) in map.iter().enumerate().take(map[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_11.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 97 - print!("\n"); [INFO] [stdout] 97 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_11.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return search_galaxy.smart_search(point_a, point_b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return search_galaxy.smart_search(point_a, point_b); [INFO] [stdout] 106 + search_galaxy.smart_search(point_a, point_b) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_11.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | return distance; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return distance; [INFO] [stdout] 146 + distance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_11.rs:209:30 [INFO] [stdout] | [INFO] [stdout] 209 | let galaxy = Galaxy::new(&input, 1000000 - 1); [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_11.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | return galaxy.get_distance_between_2_galaxy_points(galaxy_points_pair.0, galaxy_points_pair.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return galaxy.get_distance_between_2_galaxy_points(galaxy_points_pair.0, galaxy_points_pair.1); [INFO] [stdout] 223 + galaxy.get_distance_between_2_galaxy_points(galaxy_points_pair.0, galaxy_points_pair.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_14.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 41 - print!("\n"); [INFO] [stdout] 41 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return true; [INFO] [stdout] 39 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_14.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return false; [INFO] [stdout] 60 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_12.rs:3:41 [INFO] [stdout] | [INFO] [stdout] 3 | fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] 3 + fn sequence_is_valid_for_spring(spring: &[char], is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolvers/advent_14.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / if map.map_data[i][j] == b'O' { [INFO] [stdout] 54 | | if map.map_data[c2.0][c2.1] == b'.' { [INFO] [stdout] 55 | | map.map_data[c2.0][c2.1] = b'O'; [INFO] [stdout] 56 | | map.map_data[i][j] = b'.'; [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 53 ~ if map.map_data[i][j] == b'O' [INFO] [stdout] 54 ~ && map.map_data[c2.0][c2.1] == b'.' { [INFO] [stdout] 55 | map.map_data[c2.0][c2.1] = b'O'; [INFO] [stdout] 56 | map.map_data[i][j] = b'.'; [INFO] [stdout] 57 | return true; [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_12.rs:3:79 [INFO] [stdout] | [INFO] [stdout] 3 | fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &Vec) -> bool { [INFO] [stdout] 3 + fn sequence_is_valid_for_spring(spring: &Vec, is_full: bool, sequences: &[usize]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_14.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return sum; [INFO] [stdout] 72 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return current_slice; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return current_slice; [INFO] [stdout] 48 + current_slice [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `found_in_map` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_12.rs:56:17 [INFO] [stdout] | [INFO] [stdout] 55 | if found_in_map.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = found_in_map` [INFO] [stdout] 56 | return *found_in_map.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return result; [INFO] [stdout] 88 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_12.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | if current.len() > 0 && !sequence_is_valid_for_spring(current, rest.len() == 0, sequences) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_12.rs:59:68 [INFO] [stdout] | [INFO] [stdout] 59 | if current.len() > 0 && !sequence_is_valid_for_spring(current, rest.len() == 0, sequences) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_12.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | if rest.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_14.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - pub fn resolve(input: &String) { [INFO] [stdout] 125 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `rest` [INFO] [stdout] --> src/resolvers/advent_12.rs:78:14 [INFO] [stdout] | [INFO] [stdout] 78 | for i in 1..rest.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 78 - for i in 1..rest.len() { [INFO] [stdout] 78 + for in rest.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | return explore(&Vec::new(), &springs[0..], sequences, &mut HashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return explore(&Vec::new(), &springs[0..], sequences, &mut HashMap::new()); [INFO] [stdout] 92 + explore(&Vec::new(), &springs[0..], sequences, &mut HashMap::new()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_12.rs:91:35 [INFO] [stdout] | [INFO] [stdout] 91 | fn compute_possibilities(springs: &Vec, sequences: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - fn compute_possibilities(springs: &Vec, sequences: &Vec) -> usize { [INFO] [stdout] 91 + fn compute_possibilities(springs: &[char], sequences: &Vec) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_12.rs:95:23 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 95 - pub fn resolve(input: &String) { [INFO] [stdout] 95 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/resolvers/advent_12.rs:99:104 [INFO] [stdout] | [INFO] [stdout] 99 | ...c.len() == 1).map(|c| c.chars().nth(0).unwrap()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `c.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_12.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | return seq.trim().parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return seq.trim().parse().unwrap(); [INFO] [stdout] 101 + seq.trim().parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_15.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if self.content[i].len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.content[i].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_15.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return sum; [INFO] [stdout] 34 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_15.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return hash; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return hash; [INFO] [stdout] 46 + hash [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_15.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | hash = hash * 17; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `hash *= 17` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_13.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return x; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return x; [INFO] [stdout] 49 + x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_15.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | hash = hash % 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `hash %= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_15.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | fn part_1(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - fn part_1(input: &String) { [INFO] [stdout] 48 + fn part_1(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `box_found` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_15.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 62 | if box_found.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = box_found` [INFO] [stdout] 63 | let found_at = box_found.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `box_found` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_15.rs:69:32 [INFO] [stdout] | [INFO] [stdout] 68 | if box_found.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = box_found` [INFO] [stdout] 69 | let found_at = box_found.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_15.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | fn part_2(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 - fn part_2(input: &String) { [INFO] [stdout] 52 + fn part_2(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/resolvers/advent_15.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 55 | let parts: Vec<&str> = step.split(|c| c == '-' || c == '=').filter(|x| x.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['-', '=']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_13.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return nb_diff; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return nb_diff; [INFO] [stdout] 63 + nb_diff [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_15.rs:55:80 [INFO] [stdout] | [INFO] [stdout] 55 | let parts: Vec<&str> = step.split(|c| c == '-' || c == '=').filter(|x| x.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_13.rs:52:21 [INFO] [stdout] | [INFO] [stdout] 52 | fn nb_diff(p_1: &Vec, p_2: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 - fn nb_diff(p_1: &Vec, p_2: &Vec) -> usize { [INFO] [stdout] 52 + fn nb_diff(p_1: &[char], p_2: &Vec) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_13.rs:52:38 [INFO] [stdout] | [INFO] [stdout] 52 | fn nb_diff(p_1: &Vec, p_2: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 - fn nb_diff(p_1: &Vec, p_2: &Vec) -> usize { [INFO] [stdout] 52 + fn nb_diff(p_1: &Vec, p_2: &[char]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_15.rs:57:33 [INFO] [stdout] | [INFO] [stdout] 57 | let box_index = do_hash(&label); [INFO] [stdout] | ^^^^^^ help: change this to: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_13.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return matching_reflection; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return matching_reflection; [INFO] [stdout] 97 + matching_reflection [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_13.rs:66:47 [INFO] [stdout] | [INFO] [stdout] 66 | fn get_reflection_from_patterns(patterns: &Vec>, max_smudges: usize) -> (usize, usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - fn get_reflection_from_patterns(patterns: &Vec>, max_smudges: usize) -> (usize, usize) { [INFO] [stdout] 66 + fn get_reflection_from_patterns(patterns: &[Vec], max_smudges: usize) -> (usize, usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TOP` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_16.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | TOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Top` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_13.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 105 - print!("\n"); [INFO] [stdout] 105 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_13.rs:110:23 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - pub fn resolve(input: &String) { [INFO] [stdout] 110 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_16.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | LEFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_16.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | RIGHT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BOTTOM` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_16.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | BOTTOM [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Bottom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_16.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 33 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 33 - for i in 0..map.len() { [INFO] [stdout] 33 + for in &map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_16.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | for j in 0..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 34 - for j in 0..map[i].len() { [INFO] [stdout] 34 + for in map.iter().take(map[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_13.rs:114:12 [INFO] [stdout] | [INFO] [stdout] 114 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_16.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 37 - print!("\n"); [INFO] [stdout] 37 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WEST` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_14.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | WEST, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `West` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EAST` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_14.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | EAST, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `East` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_16.rs:149:16 [INFO] [stdout] | [INFO] [stdout] 149 | if !next_as_option.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next_as_option.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `next_directions.1` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_16.rs:102:104 [INFO] [stdout] | [INFO] [stdout] 101 | if next_directions.1.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = next_directions.1` [INFO] [stdout] 102 | beams.push(Beam { row_index: start_beam.row_index, col_index: start_beam.col_index, direction: next_directions.1.unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NORTH` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_14.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | NORTH, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `North` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `next_directions.1` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_16.rs:156:88 [INFO] [stdout] | [INFO] [stdout] 155 | if next_directions.1.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = next_directions.1` [INFO] [stdout] 156 | new_beams.push(Beam { row_index: next.0, col_index: next.1, direction: next_directions.1.unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SOUTH` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_14.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | SOUTH [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `South` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_16.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return energize_tiles.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return energize_tiles.len(); [INFO] [stdout] 165 + energize_tiles.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_16.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 105 | if beams.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `beams.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `beams` [INFO] [stdout] --> src/resolvers/advent_16.rs:109:18 [INFO] [stdout] | [INFO] [stdout] 109 | for i in 0..beams.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 109 - for i in 0..beams.len() { [INFO] [stdout] 109 + for in &beams { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_14.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 41 - print!("\n"); [INFO] [stdout] 41 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_14.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 - return false; [INFO] [stdout] 60 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/resolvers/advent_14.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / if map.map_data[i][j] == b'O' { [INFO] [stdout] 54 | | if map.map_data[c2.0][c2.1] == b'.' { [INFO] [stdout] 55 | | map.map_data[c2.0][c2.1] = b'O'; [INFO] [stdout] 56 | | map.map_data[i][j] = b'.'; [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 53 ~ if map.map_data[i][j] == b'O' [INFO] [stdout] 54 ~ && map.map_data[c2.0][c2.1] == b'.' { [INFO] [stdout] 55 | map.map_data[c2.0][c2.1] = b'O'; [INFO] [stdout] 56 | map.map_data[i][j] = b'.'; [INFO] [stdout] 57 | return true; [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_16.rs:168:23 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 168 - pub fn resolve(input: &String) { [INFO] [stdout] 168 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_16.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | return beam_res; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return beam_res; [INFO] [stdout] 195 + beam_res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_16.rs:193:43 [INFO] [stdout] | [INFO] [stdout] 193 | let beam_res = energize_map(&map, &beam); [INFO] [stdout] | ^^^^^ help: change this to: `beam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_14.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return sum; [INFO] [stdout] 72 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current.previous_cell_index` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_17.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 21 | if current.previous_cell_index.is_some() { [INFO] [stdout] | ---------------------------------------- help: try: `if let Some() = current.previous_cell_index` [INFO] [stdout] ... [INFO] [stdout] 24 | let previous_cell = current.previous_cell_index.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_17.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return results; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return results; [INFO] [stdout] 83 + results [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_14.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 125 - pub fn resolve(input: &String) { [INFO] [stdout] 125 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_17.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return format!("{}_{}_{:?}_{}", position.row_index, position.col_index, position.previous_cell_index, position.previous_movements_in_same_direction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return format!("{}_{}_{:?}_{}", position.row_index, position.col_index, position.previous_cell_index, position.previous_movements_in_same_direction); [INFO] [stdout] 87 + format!("{}_{}_{:?}_{}", position.row_index, position.col_index, position.previous_cell_index, position.previous_movements_in_same_direction) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `found` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_17.rs:125:44 [INFO] [stdout] | [INFO] [stdout] 124 | if found.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = found` [INFO] [stdout] 125 | let best_score_value = found.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_17.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return heat_loss; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return heat_loss; [INFO] [stdout] 144 + heat_loss [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_17.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if currents.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `currents.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `currents` [INFO] [stdout] --> src/resolvers/advent_17.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | for i in 0..currents.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 105 - for i in 0..currents.len() { [INFO] [stdout] 105 + for in ¤ts { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_15.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if self.content[i].len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.content[i].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_15.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return sum; [INFO] [stdout] 34 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/resolvers/advent_17.rs:127:53 [INFO] [stdout] | [INFO] [stdout] 127 | best_score.insert(score_id, *(&next_position.total_heat)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next_position.total_heat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/resolvers/advent_17.rs:131:49 [INFO] [stdout] | [INFO] [stdout] 131 | best_score.insert(score_id, *(&next_position.total_heat)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next_position.total_heat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_15.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return hash; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return hash; [INFO] [stdout] 46 + hash [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_15.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | hash = hash * 17; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `hash *= 17` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/resolvers/advent_15.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | hash = hash % 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `hash %= 256` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_15.rs:48:18 [INFO] [stdout] | [INFO] [stdout] 48 | fn part_1(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - fn part_1(input: &String) { [INFO] [stdout] 48 + fn part_1(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_17.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 150 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 150 - for i in 0..map.len() { [INFO] [stdout] 150 + for in &map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_17.rs:151:18 [INFO] [stdout] | [INFO] [stdout] 151 | for j in 0..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 151 - for j in 0..map[i].len() { [INFO] [stdout] 151 + for in map.iter().take(map[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `box_found` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_15.rs:63:32 [INFO] [stdout] | [INFO] [stdout] 62 | if box_found.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = box_found` [INFO] [stdout] 63 | let found_at = box_found.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `box_found` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_15.rs:69:32 [INFO] [stdout] | [INFO] [stdout] 68 | if box_found.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = box_found` [INFO] [stdout] 69 | let found_at = box_found.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_15.rs:52:18 [INFO] [stdout] | [INFO] [stdout] 52 | fn part_2(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 - fn part_2(input: &String) { [INFO] [stdout] 52 + fn part_2(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_17.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 154 - print!("\n"); [INFO] [stdout] 154 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_17.rs:158:23 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 158 - pub fn resolve(input: &String) { [INFO] [stdout] 158 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/resolvers/advent_15.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 55 | let parts: Vec<&str> = step.split(|c| c == '-' || c == '=').filter(|x| x.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['-', '=']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_15.rs:55:80 [INFO] [stdout] | [INFO] [stdout] 55 | let parts: Vec<&str> = step.split(|c| c == '-' || c == '=').filter(|x| x.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_15.rs:57:33 [INFO] [stdout] | [INFO] [stdout] 57 | let box_index = do_hash(&label); [INFO] [stdout] | ^^^^^^ help: change this to: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_18.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | RIGHT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_18.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | LEFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DOWN` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_18.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | DOWN [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Down` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TOP` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_16.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | TOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Top` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_16.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | LEFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_16.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | RIGHT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_18.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 30 - for i in 0..map.len() { [INFO] [stdout] 30 + for in &map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BOTTOM` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_16.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | BOTTOM [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Bottom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_18.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | for j in 0..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 31 - for j in 0..map[i].len() { [INFO] [stdout] 31 + for in map.iter().take(map[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_18.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 39 - print!("\n"); [INFO] [stdout] 39 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_16.rs:33:14 [INFO] [stdout] | [INFO] [stdout] 33 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 33 - for i in 0..map.len() { [INFO] [stdout] 33 + for in &map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_18.rs:43:23 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - pub fn resolve(input: &String) { [INFO] [stdout] 43 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_16.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | for j in 0..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 34 - for j in 0..map[i].len() { [INFO] [stdout] 34 + for in map.iter().take(map[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_18.rs:51:59 [INFO] [stdout] | [INFO] [stdout] 51 | let parts: Vec<&str> = line.split(' ').filter(|x| x.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_16.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 37 - print!("\n"); [INFO] [stdout] 37 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_16.rs:149:16 [INFO] [stdout] | [INFO] [stdout] 149 | if !next_as_option.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next_as_option.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `next_directions.1` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_16.rs:102:104 [INFO] [stdout] | [INFO] [stdout] 101 | if next_directions.1.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = next_directions.1` [INFO] [stdout] 102 | beams.push(Beam { row_index: start_beam.row_index, col_index: start_beam.col_index, direction: next_directions.1.unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `next_directions.1` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_16.rs:156:88 [INFO] [stdout] | [INFO] [stdout] 155 | if next_directions.1.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = next_directions.1` [INFO] [stdout] 156 | new_beams.push(Beam { row_index: next.0, col_index: next.1, direction: next_directions.1.unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_16.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return energize_tiles.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return energize_tiles.len(); [INFO] [stdout] 165 + energize_tiles.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_16.rs:105:12 [INFO] [stdout] | [INFO] [stdout] 105 | if beams.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `beams.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `beams` [INFO] [stdout] --> src/resolvers/advent_16.rs:109:18 [INFO] [stdout] | [INFO] [stdout] 109 | for i in 0..beams.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 109 - for i in 0..beams.len() { [INFO] [stdout] 109 + for in &beams { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_index` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_18.rs:86:38 [INFO] [stdout] | [INFO] [stdout] 86 | for row_index in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 86 - for row_index in 0..map.len() { [INFO] [stdout] 86 + for in &mut map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_index` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_18.rs:102:38 [INFO] [stdout] | [INFO] [stdout] 102 | for row_index in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 102 - for row_index in 0..map.len() { [INFO] [stdout] 102 + for in &mut map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_16.rs:168:23 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 168 - pub fn resolve(input: &String) { [INFO] [stdout] 168 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LOWER` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_19.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | LOWER, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lower` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GREATER` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_19.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | GREATER [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Greater` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / return match op { [INFO] [stdout] 40 | | Operator::GREATER => value_a > value_b, [INFO] [stdout] 41 | | Operator::LOWER => value_a < value_b, [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ match op { [INFO] [stdout] 40 + Operator::GREATER => value_a > value_b, [INFO] [stdout] 41 + Operator::LOWER => value_a < value_b, [INFO] [stdout] 42 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / return match op { [INFO] [stdout] 47 | | Operator::GREATER => (value, RANGE_MAX), [INFO] [stdout] 48 | | Operator::LOWER => (RANGE_MIN, value), [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 ~ match op { [INFO] [stdout] 47 + Operator::GREATER => (value, RANGE_MAX), [INFO] [stdout] 48 + Operator::LOWER => (RANGE_MIN, value), [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / return if parts.len() == 2 { [INFO] [stdout] 64 | | Self { [INFO] [stdout] 65 | | category: Some(parse_category(parts[0].chars().nth(0).unwrap())), [INFO] [stdout] 66 | | operator: Some(parse_operator(parts[0].chars().nth(1).unwrap())), [INFO] [stdout] ... | [INFO] [stdout] 77 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 ~ if parts.len() == 2 { [INFO] [stdout] 64 + Self { [INFO] [stdout] 65 + category: Some(parse_category(parts[0].chars().nth(0).unwrap())), [INFO] [stdout] 66 + operator: Some(parse_operator(parts[0].chars().nth(1).unwrap())), [INFO] [stdout] 67 + value_ref: Some(parts[0][2..].to_string().parse().unwrap()), [INFO] [stdout] 68 + output: String::from(parts[1]) [INFO] [stdout] 69 + } [INFO] [stdout] 70 + } else { [INFO] [stdout] 71 + Self { [INFO] [stdout] 72 + category: None, [INFO] [stdout] 73 + operator: None, [INFO] [stdout] 74 + value_ref: None, [INFO] [stdout] 75 + output: String::from(parts[0]) [INFO] [stdout] 76 + } [INFO] [stdout] 77 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_16.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | return beam_res; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return beam_res; [INFO] [stdout] 195 + beam_res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/resolvers/advent_16.rs:193:43 [INFO] [stdout] | [INFO] [stdout] 193 | let beam_res = energize_map(&map, &beam); [INFO] [stdout] | ^^^^^ help: change this to: `beam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_19.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | if !self.category.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.category.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `current.previous_cell_index` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_17.rs:24:29 [INFO] [stdout] | [INFO] [stdout] 21 | if current.previous_cell_index.is_some() { [INFO] [stdout] | ---------------------------------------- help: try: `if let Some() = current.previous_cell_index` [INFO] [stdout] ... [INFO] [stdout] 24 | let previous_cell = current.previous_cell_index.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return None; [INFO] [stdout] 93 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_17.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | return results; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return results; [INFO] [stdout] 83 + results [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_19.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn process(&self, values: &Vec) -> Option<&String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - pub fn process(&self, values: &Vec) -> Option<&String> { [INFO] [stdout] 80 + pub fn process(&self, values: &[usize]) -> Option<&String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_19.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 97 | if !self.category.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.category.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | / return match self.operator.unwrap() { [INFO] [stdout] 104 | | Operator::GREATER => { [INFO] [stdout] 105 | | let range_value = ranges.get(&category).unwrap(); [INFO] [stdout] 106 | | next_range_valid.insert(category, (self.value_ref.unwrap() + 1, range_value.1)); [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 ~ match self.operator.unwrap() { [INFO] [stdout] 104 + Operator::GREATER => { [INFO] [stdout] 105 + let range_value = ranges.get(&category).unwrap(); [INFO] [stdout] 106 + next_range_valid.insert(category, (self.value_ref.unwrap() + 1, range_value.1)); [INFO] [stdout] 107 + next_range_invalid.insert(category, (range_value.0, self.value_ref.unwrap())); [INFO] [stdout] 108 + (&self.output, next_range_valid.clone(), Some(next_range_invalid.clone())) [INFO] [stdout] 109 + }, [INFO] [stdout] 110 + Operator::LOWER => { [INFO] [stdout] 111 + let range_value = ranges.get(&category).unwrap(); [INFO] [stdout] 112 + next_range_valid.insert(category, (range_value.0, self.value_ref.unwrap() - 1)); [INFO] [stdout] 113 + next_range_invalid.insert(category, (self.value_ref.unwrap(), range_value.1)); [INFO] [stdout] 114 + (&self.output, next_range_valid.clone(), Some(next_range_invalid.clone())) [INFO] [stdout] 115 + } [INFO] [stdout] 116 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_19.rs:126:27 [INFO] [stdout] | [INFO] [stdout] 125 | if result.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = result` [INFO] [stdout] 126 | current = result.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return result; [INFO] [stdout] 152 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_17.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | return format!("{}_{}_{:?}_{}", position.row_index, position.col_index, position.previous_cell_index, position.previous_movements_in_same_direction); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return format!("{}_{}_{:?}_{}", position.row_index, position.col_index, position.previous_cell_index, position.previous_movements_in_same_direction); [INFO] [stdout] 87 + format!("{}_{}_{:?}_{}", position.row_index, position.col_index, position.previous_cell_index, position.previous_movements_in_same_direction) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.2` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_19.rs:173:41 [INFO] [stdout] | [INFO] [stdout] 172 | if result.2.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = result.2` [INFO] [stdout] 173 | current_range = result.2.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.2` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_19.rs:181:41 [INFO] [stdout] | [INFO] [stdout] 180 | if result.2.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = result.2` [INFO] [stdout] 181 | current_range = result.2.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `found` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_17.rs:125:44 [INFO] [stdout] | [INFO] [stdout] 124 | if found.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = found` [INFO] [stdout] 125 | let best_score_value = found.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_17.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return heat_loss; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return heat_loss; [INFO] [stdout] 144 + heat_loss [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_17.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if currents.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `currents.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `currents` [INFO] [stdout] --> src/resolvers/advent_17.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | for i in 0..currents.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 105 - for i in 0..currents.len() { [INFO] [stdout] 105 + for in ¤ts { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.2` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_19.rs:187:37 [INFO] [stdout] | [INFO] [stdout] 186 | if result.2.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = result.2` [INFO] [stdout] 187 | current_range = result.2.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_19.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 192 | if currents.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `currents.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/resolvers/advent_17.rs:127:53 [INFO] [stdout] | [INFO] [stdout] 127 | best_score.insert(score_id, *(&next_position.total_heat)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next_position.total_heat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/resolvers/advent_17.rs:131:49 [INFO] [stdout] | [INFO] [stdout] 131 | best_score.insert(score_id, *(&next_position.total_heat)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `next_position.total_heat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_19.rs:211:23 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 211 - pub fn resolve(input: &String) { [INFO] [stdout] 211 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_19.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_17.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 150 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 150 - for i in 0..map.len() { [INFO] [stdout] 150 + for in &map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | return Action::new(a); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 225 - return Action::new(a); [INFO] [stdout] 225 + Action::new(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_17.rs:151:18 [INFO] [stdout] | [INFO] [stdout] 151 | for j in 0..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 151 - for j in 0..map[i].len() { [INFO] [stdout] 151 + for in map.iter().take(map[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | return part[2..].parse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return part[2..].parse().unwrap() [INFO] [stdout] 231 + part[2..].parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_17.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 154 - print!("\n"); [INFO] [stdout] 154 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_20.rs:14:44 [INFO] [stdout] | [INFO] [stdout] 14 | fn has_destination(&self, destination: &String) -> bool; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_17.rs:158:23 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 158 - pub fn resolve(input: &String) { [INFO] [stdout] 158 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RIGHT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_18.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | RIGHT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return Self { [INFO] [stdout] 29 | | label: String::from("broadcaster"), [INFO] [stdout] 30 | | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Self { [INFO] [stdout] 29 + label: String::from("broadcaster"), [INFO] [stdout] 30 + destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LEFT` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_18.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | LEFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_20.rs:30:95 [INFO] [stdout] | [INFO] [stdout] 30 | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DOWN` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_18.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | DOWN [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Down` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / return self.destinations.iter().map(|destination| -> (String, Pulse) { [INFO] [stdout] 38 | | return (destination.clone(), pulse.clone()); [INFO] [stdout] 39 | | }).collect(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ self.destinations.iter().map(|destination| -> (String, Pulse) { [INFO] [stdout] 38 + return (destination.clone(), pulse.clone()); [INFO] [stdout] 39 ~ }).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_18.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | for i in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 30 - for i in 0..map.len() { [INFO] [stdout] 30 + for in &map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | return (destination.clone(), pulse.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return (destination.clone(), pulse.clone()); [INFO] [stdout] 38 + (destination.clone(), pulse.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_18.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | for j in 0..map[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 31 - for j in 0..map[i].len() { [INFO] [stdout] 31 + for in map.iter().take(map[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pulse` which implements the `Copy` trait [INFO] [stdout] --> src/resolvers/advent_20.rs:38:42 [INFO] [stdout] | [INFO] [stdout] 38 | return (destination.clone(), pulse.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*pulse` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/resolvers/advent_18.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 39 - print!("\n"); [INFO] [stdout] 39 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return self.label.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return self.label.clone(); [INFO] [stdout] 43 + self.label.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_18.rs:43:23 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - pub fn resolve(input: &String) { [INFO] [stdout] 43 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return self.destinations.contains(destination); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return self.destinations.contains(destination); [INFO] [stdout] 47 + self.destinations.contains(destination) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_18.rs:51:59 [INFO] [stdout] | [INFO] [stdout] 51 | let parts: Vec<&str> = line.split(' ').filter(|x| x.len() > 0).collect(); [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_index` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_18.rs:86:38 [INFO] [stdout] | [INFO] [stdout] 86 | for row_index in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 86 - for row_index in 0..map.len() { [INFO] [stdout] 86 + for in &mut map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return Self { [INFO] [stdout] 62 | | label: String::from(&label[1..]), [INFO] [stdout] 63 | | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 64 | | status: false [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Self { [INFO] [stdout] 62 + label: String::from(&label[1..]), [INFO] [stdout] 63 + destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 64 + status: false [INFO] [stdout] 65 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row_index` is only used to index `map` [INFO] [stdout] --> src/resolvers/advent_18.rs:102:38 [INFO] [stdout] | [INFO] [stdout] 102 | for row_index in 0..map.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 102 - for row_index in 0..map.len() { [INFO] [stdout] 102 + for in &mut map { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_20.rs:63:95 [INFO] [stdout] | [INFO] [stdout] 63 | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LOWER` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_19.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | LOWER, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Lower` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return out; [INFO] [stdout] 82 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GREATER` contains a capitalized acronym [INFO] [stdout] --> src/resolvers/advent_19.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | GREATER [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Greater` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | return (destination.clone(), if !self.status { Pulse::High } else { Pulse::Low }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return (destination.clone(), if !self.status { Pulse::High } else { Pulse::Low }); [INFO] [stdout] 78 + (destination.clone(), if !self.status { Pulse::High } else { Pulse::Low }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / return match op { [INFO] [stdout] 40 | | Operator::GREATER => value_a > value_b, [INFO] [stdout] 41 | | Operator::LOWER => value_a < value_b, [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ match op { [INFO] [stdout] 40 + Operator::GREATER => value_a > value_b, [INFO] [stdout] 41 + Operator::LOWER => value_a < value_b, [INFO] [stdout] 42 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return self.label.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return self.label.clone(); [INFO] [stdout] 86 + self.label.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / return match op { [INFO] [stdout] 47 | | Operator::GREATER => (value, RANGE_MAX), [INFO] [stdout] 48 | | Operator::LOWER => (RANGE_MIN, value), [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 ~ match op { [INFO] [stdout] 47 + Operator::GREATER => (value, RANGE_MAX), [INFO] [stdout] 48 + Operator::LOWER => (RANGE_MIN, value), [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return self.destinations.contains(destination); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return self.destinations.contains(destination); [INFO] [stdout] 90 + self.destinations.contains(destination) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / return if parts.len() == 2 { [INFO] [stdout] 64 | | Self { [INFO] [stdout] 65 | | category: Some(parse_category(parts[0].chars().nth(0).unwrap())), [INFO] [stdout] 66 | | operator: Some(parse_operator(parts[0].chars().nth(1).unwrap())), [INFO] [stdout] ... | [INFO] [stdout] 77 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 ~ if parts.len() == 2 { [INFO] [stdout] 64 + Self { [INFO] [stdout] 65 + category: Some(parse_category(parts[0].chars().nth(0).unwrap())), [INFO] [stdout] 66 + operator: Some(parse_operator(parts[0].chars().nth(1).unwrap())), [INFO] [stdout] 67 + value_ref: Some(parts[0][2..].to_string().parse().unwrap()), [INFO] [stdout] 68 + output: String::from(parts[1]) [INFO] [stdout] 69 + } [INFO] [stdout] 70 + } else { [INFO] [stdout] 71 + Self { [INFO] [stdout] 72 + category: None, [INFO] [stdout] 73 + operator: None, [INFO] [stdout] 74 + value_ref: None, [INFO] [stdout] 75 + output: String::from(parts[0]) [INFO] [stdout] 76 + } [INFO] [stdout] 77 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | / return Self { [INFO] [stdout] 104 | | label: String::from(&label[1..]), [INFO] [stdout] 105 | | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 106 | | inputs_module: Vec::new() [INFO] [stdout] 107 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 ~ Self { [INFO] [stdout] 104 + label: String::from(&label[1..]), [INFO] [stdout] 105 + destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 106 + inputs_module: Vec::new() [INFO] [stdout] 107 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_19.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | if !self.category.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.category.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return None; [INFO] [stdout] 93 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_19.rs:80:35 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn process(&self, values: &Vec) -> Option<&String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - pub fn process(&self, values: &Vec) -> Option<&String> { [INFO] [stdout] 80 + pub fn process(&self, values: &[usize]) -> Option<&String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_19.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 97 | if !self.category.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.category.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | / return match self.operator.unwrap() { [INFO] [stdout] 104 | | Operator::GREATER => { [INFO] [stdout] 105 | | let range_value = ranges.get(&category).unwrap(); [INFO] [stdout] 106 | | next_range_valid.insert(category, (self.value_ref.unwrap() + 1, range_value.1)); [INFO] [stdout] ... | [INFO] [stdout] 116 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 ~ match self.operator.unwrap() { [INFO] [stdout] 104 + Operator::GREATER => { [INFO] [stdout] 105 + let range_value = ranges.get(&category).unwrap(); [INFO] [stdout] 106 + next_range_valid.insert(category, (self.value_ref.unwrap() + 1, range_value.1)); [INFO] [stdout] 107 + next_range_invalid.insert(category, (range_value.0, self.value_ref.unwrap())); [INFO] [stdout] 108 + (&self.output, next_range_valid.clone(), Some(next_range_invalid.clone())) [INFO] [stdout] 109 + }, [INFO] [stdout] 110 + Operator::LOWER => { [INFO] [stdout] 111 + let range_value = ranges.get(&category).unwrap(); [INFO] [stdout] 112 + next_range_valid.insert(category, (range_value.0, self.value_ref.unwrap() - 1)); [INFO] [stdout] 113 + next_range_invalid.insert(category, (self.value_ref.unwrap(), range_value.1)); [INFO] [stdout] 114 + (&self.output, next_range_valid.clone(), Some(next_range_invalid.clone())) [INFO] [stdout] 115 + } [INFO] [stdout] 116 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_20.rs:105:95 [INFO] [stdout] | [INFO] [stdout] 105 | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | return self.destinations.contains(destination); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return self.destinations.contains(destination); [INFO] [stdout] 115 + self.destinations.contains(destination) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | / return self.destinations.iter().map(|destination| -> (String, Pulse) { [INFO] [stdout] 131 | | return (destination.clone(), pulse_to_send); [INFO] [stdout] 132 | | }).collect(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 ~ self.destinations.iter().map(|destination| -> (String, Pulse) { [INFO] [stdout] 131 + return (destination.clone(), pulse_to_send); [INFO] [stdout] 132 ~ }).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | return (destination.clone(), pulse_to_send); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return (destination.clone(), pulse_to_send); [INFO] [stdout] 131 + (destination.clone(), pulse_to_send) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | return self.label.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return self.label.clone(); [INFO] [stdout] 136 + self.label.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | return self.destinations.contains(destination); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return self.destinations.contains(destination); [INFO] [stdout] 140 + self.destinations.contains(destination) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_19.rs:126:27 [INFO] [stdout] | [INFO] [stdout] 125 | if result.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = result` [INFO] [stdout] 126 | current = result.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_20.rs:178:16 [INFO] [stdout] | [INFO] [stdout] 178 | if !modules_index.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `modules_index.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | return (sum_high_pulse, sum_low_pulse, rx_called_with_low); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return (sum_high_pulse, sum_low_pulse, rx_called_with_low); [INFO] [stdout] 223 + (sum_high_pulse, sum_low_pulse, rx_called_with_low) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_20.rs:154:14 [INFO] [stdout] | [INFO] [stdout] 154 | modules: &mut Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 154 - modules: &mut Vec>, [INFO] [stdout] 154 + modules: &mut [Box], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return result; [INFO] [stdout] 152 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_20.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 163 | if actions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `actions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.2` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_19.rs:173:41 [INFO] [stdout] | [INFO] [stdout] 172 | if result.2.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = result.2` [INFO] [stdout] 173 | current_range = result.2.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.2` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_19.rs:181:41 [INFO] [stdout] | [INFO] [stdout] 180 | if result.2.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = result.2` [INFO] [stdout] 181 | current_range = result.2.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.2` after checking its variant with `is_some` [INFO] [stdout] --> src/resolvers/advent_19.rs:187:37 [INFO] [stdout] | [INFO] [stdout] 186 | if result.2.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = result.2` [INFO] [stdout] 187 | current_range = result.2.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_20.rs:243:23 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 243 - pub fn resolve(input: &String) { [INFO] [stdout] 243 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_19.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 192 | if currents.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `currents.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_19.rs:211:23 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 211 - pub fn resolve(input: &String) { [INFO] [stdout] 211 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_19.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/resolvers/advent_20.rs:253:30 [INFO] [stdout] | [INFO] [stdout] 253 | let first_char = parts[0].chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `parts[0].chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | return Action::new(a); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 225 - return Action::new(a); [INFO] [stdout] 225 + Action::new(a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_19.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | return part[2..].parse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return part[2..].parse().unwrap() [INFO] [stdout] 231 + part[2..].parse().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_21.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn resolve(input: &String) { [INFO] [stdout] 1 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_22.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn resolve(input: &String) { [INFO] [stdout] 1 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_20.rs:14:44 [INFO] [stdout] | [INFO] [stdout] 14 | fn has_destination(&self, destination: &String) -> bool; [INFO] [stdout] | ^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_23.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn resolve(input: &String) { [INFO] [stdout] 1 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return Self { [INFO] [stdout] 29 | | label: String::from("broadcaster"), [INFO] [stdout] 30 | | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Self { [INFO] [stdout] 29 + label: String::from("broadcaster"), [INFO] [stdout] 30 + destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_24.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return (a, b); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return (a, b); [INFO] [stdout] 19 + (a, b) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_20.rs:30:95 [INFO] [stdout] | [INFO] [stdout] 30 | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_24.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return (x, y); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return (x, y); [INFO] [stdout] 35 + (x, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / return self.destinations.iter().map(|destination| -> (String, Pulse) { [INFO] [stdout] 38 | | return (destination.clone(), pulse.clone()); [INFO] [stdout] 39 | | }).collect(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 ~ self.destinations.iter().map(|destination| -> (String, Pulse) { [INFO] [stdout] 38 + return (destination.clone(), pulse.clone()); [INFO] [stdout] 39 ~ }).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | return (destination.clone(), pulse.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return (destination.clone(), pulse.clone()); [INFO] [stdout] 38 + (destination.clone(), pulse.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_24.rs:43:23 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - pub fn resolve(input: &String) { [INFO] [stdout] 43 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_24.rs:50:25 [INFO] [stdout] | [INFO] [stdout] 50 | .filter(|x| x.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_24.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | .filter(|x| x.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return content; [INFO] [stdout] 9 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pulse` which implements the `Copy` trait [INFO] [stdout] --> src/resolvers/advent_20.rs:38:42 [INFO] [stdout] | [INFO] [stdout] 38 | return (destination.clone(), pulse.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*pulse` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return self.label.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return self.label.clone(); [INFO] [stdout] 43 + self.label.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return self.destinations.contains(destination); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return self.destinations.contains(destination); [INFO] [stdout] 47 + self.destinations.contains(destination) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | / return Self { [INFO] [stdout] 62 | | label: String::from(&label[1..]), [INFO] [stdout] 63 | | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 64 | | status: false [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 ~ Self { [INFO] [stdout] 62 + label: String::from(&label[1..]), [INFO] [stdout] 63 + destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 64 + status: false [INFO] [stdout] 65 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_20.rs:63:95 [INFO] [stdout] | [INFO] [stdout] 63 | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return out; [INFO] [stdout] 82 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | return (destination.clone(), if !self.status { Pulse::High } else { Pulse::Low }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return (destination.clone(), if !self.status { Pulse::High } else { Pulse::Low }); [INFO] [stdout] 78 + (destination.clone(), if !self.status { Pulse::High } else { Pulse::Low }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return self.label.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return self.label.clone(); [INFO] [stdout] 86 + self.label.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return self.destinations.contains(destination); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return self.destinations.contains(destination); [INFO] [stdout] 90 + self.destinations.contains(destination) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | / return Self { [INFO] [stdout] 104 | | label: String::from(&label[1..]), [INFO] [stdout] 105 | | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 106 | | inputs_module: Vec::new() [INFO] [stdout] 107 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 ~ Self { [INFO] [stdout] 104 + label: String::from(&label[1..]), [INFO] [stdout] 105 + destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] 106 + inputs_module: Vec::new() [INFO] [stdout] 107 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_20.rs:105:95 [INFO] [stdout] | [INFO] [stdout] 105 | destinations: out.split(", ").map(|dest| String::from(dest.trim())).filter(|dest| dest.len() > 0).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | return self.destinations.contains(destination); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return self.destinations.contains(destination); [INFO] [stdout] 115 + self.destinations.contains(destination) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | / return self.destinations.iter().map(|destination| -> (String, Pulse) { [INFO] [stdout] 131 | | return (destination.clone(), pulse_to_send); [INFO] [stdout] 132 | | }).collect(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 ~ self.destinations.iter().map(|destination| -> (String, Pulse) { [INFO] [stdout] 131 + return (destination.clone(), pulse_to_send); [INFO] [stdout] 132 ~ }).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | return (destination.clone(), pulse_to_send); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return (destination.clone(), pulse_to_send); [INFO] [stdout] 131 + (destination.clone(), pulse_to_send) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | return self.label.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return self.label.clone(); [INFO] [stdout] 136 + self.label.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | return self.destinations.contains(destination); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return self.destinations.contains(destination); [INFO] [stdout] 140 + self.destinations.contains(destination) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolvers/advent_20.rs:178:16 [INFO] [stdout] | [INFO] [stdout] 178 | if !modules_index.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `modules_index.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_20.rs:223:5 [INFO] [stdout] | [INFO] [stdout] 223 | return (sum_high_pulse, sum_low_pulse, rx_called_with_low); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - return (sum_high_pulse, sum_low_pulse, rx_called_with_low); [INFO] [stdout] 223 + (sum_high_pulse, sum_low_pulse, rx_called_with_low) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_20.rs:154:14 [INFO] [stdout] | [INFO] [stdout] 154 | modules: &mut Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 154 - modules: &mut Vec>, [INFO] [stdout] 154 + modules: &mut [Box], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_20.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 163 | if actions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `actions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_20.rs:243:23 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 243 - pub fn resolve(input: &String) { [INFO] [stdout] 243 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/resolvers/advent_20.rs:253:30 [INFO] [stdout] | [INFO] [stdout] 253 | let first_char = parts[0].chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `parts[0].chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_21.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn resolve(input: &String) { [INFO] [stdout] 1 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_22.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn resolve(input: &String) { [INFO] [stdout] 1 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_23.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn resolve(input: &String) { [INFO] [stdout] 1 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_24.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return (a, b); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return (a, b); [INFO] [stdout] 19 + (a, b) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/resolvers/advent_24.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return (x, y); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return (x, y); [INFO] [stdout] 35 + (x, y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/resolvers/advent_24.rs:43:23 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn resolve(input: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 43 - pub fn resolve(input: &String) { [INFO] [stdout] 43 + pub fn resolve(input: &str) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_24.rs:50:25 [INFO] [stdout] | [INFO] [stdout] 50 | .filter(|x| x.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/resolvers/advent_24.rs:57:25 [INFO] [stdout] | [INFO] [stdout] 57 | .filter(|x| x.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return content; [INFO] [stdout] 9 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.46s [INFO] running `Command { std: "docker" "inspect" "3bb906b0e14511efb5413e8e39de8a7f64bce88aa993771f6fef3202d65c57dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bb906b0e14511efb5413e8e39de8a7f64bce88aa993771f6fef3202d65c57dd", kill_on_drop: false }` [INFO] [stdout] 3bb906b0e14511efb5413e8e39de8a7f64bce88aa993771f6fef3202d65c57dd