[INFO] cloning repository https://github.com/ngaionice/phaseshift [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ngaionice/phaseshift" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fngaionice%2Fphaseshift", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fngaionice%2Fphaseshift'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] efb6a63f9ce8cffcd9c264e9b4bd2aeb45e600b2 [INFO] linting ngaionice/phaseshift against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fngaionice%2Fphaseshift" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ngaionice/phaseshift [INFO] finished tweaking git repo https://github.com/ngaionice/phaseshift [INFO] tweaked toml for git repo https://github.com/ngaionice/phaseshift written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ngaionice/phaseshift on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ngaionice/phaseshift already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bytemuck v1.7.2 [INFO] [stderr] Downloaded weezl v0.1.5 [INFO] [stderr] Downloaded gif v0.11.3 [INFO] [stderr] Downloaded crc32fast v1.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ab5b4c4407ec3a5079644c7758f6e3eae8976dd924292bee7209cec07080d49 [INFO] running `Command { std: "docker" "start" "-a" "7ab5b4c4407ec3a5079644c7758f6e3eae8976dd924292bee7209cec07080d49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ab5b4c4407ec3a5079644c7758f6e3eae8976dd924292bee7209cec07080d49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ab5b4c4407ec3a5079644c7758f6e3eae8976dd924292bee7209cec07080d49", kill_on_drop: false }` [INFO] [stdout] 7ab5b4c4407ec3a5079644c7758f6e3eae8976dd924292bee7209cec07080d49 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66fd8ac4159b4b847282e0d999ef3cb164f1967dcdf2ca3905b9ab9e6ca8c75e [INFO] running `Command { std: "docker" "start" "-a" "66fd8ac4159b4b847282e0d999ef3cb164f1967dcdf2ca3905b9ab9e6ca8c75e", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling libc v0.2.108 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.5 [INFO] [stderr] Checking gif v0.11.3 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rayon-core v1.9.1 [INFO] [stderr] Checking rayon v1.5.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking phaseshifter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if !fs::metadata(output_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(output_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:100:30 [INFO] [stdout] | [INFO] [stdout] 100 | fn get_filename_no_ext(path: &path::PathBuf) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 100 - fn get_filename_no_ext(path: &path::PathBuf) -> String { [INFO] [stdout] 100 + fn get_filename_no_ext(path: &Path) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if command.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if command.eq("") { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if !fs::metadata(output_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(output_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:100:30 [INFO] [stdout] | [INFO] [stdout] 100 | fn get_filename_no_ext(path: &path::PathBuf) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 100 - fn get_filename_no_ext(path: &path::PathBuf) -> String { [INFO] [stdout] 100 + fn get_filename_no_ext(path: &Path) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.30s [INFO] running `Command { std: "docker" "inspect" "66fd8ac4159b4b847282e0d999ef3cb164f1967dcdf2ca3905b9ab9e6ca8c75e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66fd8ac4159b4b847282e0d999ef3cb164f1967dcdf2ca3905b9ab9e6ca8c75e", kill_on_drop: false }` [INFO] [stdout] 66fd8ac4159b4b847282e0d999ef3cb164f1967dcdf2ca3905b9ab9e6ca8c75e