[INFO] cloning repository https://github.com/nepet/rust-passphrase [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nepet/rust-passphrase" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnepet%2Frust-passphrase", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnepet%2Frust-passphrase'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0bcb2d7868f9f8b5abee145f48709a26547e8c31 [INFO] linting nepet/rust-passphrase against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnepet%2Frust-passphrase" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nepet/rust-passphrase [INFO] finished tweaking git repo https://github.com/nepet/rust-passphrase [INFO] tweaked toml for git repo https://github.com/nepet/rust-passphrase written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nepet/rust-passphrase on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nepet/rust-passphrase already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e1edec8735a0bdf7f6362b94afca5e2cab6197a5283dbe256cd4885e405ca25 [INFO] running `Command { std: "docker" "start" "-a" "7e1edec8735a0bdf7f6362b94afca5e2cab6197a5283dbe256cd4885e405ca25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e1edec8735a0bdf7f6362b94afca5e2cab6197a5283dbe256cd4885e405ca25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e1edec8735a0bdf7f6362b94afca5e2cab6197a5283dbe256cd4885e405ca25", kill_on_drop: false }` [INFO] [stdout] 7e1edec8735a0bdf7f6362b94afca5e2cab6197a5283dbe256cd4885e405ca25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c8769c4064b23b3ae84f0ca26341e75d0dc7c2814e08e3a5868bb6decd50139 [INFO] running `Command { std: "docker" "start" "-a" "8c8769c4064b23b3ae84f0ca26341e75d0dc7c2814e08e3a5868bb6decd50139", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking rust-passphrase v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if !nw_p.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `nw_p.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !nt_p.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `nt_p.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if !np_p.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `np_p.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `nw_p` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:22:35 [INFO] [stdout] | [INFO] [stdout] 21 | if !nw_p.is_ok() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 22 | println!("error: {}", nw_p.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `nt_p` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:29:35 [INFO] [stdout] | [INFO] [stdout] 28 | if !nt_p.is_ok() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 29 | println!("error: {}", nt_p.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `np_p` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:36:35 [INFO] [stdout] | [INFO] [stdout] 35 | if !np_p.is_ok() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 36 | println!("error: {}", np_p.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/main.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | fn get_words(n: i32, dict: &Box) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn dict::Dict` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `c` is used as a loop counter [INFO] [stdout] --> src/main.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | for w in words { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `for (c, w) in (1..).zip(words.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let mut c = n.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if !nw_p.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `nw_p.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !nt_p.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `nt_p.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if !np_p.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `np_p.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `nw_p` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:22:35 [INFO] [stdout] | [INFO] [stdout] 21 | if !nw_p.is_ok() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 22 | println!("error: {}", nw_p.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `nt_p` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:29:35 [INFO] [stdout] | [INFO] [stdout] 28 | if !nt_p.is_ok() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 29 | println!("error: {}", nt_p.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `np_p` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:36:35 [INFO] [stdout] | [INFO] [stdout] 35 | if !np_p.is_ok() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 36 | println!("error: {}", np_p.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/main.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | fn get_words(n: i32, dict: &Box) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn dict::Dict` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `c` is used as a loop counter [INFO] [stdout] --> src/main.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | for w in words { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `for (c, w) in (1..).zip(words.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let mut c = n.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.90s [INFO] running `Command { std: "docker" "inspect" "8c8769c4064b23b3ae84f0ca26341e75d0dc7c2814e08e3a5868bb6decd50139", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c8769c4064b23b3ae84f0ca26341e75d0dc7c2814e08e3a5868bb6decd50139", kill_on_drop: false }` [INFO] [stdout] 8c8769c4064b23b3ae84f0ca26341e75d0dc7c2814e08e3a5868bb6decd50139