[INFO] cloning repository https://github.com/neosmart/static-compress [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/neosmart/static-compress" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fneosmart%2Fstatic-compress", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fneosmart%2Fstatic-compress'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7fe0e3dc5af9996c4b8c51ae8aa566e533ce1d9d [INFO] linting neosmart/static-compress against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fneosmart%2Fstatic-compress" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/neosmart/static-compress [INFO] finished tweaking git repo https://github.com/neosmart/static-compress [INFO] tweaked toml for git repo https://github.com/neosmart/static-compress written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/neosmart/static-compress on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/neosmart/static-compress already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded typed-arena v2.0.1 [INFO] [stderr] Downloaded separator v0.4.1 [INFO] [stderr] Downloaded stderr v0.8.0 [INFO] [stderr] Downloaded rustversion v1.0.8 [INFO] [stderr] Downloaded zopfli v0.7.1 [INFO] [stderr] Downloaded prettytable-rs v0.9.0 [INFO] [stderr] Downloaded iter-read v0.3.1 [INFO] [stderr] Downloaded filetime v0.2.17 [INFO] [stderr] Downloaded chan v0.1.23 [INFO] [stderr] Downloaded globset v0.4.9 [INFO] [stderr] Downloaded textwrap v0.15.1 [INFO] [stderr] Downloaded size v0.4.0 [INFO] [stderr] Downloaded clap v3.2.22 [INFO] [stderr] Downloaded libc v0.2.133 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b6dbafd933e17195a73f1af6120160305c3713e8987d7a57e64df4af12699785 [INFO] running `Command { std: "docker" "start" "-a" "b6dbafd933e17195a73f1af6120160305c3713e8987d7a57e64df4af12699785", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b6dbafd933e17195a73f1af6120160305c3713e8987d7a57e64df4af12699785", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6dbafd933e17195a73f1af6120160305c3713e8987d7a57e64df4af12699785", kill_on_drop: false }` [INFO] [stdout] b6dbafd933e17195a73f1af6120160305c3713e8987d7a57e64df4af12699785 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d69934b491819eff9616065bdc5794ff610da858864c4a836786efc444b9f838 [INFO] running `Command { std: "docker" "start" "-a" "d69934b491819eff9616065bdc5794ff610da858864c4a836786efc444b9f838", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling libc v0.2.133 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling backtrace v0.3.66 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking gimli v0.26.2 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking object v0.29.0 [INFO] [stderr] Checking crc-catalog v2.1.0 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking crc v3.0.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking iter-read v0.3.1 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking textwrap v0.15.1 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking stderr v0.8.0 [INFO] [stderr] Checking clap v3.2.22 [INFO] [stderr] Checking zopfli v0.7.1 [INFO] [stderr] Checking chan v0.1.23 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Checking size v0.4.0 [INFO] [stderr] Checking separator v0.4.1 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking globset v0.4.9 [INFO] [stderr] Checking prettytable-rs v0.9.0 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking static-compress v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `has_error_description_deprecated` [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | errors { [INFO] [stdout] 3 | | InvalidParameterValue(pname: &'static str) { [INFO] [stdout] 4 | | description("An invalid value was supplied for a command line argument.") [INFO] [stdout] ... | [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `impl_error_chain_processed` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `impl_error_chain_processed` may come from an old version of the `error_chain` crate, try updating your dependency with `cargo update -p error_chain` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lists.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub const COMP_EXTS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lists.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | pub const COMP_EXTS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `has_error_description_deprecated` [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | errors { [INFO] [stdout] 3 | | InvalidParameterValue(pname: &'static str) { [INFO] [stdout] 4 | | description("An invalid value was supplied for a command line argument.") [INFO] [stdout] ... | [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `impl_error_chain_processed` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `impl_error_chain_processed` may come from an old version of the `error_chain` crate, try updating your dependency with `cargo update -p error_chain` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lists.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub const COMP_EXTS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lists.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | pub const COMP_EXTS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `show_summary` is never read [INFO] [stdout] --> src/structs.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Parameters { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub show_summary: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/compression.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / match self { [INFO] [stdout] 15 | | &CompressionAlgorithm::Brotli => "br", [INFO] [stdout] 16 | | &CompressionAlgorithm::GZip => "gz", [INFO] [stdout] 17 | | &CompressionAlgorithm::WebP => "webp", [INFO] [stdout] 18 | | &CompressionAlgorithm::Zopfli => "gz", [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 14 ~ match *self { [INFO] [stdout] 15 ~ CompressionAlgorithm::Brotli => "br", [INFO] [stdout] 16 ~ CompressionAlgorithm::GZip => "gz", [INFO] [stdout] 17 ~ CompressionAlgorithm::WebP => "webp", [INFO] [stdout] 18 ~ CompressionAlgorithm::Zopfli => "gz", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/compression.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / match self { [INFO] [stdout] 26 | | &CompressionAlgorithm::GZip => gzip_compress(src, dst, quality), [INFO] [stdout] 27 | | &CompressionAlgorithm::Brotli => brotli_compress(src, dst, quality), [INFO] [stdout] 28 | | &CompressionAlgorithm::WebP => webp_compress(src, dst, quality), [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 25 ~ match *self { [INFO] [stdout] 26 ~ CompressionAlgorithm::GZip => gzip_compress(src, dst, quality), [INFO] [stdout] 27 ~ CompressionAlgorithm::Brotli => brotli_compress(src, dst, quality), [INFO] [stdout] 28 ~ CompressionAlgorithm::WebP => webp_compress(src, dst, quality), [INFO] [stdout] 29 ~ CompressionAlgorithm::Zopfli => zopfli_compress(src, dst, quality), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return Ok(r); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return Ok(r); [INFO] [stdout] 34 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | return self.total_compressed as f32 / self.total_uncompressed as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return self.total_compressed as f32 / self.total_uncompressed as f32; [INFO] [stdout] 89 + self.total_compressed as f32 / self.total_uncompressed as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return self.total_compressed_now as f32 / self.total_uncompressed_now as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return self.total_compressed_now as f32 / self.total_uncompressed_now as f32; [INFO] [stdout] 93 + self.total_compressed_now as f32 / self.total_uncompressed_now as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/structs.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:91:22 [INFO] [stdout] | [INFO] [stdout] 91 | fn get_parameter<'a, T>(matches: &clap::ArgMatches, name: &'static str, default_value: T) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:161:18 [INFO] [stdout] | [INFO] [stdout] 161 | fn start_workers<'a>(params: &Arc) -> (chan::Sender, mpsc::Receiver, chan::WaitGroup) { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:280:8 [INFO] [stdout] | [INFO] [stdout] 280 | if !stats_tx.send(local_stats).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stats_tx.send(local_stats).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | / loop { [INFO] [stdout] 223 | | let src = match rx.recv() { [INFO] [stdout] 224 | | Some(task) => task, [INFO] [stdout] 225 | | None => break, // No more tasks [INFO] [stdout] ... | [INFO] [stdout] 278 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 222 ~ while let Some(task) = rx.recv() { [INFO] [stdout] 223 + let src = task; [INFO] [stdout] 224 + .. [INFO] [stdout] 225 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/main.rs:268:18 [INFO] [stdout] | [INFO] [stdout] 268 | .map_err(|e| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 268 ~ .inspect_err(|e| { [INFO] [stdout] 269 | // Try deleting the invalid destination file, but don't care if we can't [INFO] [stdout] 270 ~ std::fs::remove_file(dst).unwrap_or_default(); // Bubble up the same error [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:267:19 [INFO] [stdout] | [INFO] [stdout] 267 | }(&mut local_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `local_stats` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:314:5 [INFO] [stdout] | [INFO] [stdout] 314 | return Ok(r); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 314 - return Ok(r); [INFO] [stdout] 314 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:309:35 [INFO] [stdout] | [INFO] [stdout] 309 | str_search(COMP_EXTS, &ext, false).is_ok() [INFO] [stdout] | ^^^^ help: change this to: `ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | fn fix_filters(filters: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 318 - fn fix_filters(filters: &mut Vec) { [INFO] [stdout] 318 + fn fix_filters(filters: &mut [String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `filters` [INFO] [stdout] --> src/main.rs:319:14 [INFO] [stdout] | [INFO] [stdout] 319 | for i in 0..filters.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 319 - for i in 0..filters.len() { [INFO] [stdout] 319 + for in &mut filters { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/main.rs:322:17 [INFO] [stdout] | [INFO] [stdout] 322 | let ref path = filters[i]; [INFO] [stdout] | ----^^^^^^^^-------------- help: try: `let path = &filters[i];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:353:45 [INFO] [stdout] | [INFO] [stdout] 353 | c => { last_char = Some(c.clone()); true } [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:386:29 [INFO] [stdout] | [INFO] [stdout] 386 | let dir = match PathBuf::from(dir).parent() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `show_summary` is never read [INFO] [stdout] --> src/structs.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Parameters { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub show_summary: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/compression.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / match self { [INFO] [stdout] 15 | | &CompressionAlgorithm::Brotli => "br", [INFO] [stdout] 16 | | &CompressionAlgorithm::GZip => "gz", [INFO] [stdout] 17 | | &CompressionAlgorithm::WebP => "webp", [INFO] [stdout] 18 | | &CompressionAlgorithm::Zopfli => "gz", [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 14 ~ match *self { [INFO] [stdout] 15 ~ CompressionAlgorithm::Brotli => "br", [INFO] [stdout] 16 ~ CompressionAlgorithm::GZip => "gz", [INFO] [stdout] 17 ~ CompressionAlgorithm::WebP => "webp", [INFO] [stdout] 18 ~ CompressionAlgorithm::Zopfli => "gz", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/compression.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / match self { [INFO] [stdout] 26 | | &CompressionAlgorithm::GZip => gzip_compress(src, dst, quality), [INFO] [stdout] 27 | | &CompressionAlgorithm::Brotli => brotli_compress(src, dst, quality), [INFO] [stdout] 28 | | &CompressionAlgorithm::WebP => webp_compress(src, dst, quality), [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 25 ~ match *self { [INFO] [stdout] 26 ~ CompressionAlgorithm::GZip => gzip_compress(src, dst, quality), [INFO] [stdout] 27 ~ CompressionAlgorithm::Brotli => brotli_compress(src, dst, quality), [INFO] [stdout] 28 ~ CompressionAlgorithm::WebP => webp_compress(src, dst, quality), [INFO] [stdout] 29 ~ CompressionAlgorithm::Zopfli => zopfli_compress(src, dst, quality), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return Ok(r); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return Ok(r); [INFO] [stdout] 34 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | return self.total_compressed as f32 / self.total_uncompressed as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return self.total_compressed as f32 / self.total_uncompressed as f32; [INFO] [stdout] 89 + self.total_compressed as f32 / self.total_uncompressed as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return self.total_compressed_now as f32 / self.total_uncompressed_now as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return self.total_compressed_now as f32 / self.total_uncompressed_now as f32; [INFO] [stdout] 93 + self.total_compressed_now as f32 / self.total_uncompressed_now as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/structs.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:91:22 [INFO] [stdout] | [INFO] [stdout] 91 | fn get_parameter<'a, T>(matches: &clap::ArgMatches, name: &'static str, default_value: T) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:161:18 [INFO] [stdout] | [INFO] [stdout] 161 | fn start_workers<'a>(params: &Arc) -> (chan::Sender, mpsc::Receiver, chan::WaitGroup) { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:280:8 [INFO] [stdout] | [INFO] [stdout] 280 | if !stats_tx.send(local_stats).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stats_tx.send(local_stats).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | / loop { [INFO] [stdout] 223 | | let src = match rx.recv() { [INFO] [stdout] 224 | | Some(task) => task, [INFO] [stdout] 225 | | None => break, // No more tasks [INFO] [stdout] ... | [INFO] [stdout] 278 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 222 ~ while let Some(task) = rx.recv() { [INFO] [stdout] 223 + let src = task; [INFO] [stdout] 224 + .. [INFO] [stdout] 225 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/main.rs:268:18 [INFO] [stdout] | [INFO] [stdout] 268 | .map_err(|e| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 268 ~ .inspect_err(|e| { [INFO] [stdout] 269 | // Try deleting the invalid destination file, but don't care if we can't [INFO] [stdout] 270 ~ std::fs::remove_file(dst).unwrap_or_default(); // Bubble up the same error [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:267:19 [INFO] [stdout] | [INFO] [stdout] 267 | }(&mut local_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `local_stats` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:314:5 [INFO] [stdout] | [INFO] [stdout] 314 | return Ok(r); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 314 - return Ok(r); [INFO] [stdout] 314 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:309:35 [INFO] [stdout] | [INFO] [stdout] 309 | str_search(COMP_EXTS, &ext, false).is_ok() [INFO] [stdout] | ^^^^ help: change this to: `ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:318:25 [INFO] [stdout] | [INFO] [stdout] 318 | fn fix_filters(filters: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 318 - fn fix_filters(filters: &mut Vec) { [INFO] [stdout] 318 + fn fix_filters(filters: &mut [String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `filters` [INFO] [stdout] --> src/main.rs:319:14 [INFO] [stdout] | [INFO] [stdout] 319 | for i in 0..filters.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 319 - for i in 0..filters.len() { [INFO] [stdout] 319 + for in &mut filters { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/main.rs:322:17 [INFO] [stdout] | [INFO] [stdout] 322 | let ref path = filters[i]; [INFO] [stdout] | ----^^^^^^^^-------------- help: try: `let path = &filters[i];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:353:45 [INFO] [stdout] | [INFO] [stdout] 353 | c => { last_char = Some(c.clone()); true } [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:386:29 [INFO] [stdout] | [INFO] [stdout] 386 | let dir = match PathBuf::from(dir).parent() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.20s [INFO] running `Command { std: "docker" "inspect" "d69934b491819eff9616065bdc5794ff610da858864c4a836786efc444b9f838", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d69934b491819eff9616065bdc5794ff610da858864c4a836786efc444b9f838", kill_on_drop: false }` [INFO] [stdout] d69934b491819eff9616065bdc5794ff610da858864c4a836786efc444b9f838