[INFO] cloning repository https://github.com/nelhage/iron-gollum [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nelhage/iron-gollum" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnelhage%2Firon-gollum", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnelhage%2Firon-gollum'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 504c88b3d928478fce2c98b6a54d5b85e728e858 [INFO] linting nelhage/iron-gollum against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnelhage%2Firon-gollum" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nelhage/iron-gollum [INFO] finished tweaking git repo https://github.com/nelhage/iron-gollum [INFO] tweaked toml for git repo https://github.com/nelhage/iron-gollum written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nelhage/iron-gollum on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nelhage/iron-gollum already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded textwrap v0.9.0 [INFO] [stderr] Downloaded pest v1.0.6 [INFO] [stderr] Downloaded pest_derive v1.0.7 [INFO] [stderr] Downloaded clap v2.31.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 90e0711307dd9ff882d3012fdfcfd5dd5a7b570d7a5f96a8d0c4697f88a95885 [INFO] running `Command { std: "docker" "start" "-a" "90e0711307dd9ff882d3012fdfcfd5dd5a7b570d7a5f96a8d0c4697f88a95885", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "90e0711307dd9ff882d3012fdfcfd5dd5a7b570d7a5f96a8d0c4697f88a95885", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90e0711307dd9ff882d3012fdfcfd5dd5a7b570d7a5f96a8d0c4697f88a95885", kill_on_drop: false }` [INFO] [stdout] 90e0711307dd9ff882d3012fdfcfd5dd5a7b570d7a5f96a8d0c4697f88a95885 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a4dbe34ff3071b754d972de779fd917e1cd974cd0ecaefebf43684ec8b3efba [INFO] running `Command { std: "docker" "start" "-a" "7a4dbe34ff3071b754d972de779fd917e1cd974cd0ecaefebf43684ec8b3efba", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Compiling pest v1.0.6 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking atty v0.2.8 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling pest_derive v1.0.7 [INFO] [stderr] Checking iron-golem v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/parser.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | const _GRAMMAR: &'static str = include_str!("gollum.pest"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/parser.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | const _GRAMMAR: &'static str = include_str!("gollum.pest"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | const VERSION: &'static str = "0.0.1"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | const VERSION: &'static str = "0.0.1"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | let mut inner = pair.into_inner(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | let mut expr = *build(path, inner.next().unwrap()); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | let mut inner = pair.into_inner(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parser.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | let mut expr = *build(path, inner.next().unwrap()); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 50 | file: &path, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:50:27 [INFO] [stdout] | [INFO] [stdout] 50 | file: &path, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/types.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / match &**ty { [INFO] [stdout] 18 | | &Type::Primitive(_) => Rc::clone(ty), [INFO] [stdout] 19 | | &Type::Variable(_) => map(Rc::clone(ty)), [INFO] [stdout] 20 | | &Type::Function(ref dom, ref range) => { [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 ~ match **ty { [INFO] [stdout] 18 ~ Type::Primitive(_) => Rc::clone(ty), [INFO] [stdout] 19 ~ Type::Variable(_) => map(Rc::clone(ty)), [INFO] [stdout] 20 ~ Type::Function(ref dom, ref range) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:192:21 [INFO] [stdout] | [INFO] [stdout] 192 | assert!(!res.is_ok(), "parse({}): {:?}", test, res) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/types.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | &Type::Function(ref dom, ref range) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 20 - &Type::Function(ref dom, ref range) => { [INFO] [stdout] 20 + Type::Function(dom, range) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/types.rs:21:45 [INFO] [stdout] | [INFO] [stdout] 21 | Rc::new(Type::Function(map_vars(&dom, map), map_vars(&range, map))) [INFO] [stdout] | ^^^^ help: change this to: `dom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/types.rs:21:66 [INFO] [stdout] | [INFO] [stdout] 21 | Rc::new(Type::Function(map_vars(&dom, map), map_vars(&range, map))) [INFO] [stdout] | ^^^^^^ help: change this to: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/typecheck.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return false; [INFO] [stdout] 71 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/types.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / match &**ty { [INFO] [stdout] 18 | | &Type::Primitive(_) => Rc::clone(ty), [INFO] [stdout] 19 | | &Type::Variable(_) => map(Rc::clone(ty)), [INFO] [stdout] 20 | | &Type::Function(ref dom, ref range) => { [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 ~ match **ty { [INFO] [stdout] 18 ~ Type::Primitive(_) => Rc::clone(ty), [INFO] [stdout] 19 ~ Type::Variable(_) => map(Rc::clone(ty)), [INFO] [stdout] 20 ~ Type::Function(ref dom, ref range) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/types.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | &Type::Function(ref dom, ref range) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 20 - &Type::Function(ref dom, ref range) => { [INFO] [stdout] 20 + Type::Function(dom, range) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/types.rs:21:45 [INFO] [stdout] | [INFO] [stdout] 21 | Rc::new(Type::Function(map_vars(&dom, map), map_vars(&range, map))) [INFO] [stdout] | ^^^^ help: change this to: `dom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/types.rs:21:66 [INFO] [stdout] | [INFO] [stdout] 21 | Rc::new(Type::Function(map_vars(&dom, map), map_vars(&range, map))) [INFO] [stdout] | ^^^^^^ help: change this to: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:97:14 [INFO] [stdout] | [INFO] [stdout] 97 | (&types::Type::Variable(ref lv), _) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 97 - (&types::Type::Variable(ref lv), _) => { [INFO] [stdout] 97 + (types::Type::Variable(lv), _) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | (_, &types::Type::Variable(ref rv)) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 107 - (_, &types::Type::Variable(ref rv)) => { [INFO] [stdout] 107 + (_, types::Type::Variable(rv)) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | &types::Type::Function(ref ldom, ref lrange), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 118 - &types::Type::Function(ref ldom, ref lrange), [INFO] [stdout] 118 + types::Type::Function(ldom, lrange), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | &types::Type::Function(ref rdom, ref rrange), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 119 - &types::Type::Function(ref rdom, ref rrange), [INFO] [stdout] 119 + types::Type::Function(rdom, rrange), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:124:14 [INFO] [stdout] | [INFO] [stdout] 124 | (&types::Type::Primitive(ref lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 124 - (&types::Type::Primitive(ref lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] 124 + (types::Type::Primitive(lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:124:47 [INFO] [stdout] | [INFO] [stdout] 124 | (&types::Type::Primitive(ref lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 124 - (&types::Type::Primitive(ref lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] 124 + (&types::Type::Primitive(ref lt), types::Type::Primitive(rt)) if lt == rt => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:147:47 [INFO] [stdout] | [INFO] [stdout] 147 | let dom_ty = self.ast_to_type(&env, dom)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:148:49 [INFO] [stdout] | [INFO] [stdout] 148 | let range_ty = self.ast_to_type(&env, range)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:167:46 [INFO] [stdout] | [INFO] [stdout] 167 | let func_ty = self.typecheck(&env, func)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:168:45 [INFO] [stdout] | [INFO] [stdout] 168 | let arg_ty = self.typecheck(&env, arg)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:180:51 [INFO] [stdout] | [INFO] [stdout] 180 | let ty = self.ast_to_type(&env, ty)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:192:52 [INFO] [stdout] | [INFO] [stdout] 192 | let frame = TypeEnv::with_bindings(&env, &[(var.clone(), Rc::clone(&ty))]); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:197:46 [INFO] [stdout] | [INFO] [stdout] 197 | let cond_ty = self.typecheck(&env, cond)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:198:46 [INFO] [stdout] | [INFO] [stdout] 198 | let cons_ty = self.typecheck(&env, cons)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:199:45 [INFO] [stdout] | [INFO] [stdout] 199 | let alt_ty = self.typecheck(&env, alt)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:207:45 [INFO] [stdout] | [INFO] [stdout] 207 | let got_ty = self.typecheck(&env, val)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:208:47 [INFO] [stdout] | [INFO] [stdout] 208 | let exp_ty = self.ast_to_type(&env, ty)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/names.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn ident(s: &str) -> Name { [INFO] [stdout] | ^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 10 | pub fn ident(s: &str) -> Name<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/names.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn typ(s: &str) -> Name { [INFO] [stdout] | ^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 14 | pub fn typ(s: &str) -> Name<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/typecheck.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return false; [INFO] [stdout] 71 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:97:14 [INFO] [stdout] | [INFO] [stdout] 97 | (&types::Type::Variable(ref lv), _) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 97 - (&types::Type::Variable(ref lv), _) => { [INFO] [stdout] 97 + (types::Type::Variable(lv), _) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | (_, &types::Type::Variable(ref rv)) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 107 - (_, &types::Type::Variable(ref rv)) => { [INFO] [stdout] 107 + (_, types::Type::Variable(rv)) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:118:17 [INFO] [stdout] | [INFO] [stdout] 118 | &types::Type::Function(ref ldom, ref lrange), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 118 - &types::Type::Function(ref ldom, ref lrange), [INFO] [stdout] 118 + types::Type::Function(ldom, lrange), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | &types::Type::Function(ref rdom, ref rrange), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 119 - &types::Type::Function(ref rdom, ref rrange), [INFO] [stdout] 119 + types::Type::Function(rdom, rrange), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:124:14 [INFO] [stdout] | [INFO] [stdout] 124 | (&types::Type::Primitive(ref lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 124 - (&types::Type::Primitive(ref lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] 124 + (types::Type::Primitive(lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/typecheck.rs:124:47 [INFO] [stdout] | [INFO] [stdout] 124 | (&types::Type::Primitive(ref lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 124 - (&types::Type::Primitive(ref lt), &types::Type::Primitive(ref rt)) if lt == rt => {} [INFO] [stdout] 124 + (&types::Type::Primitive(ref lt), types::Type::Primitive(rt)) if lt == rt => {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:147:47 [INFO] [stdout] | [INFO] [stdout] 147 | let dom_ty = self.ast_to_type(&env, dom)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:148:49 [INFO] [stdout] | [INFO] [stdout] 148 | let range_ty = self.ast_to_type(&env, range)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:167:46 [INFO] [stdout] | [INFO] [stdout] 167 | let func_ty = self.typecheck(&env, func)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:168:45 [INFO] [stdout] | [INFO] [stdout] 168 | let arg_ty = self.typecheck(&env, arg)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:180:51 [INFO] [stdout] | [INFO] [stdout] 180 | let ty = self.ast_to_type(&env, ty)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:192:52 [INFO] [stdout] | [INFO] [stdout] 192 | let frame = TypeEnv::with_bindings(&env, &[(var.clone(), Rc::clone(&ty))]); [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:197:46 [INFO] [stdout] | [INFO] [stdout] 197 | let cond_ty = self.typecheck(&env, cond)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:198:46 [INFO] [stdout] | [INFO] [stdout] 198 | let cons_ty = self.typecheck(&env, cons)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:199:45 [INFO] [stdout] | [INFO] [stdout] 199 | let alt_ty = self.typecheck(&env, alt)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:207:45 [INFO] [stdout] | [INFO] [stdout] 207 | let got_ty = self.typecheck(&env, val)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/typecheck.rs:208:47 [INFO] [stdout] | [INFO] [stdout] 208 | let exp_ty = self.ast_to_type(&env, ty)?; [INFO] [stdout] | ^^^^ help: change this to: `env` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/names.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn ident(s: &str) -> Name { [INFO] [stdout] | ^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 10 | pub fn ident(s: &str) -> Name<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/names.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn typ(s: &str) -> Name { [INFO] [stdout] | ^^^^ ^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 14 | pub fn typ(s: &str) -> Name<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | const VERSION: &'static str = "0.0.1"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | const VERSION: &'static str = "0.0.1"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/test_corpus.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/test_corpus.rs:45:30 [INFO] [stdout] | [INFO] [stdout] 45 | (Err(err), _) => assert!(false, format!("parse({}): {:?}", src, err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/test_corpus.rs:46:30 [INFO] [stdout] | [INFO] [stdout] 46 | (_, Err(err)) => assert!(false, format!("parse_type({}): {:?}", expect_src, err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> tests/test_corpus.rs:56:10 [INFO] [stdout] | [INFO] [stdout] 56 | i= i +1; [INFO] [stdout] | ^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/test_corpus.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | assert!(false, format!("typecheck({}) = {:?}", path.display(), ty)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/test_corpus.rs:38:38 [INFO] [stdout] | [INFO] [stdout] 38 | assert!(got.is_ok(), format!("typecheck({}): {:?}", src, got)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 38 - assert!(got.is_ok(), format!("typecheck({}): {:?}", src, got)); [INFO] [stdout] 38 + assert!(got.is_ok(), "typecheck({}): {:?}", src, got); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/test_corpus.rs:39:37 [INFO] [stdout] | [INFO] [stdout] 39 | assert!(ty.is_ok(), format!("expect: {:?}", ty)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 39 - assert!(ty.is_ok(), format!("expect: {:?}", ty)); [INFO] [stdout] 39 + assert!(ty.is_ok(), "expect: {:?}", ty); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/test_corpus.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | format!("tc({}) = {:?} != {:?}", src, got, ty) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 42 - format!("tc({}) = {:?} != {:?}", src, got, ty) [INFO] [stdout] 42 + "tc({}) = {:?} != {:?}", src, got, ty [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/test_corpus.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 45 | (Err(err), _) => assert!(false, format!("parse({}): {:?}", src, err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 45 - (Err(err), _) => assert!(false, format!("parse({}): {:?}", src, err)), [INFO] [stdout] 45 + (Err(err), _) => assert!(false, "parse({}): {:?}", src, err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/test_corpus.rs:46:45 [INFO] [stdout] | [INFO] [stdout] 46 | (_, Err(err)) => assert!(false, format!("parse_type({}): {:?}", expect_src, err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 46 - (_, Err(err)) => assert!(false, format!("parse_type({}): {:?}", expect_src, err)), [INFO] [stdout] 46 + (_, Err(err)) => assert!(false, "parse_type({}): {:?}", expect_src, err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/test_corpus.rs:66:32 [INFO] [stdout] | [INFO] [stdout] 66 | assert!(false, format!("typecheck({}) = {:?}", path.display(), ty)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 66 - assert!(false, format!("typecheck({}) = {:?}", path.display(), ty)) [INFO] [stdout] 66 + assert!(false, "typecheck({}) = {:?}", path.display(), ty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.63s [INFO] running `Command { std: "docker" "inspect" "7a4dbe34ff3071b754d972de779fd917e1cd974cd0ecaefebf43684ec8b3efba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a4dbe34ff3071b754d972de779fd917e1cd974cd0ecaefebf43684ec8b3efba", kill_on_drop: false }` [INFO] [stdout] 7a4dbe34ff3071b754d972de779fd917e1cd974cd0ecaefebf43684ec8b3efba