[INFO] cloning repository https://github.com/nduplessis11/strata-engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nduplessis11/strata-engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnduplessis11%2Fstrata-engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnduplessis11%2Fstrata-engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6f5a54ac119751051dba9cd07fe25fde9b7f435b [INFO] linting nduplessis11/strata-engine against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnduplessis11%2Fstrata-engine" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nduplessis11/strata-engine [INFO] finished tweaking git repo https://github.com/nduplessis11/strata-engine [INFO] tweaked toml for git repo https://github.com/nduplessis11/strata-engine written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nduplessis11/strata-engine on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nduplessis11/strata-engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ash-window v0.13.0 [INFO] [stderr] Downloaded raw-window-metal v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a22ddabd1dab646b02e4b978e02b7955abcd835a96d596f2b0547b0afb6268f [INFO] running `Command { std: "docker" "start" "-a" "8a22ddabd1dab646b02e4b978e02b7955abcd835a96d596f2b0547b0afb6268f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a22ddabd1dab646b02e4b978e02b7955abcd835a96d596f2b0547b0afb6268f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a22ddabd1dab646b02e4b978e02b7955abcd835a96d596f2b0547b0afb6268f", kill_on_drop: false }` [INFO] [stdout] 8a22ddabd1dab646b02e4b978e02b7955abcd835a96d596f2b0547b0afb6268f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c4143053cac4935d7a7001a720719426099a3c3a405170fb713c3c6568548086 [INFO] running `Command { std: "docker" "start" "-a" "c4143053cac4935d7a7001a720719426099a3c3a405170fb713c3c6568548086", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Compiling ash v0.38.0+1.3.281 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling anyhow v1.0.101 [INFO] [stderr] Checking substrate v0.1.0 (/opt/rustwide/workdir/crates/substrate) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/substrate/src/arena.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return unsafe { ptr.as_mut().ok_or(ArenaError::OutOfMemory) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return unsafe { ptr.as_mut().ok_or(ArenaError::OutOfMemory) }; [INFO] [stdout] 55 + unsafe { ptr.as_mut().ok_or(ArenaError::OutOfMemory) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/substrate/src/arena.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return unsafe { ptr.as_mut().ok_or(ArenaError::OutOfMemory) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return unsafe { ptr.as_mut().ok_or(ArenaError::OutOfMemory) }; [INFO] [stdout] 55 + unsafe { ptr.as_mut().ok_or(ArenaError::OutOfMemory) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking ash-window v0.13.0 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking strata v0.1.0 (/opt/rustwide/workdir/crates/strata) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/strata/src/renderer.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | / if let Some(messenger) = self.debug_messenger { [INFO] [stdout] 203 | | if let Some(loader) = &self.debug_utils_loader { [INFO] [stdout] 204 | | loader.destroy_debug_utils_messenger(messenger, None); [INFO] [stdout] 205 | | } [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 202 ~ if let Some(messenger) = self.debug_messenger [INFO] [stdout] 203 ~ && let Some(loader) = &self.debug_utils_loader { [INFO] [stdout] 204 | loader.destroy_debug_utils_messenger(messenger, None); [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/strata/src/renderer.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | / if let Some(messenger) = self.debug_messenger { [INFO] [stdout] 203 | | if let Some(loader) = &self.debug_utils_loader { [INFO] [stdout] 204 | | loader.destroy_debug_utils_messenger(messenger, None); [INFO] [stdout] 205 | | } [INFO] [stdout] 206 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 202 ~ if let Some(messenger) = self.debug_messenger [INFO] [stdout] 203 ~ && let Some(loader) = &self.debug_utils_loader { [INFO] [stdout] 204 | loader.destroy_debug_utils_messenger(messenger, None); [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking example-game v0.1.0 (/opt/rustwide/workdir/crates/example-game) [INFO] [stderr] Checking editor v0.1.0 (/opt/rustwide/workdir/crates/editor) [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/example-game/src/main.rs:23:28 [INFO] [stdout] | [INFO] [stdout] 23 | if PRINT_FRAMES && self.frame_count % 60 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.frame_count.is_multiple_of(60)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/example-game/src/main.rs:23:28 [INFO] [stdout] | [INFO] [stdout] 23 | if PRINT_FRAMES && self.frame_count % 60 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.frame_count.is_multiple_of(60)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 43.50s [INFO] running `Command { std: "docker" "inspect" "c4143053cac4935d7a7001a720719426099a3c3a405170fb713c3c6568548086", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4143053cac4935d7a7001a720719426099a3c3a405170fb713c3c6568548086", kill_on_drop: false }` [INFO] [stdout] c4143053cac4935d7a7001a720719426099a3c3a405170fb713c3c6568548086