[INFO] cloning repository https://github.com/ncrouch1/AdventOfCode2023-Rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ncrouch1/AdventOfCode2023-Rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fncrouch1%2FAdventOfCode2023-Rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fncrouch1%2FAdventOfCode2023-Rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 465ffd8817190540a34a336ad7e2699be553ea27 [INFO] linting ncrouch1/AdventOfCode2023-Rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fncrouch1%2FAdventOfCode2023-Rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ncrouch1/AdventOfCode2023-Rust [INFO] finished tweaking git repo https://github.com/ncrouch1/AdventOfCode2023-Rust [INFO] tweaked toml for git repo https://github.com/ncrouch1/AdventOfCode2023-Rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ncrouch1/AdventOfCode2023-Rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ncrouch1/AdventOfCode2023-Rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc61078b6a1e2dcd02d9ec4d34d6710b3d3c6a91800ad6e6b6f213f3355eefa0 [INFO] running `Command { std: "docker" "start" "-a" "cc61078b6a1e2dcd02d9ec4d34d6710b3d3c6a91800ad6e6b6f213f3355eefa0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc61078b6a1e2dcd02d9ec4d34d6710b3d3c6a91800ad6e6b6f213f3355eefa0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc61078b6a1e2dcd02d9ec4d34d6710b3d3c6a91800ad6e6b6f213f3355eefa0", kill_on_drop: false }` [INFO] [stdout] cc61078b6a1e2dcd02d9ec4d34d6710b3d3c6a91800ad6e6b6f213f3355eefa0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc940922b874069b6f962b7811c016ab4dc1612e7861417ed7fad0540bd59eee [INFO] running `Command { std: "docker" "start" "-a" "cc940922b874069b6f962b7811c016ab4dc1612e7861417ed7fad0540bd59eee", kill_on_drop: false }` [INFO] [stderr] Checking day1 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if !line.find(first_char).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `line.find(first_char).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !line.rfind(last_char).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `line.rfind(last_char).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if !index.is_none() && ((index.unwrap() as i32) < first_str_index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `index.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if !rindex.is_none() && ((rindex.unwrap() as i32) > last_str_index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `rindex.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `index` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:35:35 [INFO] [stdout] | [INFO] [stdout] 34 | if !index.is_none() && ((index.unwrap() as i32) < first_str_index) { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 35 | first_str_index = index.unwrap() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rindex` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:40:34 [INFO] [stdout] | [INFO] [stdout] 39 | if !rindex.is_none() && ((rindex.unwrap() as i32) > last_str_index) { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 40 | last_str_index = rindex.unwrap() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `num_strs` [INFO] [stdout] --> src/main.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for i in 0..num_strs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 5 - for i in 0..num_strs.len() { [INFO] [stdout] 5 + for (i, ) in num_strs.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/main.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | if c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/main.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | if c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if !line.find(first_char).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `line.find(first_char).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !line.rfind(last_char).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `line.rfind(last_char).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if !index.is_none() && ((index.unwrap() as i32) < first_str_index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `index.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if !rindex.is_none() && ((rindex.unwrap() as i32) > last_str_index) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `rindex.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `index` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:35:35 [INFO] [stdout] | [INFO] [stdout] 34 | if !index.is_none() && ((index.unwrap() as i32) < first_str_index) { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 35 | first_str_index = index.unwrap() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rindex` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:40:34 [INFO] [stdout] | [INFO] [stdout] 39 | if !rindex.is_none() && ((rindex.unwrap() as i32) > last_str_index) { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 40 | last_str_index = rindex.unwrap() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `num_strs` [INFO] [stdout] --> src/main.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for i in 0..num_strs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 5 - for i in 0..num_strs.len() { [INFO] [stdout] 5 + for (i, ) in num_strs.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/main.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | if c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/main.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | if c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] running `Command { std: "docker" "inspect" "cc940922b874069b6f962b7811c016ab4dc1612e7861417ed7fad0540bd59eee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc940922b874069b6f962b7811c016ab4dc1612e7861417ed7fad0540bd59eee", kill_on_drop: false }` [INFO] [stdout] cc940922b874069b6f962b7811c016ab4dc1612e7861417ed7fad0540bd59eee