[INFO] cloning repository https://github.com/ncoish/NESO3
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ncoish/NESO3" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fncoish%2FNESO3", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fncoish%2FNESO3'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 25becf64d521225d9723cfa4875d70a7ee57b790
[INFO] linting ncoish/NESO3 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fncoish%2FNESO3" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/ncoish/NESO3
[INFO] finished tweaking git repo https://github.com/ncoish/NESO3
[INFO] tweaked toml for git repo https://github.com/ncoish/NESO3 written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/ncoish/NESO3 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/ncoish/NESO3 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded gl_generator v0.6.1
[INFO] [stderr]   Downloaded gl v0.6.5
[INFO] [stderr]   Downloaded sdl2-sys v0.30.0
[INFO] [stderr]   Downloaded sdl2 v0.30.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] ea49c9d489845796b79857a9f0bdb9254386003ded41436d24d4820014796dbe
[INFO] running `Command { std: "docker" "start" "-a" "ea49c9d489845796b79857a9f0bdb9254386003ded41436d24d4820014796dbe", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "ea49c9d489845796b79857a9f0bdb9254386003ded41436d24d4820014796dbe", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ea49c9d489845796b79857a9f0bdb9254386003ded41436d24d4820014796dbe", kill_on_drop: false }`
[INFO] [stdout] ea49c9d489845796b79857a9f0bdb9254386003ded41436d24d4820014796dbe
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 3f35069c236bd6e85adeee0722b5210f016eed0a5345674e697a3bc5a20fac36
[INFO] running `Command { std: "docker" "start" "-a" "3f35069c236bd6e85adeee0722b5210f016eed0a5345674e697a3bc5a20fac36", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.141
[INFO] [stderr]    Compiling log v0.4.17
[INFO] [stderr]    Compiling num-traits v0.2.15
[INFO] [stderr]    Compiling khronos_api v2.2.0
[INFO] [stderr]    Compiling num-integer v0.1.45
[INFO] [stderr]    Compiling num-iter v0.1.43
[INFO] [stderr]    Compiling sdl2-sys v0.30.0
[INFO] [stderr]     Checking bitflags v0.7.0
[INFO] [stderr]    Compiling neso3 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stderr]    Compiling xml-rs v0.7.0
[INFO] [stderr]     Checking textwrap v0.11.0
[INFO] [stderr]     Checking lazy_static v0.2.11
[INFO] [stderr]    Compiling log v0.3.9
[INFO] [stderr]     Checking rand v0.4.6
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]    Compiling gl_generator v0.6.1
[INFO] [stderr]     Checking clap v2.34.0
[INFO] [stderr]     Checking rand v0.3.23
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking sdl2 v0.30.0
[INFO] [stderr]    Compiling gl v0.6.5
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/gfx.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | use gl;
[INFO] [stdout]   | ^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/gfx.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | use sdl2;
[INFO] [stdout]   | ^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/gfx.rs:9:1
[INFO] [stdout]   |
[INFO] [stdout] 9 | use std;
[INFO] [stdout]   | ^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/util.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use sdl2;
[INFO] [stdout]   | ^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/gfx.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | use gl;
[INFO] [stdout]   | ^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/gfx.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | use sdl2;
[INFO] [stdout]   | ^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/gfx.rs:9:1
[INFO] [stdout]   |
[INFO] [stdout] 9 | use std;
[INFO] [stdout]   | ^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/util.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use sdl2;
[INFO] [stdout]   | ^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `controller`
[INFO] [stdout]   --> src/gfx.rs:60:9
[INFO] [stdout]    |
[INFO] [stdout] 60 |     let controller = joystick_subsystem.open(0).unwrap();
[INFO] [stdout]    |         ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_controller`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `DUAL` is never constructed
[INFO] [stdout]   --> src/parser.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 13 | pub enum TVSystem {
[INFO] [stdout]    |          -------- variant in this enum
[INFO] [stdout] ...
[INFO] [stdout] 16 |     DUAL,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `TVSystem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `raw_header`, `mirroring`, `battery_ram`, `mapper`, `ram_banks`, and `tv_system` are never read
[INFO] [stdout]   --> src/parser.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 20 | pub struct Header {
[INFO] [stdout]    |            ------ fields in this struct
[INFO] [stdout] 21 |     raw_header: [u8; 16],
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 24 |     mirroring: Mirroring,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout] 25 |     battery_ram: bool,
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout] 26 |     trainer: bool,
[INFO] [stdout] 27 |     mapper: Mapper,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 28 |     ram_banks: u8,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout] 29 |     tv_system: TVSystem,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `prg_rom` is never read
[INFO] [stdout]  --> src/memory.rs:7:9
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub struct GameMemory {
[INFO] [stdout]   |            ---------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 7 |     pub prg_rom: Vec<u8>,
[INFO] [stdout]   |         ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait `Memory` is never used
[INFO] [stdout]   --> src/memory.rs:25:11
[INFO] [stdout]    |
[INFO] [stdout] 25 | pub trait Memory {
[INFO] [stdout]    |           ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `get_number` is never used
[INFO] [stdout]   --> src/mapper.rs:24:12
[INFO] [stdout]    |
[INFO] [stdout] 12 | impl Mapper {
[INFO] [stdout]    | ----------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 24 |     pub fn get_number(&self) -> u8 {
[INFO] [stdout]    |            ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `CPU` is never constructed
[INFO] [stdout]  --> src/cpu.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct CPU {
[INFO] [stdout]   |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `PPU` is never constructed
[INFO] [stdout]  --> src/ppu.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct PPU {
[INFO] [stdout]   |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `OAM` is never constructed
[INFO] [stdout]   --> src/ppu.rs:26:8
[INFO] [stdout]    |
[INFO] [stdout] 26 | struct OAM {
[INFO] [stdout]    |        ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `NTSC` contains a capitalized acronym
[INFO] [stdout]   --> src/parser.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     NTSC,
[INFO] [stdout]    |     ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ntsc`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `PAL` contains a capitalized acronym
[INFO] [stdout]   --> src/parser.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 |     PAL,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Pal`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `DUAL` contains a capitalized acronym
[INFO] [stdout]   --> src/parser.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 |     DUAL,
[INFO] [stdout]    |     ^^^^ help: consider making the acronym lowercase, except the initial letter: `Dual`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/parser.rs:36:8
[INFO] [stdout]    |
[INFO] [stdout] 36 |     if !(&buf[0..4] == b"NES\x1A") {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&buf[0..4] != b"NES\x1A")`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `controller`
[INFO] [stdout]   --> src/gfx.rs:60:9
[INFO] [stdout]    |
[INFO] [stdout] 60 |     let controller = joystick_subsystem.open(0).unwrap();
[INFO] [stdout]    |         ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_controller`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant `DUAL` is never constructed
[INFO] [stdout]   --> src/parser.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 13 | pub enum TVSystem {
[INFO] [stdout]    |          -------- variant in this enum
[INFO] [stdout] ...
[INFO] [stdout] 16 |     DUAL,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `TVSystem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `raw_header`, `mirroring`, `battery_ram`, `mapper`, `ram_banks`, and `tv_system` are never read
[INFO] [stdout]   --> src/parser.rs:21:5
[INFO] [stdout]    |
[INFO] [stdout] 20 | pub struct Header {
[INFO] [stdout]    |            ------ fields in this struct
[INFO] [stdout] 21 |     raw_header: [u8; 16],
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 24 |     mirroring: Mirroring,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout] 25 |     battery_ram: bool,
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout] 26 |     trainer: bool,
[INFO] [stdout] 27 |     mapper: Mapper,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 28 |     ram_banks: u8,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout] 29 |     tv_system: TVSystem,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `prg_rom` is never read
[INFO] [stdout]  --> src/memory.rs:7:9
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub struct GameMemory {
[INFO] [stdout]   |            ---------- field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 7 |     pub prg_rom: Vec<u8>,
[INFO] [stdout]   |         ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait `Memory` is never used
[INFO] [stdout]   --> src/memory.rs:25:11
[INFO] [stdout]    |
[INFO] [stdout] 25 | pub trait Memory {
[INFO] [stdout]    |           ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `get_number` is never used
[INFO] [stdout]   --> src/mapper.rs:24:12
[INFO] [stdout]    |
[INFO] [stdout] 12 | impl Mapper {
[INFO] [stdout]    | ----------- method in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 24 |     pub fn get_number(&self) -> u8 {
[INFO] [stdout]    |            ^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `CPU` is never constructed
[INFO] [stdout]  --> src/cpu.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct CPU {
[INFO] [stdout]   |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `PPU` is never constructed
[INFO] [stdout]  --> src/ppu.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct PPU {
[INFO] [stdout]   |            ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `OAM` is never constructed
[INFO] [stdout]   --> src/ppu.rs:26:8
[INFO] [stdout]    |
[INFO] [stdout] 26 | struct OAM {
[INFO] [stdout]    |        ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `NROM` contains a capitalized acronym
[INFO] [stdout]  --> src/mapper.rs:4:5
[INFO] [stdout]   |
[INFO] [stdout] 4 |     NROM,
[INFO] [stdout]   |     ^^^^ help: consider making the acronym lowercase, except the initial letter: `Nrom`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `CNROM` contains a capitalized acronym
[INFO] [stdout]  --> src/mapper.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 |     CNROM,
[INFO] [stdout]   |     ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cnrom`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `NTSC` contains a capitalized acronym
[INFO] [stdout]   --> src/parser.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     NTSC,
[INFO] [stdout]    |     ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ntsc`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `PAL` contains a capitalized acronym
[INFO] [stdout]   --> src/parser.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 |     PAL,
[INFO] [stdout]    |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Pal`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `DUAL` contains a capitalized acronym
[INFO] [stdout]   --> src/parser.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 |     DUAL,
[INFO] [stdout]    |     ^^^^ help: consider making the acronym lowercase, except the initial letter: `Dual`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/parser.rs:36:8
[INFO] [stdout]    |
[INFO] [stdout] 36 |     if !(&buf[0..4] == b"NES\x1A") {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&buf[0..4] != b"NES\x1A")`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `NROM` contains a capitalized acronym
[INFO] [stdout]  --> src/mapper.rs:4:5
[INFO] [stdout]   |
[INFO] [stdout] 4 |     NROM,
[INFO] [stdout]   |     ^^^^ help: consider making the acronym lowercase, except the initial letter: `Nrom`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `CNROM` contains a capitalized acronym
[INFO] [stdout]  --> src/mapper.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 |     CNROM,
[INFO] [stdout]   |     ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Cnrom`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]   --> src/mapper.rs:20:29
[INFO] [stdout]    |
[INFO] [stdout] 20 |             n => return Err(From::from(format!("Mapper unsupported: {}", n)))
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `format!("Mapper unsupported: {}", n)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `CPU` contains a capitalized acronym
[INFO] [stdout]  --> src/cpu.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct CPU {
[INFO] [stdout]   |            ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `PPU` contains a capitalized acronym
[INFO] [stdout]  --> src/ppu.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct PPU {
[INFO] [stdout]   |            ^^^ help: consider making the acronym lowercase, except the initial letter: `Ppu`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `OAM` contains a capitalized acronym
[INFO] [stdout]   --> src/ppu.rs:26:8
[INFO] [stdout]    |
[INFO] [stdout] 26 | struct OAM {
[INFO] [stdout]    |        ^^^ help: consider making the acronym lowercase, except the initial letter: `Oam`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]   --> src/mapper.rs:20:29
[INFO] [stdout]    |
[INFO] [stdout] 20 |             n => return Err(From::from(format!("Mapper unsupported: {}", n)))
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `format!("Mapper unsupported: {}", n)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `CPU` contains a capitalized acronym
[INFO] [stdout]  --> src/cpu.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct CPU {
[INFO] [stdout]   |            ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `PPU` contains a capitalized acronym
[INFO] [stdout]  --> src/ppu.rs:3:12
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub struct PPU {
[INFO] [stdout]   |            ^^^ help: consider making the acronym lowercase, except the initial letter: `Ppu`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `OAM` contains a capitalized acronym
[INFO] [stdout]   --> src/ppu.rs:26:8
[INFO] [stdout]    |
[INFO] [stdout] 26 | struct OAM {
[INFO] [stdout]    |        ^^^ help: consider making the acronym lowercase, except the initial letter: `Oam`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: it looks like you're manually copying between slices
[INFO] [stdout]   --> src/gfx.rs:41:5
[INFO] [stdout]    |
[INFO] [stdout] 41 | /     for i in 0..(200) {
[INFO] [stdout] 42 | |         buf[i] = surf_data[i];
[INFO] [stdout] 43 | |     }
[INFO] [stdout]    | |_____^ help: try replacing the loop by: `buf[..(200)].copy_from_slice(&surf_data[..(200)]);`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stdout]    = note: `#[warn(clippy::manual_memcpy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless parenthesis on range literals can be removed
[INFO] [stdout]   --> src/gfx.rs:41:17
[INFO] [stdout]    |
[INFO] [stdout] 41 |     for i in 0..(200) {
[INFO] [stdout]    |                 ^^^^^ help: try: `200`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_parens_on_range_literals
[INFO] [stdout]    = note: `#[warn(clippy::needless_parens_on_range_literals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: it looks like you're manually copying between slices
[INFO] [stdout]   --> src/gfx.rs:41:5
[INFO] [stdout]    |
[INFO] [stdout] 41 | /     for i in 0..(200) {
[INFO] [stdout] 42 | |         buf[i] = surf_data[i];
[INFO] [stdout] 43 | |     }
[INFO] [stdout]    | |_____^ help: try replacing the loop by: `buf[..(200)].copy_from_slice(&surf_data[..(200)]);`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stdout]    = note: `#[warn(clippy::manual_memcpy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needless parenthesis on range literals can be removed
[INFO] [stdout]   --> src/gfx.rs:41:17
[INFO] [stdout]    |
[INFO] [stdout] 41 |     for i in 0..(200) {
[INFO] [stdout]    |                 ^^^^^ help: try: `200`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_parens_on_range_literals
[INFO] [stdout]    = note: `#[warn(clippy::needless_parens_on_range_literals)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `A` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:4:5
[INFO] [stdout]   |
[INFO] [stdout] 4 |     A: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case: `a`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `X` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:5:5
[INFO] [stdout]   |
[INFO] [stdout] 5 |     X: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case (notice the capitalization): `x`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `Y` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 6 |     Y: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case (notice the capitalization): `y`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `PC` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 |     PC: u16,
[INFO] [stdout]   |     ^^ help: convert the identifier to snake case: `pc`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `S` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 |     S: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case (notice the capitalization): `s`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `P` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 |     P: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case: `p`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `A` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:4:5
[INFO] [stdout]   |
[INFO] [stdout] 4 |     A: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case: `a`
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `X` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:5:5
[INFO] [stdout]   |
[INFO] [stdout] 5 |     X: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case (notice the capitalization): `x`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `Y` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 6 |     Y: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case (notice the capitalization): `y`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `PC` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 |     PC: u16,
[INFO] [stdout]   |     ^^ help: convert the identifier to snake case: `pc`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `S` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:8:5
[INFO] [stdout]   |
[INFO] [stdout] 8 |     S: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case (notice the capitalization): `s`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: structure field `P` should have a snake case name
[INFO] [stdout]  --> src/cpu.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 |     P: u8,
[INFO] [stdout]   |     ^ help: convert the identifier to snake case: `p`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.12s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.7.0
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2`
[INFO] running `Command { std: "docker" "inspect" "3f35069c236bd6e85adeee0722b5210f016eed0a5345674e697a3bc5a20fac36", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3f35069c236bd6e85adeee0722b5210f016eed0a5345674e697a3bc5a20fac36", kill_on_drop: false }`
[INFO] [stdout] 3f35069c236bd6e85adeee0722b5210f016eed0a5345674e697a3bc5a20fac36