[INFO] cloning repository https://github.com/nbfritch/musync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nbfritch/musync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnbfritch%2Fmusync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnbfritch%2Fmusync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 19268658124075b9ef1dbb15dc2e1054fd3d0ee5 [INFO] linting nbfritch/musync against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnbfritch%2Fmusync" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-3-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/nbfritch/musync [INFO] finished tweaking git repo https://github.com/nbfritch/musync [INFO] tweaked toml for git repo https://github.com/nbfritch/musync written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nbfritch/musync on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nbfritch/musync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d2c86c2772af5a3a51aabfbae6c6955815531c1f2f1f5e905c3d5ae9d7beec0 [INFO] running `Command { std: "docker" "start" "-a" "1d2c86c2772af5a3a51aabfbae6c6955815531c1f2f1f5e905c3d5ae9d7beec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d2c86c2772af5a3a51aabfbae6c6955815531c1f2f1f5e905c3d5ae9d7beec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d2c86c2772af5a3a51aabfbae6c6955815531c1f2f1f5e905c3d5ae9d7beec0", kill_on_drop: false }` [INFO] [stdout] 1d2c86c2772af5a3a51aabfbae6c6955815531c1f2f1f5e905c3d5ae9d7beec0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eee93f8ca7c4552d0c40d28a30654886c7e1be5691f10898b812c19359b20d3f [INFO] running `Command { std: "docker" "start" "-a" "eee93f8ca7c4552d0c40d28a30654886c7e1be5691f10898b812c19359b20d3f", kill_on_drop: false }` [INFO] [stderr] Checking musync v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | let sub_entries = crawl_dir(&base_path, &full_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `base_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:67:33 [INFO] [stdout] | [INFO] [stdout] 67 | let src_entries = crawl_dir(&source_path, &source_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `source_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:67:47 [INFO] [stdout] | [INFO] [stdout] 67 | let src_entries = crawl_dir(&source_path, &source_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `source_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | let dst_entries = crawl_dir(&dest_path, &dest_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `dest_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:72:45 [INFO] [stdout] | [INFO] [stdout] 72 | let dst_entries = crawl_dir(&dest_path, &dest_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `dest_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if !rm_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `rm_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:108:43 [INFO] [stdout] | [INFO] [stdout] 108 | fs::create_dir_all(to_parent_dir).expect(&format!("Could not create {:?}", to_parent_dir)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not create {:?}", to_parent_dir))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | / format!( [INFO] [stdout] 112 | | "{}", [INFO] [stdout] 113 | | copy_from_path [INFO] [stdout] 114 | | .to_str() [INFO] [stdout] 115 | | .expect("Error stringifying from path") [INFO] [stdout] 116 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 111 ~ copy_from_path [INFO] [stdout] 112 + .to_str() [INFO] [stdout] 113 ~ .expect("Error stringifying from path").to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | / format!( [INFO] [stdout] 118 | | "{}", [INFO] [stdout] 119 | | copy_to_path.to_str().expect("Error stringifying to path") [INFO] [stdout] 120 | | ), [INFO] [stdout] | |_________________^ help: consider using `.to_string()`: `copy_to_path.to_str().expect("Error stringifying to path").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | let sub_entries = crawl_dir(&base_path, &full_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `base_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:67:33 [INFO] [stdout] | [INFO] [stdout] 67 | let src_entries = crawl_dir(&source_path, &source_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `source_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:67:47 [INFO] [stdout] | [INFO] [stdout] 67 | let src_entries = crawl_dir(&source_path, &source_path)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `source_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | let dst_entries = crawl_dir(&dest_path, &dest_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `dest_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:72:45 [INFO] [stdout] | [INFO] [stdout] 72 | let dst_entries = crawl_dir(&dest_path, &dest_path)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `dest_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if !rm_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `rm_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:108:43 [INFO] [stdout] | [INFO] [stdout] 108 | fs::create_dir_all(to_parent_dir).expect(&format!("Could not create {:?}", to_parent_dir)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not create {:?}", to_parent_dir))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | / format!( [INFO] [stdout] 112 | | "{}", [INFO] [stdout] 113 | | copy_from_path [INFO] [stdout] 114 | | .to_str() [INFO] [stdout] 115 | | .expect("Error stringifying from path") [INFO] [stdout] 116 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 111 ~ copy_from_path [INFO] [stdout] 112 + .to_str() [INFO] [stdout] 113 ~ .expect("Error stringifying from path").to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | / format!( [INFO] [stdout] 118 | | "{}", [INFO] [stdout] 119 | | copy_to_path.to_str().expect("Error stringifying to path") [INFO] [stdout] 120 | | ), [INFO] [stdout] | |_________________^ help: consider using `.to_string()`: `copy_to_path.to_str().expect("Error stringifying to path").to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s [INFO] running `Command { std: "docker" "inspect" "eee93f8ca7c4552d0c40d28a30654886c7e1be5691f10898b812c19359b20d3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eee93f8ca7c4552d0c40d28a30654886c7e1be5691f10898b812c19359b20d3f", kill_on_drop: false }` [INFO] [stdout] eee93f8ca7c4552d0c40d28a30654886c7e1be5691f10898b812c19359b20d3f