[INFO] cloning repository https://github.com/nathanyoung2/summative-assessment-2025
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nathanyoung2/summative-assessment-2025" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnathanyoung2%2Fsummative-assessment-2025", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnathanyoung2%2Fsummative-assessment-2025'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 344659c34b2d589801e2fa7564905a5e6578226c
[INFO] linting nathanyoung2/summative-assessment-2025 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnathanyoung2%2Fsummative-assessment-2025" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/nathanyoung2/summative-assessment-2025
[INFO] finished tweaking git repo https://github.com/nathanyoung2/summative-assessment-2025
[INFO] tweaked toml for git repo https://github.com/nathanyoung2/summative-assessment-2025 written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/nathanyoung2/summative-assessment-2025 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/nathanyoung2/summative-assessment-2025 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] e3e4e302455d1d64cb3ad7495f133799d3c3cebf87e792bb9a3705100d123c89
[INFO] running `Command { std: "docker" "start" "-a" "e3e4e302455d1d64cb3ad7495f133799d3c3cebf87e792bb9a3705100d123c89", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "e3e4e302455d1d64cb3ad7495f133799d3c3cebf87e792bb9a3705100d123c89", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e3e4e302455d1d64cb3ad7495f133799d3c3cebf87e792bb9a3705100d123c89", kill_on_drop: false }`
[INFO] [stdout] e3e4e302455d1d64cb3ad7495f133799d3c3cebf87e792bb9a3705100d123c89
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] bd7095cdecc5daa3d367ace192eda7014ec5b70f2edcd53f6f40212f0ad16f8b
[INFO] running `Command { std: "docker" "start" "-a" "bd7095cdecc5daa3d367ace192eda7014ec5b70f2edcd53f6f40212f0ad16f8b", kill_on_drop: false }`
[INFO] [stderr]     Checking assessment-2025 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/commands/ls_command.rs:18:36
[INFO] [stdout]    |
[INFO] [stdout] 18 |         if arguments.len() != 1 && arguments.len() != 0 {
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!arguments.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of left operand
[INFO] [stdout]   --> src/tree.rs:40:13
[INFO] [stdout]    |
[INFO] [stdout] 40 |             &dir.name().unwrap() == dir_name
[INFO] [stdout]    |             --------------------^^^^^^^^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: use the left value directly: `dir.name().unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]    = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/tree.rs:44:33
[INFO] [stdout]    |
[INFO] [stdout] 44 |             let dir = Rc::clone(&dir);
[INFO] [stdout]    |                                 ^^^^ help: change this to: `dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]    --> src/tree.rs:131:59
[INFO] [stdout]     |
[INFO] [stdout] 131 |             return write!(f, "{}/{}", parent, self.name().unwrap_or(String::new()));
[INFO] [stdout]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]     = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]    --> src/tree.rs:168:15
[INFO] [stdout]     |
[INFO] [stdout] 168 |         match &*self {
[INFO] [stdout]     |               ^^^^^^ help: if you would like to reborrow, try removing `&*`: `self`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout]     = note: `#[warn(clippy::borrow_deref_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]    --> src/tree.rs:177:15
[INFO] [stdout]     |
[INFO] [stdout] 177 |         match &*self {
[INFO] [stdout]     |               ^^^^^^ help: if you would like to reborrow, try removing `&*`: `self`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/tree.rs:205:43
[INFO] [stdout]     |
[INFO] [stdout] 205 |             Node::Folder { depth, .. } => depth.borrow().clone(),
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*depth.borrow()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/tree.rs:206:41
[INFO] [stdout]     |
[INFO] [stdout] 206 |             Node::File { depth, .. } => depth.borrow().clone(),
[INFO] [stdout]     |                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*depth.borrow()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:253:13
[INFO] [stdout]     |
[INFO] [stdout] 253 |             return Err(format!["Could not locate item: {}", node_name]);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 253 -             return Err(format!["Could not locate item: {}", node_name]);
[INFO] [stdout] 253 +             Err(format!["Could not locate item: {}", node_name])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of left operand
[INFO] [stdout]    --> src/tree.rs:249:20
[INFO] [stdout]     |
[INFO] [stdout] 249 |                 if &node.name().unwrap() == node_name {
[INFO] [stdout]     |                    ---------------------^^^^^^^^^^^^^
[INFO] [stdout]     |                    |
[INFO] [stdout]     |                    help: use the left value directly: `node.name().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:119:9
[INFO] [stdout]     |
[INFO] [stdout] 119 |         return Ok(commands);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 -         return Ok(commands);
[INFO] [stdout] 119 +         Ok(commands)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/parser.rs:50:12
[INFO] [stdout]    |
[INFO] [stdout] 50 |         if self.tokens.len() < 1 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tokens.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `map` over `inspect`
[INFO] [stdout]   --> src/parser.rs:76:55
[INFO] [stdout]    |
[INFO] [stdout] 76 |                         self.current_command.as_mut().map(|command| {
[INFO] [stdout]    |                                                       ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
[INFO] [stdout]    = note: `#[warn(clippy::manual_inspect)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 76 ~                         self.current_command.as_mut().inspect(|command| {
[INFO] [stdout] 77 ~                             command.add_argument(arg);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]   --> src/parser.rs:90:28
[INFO] [stdout]    |
[INFO] [stdout] 90 |                     if let None = self.arg_start {
[INFO] [stdout]    |                     -------^^^^----------------- help: try: `if self.arg_start.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `map` over `inspect`
[INFO] [stdout]    --> src/parser.rs:102:51
[INFO] [stdout]     |
[INFO] [stdout] 102 |                     self.current_command.as_mut().map(|command| {
[INFO] [stdout]     |                                                   ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 102 ~                     self.current_command.as_mut().inspect(|command| {
[INFO] [stdout] 103 ~                         command.add_argument(arg);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:198:13
[INFO] [stdout]     |
[INFO] [stdout] 198 |             return compile_path(tokens).map(|path| Argument::Path(path));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 198 -             return compile_path(tokens).map(|path| Argument::Path(path));
[INFO] [stdout] 198 +             compile_path(tokens).map(|path| Argument::Path(path))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:201:13
[INFO] [stdout]     |
[INFO] [stdout] 201 |             return Ok(Argument::Number(*n));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 201 -             return Ok(Argument::Number(*n));
[INFO] [stdout] 201 +             Ok(Argument::Number(*n))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:204:13
[INFO] [stdout]     |
[INFO] [stdout] 204 |             return Err(SyntaxError::UnexpectedToken);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 204 -             return Err(SyntaxError::UnexpectedToken);
[INFO] [stdout] 204 +             Err(SyntaxError::UnexpectedToken)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tokens.get(0)`
[INFO] [stdout]    --> src/parser.rs:195:11
[INFO] [stdout]     |
[INFO] [stdout] 195 |     match tokens.get(0) {
[INFO] [stdout]     |           ^^^^^^^^^^^^^ help: try: `tokens.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]     = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/parser.rs:198:45
[INFO] [stdout]     |
[INFO] [stdout] 198 |             return compile_path(tokens).map(|path| Argument::Path(path));
[INFO] [stdout]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Argument::Path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tokens.get(0)`
[INFO] [stdout]    --> src/parser.rs:211:33
[INFO] [stdout]     |
[INFO] [stdout] 211 |     if let Some(Token::Slash) = tokens.get(0) {
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^ help: try: `tokens.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/lexer.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     UnexpectedToken(char),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]    = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lexer.rs:102:21
[INFO] [stdout]     |
[INFO] [stdout] 102 |                     return Some(Token::Word(word_contents.to_string()));
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 102 -                     return Some(Token::Word(word_contents.to_string()));
[INFO] [stdout] 102 +                     Some(Token::Word(word_contents.to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lexer.rs:105:21
[INFO] [stdout]     |
[INFO] [stdout] 105 |                     return Some(Token::UnexpectedToken(current_char))
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 105 -                     return Some(Token::UnexpectedToken(current_char))
[INFO] [stdout] 105 +                     Some(Token::UnexpectedToken(current_char))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lexer.rs:167:9
[INFO] [stdout]     |
[INFO] [stdout] 167 |         return self.input.len();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 167 -         return self.input.len();
[INFO] [stdout] 167 +         self.input.len()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:59:48
[INFO] [stdout]    |
[INFO] [stdout] 59 |             let mut command_lexer = Lexer::new(&input.trim());
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^ help: change this to: `input.trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/commands/ls_command.rs:18:36
[INFO] [stdout]    |
[INFO] [stdout] 18 |         if arguments.len() != 1 && arguments.len() != 0 {
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!arguments.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of left operand
[INFO] [stdout]   --> src/tree.rs:40:13
[INFO] [stdout]    |
[INFO] [stdout] 40 |             &dir.name().unwrap() == dir_name
[INFO] [stdout]    |             --------------------^^^^^^^^^^^^
[INFO] [stdout]    |             |
[INFO] [stdout]    |             help: use the left value directly: `dir.name().unwrap()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout]    = note: `#[warn(clippy::op_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/tree.rs:44:33
[INFO] [stdout]    |
[INFO] [stdout] 44 |             let dir = Rc::clone(&dir);
[INFO] [stdout]    |                                 ^^^^ help: change this to: `dir`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `unwrap_or` to construct default value
[INFO] [stdout]    --> src/tree.rs:131:59
[INFO] [stdout]     |
[INFO] [stdout] 131 |             return write!(f, "{}/{}", parent, self.name().unwrap_or(String::new()));
[INFO] [stdout]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
[INFO] [stdout]     = note: `#[warn(clippy::unwrap_or_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]    --> src/tree.rs:168:15
[INFO] [stdout]     |
[INFO] [stdout] 168 |         match &*self {
[INFO] [stdout]     |               ^^^^^^ help: if you would like to reborrow, try removing `&*`: `self`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout]     = note: `#[warn(clippy::borrow_deref_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]    --> src/tree.rs:177:15
[INFO] [stdout]     |
[INFO] [stdout] 177 |         match &*self {
[INFO] [stdout]     |               ^^^^^^ help: if you would like to reborrow, try removing `&*`: `self`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/tree.rs:205:43
[INFO] [stdout]     |
[INFO] [stdout] 205 |             Node::Folder { depth, .. } => depth.borrow().clone(),
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*depth.borrow()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/tree.rs:206:41
[INFO] [stdout]     |
[INFO] [stdout] 206 |             Node::File { depth, .. } => depth.borrow().clone(),
[INFO] [stdout]     |                                         ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*depth.borrow()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/tree.rs:253:13
[INFO] [stdout]     |
[INFO] [stdout] 253 |             return Err(format!["Could not locate item: {}", node_name]);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 253 -             return Err(format!["Could not locate item: {}", node_name]);
[INFO] [stdout] 253 +             Err(format!["Could not locate item: {}", node_name])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: needlessly taken reference of left operand
[INFO] [stdout]    --> src/tree.rs:249:20
[INFO] [stdout]     |
[INFO] [stdout] 249 |                 if &node.name().unwrap() == node_name {
[INFO] [stdout]     |                    ---------------------^^^^^^^^^^^^^
[INFO] [stdout]     |                    |
[INFO] [stdout]     |                    help: use the left value directly: `node.name().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:119:9
[INFO] [stdout]     |
[INFO] [stdout] 119 |         return Ok(commands);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 -         return Ok(commands);
[INFO] [stdout] 119 +         Ok(commands)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to one
[INFO] [stdout]   --> src/parser.rs:50:12
[INFO] [stdout]    |
[INFO] [stdout] 50 |         if self.tokens.len() < 1 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tokens.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `map` over `inspect`
[INFO] [stdout]   --> src/parser.rs:76:55
[INFO] [stdout]    |
[INFO] [stdout] 76 |                         self.current_command.as_mut().map(|command| {
[INFO] [stdout]    |                                                       ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
[INFO] [stdout]    = note: `#[warn(clippy::manual_inspect)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 76 ~                         self.current_command.as_mut().inspect(|command| {
[INFO] [stdout] 77 ~                             command.add_argument(arg);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stdout]   --> src/parser.rs:90:28
[INFO] [stdout]    |
[INFO] [stdout] 90 |                     if let None = self.arg_start {
[INFO] [stdout]    |                     -------^^^^----------------- help: try: `if self.arg_start.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]    = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `map` over `inspect`
[INFO] [stdout]    --> src/parser.rs:102:51
[INFO] [stdout]     |
[INFO] [stdout] 102 |                     self.current_command.as_mut().map(|command| {
[INFO] [stdout]     |                                                   ^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 102 ~                     self.current_command.as_mut().inspect(|command| {
[INFO] [stdout] 103 ~                         command.add_argument(arg);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:198:13
[INFO] [stdout]     |
[INFO] [stdout] 198 |             return compile_path(tokens).map(|path| Argument::Path(path));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 198 -             return compile_path(tokens).map(|path| Argument::Path(path));
[INFO] [stdout] 198 +             compile_path(tokens).map(|path| Argument::Path(path))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:201:13
[INFO] [stdout]     |
[INFO] [stdout] 201 |             return Ok(Argument::Number(*n));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 201 -             return Ok(Argument::Number(*n));
[INFO] [stdout] 201 +             Ok(Argument::Number(*n))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:204:13
[INFO] [stdout]     |
[INFO] [stdout] 204 |             return Err(SyntaxError::UnexpectedToken);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 204 -             return Err(SyntaxError::UnexpectedToken);
[INFO] [stdout] 204 +             Err(SyntaxError::UnexpectedToken)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tokens.get(0)`
[INFO] [stdout]    --> src/parser.rs:195:11
[INFO] [stdout]     |
[INFO] [stdout] 195 |     match tokens.get(0) {
[INFO] [stdout]     |           ^^^^^^^^^^^^^ help: try: `tokens.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]     = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/parser.rs:198:45
[INFO] [stdout]     |
[INFO] [stdout] 198 |             return compile_path(tokens).map(|path| Argument::Path(path));
[INFO] [stdout]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Argument::Path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tokens.get(0)`
[INFO] [stdout]    --> src/parser.rs:211:33
[INFO] [stdout]     |
[INFO] [stdout] 211 |     if let Some(Token::Slash) = tokens.get(0) {
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^ help: try: `tokens.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/parser.rs:268:17
[INFO] [stdout]     |
[INFO] [stdout] 268 |         assert!(!commands.is_ok());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^ help: try: `commands.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/parser.rs:304:17
[INFO] [stdout]     |
[INFO] [stdout] 304 |         assert!(!commands.is_ok());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^ help: try: `commands.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variant name ends with the enum's name
[INFO] [stdout]   --> src/lexer.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     UnexpectedToken(char),
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stdout]    = note: `#[warn(clippy::enum_variant_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lexer.rs:102:21
[INFO] [stdout]     |
[INFO] [stdout] 102 |                     return Some(Token::Word(word_contents.to_string()));
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 102 -                     return Some(Token::Word(word_contents.to_string()));
[INFO] [stdout] 102 +                     Some(Token::Word(word_contents.to_string()))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lexer.rs:105:21
[INFO] [stdout]     |
[INFO] [stdout] 105 |                     return Some(Token::UnexpectedToken(current_char))
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 105 -                     return Some(Token::UnexpectedToken(current_char))
[INFO] [stdout] 105 +                     Some(Token::UnexpectedToken(current_char))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lexer.rs:167:9
[INFO] [stdout]     |
[INFO] [stdout] 167 |         return self.input.len();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 167 -         return self.input.len();
[INFO] [stdout] 167 +         self.input.len()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:59:48
[INFO] [stdout]    |
[INFO] [stdout] 59 |             let mut command_lexer = Lexer::new(&input.trim());
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^ help: change this to: `input.trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.47s
[INFO] running `Command { std: "docker" "inspect" "bd7095cdecc5daa3d367ace192eda7014ec5b70f2edcd53f6f40212f0ad16f8b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "bd7095cdecc5daa3d367ace192eda7014ec5b70f2edcd53f6f40212f0ad16f8b", kill_on_drop: false }`
[INFO] [stdout] bd7095cdecc5daa3d367ace192eda7014ec5b70f2edcd53f6f40212f0ad16f8b