[INFO] cloning repository https://github.com/naiba/sjson.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/naiba/sjson.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaiba%2Fsjson.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaiba%2Fsjson.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3e4ce41a5926fbcb78d4e409bab211e17b569840 [INFO] linting naiba/sjson.rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaiba%2Fsjson.rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/naiba/sjson.rs [INFO] finished tweaking git repo https://github.com/naiba/sjson.rs [INFO] tweaked toml for git repo https://github.com/naiba/sjson.rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/naiba/sjson.rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/naiba/sjson.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31a3a9d99edf26c3be9f1fd2b9252a768b29df461ac665ca7c652b735d898d22 [INFO] running `Command { std: "docker" "start" "-a" "31a3a9d99edf26c3be9f1fd2b9252a768b29df461ac665ca7c652b735d898d22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31a3a9d99edf26c3be9f1fd2b9252a768b29df461ac665ca7c652b735d898d22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31a3a9d99edf26c3be9f1fd2b9252a768b29df461ac665ca7c652b735d898d22", kill_on_drop: false }` [INFO] [stdout] 31a3a9d99edf26c3be9f1fd2b9252a768b29df461ac665ca7c652b735d898d22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cd74fa300797dd6ed77915d7aae11e853fe8df22ed6c5d0488333d9e1cae0ca [INFO] running `Command { std: "docker" "start" "-a" "2cd74fa300797dd6ed77915d7aae11e853fe8df22ed6c5d0488333d9e1cae0ca", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.97 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking serde_json v1.0.142 [INFO] [stderr] Checking sjson v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | ch >= '.' && ch <= 'z' && !(ch > '9' && ch < 'A') && ch <= 'z' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 - ch >= '.' && ch <= 'z' && !(ch > '9' && ch < 'A') && ch <= 'z' [INFO] [stdout] 61 + !(ch < '.' || ch > 'z' || ch > '9' && ch < 'A') [INFO] [stdout] | [INFO] [stdout] 61 - ch >= '.' && ch <= 'z' && !(ch > '9' && ch < 'A') && ch <= 'z' [INFO] [stdout] 61 + (ch >= 'A' || ch <= '9') && ch <= 'z' && ch >= '.' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | ch >= '.' && ch <= 'z' && !(ch > '9' && ch < 'A') && ch <= 'z' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `('.'..='z').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:181:19 [INFO] [stdout] | [INFO] [stdout] 181 | && !value.parse::().is_ok() && value != "true" && value != "false" && value != "null" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parts` [INFO] [stdout] --> src/lib.rs:215:14 [INFO] [stdout] | [INFO] [stdout] 215 | for i in 0..parts.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 215 - for i in 0..parts.len() - 1 { [INFO] [stdout] 215 + for in parts.iter().take(parts.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parts` [INFO] [stdout] --> src/lib.rs:348:14 [INFO] [stdout] | [INFO] [stdout] 348 | for i in 0..parts.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 348 - for i in 0..parts.len() - 1 { [INFO] [stdout] 348 + for in parts.iter().take(parts.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/lib.rs:421:50 [INFO] [stdout] | [INFO] [stdout] 421 | let key_pattern = format!("\"{}\":", path.split('.').last().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 421 - let key_pattern = format!("\"{}\":", path.split('.').last().unwrap()); [INFO] [stdout] 421 + let key_pattern = format!("\"{}\":", path.split('.').next_back().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:432:34 [INFO] [stdout] | [INFO] [stdout] 432 | while pos > 0 && json[pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 432 - while pos > 0 && json[pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] 432 + while pos > 0 && json[pos..].chars().next().is_some_and(|c| c.is_whitespace()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:438:47 [INFO] [stdout] | [INFO] [stdout] 438 | while actual_start > 0 && json[actual_start-1..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 438 - while actual_start > 0 && json[actual_start-1..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] 438 + while actual_start > 0 && json[actual_start-1..].chars().next().is_some_and(|c| c.is_whitespace()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:449:44 [INFO] [stdout] | [INFO] [stdout] 449 | while skip_pos < json.len() && json[skip_pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 449 - while skip_pos < json.len() && json[skip_pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] 449 + while skip_pos < json.len() && json[skip_pos..].chars().next().is_some_and(|c| c.is_whitespace()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:456:48 [INFO] [stdout] | [INFO] [stdout] 456 | while skip_pos < json.len() && json[skip_pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 456 - while skip_pos < json.len() && json[skip_pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] 456 + while skip_pos < json.len() && json[skip_pos..].chars().next().is_some_and(|c| c.is_whitespace()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parts` [INFO] [stdout] --> src/lib.rs:479:14 [INFO] [stdout] | [INFO] [stdout] 479 | for i in 0..parts.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 479 - for i in 0..parts.len() - 1 { [INFO] [stdout] 479 + for in parts.iter().take(parts.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | ch >= '.' && ch <= 'z' && !(ch > '9' && ch < 'A') && ch <= 'z' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 - ch >= '.' && ch <= 'z' && !(ch > '9' && ch < 'A') && ch <= 'z' [INFO] [stdout] 61 + !(ch < '.' || ch > 'z' || ch > '9' && ch < 'A') [INFO] [stdout] | [INFO] [stdout] 61 - ch >= '.' && ch <= 'z' && !(ch > '9' && ch < 'A') && ch <= 'z' [INFO] [stdout] 61 + (ch >= 'A' || ch <= '9') && ch <= 'z' && ch >= '.' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | ch >= '.' && ch <= 'z' && !(ch > '9' && ch < 'A') && ch <= 'z' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `('.'..='z').contains(&ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:181:19 [INFO] [stdout] | [INFO] [stdout] 181 | && !value.parse::().is_ok() && value != "true" && value != "false" && value != "null" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parts` [INFO] [stdout] --> src/lib.rs:215:14 [INFO] [stdout] | [INFO] [stdout] 215 | for i in 0..parts.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 215 - for i in 0..parts.len() - 1 { [INFO] [stdout] 215 + for in parts.iter().take(parts.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parts` [INFO] [stdout] --> src/lib.rs:348:14 [INFO] [stdout] | [INFO] [stdout] 348 | for i in 0..parts.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 348 - for i in 0..parts.len() - 1 { [INFO] [stdout] 348 + for in parts.iter().take(parts.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/lib.rs:421:50 [INFO] [stdout] | [INFO] [stdout] 421 | let key_pattern = format!("\"{}\":", path.split('.').last().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 421 - let key_pattern = format!("\"{}\":", path.split('.').last().unwrap()); [INFO] [stdout] 421 + let key_pattern = format!("\"{}\":", path.split('.').next_back().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:432:34 [INFO] [stdout] | [INFO] [stdout] 432 | while pos > 0 && json[pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 432 - while pos > 0 && json[pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] 432 + while pos > 0 && json[pos..].chars().next().is_some_and(|c| c.is_whitespace()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:438:47 [INFO] [stdout] | [INFO] [stdout] 438 | while actual_start > 0 && json[actual_start-1..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 438 - while actual_start > 0 && json[actual_start-1..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] 438 + while actual_start > 0 && json[actual_start-1..].chars().next().is_some_and(|c| c.is_whitespace()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:449:44 [INFO] [stdout] | [INFO] [stdout] 449 | while skip_pos < json.len() && json[skip_pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 449 - while skip_pos < json.len() && json[skip_pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] 449 + while skip_pos < json.len() && json[skip_pos..].chars().next().is_some_and(|c| c.is_whitespace()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/lib.rs:456:48 [INFO] [stdout] | [INFO] [stdout] 456 | while skip_pos < json.len() && json[skip_pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 456 - while skip_pos < json.len() && json[skip_pos..].chars().next().map_or(false, |c| c.is_whitespace()) { [INFO] [stdout] 456 + while skip_pos < json.len() && json[skip_pos..].chars().next().is_some_and(|c| c.is_whitespace()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `parts` [INFO] [stdout] --> src/lib.rs:479:14 [INFO] [stdout] | [INFO] [stdout] 479 | for i in 0..parts.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 479 - for i in 0..parts.len() - 1 { [INFO] [stdout] 479 + for in parts.iter().take(parts.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> examples/options.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `sjson::Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> examples/options.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> examples/options.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `sjson::Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> examples/options.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> examples/options.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `sjson::Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> examples/options.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> examples/options.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `sjson::Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> examples/options.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> examples/options.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `sjson::Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> examples/options.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:673:9 [INFO] [stdout] | [INFO] [stdout] 673 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:672:9 [INFO] [stdout] | [INFO] [stdout] 672 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:730:9 [INFO] [stdout] | [INFO] [stdout] 730 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:729:9 [INFO] [stdout] | [INFO] [stdout] 729 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:739:9 [INFO] [stdout] | [INFO] [stdout] 739 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:738:9 [INFO] [stdout] | [INFO] [stdout] 738 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:765:9 [INFO] [stdout] | [INFO] [stdout] 765 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:764:9 [INFO] [stdout] | [INFO] [stdout] 764 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:777:9 [INFO] [stdout] | [INFO] [stdout] 777 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:776:9 [INFO] [stdout] | [INFO] [stdout] 776 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:786:9 [INFO] [stdout] | [INFO] [stdout] 786 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:785:9 [INFO] [stdout] | [INFO] [stdout] 785 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:796:9 [INFO] [stdout] | [INFO] [stdout] 796 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:795:9 [INFO] [stdout] | [INFO] [stdout] 795 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:805:9 [INFO] [stdout] | [INFO] [stdout] 805 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:804:9 [INFO] [stdout] | [INFO] [stdout] 804 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:814:9 [INFO] [stdout] | [INFO] [stdout] 814 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:813:9 [INFO] [stdout] | [INFO] [stdout] 813 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:823:9 [INFO] [stdout] | [INFO] [stdout] 823 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:822:9 [INFO] [stdout] | [INFO] [stdout] 822 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:843:9 [INFO] [stdout] | [INFO] [stdout] 843 | opts1.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:842:9 [INFO] [stdout] | [INFO] [stdout] 842 | let mut opts1 = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:851:9 [INFO] [stdout] | [INFO] [stdout] 851 | assert_eq!(opts.optimistic, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 851 - assert_eq!(opts.optimistic, false); [INFO] [stdout] 851 + assert!(!opts.optimistic); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:858:9 [INFO] [stdout] | [INFO] [stdout] 858 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:857:9 [INFO] [stdout] | [INFO] [stdout] 857 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:870:9 [INFO] [stdout] | [INFO] [stdout] 870 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:869:9 [INFO] [stdout] | [INFO] [stdout] 869 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:879:9 [INFO] [stdout] | [INFO] [stdout] 879 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:878:9 [INFO] [stdout] | [INFO] [stdout] 878 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:889:9 [INFO] [stdout] | [INFO] [stdout] 889 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:888:9 [INFO] [stdout] | [INFO] [stdout] 888 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:898:9 [INFO] [stdout] | [INFO] [stdout] 898 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:897:9 [INFO] [stdout] | [INFO] [stdout] 897 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:913:9 [INFO] [stdout] | [INFO] [stdout] 913 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:912:9 [INFO] [stdout] | [INFO] [stdout] 912 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:932:9 [INFO] [stdout] | [INFO] [stdout] 932 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:931:9 [INFO] [stdout] | [INFO] [stdout] 931 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:941:9 [INFO] [stdout] | [INFO] [stdout] 941 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:940:9 [INFO] [stdout] | [INFO] [stdout] 940 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:950:9 [INFO] [stdout] | [INFO] [stdout] 950 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:949:9 [INFO] [stdout] | [INFO] [stdout] 949 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:959:9 [INFO] [stdout] | [INFO] [stdout] 959 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:958:9 [INFO] [stdout] | [INFO] [stdout] 958 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:968:9 [INFO] [stdout] | [INFO] [stdout] 968 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:967:9 [INFO] [stdout] | [INFO] [stdout] 967 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:978:9 [INFO] [stdout] | [INFO] [stdout] 978 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:977:9 [INFO] [stdout] | [INFO] [stdout] 977 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:987:9 [INFO] [stdout] | [INFO] [stdout] 987 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:986:9 [INFO] [stdout] | [INFO] [stdout] 986 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:997:9 [INFO] [stdout] | [INFO] [stdout] 997 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:996:9 [INFO] [stdout] | [INFO] [stdout] 996 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1006:9 [INFO] [stdout] | [INFO] [stdout] 1006 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1005:9 [INFO] [stdout] | [INFO] [stdout] 1005 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1015:9 [INFO] [stdout] | [INFO] [stdout] 1015 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1014:9 [INFO] [stdout] | [INFO] [stdout] 1014 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1032:9 [INFO] [stdout] | [INFO] [stdout] 1032 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1031:9 [INFO] [stdout] | [INFO] [stdout] 1031 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1042:9 [INFO] [stdout] | [INFO] [stdout] 1042 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1041:9 [INFO] [stdout] | [INFO] [stdout] 1041 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1059:9 [INFO] [stdout] | [INFO] [stdout] 1059 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1058:9 [INFO] [stdout] | [INFO] [stdout] 1058 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1076:9 [INFO] [stdout] | [INFO] [stdout] 1076 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1075:9 [INFO] [stdout] | [INFO] [stdout] 1075 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1085:9 [INFO] [stdout] | [INFO] [stdout] 1085 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1084:9 [INFO] [stdout] | [INFO] [stdout] 1084 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:1094:9 [INFO] [stdout] | [INFO] [stdout] 1094 | opts.optimistic = true; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Options { optimistic: true }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:1093:9 [INFO] [stdout] | [INFO] [stdout] 1093 | let mut opts = Options::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.72s [INFO] running `Command { std: "docker" "inspect" "2cd74fa300797dd6ed77915d7aae11e853fe8df22ed6c5d0488333d9e1cae0ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cd74fa300797dd6ed77915d7aae11e853fe8df22ed6c5d0488333d9e1cae0ca", kill_on_drop: false }` [INFO] [stdout] 2cd74fa300797dd6ed77915d7aae11e853fe8df22ed6c5d0488333d9e1cae0ca