[INFO] cloning repository https://github.com/nahtaan/SelfUserBot [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/nahtaan/SelfUserBot" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnahtaan%2FSelfUserBot", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnahtaan%2FSelfUserBot'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 28d69f4004f937a60314c9113d7191de99f63795 [INFO] linting nahtaan/SelfUserBot against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnahtaan%2FSelfUserBot" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/nahtaan/SelfUserBot [INFO] finished tweaking git repo https://github.com/nahtaan/SelfUserBot [INFO] tweaked toml for git repo https://github.com/nahtaan/SelfUserBot written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/nahtaan/SelfUserBot on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/nahtaan/SelfUserBot already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded icu_properties v1.5.0 [INFO] [stderr] Downloaded serde_spanned v0.6.6 [INFO] [stderr] Downloaded url v2.5.1 [INFO] [stderr] Downloaded zerovec-derive v0.10.2 [INFO] [stderr] Downloaded httparse v1.9.3 [INFO] [stderr] Downloaded actix-server v2.4.0 [INFO] [stderr] Downloaded toml v0.8.14 [INFO] [stderr] Downloaded zerovec v0.10.2 [INFO] [stderr] Downloaded toml_edit v0.22.14 [INFO] [stderr] Downloaded actix-http v3.7.0 [INFO] [stderr] Downloaded reqwest v0.12.4 [INFO] [stderr] Downloaded winnow v0.6.13 [INFO] [stderr] Downloaded idna v1.0.0 [INFO] [stderr] Downloaded actix-web v4.7.0 [INFO] [stderr] Downloaded object v0.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ae813a80524b35d2d8def257013283e985a7a6a7f8d7599267575b6e53518bc [INFO] running `Command { std: "docker" "start" "-a" "9ae813a80524b35d2d8def257013283e985a7a6a7f8d7599267575b6e53518bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ae813a80524b35d2d8def257013283e985a7a6a7f8d7599267575b6e53518bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ae813a80524b35d2d8def257013283e985a7a6a7f8d7599267575b6e53518bc", kill_on_drop: false }` [INFO] [stdout] 9ae813a80524b35d2d8def257013283e985a7a6a7f8d7599267575b6e53518bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac418e58aeef69fd0f350d9d039baf2d2416caecd5d68ccc44e27e071ec01387 [INFO] running `Command { std: "docker" "start" "-a" "ac418e58aeef69fd0f350d9d039baf2d2416caecd5d68ccc44e27e071ec01387", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking litemap v0.7.3 [INFO] [stderr] Compiling httparse v1.9.3 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Checking bytestring v1.3.1 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Compiling regex-lite v0.1.6 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ordered-multimap v0.6.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking rust-ini v0.19.0 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking actix-server v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Compiling zerovec-derive v0.10.2 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking zerofrom v0.1.4 [INFO] [stderr] Checking pest v2.7.10 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Checking zerovec v0.10.2 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking icu_properties v1.5.0 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking idna v1.0.0 [INFO] [stderr] Checking actix-http v3.7.0 [INFO] [stderr] Checking url v2.5.1 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking actix-web v4.7.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking SelfUserBot v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/init_commands.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / pub mod init_commands { [INFO] [stdout] 3 | | use std::fs; [INFO] [stdout] 4 | | use std::fs::File; [INFO] [stdout] 5 | | use std::ops::Deref; [INFO] [stdout] ... | [INFO] [stdout] 411 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/init_commands.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return r.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return r.clone(); [INFO] [stdout] 22 + r.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/init_commands.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return r.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return r.clone(); [INFO] [stdout] 27 + r.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/init_commands.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / match application_response { [INFO] [stdout] 71 | | Ok(resp) => { [INFO] [stdout] 72 | | let text: String = resp.text().unwrap(); [INFO] [stdout] 73 | | let json: Value = from_str(text.as_str()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 78 | | Err(_) => {} [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 ~ if let Ok(resp) = application_response { [INFO] [stdout] 71 + let text: String = resp.text().unwrap(); [INFO] [stdout] 72 + let json: Value = from_str(text.as_str()).unwrap(); [INFO] [stdout] 73 + let mut w = APPLICATION_ID.write().unwrap(); [INFO] [stdout] 74 + *w = json.get("id").unwrap().as_str().unwrap().to_string(); [INFO] [stdout] 75 + let _ = w.deref(); [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/init_commands.rs:88:25 [INFO] [stdout] | [INFO] [stdout] 88 | for response in r.to_vec() { [INFO] [stdout] | ^^^^^^^^^^ help: use: `r.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/init_commands.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | if !fs::metadata("Commands.yml").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("Commands.yml").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/init_commands.rs:258:36 [INFO] [stdout] | [INFO] [stdout] 258 | ... color: color.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/init_commands.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / pub mod init_commands { [INFO] [stdout] 3 | | use std::fs; [INFO] [stdout] 4 | | use std::fs::File; [INFO] [stdout] 5 | | use std::ops::Deref; [INFO] [stdout] ... | [INFO] [stdout] 411 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/init_commands.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return r.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return r.clone(); [INFO] [stdout] 22 + r.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/init_commands.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return r.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return r.clone(); [INFO] [stdout] 27 + r.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/init_commands.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / match application_response { [INFO] [stdout] 71 | | Ok(resp) => { [INFO] [stdout] 72 | | let text: String = resp.text().unwrap(); [INFO] [stdout] 73 | | let json: Value = from_str(text.as_str()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 78 | | Err(_) => {} [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 ~ if let Ok(resp) = application_response { [INFO] [stdout] 71 + let text: String = resp.text().unwrap(); [INFO] [stdout] 72 + let json: Value = from_str(text.as_str()).unwrap(); [INFO] [stdout] 73 + let mut w = APPLICATION_ID.write().unwrap(); [INFO] [stdout] 74 + *w = json.get("id").unwrap().as_str().unwrap().to_string(); [INFO] [stdout] 75 + let _ = w.deref(); [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/init_commands.rs:88:25 [INFO] [stdout] | [INFO] [stdout] 88 | for response in r.to_vec() { [INFO] [stdout] | ^^^^^^^^^^ help: use: `r.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/init_commands.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | if !fs::metadata("Commands.yml").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("Commands.yml").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interaction_endpoint.rs:41:73 [INFO] [stdout] | [INFO] [stdout] 41 | let interaction: Interaction = serde_json::from_str(&body.as_str()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `body.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/interaction_endpoint.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 42 | if &interaction.r#type == &u8::from(1u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 42 - if &interaction.r#type == &u8::from(1u8) { [INFO] [stdout] 42 + if interaction.r#type == u8::from(1u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/interaction_endpoint.rs:42:48 [INFO] [stdout] | [INFO] [stdout] 42 | if &interaction.r#type == &u8::from(1u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `u8::from()`: `1u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/init_commands.rs:258:36 [INFO] [stdout] | [INFO] [stdout] 258 | ... color: color.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interaction_endpoint.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | .verify(&content.as_slice(), &(sig_ed25519.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `content.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/handle_responses.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod handle_responses { [INFO] [stdout] 2 | | use std::sync::mpsc::{Receiver}; [INFO] [stdout] 3 | | use reqwest::StatusCode; [INFO] [stdout] 4 | | use threadpool::ThreadPool; [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !fs::metadata("Config.yml").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("Config.yml").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | init_commands::init_commands::load_cmds(&token); [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/interaction_endpoint.rs:47:34 [INFO] [stdout] | [INFO] [stdout] 47 | let _ = &SENDER.clone().unwrap().send(interaction); [INFO] [stdout] | ^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interaction_endpoint.rs:41:73 [INFO] [stdout] | [INFO] [stdout] 41 | let interaction: Interaction = serde_json::from_str(&body.as_str()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `body.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/interaction_endpoint.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 42 | if &interaction.r#type == &u8::from(1u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 42 - if &interaction.r#type == &u8::from(1u8) { [INFO] [stdout] 42 + if interaction.r#type == u8::from(1u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/interaction_endpoint.rs:42:48 [INFO] [stdout] | [INFO] [stdout] 42 | if &interaction.r#type == &u8::from(1u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider removing `u8::from()`: `1u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interaction_endpoint.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | .verify(&content.as_slice(), &(sig_ed25519.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `content.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/handle_responses.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod handle_responses { [INFO] [stdout] 2 | | use std::sync::mpsc::{Receiver}; [INFO] [stdout] 3 | | use reqwest::StatusCode; [INFO] [stdout] 4 | | use threadpool::ThreadPool; [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !fs::metadata("Config.yml").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("Config.yml").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | init_commands::init_commands::load_cmds(&token); [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/interaction_endpoint.rs:47:34 [INFO] [stdout] | [INFO] [stdout] 47 | let _ = &SENDER.clone().unwrap().send(interaction); [INFO] [stdout] | ^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 58.32s [INFO] running `Command { std: "docker" "inspect" "ac418e58aeef69fd0f350d9d039baf2d2416caecd5d68ccc44e27e071ec01387", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac418e58aeef69fd0f350d9d039baf2d2416caecd5d68ccc44e27e071ec01387", kill_on_drop: false }` [INFO] [stdout] ac418e58aeef69fd0f350d9d039baf2d2416caecd5d68ccc44e27e071ec01387