[INFO] cloning repository https://github.com/naav97/EHTML [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/naav97/EHTML" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaav97%2FEHTML", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaav97%2FEHTML'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2922015855bb27a79f50ed4f193a810a3af918dc [INFO] linting naav97/EHTML against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaav97%2FEHTML" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/naav97/EHTML [INFO] finished tweaking git repo https://github.com/naav97/EHTML [INFO] tweaked toml for git repo https://github.com/naav97/EHTML written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/naav97/EHTML on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/naav97/EHTML already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf96f2f1b43c10ee6812b02aa5fb115a2250b194bea8228a30ca7ac504059540 [INFO] running `Command { std: "docker" "start" "-a" "bf96f2f1b43c10ee6812b02aa5fb115a2250b194bea8228a30ca7ac504059540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf96f2f1b43c10ee6812b02aa5fb115a2250b194bea8228a30ca7ac504059540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf96f2f1b43c10ee6812b02aa5fb115a2250b194bea8228a30ca7ac504059540", kill_on_drop: false }` [INFO] [stdout] bf96f2f1b43c10ee6812b02aa5fb115a2250b194bea8228a30ca7ac504059540 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 707988532b9477f6a48f455882a30c6c7cf920ca91e30622e6aee253ae161dea [INFO] running `Command { std: "docker" "start" "-a" "707988532b9477f6a48f455882a30c6c7cf920ca91e30622e6aee253ae161dea", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking EHTML v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/engine.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/engine.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/html.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return re; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return re; [INFO] [stdout] 11 + re [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/html.rs:1:32 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn get_element_pos(tokens: &Vec<&str>, element: &str) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn get_element_pos(tokens: &Vec<&str>, element: &str) -> usize { [INFO] [stdout] 1 + pub fn get_element_pos(tokens: &[&str], element: &str) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/html.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/html.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return re; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return re; [INFO] [stdout] 26 + re [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/html.rs:14:30 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn find_meta_tag(tokens: &Vec<&str>) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - pub fn find_meta_tag(tokens: &Vec<&str>) -> usize { [INFO] [stdout] 14 + pub fn find_meta_tag(tokens: &[&str]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/html.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / if tokens[i].starts_with(" src/html.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/html.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | if !(pos_end_head > 2) || !(pos_end_head == pos_start_body-1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(pos_end_head <= 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/html.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | if !(pos_end_head > 2) || !(pos_end_head == pos_start_body-1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(pos_end_head != pos_start_body-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/html.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !(pos_start_title > 2 && pos_start_title < pos_end_title) || !(pos_end_title < pos_end_head) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(pos_start_title > 2 && pos_start_title < pos_end_title && (pos_end_title < pos_end_head))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/html.rs:65:69 [INFO] [stdout] | [INFO] [stdout] 65 | if !(pos_start_title > 2 && pos_start_title < pos_end_title) || !(pos_end_title < pos_end_head) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(pos_end_title >= pos_end_head)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/html.rs:57:49 [INFO] [stdout] | [INFO] [stdout] 57 | let pos_end_head = get_element_pos(&elemts, &""); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/html.rs:58:51 [INFO] [stdout] | [INFO] [stdout] 58 | let pos_start_body = get_element_pos(&elemts, &""); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/html.rs:63:52 [INFO] [stdout] | [INFO] [stdout] 63 | let pos_start_title = get_element_pos(&elemts, &" src/html.rs:64:50 [INFO] [stdout] | [INFO] [stdout] 64 | let pos_end_title = get_element_pos(&elemts, &""); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/html.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/seo.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return tit_cont.chars().count() >= 50 && tit_cont.chars().count() <= 60; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return tit_cont.chars().count() >= 50 && tit_cont.chars().count() <= 60; [INFO] [stdout] 12 + tit_cont.chars().count() >= 50 && tit_cont.chars().count() <= 60 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/seo.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return tokens[0].len() >= 150 && tokens[0].len() <= 160; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return tokens[0].len() >= 150 && tokens[0].len() <= 160; [INFO] [stdout] 25 + tokens[0].len() >= 150 && tokens[0].len() <= 160 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/seo.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return false; [INFO] [stdout] 29 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/seo.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return false; [INFO] [stdout] 34 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/seo.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | if alt.chars().nth(0).unwrap() == '"' || alt.chars().nth(1).unwrap() == '"' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `alt.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return temp; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return temp; [INFO] [stdout] 31 + temp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return val.replace(" ", "").to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return val.replace(" ", "").to_string(); [INFO] [stdout] 34 + val.replace(" ", "").to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/engine.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 41 | let trimval = proc_val(&val); [INFO] [stdout] | ^^^^ help: change this to: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/engine.rs:50:32 [INFO] [stdout] | [INFO] [stdout] 50 | let trimval = proc_val(&val); [INFO] [stdout] | ^^^^ help: change this to: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | return vars; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return vars; [INFO] [stdout] 120 + vars [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/engine.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:23:53 [INFO] [stdout] | [INFO] [stdout] 23 | let final_html: String = replace_vars(vars, &parts[1]); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `parts[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `imgE` should have a snake case name [INFO] [stdout] --> src/seo.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | for imgE in tokens { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `img_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/engine.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(while_true)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: denote infinite loops with `loop { ... }` [INFO] [stdout] --> src/engine.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | while true { [INFO] [stdout] | ^^^^^^^^^^ help: use `loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/html.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return re; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return re; [INFO] [stdout] 11 + re [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/html.rs:1:32 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn get_element_pos(tokens: &Vec<&str>, element: &str) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn get_element_pos(tokens: &Vec<&str>, element: &str) -> usize { [INFO] [stdout] 1 + pub fn get_element_pos(tokens: &[&str], element: &str) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/html.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/html.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return re; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return re; [INFO] [stdout] 26 + re [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/html.rs:14:30 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn find_meta_tag(tokens: &Vec<&str>) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - pub fn find_meta_tag(tokens: &Vec<&str>) -> usize { [INFO] [stdout] 14 + pub fn find_meta_tag(tokens: &[&str]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/html.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / if tokens[i].starts_with(" src/html.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/html.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | if !(pos_end_head > 2) || !(pos_end_head == pos_start_body-1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `(pos_end_head <= 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/html.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | if !(pos_end_head > 2) || !(pos_end_head == pos_start_body-1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(pos_end_head != pos_start_body-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/html.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !(pos_start_title > 2 && pos_start_title < pos_end_title) || !(pos_end_title < pos_end_head) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(pos_start_title > 2 && pos_start_title < pos_end_title && (pos_end_title < pos_end_head))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/html.rs:65:69 [INFO] [stdout] | [INFO] [stdout] 65 | if !(pos_start_title > 2 && pos_start_title < pos_end_title) || !(pos_end_title < pos_end_head) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(pos_end_title >= pos_end_head)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/html.rs:57:49 [INFO] [stdout] | [INFO] [stdout] 57 | let pos_end_head = get_element_pos(&elemts, &""); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/html.rs:58:51 [INFO] [stdout] | [INFO] [stdout] 58 | let pos_start_body = get_element_pos(&elemts, &""); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/html.rs:63:52 [INFO] [stdout] | [INFO] [stdout] 63 | let pos_start_title = get_element_pos(&elemts, &" src/html.rs:64:50 [INFO] [stdout] | [INFO] [stdout] 64 | let pos_end_title = get_element_pos(&elemts, &""); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/html.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/seo.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return tit_cont.chars().count() >= 50 && tit_cont.chars().count() <= 60; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return tit_cont.chars().count() >= 50 && tit_cont.chars().count() <= 60; [INFO] [stdout] 12 + tit_cont.chars().count() >= 50 && tit_cont.chars().count() <= 60 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/seo.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return tokens[0].len() >= 150 && tokens[0].len() <= 160; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return tokens[0].len() >= 150 && tokens[0].len() <= 160; [INFO] [stdout] 25 + tokens[0].len() >= 150 && tokens[0].len() <= 160 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/seo.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return false; [INFO] [stdout] 29 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/seo.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return false; [INFO] [stdout] 34 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/seo.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | if alt.chars().nth(0).unwrap() == '"' || alt.chars().nth(1).unwrap() == '"' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `alt.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return temp; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return temp; [INFO] [stdout] 31 + temp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return val.replace(" ", "").to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return val.replace(" ", "").to_string(); [INFO] [stdout] 34 + val.replace(" ", "").to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/engine.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 41 | let trimval = proc_val(&val); [INFO] [stdout] | ^^^^ help: change this to: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/engine.rs:50:32 [INFO] [stdout] | [INFO] [stdout] 50 | let trimval = proc_val(&val); [INFO] [stdout] | ^^^^ help: change this to: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/engine.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | return vars; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return vars; [INFO] [stdout] 120 + vars [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/engine.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:23:53 [INFO] [stdout] | [INFO] [stdout] 23 | let final_html: String = replace_vars(vars, &parts[1]); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `parts[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `imgE` should have a snake case name [INFO] [stdout] --> src/seo.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | for imgE in tokens { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `img_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.07s [INFO] running `Command { std: "docker" "inspect" "707988532b9477f6a48f455882a30c6c7cf920ca91e30622e6aee253ae161dea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "707988532b9477f6a48f455882a30c6c7cf920ca91e30622e6aee253ae161dea", kill_on_drop: false }` [INFO] [stdout] 707988532b9477f6a48f455882a30c6c7cf920ca91e30622e6aee253ae161dea