[INFO] cloning repository https://github.com/naari3/naanes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/naari3/naanes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaari3%2Fnaanes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaari3%2Fnaanes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e871140cccfaeacafd4a6d1bda3fbd2a88fbcfa8 [INFO] linting naari3/naanes against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnaari3%2Fnaanes" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/naari3/naanes [INFO] finished tweaking git repo https://github.com/naari3/naanes [INFO] tweaked toml for git repo https://github.com/naari3/naanes written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/naari3/naanes on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/naari3/naanes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/naari3/emu6502` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded weezl v0.1.4 [INFO] [stderr] Downloaded bytemuck v1.5.1 [INFO] [stderr] Downloaded gif v0.11.1 [INFO] [stderr] Downloaded image v0.23.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 408ee0ba10c17bfcd3b02e7c007ae0539cf714ad2d0b04bdbb7cce8748cc0a9b [INFO] running `Command { std: "docker" "start" "-a" "408ee0ba10c17bfcd3b02e7c007ae0539cf714ad2d0b04bdbb7cce8748cc0a9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "408ee0ba10c17bfcd3b02e7c007ae0539cf714ad2d0b04bdbb7cce8748cc0a9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "408ee0ba10c17bfcd3b02e7c007ae0539cf714ad2d0b04bdbb7cce8748cc0a9b", kill_on_drop: false }` [INFO] [stdout] 408ee0ba10c17bfcd3b02e7c007ae0539cf714ad2d0b04bdbb7cce8748cc0a9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c5dc24210b1e4a9da364829767ad8178accea777c10ce031b2374ae9d1e5dcb [INFO] running `Command { std: "docker" "start" "-a" "4c5dc24210b1e4a9da364829767ad8178accea777c10ce031b2374ae9d1e5dcb", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.3 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking weezl v0.1.4 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Checking bytemuck v1.5.1 [INFO] [stderr] Checking emu6502 v0.1.0 (https://github.com/naari3/emu6502?rev=b481518#b4815180) [INFO] [stderr] Checking num-integer v0.1.44 [INFO] [stderr] Checking num-rational v0.3.2 [INFO] [stderr] Checking num-iter v0.1.42 [INFO] [stderr] Checking gif v0.11.1 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.3 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking rayon-core v1.9.0 [INFO] [stderr] Checking rayon v1.5.0 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.13 [INFO] [stderr] Checking naanes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/ppu.rs:257:27 [INFO] [stdout] | [INFO] [stdout] 257 | .push(u8::from(byte1 & (1 << j) != 0) + u8::from(byte2 & (1 << j) != 0) << 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(u8::from(byte1 & (1 << j) != 0) + u8::from(byte2 & (1 << j) != 0)) << 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/ppu.rs:257:27 [INFO] [stdout] | [INFO] [stdout] 257 | .push(u8::from(byte1 & (1 << j) != 0) + u8::from(byte2 & (1 << j) != 0) << 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(u8::from(byte1 & (1 << j) != 0) + u8::from(byte2 & (1 << j) != 0)) << 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/ppu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PPU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 20 | data: Data, // $2007 [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PPU` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `addr` is never read [INFO] [stdout] --> src/ppu.rs:718:5 [INFO] [stdout] | [INFO] [stdout] 717 | struct Data { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 718 | addr: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Data` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/ppu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PPU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 20 | data: Data, // $2007 [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PPU` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `addr` is never read [INFO] [stdout] --> src/ppu.rs:718:5 [INFO] [stdout] | [INFO] [stdout] 717 | struct Data { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 718 | addr: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Data` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | Button::A => self.input = self.input | 0x01, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | Button::B => self.input = self.input | 0x02, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x02` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 26 | Button::Select => self.input = self.input | 0x04, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x04` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:27:30 [INFO] [stdout] | [INFO] [stdout] 27 | Button::Start => self.input = self.input | 0x08, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x08` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | Button::Up => self.input = self.input | 0x10, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 29 | Button::Down => self.input = self.input | 0x20, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | Button::Left => self.input = self.input | 0x40, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 31 | Button::Right => self.input = self.input | 0x80, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x80` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | Button::A => self.input = self.input & !0x01, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | Button::B => self.input = self.input & !0x02, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x02` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | Button::Select => self.input = self.input & !0x04, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x04` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | Button::Start => self.input = self.input & !0x08, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x08` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 42 | Button::Up => self.input = self.input & !0x10, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | Button::Down => self.input = self.input & !0x20, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:44:29 [INFO] [stdout] | [INFO] [stdout] 44 | Button::Left => self.input = self.input & !0x40, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:45:30 [INFO] [stdout] | [INFO] [stdout] 45 | Button::Right => self.input = self.input & !0x80, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x80` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | Button::A => self.input = self.input | 0x01, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | Button::B => self.input = self.input | 0x02, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x02` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 26 | Button::Select => self.input = self.input | 0x04, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x04` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:27:30 [INFO] [stdout] | [INFO] [stdout] 27 | Button::Start => self.input = self.input | 0x08, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x08` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | Button::Up => self.input = self.input | 0x10, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 29 | Button::Down => self.input = self.input | 0x20, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | Button::Left => self.input = self.input | 0x40, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 31 | Button::Right => self.input = self.input | 0x80, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x80` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | Button::A => self.input = self.input & !0x01, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | Button::B => self.input = self.input & !0x02, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x02` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | Button::Select => self.input = self.input & !0x04, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x04` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | Button::Start => self.input = self.input & !0x08, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x08` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 42 | Button::Up => self.input = self.input & !0x10, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | Button::Down => self.input = self.input & !0x20, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:44:29 [INFO] [stdout] | [INFO] [stdout] 44 | Button::Left => self.input = self.input & !0x40, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:45:30 [INFO] [stdout] | [INFO] [stdout] 45 | Button::Right => self.input = self.input & !0x80, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x80` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/ppu.rs:103:64 [INFO] [stdout] | [INFO] [stdout] 103 | self.secondary_oam.set_sprite(found_count, s.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | && !(x == 255) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(x != 255)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:196:16 [INFO] [stdout] | [INFO] [stdout] 196 | && !(background_c == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(background_c != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ppu.rs:245:45 [INFO] [stdout] | [INFO] [stdout] 245 | .map(|(i, addr)| self.read_byte(*addr as usize + i)) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/ppu.rs:103:64 [INFO] [stdout] | [INFO] [stdout] 103 | self.secondary_oam.set_sprite(found_count, s.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `pixels` [INFO] [stdout] --> src/ppu.rs:287:18 [INFO] [stdout] | [INFO] [stdout] 287 | for i in 0..pixels.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 287 - for i in 0..pixels.len() { [INFO] [stdout] 287 + for (i, ) in pixels.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | && !(x == 255) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(x != 255)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ppu.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | (attr_addr as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `attr_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:196:16 [INFO] [stdout] | [INFO] [stdout] 196 | && !(background_c == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(background_c != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ppu.rs:245:45 [INFO] [stdout] | [INFO] [stdout] 245 | .map(|(i, addr)| self.read_byte(*addr as usize + i)) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:393:20 [INFO] [stdout] | [INFO] [stdout] 393 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/ppu.rs:432:17 [INFO] [stdout] | [INFO] [stdout] 424 | / let byte = match address { [INFO] [stdout] 425 | | // https://wiki.nesdev.com/w/index.php/PPU_memory_map [INFO] [stdout] 426 | | 0x0000..=0x0FFF => self.chr_rom[address], [INFO] [stdout] 427 | | 0x1000..=0x1FFF => self.chr_rom[address], [INFO] [stdout] ... | [INFO] [stdout] 430 | | _ => 0, [INFO] [stdout] 431 | | }; [INFO] [stdout] | |__________________- unnecessary `let` binding [INFO] [stdout] 432 | byte [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 424 ~ [INFO] [stdout] 425 ~ match address { [INFO] [stdout] 426 + // https://wiki.nesdev.com/w/index.php/PPU_memory_map [INFO] [stdout] 427 + 0x0000..=0x0FFF => self.chr_rom[address], [INFO] [stdout] 428 + 0x1000..=0x1FFF => self.chr_rom[address], [INFO] [stdout] 429 + 0x2000..=0x2FFF => self.read_byte_from_nametable(address), [INFO] [stdout] 430 + 0x3F00..=0x3FFF => self.palette_ram.read_byte(addr - 0x3F00), [INFO] [stdout] 431 + _ => 0, [INFO] [stdout] 432 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `pixels` [INFO] [stdout] --> src/ppu.rs:287:18 [INFO] [stdout] | [INFO] [stdout] 287 | for i in 0..pixels.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 287 - for i in 0..pixels.len() { [INFO] [stdout] 287 + for (i, ) in pixels.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:421:20 [INFO] [stdout] | [INFO] [stdout] 421 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:450:20 [INFO] [stdout] | [INFO] [stdout] 450 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ppu.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | (attr_addr as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `attr_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:393:20 [INFO] [stdout] | [INFO] [stdout] 393 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/ppu.rs:432:17 [INFO] [stdout] | [INFO] [stdout] 424 | / let byte = match address { [INFO] [stdout] 425 | | // https://wiki.nesdev.com/w/index.php/PPU_memory_map [INFO] [stdout] 426 | | 0x0000..=0x0FFF => self.chr_rom[address], [INFO] [stdout] 427 | | 0x1000..=0x1FFF => self.chr_rom[address], [INFO] [stdout] ... | [INFO] [stdout] 430 | | _ => 0, [INFO] [stdout] 431 | | }; [INFO] [stdout] | |__________________- unnecessary `let` binding [INFO] [stdout] 432 | byte [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 424 ~ [INFO] [stdout] 425 ~ match address { [INFO] [stdout] 426 + // https://wiki.nesdev.com/w/index.php/PPU_memory_map [INFO] [stdout] 427 + 0x0000..=0x0FFF => self.chr_rom[address], [INFO] [stdout] 428 + 0x1000..=0x1FFF => self.chr_rom[address], [INFO] [stdout] 429 + 0x2000..=0x2FFF => self.read_byte_from_nametable(address), [INFO] [stdout] 430 + 0x3F00..=0x3FFF => self.palette_ram.read_byte(addr - 0x3F00), [INFO] [stdout] 431 + _ => 0, [INFO] [stdout] 432 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:421:20 [INFO] [stdout] | [INFO] [stdout] 421 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:450:20 [INFO] [stdout] | [INFO] [stdout] 450 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:660:1 [INFO] [stdout] | [INFO] [stdout] 660 | / impl Default for ScrollNext { [INFO] [stdout] 661 | | fn default() -> Self { [INFO] [stdout] 662 | | ScrollNext::X [INFO] [stdout] 663 | | } [INFO] [stdout] 664 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 655 + #[derive(Default)] [INFO] [stdout] 656 | enum ScrollNext { [INFO] [stdout] 657 ~ #[default] [INFO] [stdout] 658 ~ X, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:728:1 [INFO] [stdout] | [INFO] [stdout] 728 | / impl Default for OAMDMAStatus { [INFO] [stdout] 729 | | fn default() -> Self { [INFO] [stdout] 730 | | Self::NotRunning [INFO] [stdout] 731 | | } [INFO] [stdout] 732 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 722 + #[derive(Default)] [INFO] [stdout] 723 | pub enum OAMDMAStatus { [INFO] [stdout] 724 ~ #[default] [INFO] [stdout] 725 ~ NotRunning, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OAMDMA` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:736:8 [INFO] [stdout] | [INFO] [stdout] 736 | struct OAMDMA { [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Oamdma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:660:1 [INFO] [stdout] | [INFO] [stdout] 660 | / impl Default for ScrollNext { [INFO] [stdout] 661 | | fn default() -> Self { [INFO] [stdout] 662 | | ScrollNext::X [INFO] [stdout] 663 | | } [INFO] [stdout] 664 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 655 + #[derive(Default)] [INFO] [stdout] 656 | enum ScrollNext { [INFO] [stdout] 657 ~ #[default] [INFO] [stdout] 658 ~ X, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:796:1 [INFO] [stdout] | [INFO] [stdout] 796 | / impl Default for SpritePriority { [INFO] [stdout] 797 | | fn default() -> Self { [INFO] [stdout] 798 | | Self::Back [INFO] [stdout] 799 | | } [INFO] [stdout] 800 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 791 + #[derive(Default)] [INFO] [stdout] 792 | enum SpritePriority { [INFO] [stdout] 793 | Front, [INFO] [stdout] 794 ~ #[default] [INFO] [stdout] 795 ~ Back, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OAM` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:839:8 [INFO] [stdout] | [INFO] [stdout] 839 | struct OAM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Oam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:728:1 [INFO] [stdout] | [INFO] [stdout] 728 | / impl Default for OAMDMAStatus { [INFO] [stdout] 729 | | fn default() -> Self { [INFO] [stdout] 730 | | Self::NotRunning [INFO] [stdout] 731 | | } [INFO] [stdout] 732 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 722 + #[derive(Default)] [INFO] [stdout] 723 | pub enum OAMDMAStatus { [INFO] [stdout] 724 ~ #[default] [INFO] [stdout] 725 ~ NotRunning, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OAMDMA` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:736:8 [INFO] [stdout] | [INFO] [stdout] 736 | struct OAMDMA { [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Oamdma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:796:1 [INFO] [stdout] | [INFO] [stdout] 796 | / impl Default for SpritePriority { [INFO] [stdout] 797 | | fn default() -> Self { [INFO] [stdout] 798 | | Self::Back [INFO] [stdout] 799 | | } [INFO] [stdout] 800 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 791 + #[derive(Default)] [INFO] [stdout] 792 | enum SpritePriority { [INFO] [stdout] 793 | Front, [INFO] [stdout] 794 ~ #[default] [INFO] [stdout] 795 ~ Back, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OAM` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:839:8 [INFO] [stdout] | [INFO] [stdout] 839 | struct OAM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Oam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/ppu.rs:257:27 [INFO] [stdout] | [INFO] [stdout] 257 | .push(u8::from(byte1 & (1 << j) != 0) + u8::from(byte2 & (1 << j) != 0) << 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(u8::from(byte1 & (1 << j) != 0) + u8::from(byte2 & (1 << j) != 0)) << 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/ppu.rs:257:27 [INFO] [stdout] | [INFO] [stdout] 257 | .push(u8::from(byte1 & (1 << j) != 0) + u8::from(byte2 & (1 << j) != 0) << 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(u8::from(byte1 & (1 << j) != 0) + u8::from(byte2 & (1 << j) != 0)) << 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/ppu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PPU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 20 | data: Data, // $2007 [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PPU` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `addr` is never read [INFO] [stdout] --> src/ppu.rs:718:5 [INFO] [stdout] | [INFO] [stdout] 717 | struct Data { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 718 | addr: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Data` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | Button::A => self.input = self.input | 0x01, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | Button::B => self.input = self.input | 0x02, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x02` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 26 | Button::Select => self.input = self.input | 0x04, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x04` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:27:30 [INFO] [stdout] | [INFO] [stdout] 27 | Button::Start => self.input = self.input | 0x08, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x08` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | Button::Up => self.input = self.input | 0x10, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 29 | Button::Down => self.input = self.input | 0x20, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | Button::Left => self.input = self.input | 0x40, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 31 | Button::Right => self.input = self.input | 0x80, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x80` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | Button::A => self.input = self.input & !0x01, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | Button::B => self.input = self.input & !0x02, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x02` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | Button::Select => self.input = self.input & !0x04, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x04` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | Button::Start => self.input = self.input & !0x08, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x08` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 42 | Button::Up => self.input = self.input & !0x10, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | Button::Down => self.input = self.input & !0x20, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:44:29 [INFO] [stdout] | [INFO] [stdout] 44 | Button::Left => self.input = self.input & !0x40, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:45:30 [INFO] [stdout] | [INFO] [stdout] 45 | Button::Right => self.input = self.input & !0x80, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x80` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NES` contains a capitalized acronym [INFO] [stdout] --> src/nes.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct NES { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PPU` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ppu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/ppu.rs:103:64 [INFO] [stdout] | [INFO] [stdout] 103 | self.secondary_oam.set_sprite(found_count, s.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | && !(x == 255) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(x != 255)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:196:16 [INFO] [stdout] | [INFO] [stdout] 196 | && !(background_c == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(background_c != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `data` is never read [INFO] [stdout] --> src/ppu.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PPU { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 20 | data: Data, // $2007 [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PPU` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `addr` is never read [INFO] [stdout] --> src/ppu.rs:718:5 [INFO] [stdout] | [INFO] [stdout] 717 | struct Data { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 718 | addr: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Data` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ppu.rs:245:45 [INFO] [stdout] | [INFO] [stdout] 245 | .map(|(i, addr)| self.read_byte(*addr as usize + i)) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `pixels` [INFO] [stdout] --> src/ppu.rs:287:18 [INFO] [stdout] | [INFO] [stdout] 287 | for i in 0..pixels.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 287 - for i in 0..pixels.len() { [INFO] [stdout] 287 + for (i, ) in pixels.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ppu.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | (attr_addr as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `attr_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:393:20 [INFO] [stdout] | [INFO] [stdout] 393 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/ppu.rs:432:17 [INFO] [stdout] | [INFO] [stdout] 424 | / let byte = match address { [INFO] [stdout] 425 | | // https://wiki.nesdev.com/w/index.php/PPU_memory_map [INFO] [stdout] 426 | | 0x0000..=0x0FFF => self.chr_rom[address], [INFO] [stdout] 427 | | 0x1000..=0x1FFF => self.chr_rom[address], [INFO] [stdout] ... | [INFO] [stdout] 430 | | _ => 0, [INFO] [stdout] 431 | | }; [INFO] [stdout] | |__________________- unnecessary `let` binding [INFO] [stdout] 432 | byte [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 424 ~ [INFO] [stdout] 425 ~ match address { [INFO] [stdout] 426 + // https://wiki.nesdev.com/w/index.php/PPU_memory_map [INFO] [stdout] 427 + 0x0000..=0x0FFF => self.chr_rom[address], [INFO] [stdout] 428 + 0x1000..=0x1FFF => self.chr_rom[address], [INFO] [stdout] 429 + 0x2000..=0x2FFF => self.read_byte_from_nametable(address), [INFO] [stdout] 430 + 0x3F00..=0x3FFF => self.palette_ram.read_byte(addr - 0x3F00), [INFO] [stdout] 431 + _ => 0, [INFO] [stdout] 432 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:421:20 [INFO] [stdout] | [INFO] [stdout] 421 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | Button::A => self.input = self.input | 0x01, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | Button::B => self.input = self.input | 0x02, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x02` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:450:20 [INFO] [stdout] | [INFO] [stdout] 450 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:26:31 [INFO] [stdout] | [INFO] [stdout] 26 | Button::Select => self.input = self.input | 0x04, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x04` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:27:30 [INFO] [stdout] | [INFO] [stdout] 27 | Button::Start => self.input = self.input | 0x08, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x08` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | Button::Up => self.input = self.input | 0x10, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 29 | Button::Down => self.input = self.input | 0x20, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | Button::Left => self.input = self.input | 0x40, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 31 | Button::Right => self.input = self.input | 0x80, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input |= 0x80` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:38:26 [INFO] [stdout] | [INFO] [stdout] 38 | Button::A => self.input = self.input & !0x01, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x01` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | Button::B => self.input = self.input & !0x02, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x02` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | Button::Select => self.input = self.input & !0x04, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x04` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 41 | Button::Start => self.input = self.input & !0x08, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x08` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:42:27 [INFO] [stdout] | [INFO] [stdout] 42 | Button::Up => self.input = self.input & !0x10, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | Button::Down => self.input = self.input & !0x20, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x20` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:44:29 [INFO] [stdout] | [INFO] [stdout] 44 | Button::Left => self.input = self.input & !0x40, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x40` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/controller.rs:45:30 [INFO] [stdout] | [INFO] [stdout] 45 | Button::Right => self.input = self.input & !0x80, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.input &= !0x80` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NES` contains a capitalized acronym [INFO] [stdout] --> src/nes.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct NES { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:660:1 [INFO] [stdout] | [INFO] [stdout] 660 | / impl Default for ScrollNext { [INFO] [stdout] 661 | | fn default() -> Self { [INFO] [stdout] 662 | | ScrollNext::X [INFO] [stdout] 663 | | } [INFO] [stdout] 664 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 655 + #[derive(Default)] [INFO] [stdout] 656 | enum ScrollNext { [INFO] [stdout] 657 ~ #[default] [INFO] [stdout] 658 ~ X, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:728:1 [INFO] [stdout] | [INFO] [stdout] 728 | / impl Default for OAMDMAStatus { [INFO] [stdout] 729 | | fn default() -> Self { [INFO] [stdout] 730 | | Self::NotRunning [INFO] [stdout] 731 | | } [INFO] [stdout] 732 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 722 + #[derive(Default)] [INFO] [stdout] 723 | pub enum OAMDMAStatus { [INFO] [stdout] 724 ~ #[default] [INFO] [stdout] 725 ~ NotRunning, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PPU` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ppu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OAMDMA` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:736:8 [INFO] [stdout] | [INFO] [stdout] 736 | struct OAMDMA { [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Oamdma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:796:1 [INFO] [stdout] | [INFO] [stdout] 796 | / impl Default for SpritePriority { [INFO] [stdout] 797 | | fn default() -> Self { [INFO] [stdout] 798 | | Self::Back [INFO] [stdout] 799 | | } [INFO] [stdout] 800 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 791 + #[derive(Default)] [INFO] [stdout] 792 | enum SpritePriority { [INFO] [stdout] 793 | Front, [INFO] [stdout] 794 ~ #[default] [INFO] [stdout] 795 ~ Back, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OAM` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:839:8 [INFO] [stdout] | [INFO] [stdout] 839 | struct OAM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Oam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROM` contains a capitalized acronym [INFO] [stdout] --> src/rom.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ROM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sprite` which implements the `Copy` trait [INFO] [stdout] --> src/ppu.rs:103:64 [INFO] [stdout] | [INFO] [stdout] 103 | self.secondary_oam.set_sprite(found_count, s.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | && !(x == 255) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(x != 255)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:196:16 [INFO] [stdout] | [INFO] [stdout] 196 | && !(background_c == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(background_c != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ppu.rs:245:45 [INFO] [stdout] | [INFO] [stdout] 245 | .map(|(i, addr)| self.read_byte(*addr as usize + i)) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `pixels` [INFO] [stdout] --> src/ppu.rs:287:18 [INFO] [stdout] | [INFO] [stdout] 287 | for i in 0..pixels.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 287 - for i in 0..pixels.len() { [INFO] [stdout] 287 + for (i, ) in pixels.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/ppu.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | (attr_addr as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `attr_addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:393:20 [INFO] [stdout] | [INFO] [stdout] 393 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/ppu.rs:432:17 [INFO] [stdout] | [INFO] [stdout] 424 | / let byte = match address { [INFO] [stdout] 425 | | // https://wiki.nesdev.com/w/index.php/PPU_memory_map [INFO] [stdout] 426 | | 0x0000..=0x0FFF => self.chr_rom[address], [INFO] [stdout] 427 | | 0x1000..=0x1FFF => self.chr_rom[address], [INFO] [stdout] ... | [INFO] [stdout] 430 | | _ => 0, [INFO] [stdout] 431 | | }; [INFO] [stdout] | |__________________- unnecessary `let` binding [INFO] [stdout] 432 | byte [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 424 ~ [INFO] [stdout] 425 ~ match address { [INFO] [stdout] 426 + // https://wiki.nesdev.com/w/index.php/PPU_memory_map [INFO] [stdout] 427 + 0x0000..=0x0FFF => self.chr_rom[address], [INFO] [stdout] 428 + 0x1000..=0x1FFF => self.chr_rom[address], [INFO] [stdout] 429 + 0x2000..=0x2FFF => self.read_byte_from_nametable(address), [INFO] [stdout] 430 + 0x3F00..=0x3FFF => self.palette_ram.read_byte(addr - 0x3F00), [INFO] [stdout] 431 + _ => 0, [INFO] [stdout] 432 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:421:20 [INFO] [stdout] | [INFO] [stdout] 421 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/ppu.rs:450:20 [INFO] [stdout] | [INFO] [stdout] 450 | if addr >= 0x3000 && addr <= 0x3EFF { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x3000..=0x3EFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:660:1 [INFO] [stdout] | [INFO] [stdout] 660 | / impl Default for ScrollNext { [INFO] [stdout] 661 | | fn default() -> Self { [INFO] [stdout] 662 | | ScrollNext::X [INFO] [stdout] 663 | | } [INFO] [stdout] 664 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 655 + #[derive(Default)] [INFO] [stdout] 656 | enum ScrollNext { [INFO] [stdout] 657 ~ #[default] [INFO] [stdout] 658 ~ X, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:728:1 [INFO] [stdout] | [INFO] [stdout] 728 | / impl Default for OAMDMAStatus { [INFO] [stdout] 729 | | fn default() -> Self { [INFO] [stdout] 730 | | Self::NotRunning [INFO] [stdout] 731 | | } [INFO] [stdout] 732 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 722 + #[derive(Default)] [INFO] [stdout] 723 | pub enum OAMDMAStatus { [INFO] [stdout] 724 ~ #[default] [INFO] [stdout] 725 ~ NotRunning, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OAMDMA` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:736:8 [INFO] [stdout] | [INFO] [stdout] 736 | struct OAMDMA { [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Oamdma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/ppu.rs:796:1 [INFO] [stdout] | [INFO] [stdout] 796 | / impl Default for SpritePriority { [INFO] [stdout] 797 | | fn default() -> Self { [INFO] [stdout] 798 | | Self::Back [INFO] [stdout] 799 | | } [INFO] [stdout] 800 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 791 + #[derive(Default)] [INFO] [stdout] 792 | enum SpritePriority { [INFO] [stdout] 793 | Front, [INFO] [stdout] 794 ~ #[default] [INFO] [stdout] 795 ~ Back, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OAM` contains a capitalized acronym [INFO] [stdout] --> src/ppu.rs:839:8 [INFO] [stdout] | [INFO] [stdout] 839 | struct OAM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Oam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROM` contains a capitalized acronym [INFO] [stdout] --> src/rom.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ROM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.46s [INFO] running `Command { std: "docker" "inspect" "4c5dc24210b1e4a9da364829767ad8178accea777c10ce031b2374ae9d1e5dcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c5dc24210b1e4a9da364829767ad8178accea777c10ce031b2374ae9d1e5dcb", kill_on_drop: false }` [INFO] [stdout] 4c5dc24210b1e4a9da364829767ad8178accea777c10ce031b2374ae9d1e5dcb