[INFO] cloning repository https://github.com/mzhou/http-sir [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mzhou/http-sir" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmzhou%2Fhttp-sir", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmzhou%2Fhttp-sir'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9f08822d68ac1502b23d7194069e6e92c5e5e88c [INFO] linting mzhou/http-sir against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmzhou%2Fhttp-sir" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-0-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/mzhou/http-sir [INFO] finished tweaking git repo https://github.com/mzhou/http-sir [INFO] tweaked toml for git repo https://github.com/mzhou/http-sir written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mzhou/http-sir on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mzhou/http-sir already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded uuid v1.0.0 [INFO] [stderr] Downloaded tokio-macros v1.7.0 [INFO] [stderr] Downloaded unicode-xid v0.2.3 [INFO] [stderr] Downloaded futures-task v0.3.21 [INFO] [stderr] Downloaded tower-service v0.3.1 [INFO] [stderr] Downloaded slab v0.4.6 [INFO] [stderr] Downloaded httpdate v1.0.2 [INFO] [stderr] Downloaded try-lock v0.2.3 [INFO] [stderr] Downloaded want v0.3.0 [INFO] [stderr] Downloaded clap_lex v0.2.0 [INFO] [stderr] Downloaded futures-core v0.3.21 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.80 [INFO] [stderr] Downloaded itoa v1.0.1 [INFO] [stderr] Downloaded http-body v0.4.4 [INFO] [stderr] Downloaded untrusted v0.7.1 [INFO] [stderr] Downloaded quote v1.0.18 [INFO] [stderr] Downloaded clap_derive v3.1.7 [INFO] [stderr] Downloaded os_str_bytes v6.0.0 [INFO] [stderr] Downloaded textwrap v0.15.0 [INFO] [stderr] Downloaded indexmap v1.8.1 [INFO] [stderr] Downloaded hashbrown v0.11.2 [INFO] [stderr] Downloaded http v0.2.7 [INFO] [stderr] Downloaded tokio-util v0.7.1 [INFO] [stderr] Downloaded futures-util v0.3.21 [INFO] [stderr] Downloaded h2 v0.3.13 [INFO] [stderr] Downloaded wasm-bindgen v0.2.80 [INFO] [stderr] Downloaded hyper v0.14.18 [INFO] [stderr] Downloaded clap v3.1.17 [INFO] [stderr] Downloaded syn v1.0.93 [INFO] [stderr] Downloaded rustls v0.20.4 [INFO] [stderr] Downloaded bumpalo v3.9.1 [INFO] [stderr] Downloaded webpki v0.22.0 [INFO] [stderr] Downloaded mio v0.8.3 [INFO] [stderr] Downloaded tracing-core v0.1.26 [INFO] [stderr] Downloaded tracing v0.1.34 [INFO] [stderr] Downloaded security-framework v2.6.1 [INFO] [stderr] Downloaded js-sys v0.3.57 [INFO] [stderr] Downloaded tokio v1.18.2 [INFO] [stderr] Downloaded bytes v1.1.0 [INFO] [stderr] Downloaded schannel v0.1.19 [INFO] [stderr] Downloaded rustls-native-certs v0.6.2 [INFO] [stderr] Downloaded cc v1.0.73 [INFO] [stderr] Downloaded thiserror v1.0.31 [INFO] [stderr] Downloaded redox_syscall v0.2.13 [INFO] [stderr] Downloaded parking_lot v0.12.0 [INFO] [stderr] Downloaded socket2 v0.4.4 [INFO] [stderr] Downloaded proc-macro2 v1.0.38 [INFO] [stderr] Downloaded libc v0.2.125 [INFO] [stderr] Downloaded termcolor v1.1.3 [INFO] [stderr] Downloaded futures-channel v0.3.21 [INFO] [stderr] Downloaded httparse v1.7.1 [INFO] [stderr] Downloaded web-sys v0.3.57 [INFO] [stderr] Downloaded sct v0.7.0 [INFO] [stderr] Downloaded lock_api v0.4.7 [INFO] [stderr] Downloaded smallvec v1.8.0 [INFO] [stderr] Downloaded tracing-attributes v0.1.21 [INFO] [stderr] Downloaded security-framework-sys v2.6.1 [INFO] [stderr] Downloaded tokio-rustls v0.23.4 [INFO] [stderr] Downloaded hyper-rustls v0.23.0 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.80 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.80 [INFO] [stderr] Downloaded once_cell v1.10.0 [INFO] [stderr] Downloaded getrandom v0.2.6 [INFO] [stderr] Downloaded thiserror-impl v1.0.31 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.80 [INFO] [stderr] Downloaded futures-sink v0.3.21 [INFO] [stderr] Downloaded spin v0.5.2 [INFO] [stderr] Downloaded rustls-pemfile v1.0.0 [INFO] [stderr] Downloaded ring v0.16.20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d8d1c4438354f15daf6020ccd3afef2b2c167bfa211a5c3c85e06a7518edaa11 [INFO] running `Command { std: "docker" "start" "-a" "d8d1c4438354f15daf6020ccd3afef2b2c167bfa211a5c3c85e06a7518edaa11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d8d1c4438354f15daf6020ccd3afef2b2c167bfa211a5c3c85e06a7518edaa11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8d1c4438354f15daf6020ccd3afef2b2c167bfa211a5c3c85e06a7518edaa11", kill_on_drop: false }` [INFO] [stdout] d8d1c4438354f15daf6020ccd3afef2b2c167bfa211a5c3c85e06a7518edaa11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b3f263bbeecb14fe832c2e6c4967e9967768e7ccec2907e778beca33a04a61b [INFO] running `Command { std: "docker" "start" "-a" "5b3f263bbeecb14fe832c2e6c4967e9967768e7ccec2907e778beca33a04a61b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling proc-macro2 v1.0.38 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Compiling syn v1.0.93 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking http v0.2.7 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling rustls v0.20.4 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking rustls-pemfile v1.0.0 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking rustls-native-certs v0.6.2 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking uuid v1.0.0 [INFO] [stderr] Checking clap_lex v0.2.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling clap_derive v3.1.7 [INFO] [stderr] Checking tokio v1.18.2 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking clap v3.1.17 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking hyper-rustls v0.23.0 [INFO] [stderr] Checking http-sir v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `async_closure` has been stable since 1.85.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/bin/http-sir-server/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(async_closure)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/http-sir-server/main.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | let mut fin; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `async_closure` has been stable since 1.85.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/bin/http-sir-client/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(async_closure)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `async_closure` has been stable since 1.85.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/bin/http-sir-client/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(async_closure)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `async_closure` has been stable since 1.85.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/bin/http-sir-server/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(async_closure)] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/http-sir-server/main.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | let mut fin; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/http-sir-server/main.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | let mut fin; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cfg` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | cfg: Arc, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cfg` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | addr: SocketAddr, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 209 | addr: SocketAddr, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/http-sir-server/main.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | let mut fin; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/bin/http-sir-server/main.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | / conn_rx [INFO] [stdout] 100 | | .buf [INFO] [stdout] 101 | | .range(conn_rx.buf.len() - (conn_rx.seq - seq)..) [INFO] [stdout] 102 | | .map(|b| *b) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 99 ~ conn_rx [INFO] [stdout] 100 + .buf [INFO] [stdout] 101 + .range(conn_rx.buf.len() - (conn_rx.seq - seq)..).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | if let Err(_) = rx_sub.changed().await { [INFO] [stdout] | -------^^^^^^------------------------- help: try: `if rx_sub.changed().await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:119:16 [INFO] [stdout] | [INFO] [stdout] 119 | if let Err(_) = sender.send_data(buf.into()).await { [INFO] [stdout] | -------^^^^^^------------------------------------- help: try: `if sender.send_data(buf.into()).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 139 | if let Err(_) = conn.rx_pub.send(seq) { [INFO] [stdout] | -------^^^^^^------------------------ help: try: `if conn.rx_pub.send(seq).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/bin/http-sir-server/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | / match req.method() { [INFO] [stdout] 157 | | &Method::GET => handle_get(cfg, ctx, addr, req).await, [INFO] [stdout] 158 | | &Method::POST => handle_post(cfg, ctx, addr, req).await, [INFO] [stdout] 159 | | _ => Ok(blank_status(StatusCode::METHOD_NOT_ALLOWED)), [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 156 ~ match *req.method() { [INFO] [stdout] 157 ~ Method::GET => handle_get(cfg, ctx, addr, req).await, [INFO] [stdout] 158 ~ Method::POST => handle_post(cfg, ctx, addr, req).await, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/bin/http-sir-server/main.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 163 | async fn handle_get<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:175:64 [INFO] [stdout] | [INFO] [stdout] 175 | let seq = match get_header_str(req.headers(), "s").map(|s| usize::from_str_radix(s, 10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/bin/http-sir-server/main.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | if fin {} [INFO] [stdout] | ^^^^^^^^^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/bin/http-sir-server/main.rs:206:26 [INFO] [stdout] | [INFO] [stdout] 206 | async fn handle_new_conn<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/bin/http-sir-server/main.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 308 | / let _ = tokio::spawn({ [INFO] [stdout] 309 | | let conn = conn.clone(); [INFO] [stdout] 310 | | let ctx = ctx.clone(); [INFO] [stdout] 311 | | let id = id.clone(); [INFO] [stdout] ... | [INFO] [stdout] 333 | | }); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:363:68 [INFO] [stdout] | [INFO] [stdout] 363 | let mut seq = match get_header_str(req.headers(), "s").map(|s| usize::from_str_radix(s, 10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:374:18 [INFO] [stdout] | [INFO] [stdout] 374 | .map(|a| usize::from_str_radix(a, 10).unwrap_or(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/bin/http-sir-client/main.rs:102:72 [INFO] [stdout] | [INFO] [stdout] 102 | async fn handle(cfg: CfgShared, ctx: CtxShared, mut stream: TcpStream, addr: SocketAddr) -> () { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/bin/http-sir-client/main.rs:277:17 [INFO] [stdout] | [INFO] [stdout] 277 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/bin/http-sir-client/main.rs:102:72 [INFO] [stdout] | [INFO] [stdout] 102 | async fn handle(cfg: CfgShared, ctx: CtxShared, mut stream: TcpStream, addr: SocketAddr) -> () { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/bin/http-sir-client/main.rs:277:17 [INFO] [stdout] | [INFO] [stdout] 277 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cfg` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:164:5 [INFO] [stdout] | [INFO] [stdout] 164 | cfg: Arc, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cfg` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | addr: SocketAddr, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 209 | addr: SocketAddr, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/http-sir-client/main.rs:84:41 [INFO] [stdout] | [INFO] [stdout] 84 | .with_cipher_suites(&ALL_CIPHER_SUITES) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `ALL_CIPHER_SUITES` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/http-sir-client/main.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | if !stream.write_all(&[5u8, 0]).await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stream.write_all(&[5u8, 0]).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/http-sir-client/main.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if !stream [INFO] [stdout] | ____________^ [INFO] [stdout] 154 | | .write_all(&[5u8, 0, 0, 1, 0, 0, 0, 0, 0, 0]) [INFO] [stdout] 155 | | .await [INFO] [stdout] 156 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 153 ~ if stream [INFO] [stdout] 154 + .write_all(&[5u8, 0, 0, 1, 0, 0, 0, 0, 0, 0]) [INFO] [stdout] 155 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/http-sir-client/main.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 124 | if buf[..nmethods].iter().find(|m| **m == 0u8) == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `buf[..nmethods].iter().find(|m| **m == 0u8).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/http-sir-client/main.rs:84:41 [INFO] [stdout] | [INFO] [stdout] 84 | .with_cipher_suites(&ALL_CIPHER_SUITES) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `ALL_CIPHER_SUITES` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/http-sir-client/main.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | if !stream.write_all(&[5u8, 0]).await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stream.write_all(&[5u8, 0]).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/http-sir-client/main.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if !stream [INFO] [stdout] | ____________^ [INFO] [stdout] 154 | | .write_all(&[5u8, 0, 0, 1, 0, 0, 0, 0, 0, 0]) [INFO] [stdout] 155 | | .await [INFO] [stdout] 156 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 153 ~ if stream [INFO] [stdout] 154 + .write_all(&[5u8, 0, 0, 1, 0, 0, 0, 0, 0, 0]) [INFO] [stdout] 155 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/http-sir-client/main.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 124 | if buf[..nmethods].iter().find(|m| **m == 0u8) == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `buf[..nmethods].iter().find(|m| **m == 0u8).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/bin/http-sir-server/main.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | / conn_rx [INFO] [stdout] 100 | | .buf [INFO] [stdout] 101 | | .range(conn_rx.buf.len() - (conn_rx.seq - seq)..) [INFO] [stdout] 102 | | .map(|b| *b) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 99 ~ conn_rx [INFO] [stdout] 100 + .buf [INFO] [stdout] 101 + .range(conn_rx.buf.len() - (conn_rx.seq - seq)..).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | if let Err(_) = rx_sub.changed().await { [INFO] [stdout] | -------^^^^^^------------------------- help: try: `if rx_sub.changed().await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:119:16 [INFO] [stdout] | [INFO] [stdout] 119 | if let Err(_) = sender.send_data(buf.into()).await { [INFO] [stdout] | -------^^^^^^------------------------------------- help: try: `if sender.send_data(buf.into()).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 139 | if let Err(_) = conn.rx_pub.send(seq) { [INFO] [stdout] | -------^^^^^^------------------------ help: try: `if conn.rx_pub.send(seq).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/bin/http-sir-server/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | / match req.method() { [INFO] [stdout] 157 | | &Method::GET => handle_get(cfg, ctx, addr, req).await, [INFO] [stdout] 158 | | &Method::POST => handle_post(cfg, ctx, addr, req).await, [INFO] [stdout] 159 | | _ => Ok(blank_status(StatusCode::METHOD_NOT_ALLOWED)), [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 156 ~ match *req.method() { [INFO] [stdout] 157 ~ Method::GET => handle_get(cfg, ctx, addr, req).await, [INFO] [stdout] 158 ~ Method::POST => handle_post(cfg, ctx, addr, req).await, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/bin/http-sir-server/main.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 163 | async fn handle_get<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:175:64 [INFO] [stdout] | [INFO] [stdout] 175 | let seq = match get_header_str(req.headers(), "s").map(|s| usize::from_str_radix(s, 10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/bin/http-sir-server/main.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | if fin {} [INFO] [stdout] | ^^^^^^^^^ help: you can remove it [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/bin/http-sir-server/main.rs:206:26 [INFO] [stdout] | [INFO] [stdout] 206 | async fn handle_new_conn<'a>( [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/bin/http-sir-server/main.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 308 | / let _ = tokio::spawn({ [INFO] [stdout] 309 | | let conn = conn.clone(); [INFO] [stdout] 310 | | let ctx = ctx.clone(); [INFO] [stdout] 311 | | let id = id.clone(); [INFO] [stdout] ... | [INFO] [stdout] 333 | | }); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:363:68 [INFO] [stdout] | [INFO] [stdout] 363 | let mut seq = match get_header_str(req.headers(), "s").map(|s| usize::from_str_radix(s, 10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> src/bin/http-sir-server/main.rs:374:18 [INFO] [stdout] | [INFO] [stdout] 374 | .map(|a| usize::from_str_radix(a, 10).unwrap_or(0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.52s [INFO] running `Command { std: "docker" "inspect" "5b3f263bbeecb14fe832c2e6c4967e9967768e7ccec2907e778beca33a04a61b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b3f263bbeecb14fe832c2e6c4967e9967768e7ccec2907e778beca33a04a61b", kill_on_drop: false }` [INFO] [stdout] 5b3f263bbeecb14fe832c2e6c4967e9967768e7ccec2907e778beca33a04a61b