[INFO] cloning repository https://github.com/myl2821/cless [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/myl2821/cless" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmyl2821%2Fcless", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmyl2821%2Fcless'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5c07e25af361dec6c35c7ebb777b68e71f446ffe [INFO] linting myl2821/cless against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmyl2821%2Fcless" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/myl2821/cless [INFO] finished tweaking git repo https://github.com/myl2821/cless [INFO] tweaked toml for git repo https://github.com/myl2821/cless written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/myl2821/cless on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/myl2821/cless already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pkg-config v0.3.18 [INFO] [stderr] Downloaded ncurses v5.99.0 [INFO] [stderr] Downloaded libc v0.2.74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae913a9c427d138dc1df5dfd79cbd2db63f9f2c8434508cd6d3dee5d87baa862 [INFO] running `Command { std: "docker" "start" "-a" "ae913a9c427d138dc1df5dfd79cbd2db63f9f2c8434508cd6d3dee5d87baa862", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae913a9c427d138dc1df5dfd79cbd2db63f9f2c8434508cd6d3dee5d87baa862", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae913a9c427d138dc1df5dfd79cbd2db63f9f2c8434508cd6d3dee5d87baa862", kill_on_drop: false }` [INFO] [stdout] ae913a9c427d138dc1df5dfd79cbd2db63f9f2c8434508cd6d3dee5d87baa862 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 704485c266151b8531a054408e34f1282d1cf0dad59162dfb2269587e99d4b2c [INFO] running `Command { std: "docker" "start" "-a" "704485c266151b8531a054408e34f1282d1cf0dad59162dfb2269587e99d4b2c", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling cc v1.0.58 [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Compiling ncurses v5.99.0 [INFO] [stderr] Checking cless v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ffi::OsStr` [INFO] [stdout] --> src/row.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ffi::OsStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/row.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | static WORD_LIMITS: &'static [char] = &[ [INFO] [stdout] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ffi::OsStr` [INFO] [stdout] --> src/row.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::ffi::OsStr; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/row.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | static WORD_LIMITS: &'static [char] = &[ [INFO] [stdout] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `x_offset` is never read [INFO] [stdout] --> src/main.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 36 | struct Context { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | pub x_offset: i32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Context` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/row.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / for line in buffer { [INFO] [stdout] 49 | | if let Ok(l) = line { [INFO] [stdout] 50 | | rows.push(Row { [INFO] [stdout] 51 | | raw: l, [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/row.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / if let Ok(l) = line { [INFO] [stdout] 50 | | rows.push(Row { [INFO] [stdout] 51 | | raw: l, [INFO] [stdout] 52 | | tokens: vec![], [INFO] [stdout] 53 | | }); [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 ~ for l in buffer.flatten() { [INFO] [stdout] 49 + rows.push(Row { [INFO] [stdout] 50 + raw: l, [INFO] [stdout] 51 + tokens: vec![], [INFO] [stdout] 52 + }); [INFO] [stdout] 53 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if !self.lang.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.lang.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/main.rs:126:34 [INFO] [stdout] | [INFO] [stdout] 126 | if word.as_bytes()[0] >= '0' as u8 && word.as_bytes()[0] <= '9' as u8 { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/main.rs:126:69 [INFO] [stdout] | [INFO] [stdout] 126 | if word.as_bytes()[0] >= '0' as u8 && word.as_bytes()[0] <= '9' as u8 { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'9'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | ctx.buf_length = lines.len() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Context { buf_length: lines.len() as i32, rows: lines, lang: lang, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:290:5 [INFO] [stdout] | [INFO] [stdout] 290 | let mut ctx = Context::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | / if ctx.y_offset < ctx.buf_length - 1 { [INFO] [stdout] 304 | | ctx.y_offset += 1; [INFO] [stdout] 305 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 302 ~ 0x6a | nc::KEY_DOWN [INFO] [stdout] 303 ~ if ctx.y_offset < ctx.buf_length - 1 => { [INFO] [stdout] 304 | ctx.y_offset += 1; [INFO] [stdout] 305 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | / if ctx.y_offset > 0 { [INFO] [stdout] 310 | | ctx.y_offset -= 1; [INFO] [stdout] 311 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 308 ~ 0x6b | nc::KEY_UP [INFO] [stdout] 309 ~ if ctx.y_offset > 0 => { [INFO] [stdout] 310 | ctx.y_offset -= 1; [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `x_offset` is never read [INFO] [stdout] --> src/main.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 36 | struct Context { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 42 | pub x_offset: i32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Context` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/row.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / for line in buffer { [INFO] [stdout] 49 | | if let Ok(l) = line { [INFO] [stdout] 50 | | rows.push(Row { [INFO] [stdout] 51 | | raw: l, [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/row.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / if let Ok(l) = line { [INFO] [stdout] 50 | | rows.push(Row { [INFO] [stdout] 51 | | raw: l, [INFO] [stdout] 52 | | tokens: vec![], [INFO] [stdout] 53 | | }); [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 ~ for l in buffer.flatten() { [INFO] [stdout] 49 + rows.push(Row { [INFO] [stdout] 50 + raw: l, [INFO] [stdout] 51 + tokens: vec![], [INFO] [stdout] 52 + }); [INFO] [stdout] 53 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if !self.lang.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.lang.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/main.rs:126:34 [INFO] [stdout] | [INFO] [stdout] 126 | if word.as_bytes()[0] >= '0' as u8 && word.as_bytes()[0] <= '9' as u8 { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/main.rs:126:69 [INFO] [stdout] | [INFO] [stdout] 126 | if word.as_bytes()[0] >= '0' as u8 && word.as_bytes()[0] <= '9' as u8 { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'9'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | ctx.buf_length = lines.len() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Context { buf_length: lines.len() as i32, rows: lines, lang: lang, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:290:5 [INFO] [stdout] | [INFO] [stdout] 290 | let mut ctx = Context::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | / if ctx.y_offset < ctx.buf_length - 1 { [INFO] [stdout] 304 | | ctx.y_offset += 1; [INFO] [stdout] 305 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 302 ~ 0x6a | nc::KEY_DOWN [INFO] [stdout] 303 ~ if ctx.y_offset < ctx.buf_length - 1 => { [INFO] [stdout] 304 | ctx.y_offset += 1; [INFO] [stdout] 305 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | / if ctx.y_offset > 0 { [INFO] [stdout] 310 | | ctx.y_offset -= 1; [INFO] [stdout] 311 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 308 ~ 0x6b | nc::KEY_UP [INFO] [stdout] 309 ~ if ctx.y_offset > 0 => { [INFO] [stdout] 310 | ctx.y_offset -= 1; [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.82s [INFO] running `Command { std: "docker" "inspect" "704485c266151b8531a054408e34f1282d1cf0dad59162dfb2269587e99d4b2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "704485c266151b8531a054408e34f1282d1cf0dad59162dfb2269587e99d4b2c", kill_on_drop: false }` [INFO] [stdout] 704485c266151b8531a054408e34f1282d1cf0dad59162dfb2269587e99d4b2c