[INFO] cloning repository https://github.com/mwyerman/bill-split-backend-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mwyerman/bill-split-backend-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwyerman%2Fbill-split-backend-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwyerman%2Fbill-split-backend-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 647b4190cfac2aa2ea8ad18796eac1a45d669495 [INFO] linting mwyerman/bill-split-backend-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwyerman%2Fbill-split-backend-rust" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mwyerman/bill-split-backend-rust [INFO] finished tweaking git repo https://github.com/mwyerman/bill-split-backend-rust [INFO] tweaked toml for git repo https://github.com/mwyerman/bill-split-backend-rust written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mwyerman/bill-split-backend-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mwyerman/bill-split-backend-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hyper-util v0.1.1 [INFO] [stderr] Downloaded axum-macros v0.4.1 [INFO] [stderr] Downloaded hyper v1.0.1 [INFO] [stderr] Downloaded axum v0.7.2 [INFO] [stderr] Downloaded rustix v0.38.30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6cf2dc9301f9495c696280026e48815d26c864275ad111b0239012d03f4d8035 [INFO] running `Command { std: "docker" "start" "-a" "6cf2dc9301f9495c696280026e48815d26c864275ad111b0239012d03f4d8035", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6cf2dc9301f9495c696280026e48815d26c864275ad111b0239012d03f4d8035", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cf2dc9301f9495c696280026e48815d26c864275ad111b0239012d03f4d8035", kill_on_drop: false }` [INFO] [stdout] 6cf2dc9301f9495c696280026e48815d26c864275ad111b0239012d03f4d8035 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5c242d3b8adb5e9a5b93bfdc29f1aa809b13f1b4dd07c86aebf20130a34a6c4 [INFO] running `Command { std: "docker" "start" "-a" "c5c242d3b8adb5e9a5b93bfdc29f1aa809b13f1b4dd07c86aebf20130a34a6c4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling openssl v0.10.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling axum v0.7.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling openssl-sys v0.9.99 [INFO] [stderr] Checking http-body-util v0.1.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling axum-macros v0.4.1 [INFO] [stderr] Checking tokio v1.34.0 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.15 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking h2 v0.4.2 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking hyper v1.0.1 [INFO] [stderr] Checking hyper-util v0.1.1 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.23 [INFO] [stderr] Checking billsplit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DataConfig` [INFO] [stdout] --> src/config/data_config.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | Self { [INFO] [stdout] 12 | | provider: DataProvider::Memory(Memory::new()) [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for DataConfig { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ServerConfig` [INFO] [stdout] --> src/config/server_config.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> ServerConfig { [INFO] [stdout] 9 | | ServerConfig { [INFO] [stdout] 10 | | host: "0.0.0.0".to_string(), [INFO] [stdout] 11 | | port: 3000, [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for ServerConfig { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Config` [INFO] [stdout] --> src/config/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Config { [INFO] [stdout] 13 | | Config { [INFO] [stdout] 14 | | data: data_config::DataConfig::new(), [INFO] [stdout] 15 | | app: server_config::ServerConfig::new() [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Config { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Memory` [INFO] [stdout] --> src/data/memory.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / pub fn new() -> Self { [INFO] [stdout] 18 | | Self { } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 16 + impl Default for Memory { [INFO] [stdout] 17 + fn default() -> Self { [INFO] [stdout] 18 + Self::new() [INFO] [stdout] 19 + } [INFO] [stdout] 20 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/data/memory.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / match data.get(&id) { [INFO] [stdout] 42 | | Some(bill) => Some(bill.clone()), [INFO] [stdout] 43 | | None => None [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ help: try: `data.get(&id).map(|bill| bill.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/models/bill.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 65 | for (_, item) in &self.items { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 65 - for (_, item) in &self.items { [INFO] [stdout] 65 + for item in self.items.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/models/bill.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 80 | if !self.total.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.total.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.total` after checking its variant with `is_none` [INFO] [stdout] --> src/models/bill.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 80 | if !self.total.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 84 | let total = self.total.unwrap() as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/models/bill.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 73 | for (_, item) in &self.items { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 73 - for (_, item) in &self.items { [INFO] [stdout] 73 + for item in self.items.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DataConfig` [INFO] [stdout] --> src/config/data_config.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / pub fn new() -> Self { [INFO] [stdout] 11 | | Self { [INFO] [stdout] 12 | | provider: DataProvider::Memory(Memory::new()) [INFO] [stdout] 13 | | } [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 9 + impl Default for DataConfig { [INFO] [stdout] 10 + fn default() -> Self { [INFO] [stdout] 11 + Self::new() [INFO] [stdout] 12 + } [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ServerConfig` [INFO] [stdout] --> src/config/server_config.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> ServerConfig { [INFO] [stdout] 9 | | ServerConfig { [INFO] [stdout] 10 | | host: "0.0.0.0".to_string(), [INFO] [stdout] 11 | | port: 3000, [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for ServerConfig { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Config` [INFO] [stdout] --> src/config/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Config { [INFO] [stdout] 13 | | Config { [INFO] [stdout] 14 | | data: data_config::DataConfig::new(), [INFO] [stdout] 15 | | app: server_config::ServerConfig::new() [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Config { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Memory` [INFO] [stdout] --> src/data/memory.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / pub fn new() -> Self { [INFO] [stdout] 18 | | Self { } [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 16 + impl Default for Memory { [INFO] [stdout] 17 + fn default() -> Self { [INFO] [stdout] 18 + Self::new() [INFO] [stdout] 19 + } [INFO] [stdout] 20 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/data/memory.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / match data.get(&id) { [INFO] [stdout] 42 | | Some(bill) => Some(bill.clone()), [INFO] [stdout] 43 | | None => None [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ help: try: `data.get(&id).map(|bill| bill.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LineItem` [INFO] [stdout] --> src/models/item.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | name: "".to_string(), [INFO] [stdout] 15 | | price: 0, [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for LineItem { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/data/memory.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | assert_eq!(bills.contains(&bill_with_id), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 109 - assert_eq!(bills.contains(&bill_with_id), true); [INFO] [stdout] 109 + assert!(bills.contains(&bill_with_id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/models/bill.rs:65:26 [INFO] [stdout] | [INFO] [stdout] 65 | for (_, item) in &self.items { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 65 - for (_, item) in &self.items { [INFO] [stdout] 65 + for item in self.items.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/models/bill.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 80 | if !self.total.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.total.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.total` after checking its variant with `is_none` [INFO] [stdout] --> src/models/bill.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 80 | if !self.total.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 84 | let total = self.total.unwrap() as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/models/bill.rs:73:26 [INFO] [stdout] | [INFO] [stdout] 73 | for (_, item) in &self.items { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 73 - for (_, item) in &self.items { [INFO] [stdout] 73 + for item in self.items.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LineItem` [INFO] [stdout] --> src/models/item.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | name: "".to_string(), [INFO] [stdout] 15 | | price: 0, [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for LineItem { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use billsplit; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/integration_test.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use tokio; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use billsplit; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/integration_test.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 45 | let uuid = Uuid::parse_str(&body).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/integration_test.rs:78:32 [INFO] [stdout] | [INFO] [stdout] 78 | let uuid = Uuid::parse_str(&body).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/integration_test.rs:107:32 [INFO] [stdout] | [INFO] [stdout] 107 | let uuid = Uuid::parse_str(&body).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.68s [INFO] running `Command { std: "docker" "inspect" "c5c242d3b8adb5e9a5b93bfdc29f1aa809b13f1b4dd07c86aebf20130a34a6c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5c242d3b8adb5e9a5b93bfdc29f1aa809b13f1b4dd07c86aebf20130a34a6c4", kill_on_drop: false }` [INFO] [stdout] c5c242d3b8adb5e9a5b93bfdc29f1aa809b13f1b4dd07c86aebf20130a34a6c4