[INFO] cloning repository https://github.com/mwc10/sd3norm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mwc10/sd3norm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwc10%2Fsd3norm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwc10%2Fsd3norm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0b56e682c664e46a9947cfb7257934102b6b9e41 [INFO] linting mwc10/sd3norm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmwc10%2Fsd3norm" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mwc10/sd3norm [INFO] finished tweaking git repo https://github.com/mwc10/sd3norm [INFO] tweaked toml for git repo https://github.com/mwc10/sd3norm written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mwc10/sd3norm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mwc10/sd3norm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded structopt v0.2.10 [INFO] [stderr] Downloaded bitflags v1.0.3 [INFO] [stderr] Downloaded quote v0.6.3 [INFO] [stderr] Downloaded same-file v1.0.2 [INFO] [stderr] Downloaded structopt-derive v0.2.10 [INFO] [stderr] Downloaded walkdir v2.1.4 [INFO] [stderr] Downloaded podio v0.1.6 [INFO] [stderr] Downloaded cfg-if v0.1.4 [INFO] [stderr] Downloaded build_const v0.2.1 [INFO] [stderr] Downloaded adler32 v1.0.3 [INFO] [stderr] Downloaded msdos_time v0.1.6 [INFO] [stderr] Downloaded atty v0.2.10 [INFO] [stderr] Downloaded byteorder v1.2.3 [INFO] [stderr] Downloaded aho-corasick v0.6.5 [INFO] [stderr] Downloaded miniz_oxide v0.1.3 [INFO] [stderr] Downloaded num-traits v0.2.5 [INFO] [stderr] Downloaded flate2 v1.0.1 [INFO] [stderr] Downloaded quick-xml v0.12.1 [INFO] [stderr] Downloaded serde v1.0.69 [INFO] [stderr] Downloaded calamine v0.14.1 [INFO] [stderr] Downloaded miniz_oxide_c_api v0.1.3 [INFO] [stderr] Downloaded chrono v0.4.4 [INFO] [stderr] Downloaded syn v0.14.4 [INFO] [stderr] Downloaded log v0.4.3 [INFO] [stderr] Downloaded regex v1.0.1 [INFO] [stderr] Downloaded serde_derive v1.0.69 [INFO] [stderr] Downloaded csv-core v0.1.4 [INFO] [stderr] Downloaded regex-syntax v0.6.1 [INFO] [stderr] Downloaded cc v1.0.17 [INFO] [stderr] Downloaded flexi_logger v0.8.4 [INFO] [stderr] Downloaded proc-macro2 v0.4.6 [INFO] [stderr] Downloaded libc v0.2.42 [INFO] [stderr] Downloaded zip v0.3.3 [INFO] [stderr] Downloaded rustc-demangle v0.1.8 [INFO] [stderr] Downloaded backtrace v0.3.9 [INFO] [stderr] Downloaded num-integer v0.1.39 [INFO] [stderr] Downloaded time v0.1.40 [INFO] [stderr] Downloaded glob v0.2.11 [INFO] [stderr] Downloaded ucd-util v0.1.1 [INFO] [stderr] Downloaded lazy_static v1.0.1 [INFO] [stderr] Downloaded backtrace-sys v0.1.23 [INFO] [stderr] Downloaded csv v1.0.0 [INFO] [stderr] Downloaded winapi v0.3.5 [INFO] [stderr] Downloaded encoding_rs v0.7.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 590fb5f2bfee82ff7f1148e9d951f84a539ee6e197e045fb18361f8e1874ae0d [INFO] running `Command { std: "docker" "start" "-a" "590fb5f2bfee82ff7f1148e9d951f84a539ee6e197e045fb18361f8e1874ae0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "590fb5f2bfee82ff7f1148e9d951f84a539ee6e197e045fb18361f8e1874ae0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "590fb5f2bfee82ff7f1148e9d951f84a539ee6e197e045fb18361f8e1874ae0d", kill_on_drop: false }` [INFO] [stdout] 590fb5f2bfee82ff7f1148e9d951f84a539ee6e197e045fb18361f8e1874ae0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27c2def3c307d5e14aeb8183630d2e52a22d06edba69788d0658a6e6edb913b1 [INFO] running `Command { std: "docker" "start" "-a" "27c2def3c307d5e14aeb8183630d2e52a22d06edba69788d0658a6e6edb913b1", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling cc v1.0.17 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Checking cfg-if v0.1.4 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling serde v1.0.69 [INFO] [stderr] Checking rustc-demangle v0.1.8 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Compiling regex v1.0.1 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking lazy_static v1.0.1 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Compiling proc-macro2 v0.4.6 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking regex-syntax v0.6.1 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking bitflags v1.0.3 [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking same-file v1.0.2 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking walkdir v2.1.4 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling syn v0.14.4 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking miniz_oxide v0.1.3 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking aho-corasick v0.6.5 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.3 [INFO] [stderr] Checking msdos_time v0.1.6 [INFO] [stderr] Checking chrono v0.4.4 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Checking zip v0.3.3 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Compiling serde_derive v1.0.69 [INFO] [stderr] Checking flexi_logger v0.8.4 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking calamine v0.14.1 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking sd3norm v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/sd3.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/sd3.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/sd3.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/sd3.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/mifc.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/mifc.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #[macro_use] extern crate structopt; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/main.rs:204:1 [INFO] [stdout] | [INFO] [stdout] 204 | / /// Read input path into a vec of PathBufs [INFO] [stdout] 205 | | /* [INFO] [stdout] 206 | | fn expand_dir>(entry: &P) -> Vec [INFO] [stdout] ... | [INFO] [stdout] 214 | | */ [INFO] [stdout] 215 | | [INFO] [stdout] | |_^ [INFO] [stdout] 216 | /// Check the extension of a Path to see if it is an excel workbook [INFO] [stdout] 217 | fn is_excel>(file: &P) -> bool { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `is_excel` then comment it out [INFO] [stdout] | [INFO] [stdout] 204 | // /// Read input path into a vec of PathBufs [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/sd3.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/sd3.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/sd3.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/sd3.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/mifc.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/mifc.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | #[macro_use] extern crate structopt; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/main.rs:204:1 [INFO] [stdout] | [INFO] [stdout] 204 | / /// Read input path into a vec of PathBufs [INFO] [stdout] 205 | | /* [INFO] [stdout] 206 | | fn expand_dir>(entry: &P) -> Vec [INFO] [stdout] ... | [INFO] [stdout] 214 | | */ [INFO] [stdout] 215 | | [INFO] [stdout] | |_^ [INFO] [stdout] 216 | /// Check the extension of a Path to see if it is an excel workbook [INFO] [stdout] 217 | fn is_excel>(file: &P) -> bool { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `is_excel` then comment it out [INFO] [stdout] | [INFO] [stdout] 204 | // /// Read input path into a vec of PathBufs [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let mut rows = match RangeDeserializerBuilder::new() [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/sd3.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | if f != "" { return Err(SD3Error::Excluded) } [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!f.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/sd3.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if &n != "" { n.push_str(" || "); } [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MIFC` contains a capitalized acronym [INFO] [stdout] --> src/mifc.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct MIFC { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Mifc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | let mut rows = match RangeDeserializerBuilder::new() [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / match ::std::env::var("RUST_BACKTRACE").as_ref().map(|s| s.as_str()) { [INFO] [stdout] 61 | | Ok("1") => error!("Backtrace:\n{}", e.backtrace()), [INFO] [stdout] 62 | | _ => (), [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok("1") = ::std::env::var("RUST_BACKTRACE").as_ref().map(|s| s.as_str()) { error!("Backtrace:\n{}", e.backtrace()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/sd3.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | if f != "" { return Err(SD3Error::Excluded) } [INFO] [stdout] | ^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!f.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(PathBuf::as_path)` on an `Option` value [INFO] [stdout] --> src/main.rs:70:28 [INFO] [stdout] | [INFO] [stdout] 70 | let output_directory = opts.out_dir.as_ref().map(PathBuf::as_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `opts.out_dir.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/sd3.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if &n != "" { n.push_str(" || "); } [INFO] [stdout] | ^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 83 | WalkDir::new(&entry) [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:97:54 [INFO] [stdout] | [INFO] [stdout] 97 | Ok(out) => normalize_workbook(&wb, &out, &app)?, [INFO] [stdout] | ^^^^ help: change this to: `app` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | / match &*ex.to_string_lossy() { [INFO] [stdout] 220 | | "xlsx" => true, [INFO] [stdout] 221 | | "xls" => true, [INFO] [stdout] 222 | | "xlsm" => true, [INFO] [stdout] 223 | | _ => false, [INFO] [stdout] 224 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 219 - match &*ex.to_string_lossy() { [INFO] [stdout] 220 - "xlsx" => true, [INFO] [stdout] 221 - "xls" => true, [INFO] [stdout] 222 - "xlsm" => true, [INFO] [stdout] 223 - _ => false, [INFO] [stdout] 224 - } [INFO] [stdout] 219 + matches!(&*ex.to_string_lossy(), "xlsx" | "xls" | "xlsm") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | / !file.as_ref() [INFO] [stdout] 231 | | .file_stem() [INFO] [stdout] 232 | | .filter(|s| s.to_string_lossy().starts_with("~")) [INFO] [stdout] 233 | | .is_some() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 230 ~ file.as_ref() [INFO] [stdout] 231 + .file_stem() [INFO] [stdout] 232 + .filter(|s| s.to_string_lossy().starts_with("~")).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/sd3.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `SD3` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_SD3` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/sd3.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `SD3` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_SD3` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/sd3.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Normalization` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Normalization` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/sd3.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Normalization` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Normalization` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MIFC` contains a capitalized acronym [INFO] [stdout] --> src/mifc.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct MIFC { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Mifc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/mifc.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `MIFC` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_MIFC` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/mifc.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `MIFC` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_MIFC` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/utils.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / if diff <= (largest * tol / 100.0) [INFO] [stdout] 11 | | { true } else { false } [INFO] [stdout] | |___________________________^ help: you can reduce it to: `diff <= (largest * tol / 100.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / match ::std::env::var("RUST_BACKTRACE").as_ref().map(|s| s.as_str()) { [INFO] [stdout] 61 | | Ok("1") => error!("Backtrace:\n{}", e.backtrace()), [INFO] [stdout] 62 | | _ => (), [INFO] [stdout] 63 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok("1") = ::std::env::var("RUST_BACKTRACE").as_ref().map(|s| s.as_str()) { error!("Backtrace:\n{}", e.backtrace()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(PathBuf::as_path)` on an `Option` value [INFO] [stdout] --> src/main.rs:70:28 [INFO] [stdout] | [INFO] [stdout] 70 | let output_directory = opts.out_dir.as_ref().map(PathBuf::as_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `opts.out_dir.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 83 | WalkDir::new(&entry) [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:97:54 [INFO] [stdout] | [INFO] [stdout] 97 | Ok(out) => normalize_workbook(&wb, &out, &app)?, [INFO] [stdout] | ^^^^ help: change this to: `app` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | / match &*ex.to_string_lossy() { [INFO] [stdout] 220 | | "xlsx" => true, [INFO] [stdout] 221 | | "xls" => true, [INFO] [stdout] 222 | | "xlsm" => true, [INFO] [stdout] 223 | | _ => false, [INFO] [stdout] 224 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 219 - match &*ex.to_string_lossy() { [INFO] [stdout] 220 - "xlsx" => true, [INFO] [stdout] 221 - "xls" => true, [INFO] [stdout] 222 - "xlsm" => true, [INFO] [stdout] 223 - _ => false, [INFO] [stdout] 224 - } [INFO] [stdout] 219 + matches!(&*ex.to_string_lossy(), "xlsx" | "xls" | "xlsm") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | / !file.as_ref() [INFO] [stdout] 231 | | .file_stem() [INFO] [stdout] 232 | | .filter(|s| s.to_string_lossy().starts_with("~")) [INFO] [stdout] 233 | | .is_some() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 230 ~ file.as_ref() [INFO] [stdout] 231 + .file_stem() [INFO] [stdout] 232 + .filter(|s| s.to_string_lossy().starts_with("~")).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/sd3.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `SD3` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_SD3` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/sd3.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `SD3` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_SD3` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/sd3.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Normalization` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Normalization` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/sd3.rs:58:28 [INFO] [stdout] | [INFO] [stdout] 58 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Normalization` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Normalization` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/mifc.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `MIFC` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_MIFC` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/mifc.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `MIFC` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_MIFC` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.47s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.12.1, syn v0.14.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "27c2def3c307d5e14aeb8183630d2e52a22d06edba69788d0658a6e6edb913b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27c2def3c307d5e14aeb8183630d2e52a22d06edba69788d0658a6e6edb913b1", kill_on_drop: false }` [INFO] [stdout] 27c2def3c307d5e14aeb8183630d2e52a22d06edba69788d0658a6e6edb913b1