[INFO] cloning repository https://github.com/mv-kan/leetcode_iq [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mv-kan/leetcode_iq" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmv-kan%2Fleetcode_iq", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmv-kan%2Fleetcode_iq'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9bedb2fed449cebb2af33d3163eb10c1f7fc6f51 [INFO] linting mv-kan/leetcode_iq against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmv-kan%2Fleetcode_iq" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mv-kan/leetcode_iq [INFO] finished tweaking git repo https://github.com/mv-kan/leetcode_iq [INFO] tweaked toml for git repo https://github.com/mv-kan/leetcode_iq written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mv-kan/leetcode_iq on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mv-kan/leetcode_iq already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 88127c4c1d0bd00f12aca56fd9e2ed242ca30b232ae54f01431980891b591858 [INFO] running `Command { std: "docker" "start" "-a" "88127c4c1d0bd00f12aca56fd9e2ed242ca30b232ae54f01431980891b591858", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "88127c4c1d0bd00f12aca56fd9e2ed242ca30b232ae54f01431980891b591858", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88127c4c1d0bd00f12aca56fd9e2ed242ca30b232ae54f01431980891b591858", kill_on_drop: false }` [INFO] [stdout] 88127c4c1d0bd00f12aca56fd9e2ed242ca30b232ae54f01431980891b591858 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 655122ea595f951463dced1c6ab2bbfbf74a97493a394a2d324080ed58b358bd [INFO] running `Command { std: "docker" "start" "-a" "655122ea595f951463dced1c6ab2bbfbf74a97493a394a2d324080ed58b358bd", kill_on_drop: false }` [INFO] [stderr] Checking lc_iq v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/remove_duplicates.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return nums.len() as i32 - result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return nums.len() as i32 - result; [INFO] [stdout] 19 + nums.len() as i32 - result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/remove_duplicates.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | fn solve(nums: &mut Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn solve(nums: &mut Vec) -> i32 { [INFO] [stdout] 3 + fn solve(nums: &mut [i32]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/buy_sell_stock.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return profit [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return profit [INFO] [stdout] 14 + profit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `prices` [INFO] [stdout] --> src/easy/array/buy_sell_stock.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | for i in 1..prices.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 6 - for i in 1..prices.len() { [INFO] [stdout] 6 + for in prices.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/rotate_array.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | fn solve(nums: &mut Vec, k: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 ~ fn solve(nums: &mut [i32], k: i32) { [INFO] [stdout] 4 ~ let tmp = nums.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/contains_dulplicates.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return false; [INFO] [stdout] 13 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tmp` [INFO] [stdout] --> src/easy/array/contains_dulplicates.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | for i in 1..tmp.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 7 - for i in 1..tmp.len() { [INFO] [stdout] 7 + for in tmp.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/signle_number.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return prev; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return prev; [INFO] [stdout] 18 + prev [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tmp` [INFO] [stdout] --> src/easy/array/signle_number.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | for i in 1..tmp.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 8 - for i in 1..tmp.len() { [INFO] [stdout] 8 + for in tmp.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/intersection_of_two_arrays_ii.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return inter; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return inter; [INFO] [stdout] 27 + inter [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/plus_one.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return result; [INFO] [stdout] 18 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/move_zeroes.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | fn solve(nums: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn solve(nums: &mut Vec) { [INFO] [stdout] 3 + fn solve(nums: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/two_sum.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return result [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return result [INFO] [stdout] 29 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `nums` [INFO] [stdout] --> src/easy/array/two_sum.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 9 - for i in 0..nums.len() { [INFO] [stdout] 9 + for (i, ) in nums.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `nums` [INFO] [stdout] --> src/easy/array/two_sum.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 12 - for i in 0..nums.len() { [INFO] [stdout] 12 + for (i, ) in nums.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/easy/array/two_sum.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | / if idx != i { [INFO] [stdout] 16 | | if idx > i { [INFO] [stdout] 17 | | result.push(i as i32); [INFO] [stdout] 18 | | result.push(idx as i32); [INFO] [stdout] ... | [INFO] [stdout] 23 | | return result; [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 14 ~ Some(&idx) [INFO] [stdout] 15 ~ if idx != i => { [INFO] [stdout] 16 | if idx > i { [INFO] [stdout] ... [INFO] [stdout] 23 | return result; [INFO] [stdout] 24 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/easy/array/two_sum.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / match map.get(&nums[i]) { [INFO] [stdout] 14 | | Some(&idx) => { [INFO] [stdout] 15 | | if idx != i { [INFO] [stdout] 16 | | if idx > i { [INFO] [stdout] ... | [INFO] [stdout] 26 | | _ => {}, [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 13 ~ if let Some(&idx) = map.get(&nums[i]) { [INFO] [stdout] 14 + if idx != i { [INFO] [stdout] 15 + if idx > i { [INFO] [stdout] 16 + result.push(i as i32); [INFO] [stdout] 17 + result.push(idx as i32); [INFO] [stdout] 18 + } else { [INFO] [stdout] 19 + result.push(idx as i32); [INFO] [stdout] 20 + result.push(i as i32); [INFO] [stdout] 21 + } [INFO] [stdout] 22 + return result; [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return true [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return true [INFO] [stdout] 45 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return false; [INFO] [stdout] 14 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | fn contains_dulplicates(nums: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 ~ fn contains_dulplicates(nums: &[char]) -> bool { [INFO] [stdout] 5 ~ let mut tmp = nums.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tmp` [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | for i in 1..tmp.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 8 - for i in 1..tmp.len() { [INFO] [stdout] 8 + for in tmp.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 18 | for i in 0..board.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 18 - for i in 0..board.len() { [INFO] [stdout] 18 + for in &board { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/rotate_image.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | fn rotate_outer(matrix: &mut Vec>, begin: usize, len: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - fn rotate_outer(matrix: &mut Vec>, begin: usize, len: usize) { [INFO] [stdout] 4 + fn rotate_outer(matrix: &mut [Vec], begin: usize, len: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:46:14 [INFO] [stdout] | [INFO] [stdout] 46 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 46 - for i in 0..mat.len() { [INFO] [stdout] 46 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 51 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 51 - for i in 0..mat.len() { [INFO] [stdout] 51 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 61 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 61 - for i in 0..mat.len() { [INFO] [stdout] 61 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 66 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 66 - for i in 0..mat.len() { [INFO] [stdout] 66 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 74 - for i in 0..mat.len() { [INFO] [stdout] 74 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 79 - for i in 0..mat.len() { [INFO] [stdout] 79 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/strings/reverse_string.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | fn solve(s: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn solve(s: &mut Vec) { [INFO] [stdout] 3 + fn solve(s: &mut [char]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/reverse_integer.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return tmp as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return tmp as i32; [INFO] [stdout] 16 + tmp as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i64` is unnecessary [INFO] [stdout] --> src/easy/strings/reverse_integer.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | let mut tmp = 0 as i64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/easy/strings/reverse_integer.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | num = num / 10; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `num /= 10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/first_unique_char_in_str.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return -1; [INFO] [stdout] 22 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `chars` [INFO] [stdout] --> src/easy/strings/first_unique_char_in_str.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 11 | for j in i+1..s.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 11 - for j in i+1..s.len() { [INFO] [stdout] 11 + for in chars.iter_mut().take(s.len()).skip(i+1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/valid_anagram.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return true [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return true [INFO] [stdout] 16 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/easy/strings/valid_palindrome.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | if (unfiltered[i] >= 65 as char && unfiltered[i] <= 90 as char) || [INFO] [stdout] | ____________^ [INFO] [stdout] 9 | | (unfiltered[i] >= 97 as char && unfiltered[i] <= 122 as char) || [INFO] [stdout] 10 | | (unfiltered[i] >= 48 as char && unfiltered[i] <= 57 as char) || [INFO] [stdout] 11 | | (unfiltered[i] >= 48 as char && unfiltered[i] <= 57 as char) { [INFO] [stdout] | |________________________________________________________________________^ help: try: `unfiltered[i] >= 65 as char && unfiltered[i] <= 90 as char || unfiltered[i] >= 97 as char && unfiltered[i] <= 122 as char || unfiltered[i] >= 48 as char && unfiltered[i] <= 57 as char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/valid_palindrome.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return true; [INFO] [stdout] 24 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `unfiltered` [INFO] [stdout] --> src/easy/strings/valid_palindrome.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | for i in 0..unfiltered.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 7 - for i in 0..unfiltered.len() { [INFO] [stdout] 7 + for in &unfiltered { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/string_to_int.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return r as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return r as i32; [INFO] [stdout] 71 + r as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `unfil` [INFO] [stdout] --> src/easy/strings/string_to_int.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..unfil.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 9 - for i in 0..unfil.len() { [INFO] [stdout] 9 + for in &unfil { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i64` is unnecessary [INFO] [stdout] --> src/easy/strings/string_to_int.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 54 | let ten = 10 as i64; [INFO] [stdout] | ^^^^^^^^^ help: try: `10_i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/str_str.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return -1 [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return -1 [INFO] [stdout] 18 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/longest_common_prefix.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return res.into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return res.into_iter().collect(); [INFO] [stdout] 23 + res.into_iter().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `strs` [INFO] [stdout] --> src/easy/strings/longest_common_prefix.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for i in 0..strs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 5 - for i in 0..strs.len() { [INFO] [stdout] 5 + for in &strs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `vec_of_chars` [INFO] [stdout] --> src/easy/strings/longest_common_prefix.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | for j in 1..strs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 12 - for j in 1..strs.len() { [INFO] [stdout] 12 + for in vec_of_chars.iter().take(strs.len()).skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/medium/array/three_sum.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return result; [INFO] [stdout] 90 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/remove_duplicates.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return nums.len() as i32 - result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return nums.len() as i32 - result; [INFO] [stdout] 19 + nums.len() as i32 - result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/medium/array/three_sum.rs:9:23 [INFO] [stdout] | [INFO] [stdout] 9 | let mut pair_sum: HashMap> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/remove_duplicates.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | fn solve(nums: &mut Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn solve(nums: &mut Vec) -> i32 { [INFO] [stdout] 3 + fn solve(nums: &mut [i32]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/medium/array/three_sum.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `nums` [INFO] [stdout] --> src/medium/array/three_sum.rs:45:14 [INFO] [stdout] | [INFO] [stdout] 45 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 45 - for i in 0..nums.len() { [INFO] [stdout] 45 + for (i, ) in nums.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/buy_sell_stock.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return profit [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return profit [INFO] [stdout] 14 + profit [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/medium/array/three_sum.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match pair_sum.get(&neg_num) { [INFO] [stdout] 48 | | Some(pairs) => { [INFO] [stdout] 49 | | for pair in pairs { [INFO] [stdout] 50 | | let mut triple: Vec = Vec::with_capacity(3); [INFO] [stdout] ... | [INFO] [stdout] 68 | | _ => (), [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 ~ if let Some(pairs) = pair_sum.get(&neg_num) { [INFO] [stdout] 48 + for pair in pairs { [INFO] [stdout] 49 + let mut triple: Vec = Vec::with_capacity(3); [INFO] [stdout] 50 + if pair.0.1 == i { [INFO] [stdout] 51 + continue; [INFO] [stdout] 52 + } else { [INFO] [stdout] 53 + triple.push(pair.0 .0); [INFO] [stdout] 54 + } [INFO] [stdout] 55 + if pair.1.1 == i { [INFO] [stdout] 56 + continue; [INFO] [stdout] 57 + } else { [INFO] [stdout] 58 + triple.push(pair.1 .0); [INFO] [stdout] 59 + } [INFO] [stdout] 60 + triple.push(nums[i]); [INFO] [stdout] 61 + triple.sort(); [INFO] [stdout] 62 + if unique_set.insert(triple.clone()) { [INFO] [stdout] 63 + result.push(triple); [INFO] [stdout] 64 + } [INFO] [stdout] 65 + } [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `prices` [INFO] [stdout] --> src/easy/array/buy_sell_stock.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | for i in 1..prices.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 6 - for i in 1..prices.len() { [INFO] [stdout] 6 + for in prices.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/rotate_array.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | fn solve(nums: &mut Vec, k: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 ~ fn solve(nums: &mut [i32], k: i32) { [INFO] [stdout] 4 ~ let tmp = nums.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> src/medium/array/three_sum.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | result.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 88 - result.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] 88 + result.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/contains_dulplicates.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return false; [INFO] [stdout] 13 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tmp` [INFO] [stdout] --> src/easy/array/contains_dulplicates.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | for i in 1..tmp.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 7 - for i in 1..tmp.len() { [INFO] [stdout] 7 + for in tmp.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/signle_number.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return prev; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return prev; [INFO] [stdout] 18 + prev [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tmp` [INFO] [stdout] --> src/easy/array/signle_number.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | for i in 1..tmp.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 8 - for i in 1..tmp.len() { [INFO] [stdout] 8 + for in tmp.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/intersection_of_two_arrays_ii.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return inter; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return inter; [INFO] [stdout] 27 + inter [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/plus_one.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return result; [INFO] [stdout] 18 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/move_zeroes.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | fn solve(nums: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn solve(nums: &mut Vec) { [INFO] [stdout] 3 + fn solve(nums: &mut [i32]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/two_sum.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return result [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return result [INFO] [stdout] 29 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `nums` [INFO] [stdout] --> src/easy/array/two_sum.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 9 - for i in 0..nums.len() { [INFO] [stdout] 9 + for (i, ) in nums.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `nums` [INFO] [stdout] --> src/easy/array/two_sum.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 12 - for i in 0..nums.len() { [INFO] [stdout] 12 + for (i, ) in nums.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/easy/array/two_sum.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | / if idx != i { [INFO] [stdout] 16 | | if idx > i { [INFO] [stdout] 17 | | result.push(i as i32); [INFO] [stdout] 18 | | result.push(idx as i32); [INFO] [stdout] ... | [INFO] [stdout] 23 | | return result; [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 14 ~ Some(&idx) [INFO] [stdout] 15 ~ if idx != i => { [INFO] [stdout] 16 | if idx > i { [INFO] [stdout] ... [INFO] [stdout] 23 | return result; [INFO] [stdout] 24 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/easy/array/two_sum.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / match map.get(&nums[i]) { [INFO] [stdout] 14 | | Some(&idx) => { [INFO] [stdout] 15 | | if idx != i { [INFO] [stdout] 16 | | if idx > i { [INFO] [stdout] ... | [INFO] [stdout] 26 | | _ => {}, [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 13 ~ if let Some(&idx) = map.get(&nums[i]) { [INFO] [stdout] 14 + if idx != i { [INFO] [stdout] 15 + if idx > i { [INFO] [stdout] 16 + result.push(i as i32); [INFO] [stdout] 17 + result.push(idx as i32); [INFO] [stdout] 18 + } else { [INFO] [stdout] 19 + result.push(idx as i32); [INFO] [stdout] 20 + result.push(i as i32); [INFO] [stdout] 21 + } [INFO] [stdout] 22 + return result; [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | return true [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return true [INFO] [stdout] 45 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return false; [INFO] [stdout] 14 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:4:35 [INFO] [stdout] | [INFO] [stdout] 4 | fn contains_dulplicates(nums: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 ~ fn contains_dulplicates(nums: &[char]) -> bool { [INFO] [stdout] 5 ~ let mut tmp = nums.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `tmp` [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | for i in 1..tmp.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 8 - for i in 1..tmp.len() { [INFO] [stdout] 8 + for in tmp.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `board` [INFO] [stdout] --> src/easy/array/valid_sudoku.rs:18:14 [INFO] [stdout] | [INFO] [stdout] 18 | for i in 0..board.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 18 - for i in 0..board.len() { [INFO] [stdout] 18 + for in &board { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/array/rotate_image.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | fn rotate_outer(matrix: &mut Vec>, begin: usize, len: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - fn rotate_outer(matrix: &mut Vec>, begin: usize, len: usize) { [INFO] [stdout] 4 + fn rotate_outer(matrix: &mut [Vec], begin: usize, len: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:46:14 [INFO] [stdout] | [INFO] [stdout] 46 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 46 - for i in 0..mat.len() { [INFO] [stdout] 46 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 51 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 51 - for i in 0..mat.len() { [INFO] [stdout] 51 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:61:14 [INFO] [stdout] | [INFO] [stdout] 61 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 61 - for i in 0..mat.len() { [INFO] [stdout] 61 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:66:14 [INFO] [stdout] | [INFO] [stdout] 66 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 66 - for i in 0..mat.len() { [INFO] [stdout] 66 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:74:14 [INFO] [stdout] | [INFO] [stdout] 74 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 74 - for i in 0..mat.len() { [INFO] [stdout] 74 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `mat` [INFO] [stdout] --> src/easy/array/rotate_image.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | for i in 0..mat.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 79 - for i in 0..mat.len() { [INFO] [stdout] 79 + for in &mat { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/easy/strings/reverse_string.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | fn solve(s: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn solve(s: &mut Vec) { [INFO] [stdout] 3 + fn solve(s: &mut [char]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/reverse_integer.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return tmp as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return tmp as i32; [INFO] [stdout] 16 + tmp as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i64` is unnecessary [INFO] [stdout] --> src/easy/strings/reverse_integer.rs:5:19 [INFO] [stdout] | [INFO] [stdout] 5 | let mut tmp = 0 as i64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/easy/strings/reverse_integer.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | num = num / 10; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `num /= 10` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/first_unique_char_in_str.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return -1; [INFO] [stdout] 22 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `chars` [INFO] [stdout] --> src/easy/strings/first_unique_char_in_str.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 11 | for j in i+1..s.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 11 - for j in i+1..s.len() { [INFO] [stdout] 11 + for in chars.iter_mut().take(s.len()).skip(i+1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/valid_anagram.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return true [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return true [INFO] [stdout] 16 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/easy/strings/valid_palindrome.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | if (unfiltered[i] >= 65 as char && unfiltered[i] <= 90 as char) || [INFO] [stdout] | ____________^ [INFO] [stdout] 9 | | (unfiltered[i] >= 97 as char && unfiltered[i] <= 122 as char) || [INFO] [stdout] 10 | | (unfiltered[i] >= 48 as char && unfiltered[i] <= 57 as char) || [INFO] [stdout] 11 | | (unfiltered[i] >= 48 as char && unfiltered[i] <= 57 as char) { [INFO] [stdout] | |________________________________________________________________________^ help: try: `unfiltered[i] >= 65 as char && unfiltered[i] <= 90 as char || unfiltered[i] >= 97 as char && unfiltered[i] <= 122 as char || unfiltered[i] >= 48 as char && unfiltered[i] <= 57 as char` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/valid_palindrome.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return true; [INFO] [stdout] 24 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `unfiltered` [INFO] [stdout] --> src/easy/strings/valid_palindrome.rs:7:14 [INFO] [stdout] | [INFO] [stdout] 7 | for i in 0..unfiltered.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 7 - for i in 0..unfiltered.len() { [INFO] [stdout] 7 + for in &unfiltered { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/string_to_int.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return r as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return r as i32; [INFO] [stdout] 71 + r as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `unfil` [INFO] [stdout] --> src/easy/strings/string_to_int.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | for i in 0..unfil.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 9 - for i in 0..unfil.len() { [INFO] [stdout] 9 + for in &unfil { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i64` is unnecessary [INFO] [stdout] --> src/easy/strings/string_to_int.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 54 | let ten = 10 as i64; [INFO] [stdout] | ^^^^^^^^^ help: try: `10_i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/str_str.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return -1 [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return -1 [INFO] [stdout] 18 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/easy/strings/longest_common_prefix.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return res.into_iter().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return res.into_iter().collect(); [INFO] [stdout] 23 + res.into_iter().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `strs` [INFO] [stdout] --> src/easy/strings/longest_common_prefix.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for i in 0..strs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 5 - for i in 0..strs.len() { [INFO] [stdout] 5 + for in &strs { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `vec_of_chars` [INFO] [stdout] --> src/easy/strings/longest_common_prefix.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | for j in 1..strs.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 12 - for j in 1..strs.len() { [INFO] [stdout] 12 + for in vec_of_chars.iter().take(strs.len()).skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/medium/array/three_sum.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return result; [INFO] [stdout] 90 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/medium/array/three_sum.rs:9:23 [INFO] [stdout] | [INFO] [stdout] 9 | let mut pair_sum: HashMap> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/medium/array/three_sum.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `nums` [INFO] [stdout] --> src/medium/array/three_sum.rs:45:14 [INFO] [stdout] | [INFO] [stdout] 45 | for i in 0..nums.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 45 - for i in 0..nums.len() { [INFO] [stdout] 45 + for (i, ) in nums.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/medium/array/three_sum.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / match pair_sum.get(&neg_num) { [INFO] [stdout] 48 | | Some(pairs) => { [INFO] [stdout] 49 | | for pair in pairs { [INFO] [stdout] 50 | | let mut triple: Vec = Vec::with_capacity(3); [INFO] [stdout] ... | [INFO] [stdout] 68 | | _ => (), [INFO] [stdout] 69 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 ~ if let Some(pairs) = pair_sum.get(&neg_num) { [INFO] [stdout] 48 + for pair in pairs { [INFO] [stdout] 49 + let mut triple: Vec = Vec::with_capacity(3); [INFO] [stdout] 50 + if pair.0.1 == i { [INFO] [stdout] 51 + continue; [INFO] [stdout] 52 + } else { [INFO] [stdout] 53 + triple.push(pair.0 .0); [INFO] [stdout] 54 + } [INFO] [stdout] 55 + if pair.1.1 == i { [INFO] [stdout] 56 + continue; [INFO] [stdout] 57 + } else { [INFO] [stdout] 58 + triple.push(pair.1 .0); [INFO] [stdout] 59 + } [INFO] [stdout] 60 + triple.push(nums[i]); [INFO] [stdout] 61 + triple.sort(); [INFO] [stdout] 62 + if unique_set.insert(triple.clone()) { [INFO] [stdout] 63 + result.push(triple); [INFO] [stdout] 64 + } [INFO] [stdout] 65 + } [INFO] [stdout] 66 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> src/medium/array/three_sum.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | result.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 88 - result.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] 88 + result.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.39s [INFO] running `Command { std: "docker" "inspect" "655122ea595f951463dced1c6ab2bbfbf74a97493a394a2d324080ed58b358bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "655122ea595f951463dced1c6ab2bbfbf74a97493a394a2d324080ed58b358bd", kill_on_drop: false }` [INFO] [stdout] 655122ea595f951463dced1c6ab2bbfbf74a97493a394a2d324080ed58b358bd