[INFO] cloning repository https://github.com/mustafaskyer/rust-ds-practice [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mustafaskyer/rust-ds-practice" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmustafaskyer%2Frust-ds-practice", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmustafaskyer%2Frust-ds-practice'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6887b8f4711602170d4b23fa5ebf97c69e33b282 [INFO] linting mustafaskyer/rust-ds-practice against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmustafaskyer%2Frust-ds-practice" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mustafaskyer/rust-ds-practice [INFO] finished tweaking git repo https://github.com/mustafaskyer/rust-ds-practice [INFO] tweaked toml for git repo https://github.com/mustafaskyer/rust-ds-practice written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mustafaskyer/rust-ds-practice on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mustafaskyer/rust-ds-practice already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f74914b131a0dadc7ff983e42410613b2ed118f2c9c2503806b62d95995761a2 [INFO] running `Command { std: "docker" "start" "-a" "f74914b131a0dadc7ff983e42410613b2ed118f2c9c2503806b62d95995761a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f74914b131a0dadc7ff983e42410613b2ed118f2c9c2503806b62d95995761a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f74914b131a0dadc7ff983e42410613b2ed118f2c9c2503806b62d95995761a2", kill_on_drop: false }` [INFO] [stdout] f74914b131a0dadc7ff983e42410613b2ed118f2c9c2503806b62d95995761a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 92e6141455e82036165729732c1b0fe8c5ca29ad658e11227ad1c4747224fd49 [INFO] running `Command { std: "docker" "start" "-a" "92e6141455e82036165729732c1b0fe8c5ca29ad658e11227ad1c4747224fd49", kill_on_drop: false }` [INFO] [stderr] Checking ds v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `Double_LinkList` should have an upper camel case name [INFO] [stdout] --> src/double_link_list/mod.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Double_LinkList { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DoubleLinkList` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Double_LinkList_Node` should have an upper camel case name [INFO] [stdout] --> src/double_link_list/mod.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Double_LinkList_Node { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DoubleLinkListNode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/double_link_list/mod.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if (self.head.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - if (self.head.is_none()) { [INFO] [stdout] 42 + if self.head.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/link_list/mod.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | element: element, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `element` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Double_LinkList_Node` [INFO] [stdout] --> src/main.rs:3:41 [INFO] [stdout] | [INFO] [stdout] 3 | use double_link_list::{Double_LinkList, Double_LinkList_Node}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Double_LinkList` should have an upper camel case name [INFO] [stdout] --> src/double_link_list/mod.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Double_LinkList { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DoubleLinkList` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Double_LinkList_Node` should have an upper camel case name [INFO] [stdout] --> src/double_link_list/mod.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Double_LinkList_Node { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `DoubleLinkListNode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/double_link_list/mod.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if (self.head.is_none()) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 42 - if (self.head.is_none()) { [INFO] [stdout] 42 + if self.head.is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/link_list/mod.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | element: element, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `element` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Double_LinkList_Node` [INFO] [stdout] --> src/main.rs:3:41 [INFO] [stdout] | [INFO] [stdout] 3 | use double_link_list::{Double_LinkList, Double_LinkList_Node}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/double_link_list/mod.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | while !traversal.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `traversal.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/link_list/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / match &self.head { [INFO] [stdout] 46 | | Some(prev) => Some(prev.element), [INFO] [stdout] 47 | | None => None, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_________^ help: try: `self.head.as_ref().map(|prev| prev.element)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/double_link_list/mod.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | while !traversal.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `traversal.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/link_list/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / match &self.head { [INFO] [stdout] 46 | | Some(prev) => Some(prev.element), [INFO] [stdout] 47 | | None => None, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_________^ help: try: `self.head.as_ref().map(|prev| prev.element)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s [INFO] running `Command { std: "docker" "inspect" "92e6141455e82036165729732c1b0fe8c5ca29ad658e11227ad1c4747224fd49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "92e6141455e82036165729732c1b0fe8c5ca29ad658e11227ad1c4747224fd49", kill_on_drop: false }` [INFO] [stdout] 92e6141455e82036165729732c1b0fe8c5ca29ad658e11227ad1c4747224fd49