[INFO] cloning repository https://github.com/mtuckerb/release_ready [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mtuckerb/release_ready" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmtuckerb%2Frelease_ready", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmtuckerb%2Frelease_ready'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3ad21da2ca11565b464d8526f9cf8190b2de9214 [INFO] linting mtuckerb/release_ready against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmtuckerb%2Frelease_ready" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mtuckerb/release_ready [INFO] finished tweaking git repo https://github.com/mtuckerb/release_ready [INFO] tweaked toml for git repo https://github.com/mtuckerb/release_ready written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mtuckerb/release_ready on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mtuckerb/release_ready already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustls-pemfile v1.0.3 [INFO] [stderr] Downloaded hyper-rustls v0.24.1 [INFO] [stderr] Downloaded colorize v0.1.0 [INFO] [stderr] Downloaded confy v0.5.1 [INFO] [stderr] Downloaded anstyle-parse v0.2.1 [INFO] [stderr] Downloaded clap_derive v4.3.12 [INFO] [stderr] Downloaded clap v4.3.12 [INFO] [stderr] Downloaded serde_json v1.0.102 [INFO] [stderr] Downloaded rustls-webpki v0.101.1 [INFO] [stderr] Downloaded clap_builder v4.3.12 [INFO] [stderr] Downloaded git2 v0.17.2 [INFO] [stderr] Downloaded webpki-roots v0.22.6 [INFO] [stderr] Downloaded rustls v0.21.5 [INFO] [stderr] Downloaded rustix v0.38.4 [INFO] [stderr] Downloaded linux-raw-sys v0.4.3 [INFO] [stderr] Downloaded libgit2-sys v0.15.2+1.6.4 [INFO] [stderr] Downloaded libz-sys v1.1.9 [INFO] [stderr] Downloaded openssl-src v111.26.0+1.1.1u [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b4d8e2170ceb637ef63bc182f74a289127532dc798ed6e22c489ef5155a57e0 [INFO] running `Command { std: "docker" "start" "-a" "6b4d8e2170ceb637ef63bc182f74a289127532dc798ed6e22c489ef5155a57e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b4d8e2170ceb637ef63bc182f74a289127532dc798ed6e22c489ef5155a57e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b4d8e2170ceb637ef63bc182f74a289127532dc798ed6e22c489ef5155a57e0", kill_on_drop: false }` [INFO] [stdout] 6b4d8e2170ceb637ef63bc182f74a289127532dc798ed6e22c489ef5155a57e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cae58f0c084a27a043af0d6026073a7d40cc010b4913f3bb1f7b890f070c5d7d [INFO] running `Command { std: "docker" "start" "-a" "cae58f0c084a27a043af0d6026073a7d40cc010b4913f3bb1f7b890f070c5d7d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking itoa v1.0.8 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Checking lock_api v0.4.10 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling serde v1.0.171 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling openssl v0.10.55 [INFO] [stderr] Compiling rustls v0.21.5 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking ryu v1.0.14 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Compiling serde_json v1.0.102 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling thiserror v1.0.43 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking combine v4.6.6 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Checking time v0.3.23 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking colorize v0.1.0 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking clap_builder v4.3.12 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking regex-automata v0.3.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling openssl-src v111.26.0+1.1.1u [INFO] [stderr] Compiling openssl-sys v0.9.90 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling libz-sys v1.1.9 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.15.2+1.6.4 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling serde_derive v1.0.171 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.43 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking clap v4.3.12 [INFO] [stderr] Checking rustls-webpki v0.101.1 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking webpki-roots v0.22.6 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking confy v0.5.1 [INFO] [stderr] Checking hyper-rustls v0.24.1 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking git2 v0.17.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking redis v0.22.3 [INFO] [stderr] Checking release_ready v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/get_config/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod get_config { [INFO] [stdout] 2 | | use confy; [INFO] [stdout] 3 | | use futures_util::StreamExt; [INFO] [stdout] 4 | | use serde_derive::{Deserialize, Serialize}; [INFO] [stdout] ... | [INFO] [stdout] 83 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/get_config/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod get_config { [INFO] [stdout] 2 | | use confy; [INFO] [stdout] 3 | | use futures_util::StreamExt; [INFO] [stdout] 4 | | use serde_derive::{Deserialize, Serialize}; [INFO] [stdout] ... | [INFO] [stdout] 83 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/get_config/mod.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if !(config.jira_email == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(config.jira_email != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/get_config/mod.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 26 | || !(config.jira_password == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(config.jira_password != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/get_config/mod.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | || !(config.board_id == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(config.board_id != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/get_config/mod.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | || !(config.subdomain == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(config.subdomain != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 25 | if !(config.jira_email == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.jira_email.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | || !(config.jira_password == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.jira_password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | || !(config.board_id == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.board_id.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | || !(config.subdomain == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.subdomain.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_config/mod.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return config; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return config; [INFO] [stdout] 81 + config [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | if config.jira_email == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.jira_email.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/get_config/mod.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if !(config.jira_email == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(config.jira_email != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/get_config/mod.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 26 | || !(config.jira_password == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(config.jira_password != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/get_config/mod.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | || !(config.board_id == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(config.board_id != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/get_config/mod.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | || !(config.subdomain == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(config.subdomain != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | if config.jira_password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.jira_password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 25 | if !(config.jira_email == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.jira_email.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if config.board_id == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.board_id.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | || !(config.jira_password == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.jira_password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | || !(config.board_id == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.board_id.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if config.subdomain == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.subdomain.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 28 | || !(config.subdomain == "") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.subdomain.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/get_config/mod.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return config; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return config; [INFO] [stdout] 81 + config [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | if config.jira_email == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.jira_email.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | if config.jira_password == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.jira_password.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if config.board_id == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.board_id.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/get_config/mod.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if config.subdomain == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `config.subdomain.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_jira/mod.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / return match issue { [INFO] [stdout] 69 | | Ok(val) => Ok(val), [INFO] [stdout] 70 | | Err(val) => Err(val), [INFO] [stdout] 71 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 ~ match issue { [INFO] [stdout] 69 + Ok(val) => Ok(val), [INFO] [stdout] 70 + Err(val) => Err(val), [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mtuckerb_jira/mod.rs:49:53 [INFO] [stdout] | [INFO] [stdout] 49 | let fixed_message_id = upcase_and_replace_space(&message_id); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `message_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mtuckerb_jira/mod.rs:62:112 [INFO] [stdout] | [INFO] [stdout] 62 | Err(err) => Err(format!("Could not find issue: {} in {}: {}", message_id, config.subdomain, err.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - Err(e) => return Err(e.to_string()), [INFO] [stdout] 21 + Err(e) => Err(e.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:17:80 [INFO] [stdout] | [INFO] [stdout] 17 | Err(e) => return Err(format!("Couldn't connect to redis: {}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_jira/mod.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / return match issue { [INFO] [stdout] 69 | | Ok(val) => Ok(val), [INFO] [stdout] 70 | | Err(val) => Err(val), [INFO] [stdout] 71 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 ~ match issue { [INFO] [stdout] 69 + Ok(val) => Ok(val), [INFO] [stdout] 70 + Err(val) => Err(val), [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mtuckerb_jira/mod.rs:49:53 [INFO] [stdout] | [INFO] [stdout] 49 | let fixed_message_id = upcase_and_replace_space(&message_id); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `message_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 ~ Ok(_) => Ok(()), [INFO] [stdout] 32 | Err(e) => return Err(e.to_string()), [INFO] [stdout] 33 | }, [INFO] [stdout] 34 | Err(e) => return Err(format!("Failed to set value in Redis {}", e)), [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Err(e) => Err(e.to_string()), [INFO] [stdout] 33 | }, [INFO] [stdout] 34 | Err(e) => return Err(format!("Failed to set value in Redis {}", e)), [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mtuckerb_jira/mod.rs:62:112 [INFO] [stdout] | [INFO] [stdout] 62 | Err(err) => Err(format!("Could not find issue: {} in {}: {}", message_id, config.subdomain, err.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | Err(e) => return Err(format!("Failed to set value in Redis {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 ~ Err(e) => Err(format!("Failed to set value in Redis {}", e)), [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 37 | Err(e) => return Err(format!("{}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - Err(e) => return Err(format!("{}", e.to_string())), [INFO] [stdout] 37 + Err(e) => Err(format!("{}", e.to_string())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:37:30 [INFO] [stdout] | [INFO] [stdout] 37 | Err(e) => return Err(format!("{}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:37:45 [INFO] [stdout] | [INFO] [stdout] 37 | Err(e) => return Err(format!("{}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - Err(e) => return Err(e.to_string()), [INFO] [stdout] 21 + Err(e) => Err(e.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:17:80 [INFO] [stdout] | [INFO] [stdout] 17 | Err(e) => return Err(format!("Couldn't connect to redis: {}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:31:30 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 ~ Ok(_) => Ok(()), [INFO] [stdout] 32 | Err(e) => return Err(e.to_string()), [INFO] [stdout] 33 | }, [INFO] [stdout] 34 | Err(e) => return Err(format!("Failed to set value in Redis {}", e)), [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:32:31 [INFO] [stdout] | [INFO] [stdout] 32 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Err(e) => Err(e.to_string()), [INFO] [stdout] 33 | }, [INFO] [stdout] 34 | Err(e) => return Err(format!("Failed to set value in Redis {}", e)), [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | Err(e) => return Err(format!("Failed to set value in Redis {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 ~ Err(e) => Err(format!("Failed to set value in Redis {}", e)), [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 37 | Err(e) => return Err(format!("{}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - Err(e) => return Err(format!("{}", e.to_string())), [INFO] [stdout] 37 + Err(e) => Err(format!("{}", e.to_string())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:37:30 [INFO] [stdout] | [INFO] [stdout] 37 | Err(e) => return Err(format!("{}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:37:45 [INFO] [stdout] | [INFO] [stdout] 37 | Err(e) => return Err(format!("{}", e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | Ok(_) => return Ok(()), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 ~ Ok(_) => Ok(()), [INFO] [stdout] 49 | Err(e) => return Err(e.to_string()), [INFO] [stdout] 50 | }, [INFO] [stdout] 51 | Err(e) => return Err(format!("Failed to delete value in Redis {}", e)), [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:49:31 [INFO] [stdout] | [INFO] [stdout] 49 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ Err(e) => Err(e.to_string()), [INFO] [stdout] 50 | }, [INFO] [stdout] 51 | Err(e) => return Err(format!("Failed to delete value in Redis {}", e)), [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:51:27 [INFO] [stdout] | [INFO] [stdout] 51 | Err(e) => return Err(format!("Failed to delete value in Redis {}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 ~ Err(e) => Err(format!("Failed to delete value in Redis {}", e)), [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - Err(e) => return Err(e.to_string()), [INFO] [stdout] 54 + Err(e) => Err(e.to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/mtuckerb_redis/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | / match set_redis("POR-666") { [INFO] [stdout] 65 | | Ok(_) => (), [INFO] [stdout] 66 | | Err(_) => (), [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________^ help: try: `if let Ok(_) = set_redis("POR-666") { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | let re = Regex::new(r"^(\w+\/)?(?P\w+[-\s]\d+) ").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | for x in log.unwrap().iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | Err(error) => { format!("{}", error).red().bold(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `error.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | .arg(format!("git log --since 2023-06-15 --no-merges --pretty=format:'%s %h' main release ")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"git log --since 2023-06-15 --no-merges --pretty=format:'%s %h' main release ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | let re = Regex::new(r"^(\w+\/)?(?P\w+[-\s]\d+) ").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | for x in log.unwrap().iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | Err(error) => { format!("{}", error).red().bold(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `error.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:79:14 [INFO] [stdout] | [INFO] [stdout] 79 | .arg(format!("git log --since 2023-06-15 --no-merges --pretty=format:'%s %h' main release ")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"git log --since 2023-06-15 --no-merges --pretty=format:'%s %h' main release ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 47s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: redis v0.22.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "cae58f0c084a27a043af0d6026073a7d40cc010b4913f3bb1f7b890f070c5d7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cae58f0c084a27a043af0d6026073a7d40cc010b4913f3bb1f7b890f070c5d7d", kill_on_drop: false }` [INFO] [stdout] cae58f0c084a27a043af0d6026073a7d40cc010b4913f3bb1f7b890f070c5d7d