[INFO] cloning repository https://github.com/msteen/nix-update-fetch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/msteen/nix-update-fetch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmsteen%2Fnix-update-fetch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmsteen%2Fnix-update-fetch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bc201ec28be669f67501058e97b93e6a6e7b4e07 [INFO] linting msteen/nix-update-fetch against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmsteen%2Fnix-update-fetch" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/msteen/nix-update-fetch [INFO] finished tweaking git repo https://github.com/msteen/nix-update-fetch [INFO] tweaked toml for git repo https://github.com/msteen/nix-update-fetch written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/msteen/nix-update-fetch on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/msteen/nix-update-fetch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded smallvec v0.6.8 [INFO] [stderr] Downloaded text_unit v0.1.6 [INFO] [stderr] Downloaded smol_str v0.1.9 [INFO] [stderr] Downloaded console v0.7.5 [INFO] [stderr] Downloaded colosseum v0.2.2 [INFO] [stderr] Downloaded lazy_static v1.2.0 [INFO] [stderr] Downloaded dialoguer v0.3.0 [INFO] [stderr] Downloaded clicolors-control v1.0.0 [INFO] [stderr] Downloaded rowan v0.3.3 [INFO] [stderr] Downloaded tempfile v2.2.0 [INFO] [stderr] Downloaded encode_unicode v0.3.5 [INFO] [stderr] Downloaded backtrace v0.3.13 [INFO] [stderr] Downloaded cc v1.0.28 [INFO] [stderr] Downloaded itertools v0.8.0 [INFO] [stderr] Downloaded serde v1.0.85 [INFO] [stderr] Downloaded proc-macro2 v0.4.26 [INFO] [stderr] Downloaded serde_derive v1.0.85 [INFO] [stderr] Downloaded syn v0.15.26 [INFO] [stderr] Downloaded rnix v0.5.1 [INFO] [stderr] Downloaded serde_json v1.0.37 [INFO] [stderr] Downloaded aho-corasick v0.6.9 [INFO] [stderr] Downloaded memchr v2.1.3 [INFO] [stderr] Downloaded regex v1.1.0 [INFO] [stderr] Downloaded rand_jitter v0.1.1 [INFO] [stderr] Downloaded rand_os v0.1.2 [INFO] [stderr] Downloaded rand_pcg v0.1.1 [INFO] [stderr] Downloaded cfg-if v0.1.6 [INFO] [stderr] Downloaded libc v0.2.48 [INFO] [stderr] Downloaded fuchsia-cprng v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 315eff71c37d93159dc74b6318b34263fec967c037575b65c6fac446dc953fff [INFO] running `Command { std: "docker" "start" "-a" "315eff71c37d93159dc74b6318b34263fec967c037575b65c6fac446dc953fff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "315eff71c37d93159dc74b6318b34263fec967c037575b65c6fac446dc953fff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "315eff71c37d93159dc74b6318b34263fec967c037575b65c6fac446dc953fff", kill_on_drop: false }` [INFO] [stdout] 315eff71c37d93159dc74b6318b34263fec967c037575b65c6fac446dc953fff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 22934b120587af3a33dc31957c535b82e8136ebdd8565f1408311a03dd53fff3 [INFO] running `Command { std: "docker" "start" "-a" "22934b120587af3a33dc31957c535b82e8136ebdd8565f1408311a03dd53fff3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.1 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_chacha v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Checking rand_os v0.1.2 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking clicolors-control v1.0.0 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking smol_str v0.1.9 [INFO] [stderr] Checking colosseum v0.2.2 [INFO] [stderr] Checking text_unit v0.1.6 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking rowan v0.3.3 [INFO] [stderr] Checking console v0.7.5 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking dialoguer v0.3.0 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking rnix v0.5.1 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking nix-update-fetch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_token` is never used [INFO] [stdout] --> src/main.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 88 | trait NodeExt { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 89 | fn is_token(&self) -> bool; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | if let NodeType::Token(_) = self.kind() { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 98 - if let NodeType::Token(_) = self.kind() { true } else { false } [INFO] [stdout] 98 + matches!(self.kind(), NodeType::Token(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:205:55 [INFO] [stdout] | [INFO] [stdout] 205 | if let Some(set_entry) = to_set_entry(&node)? { [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:210:73 [INFO] [stdout] | [INFO] [stdout] 210 | if let Some(set_entry) = lookup_set_entry(name, &node) { [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 288 | if !node.parent().and_then(Set::cast).filter(|set| !set.recursive()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `node.parent().and_then(Set::cast).filter(|set| !set.recursive()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_FetcherArg` [INFO] [stdout] 42 | struct FetcherArg { [INFO] [stdout] | ---------- `FetcherArg` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Pos` [INFO] [stdout] 48 | struct Pos { [INFO] [stdout] | --- `Pos` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_token` is never used [INFO] [stdout] --> src/main.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 88 | trait NodeExt { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 89 | fn is_token(&self) -> bool; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | if let NodeType::Token(_) = self.kind() { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 98 - if let NodeType::Token(_) = self.kind() { true } else { false } [INFO] [stdout] 98 + matches!(self.kind(), NodeType::Token(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:205:55 [INFO] [stdout] | [INFO] [stdout] 205 | if let Some(set_entry) = to_set_entry(&node)? { [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:210:73 [INFO] [stdout] | [INFO] [stdout] 210 | if let Some(set_entry) = lookup_set_entry(name, &node) { [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:288:8 [INFO] [stdout] | [INFO] [stdout] 288 | if !node.parent().and_then(Set::cast).filter(|set| !set.recursive()).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `node.parent().and_then(Set::cast).filter(|set| !set.recursive()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_FetcherArg` [INFO] [stdout] 42 | struct FetcherArg { [INFO] [stdout] | ---------- `FetcherArg` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Pos` [INFO] [stdout] 48 | struct Pos { [INFO] [stdout] | --- `Pos` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.59s [INFO] running `Command { std: "docker" "inspect" "22934b120587af3a33dc31957c535b82e8136ebdd8565f1408311a03dd53fff3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22934b120587af3a33dc31957c535b82e8136ebdd8565f1408311a03dd53fff3", kill_on_drop: false }` [INFO] [stdout] 22934b120587af3a33dc31957c535b82e8136ebdd8565f1408311a03dd53fff3