[INFO] cloning repository https://github.com/mschiaff/cl-forge [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mschiaff/cl-forge" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmschiaff%2Fcl-forge", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmschiaff%2Fcl-forge'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 22ec9b1c39beac18d2994d51134576f1b4578176 [INFO] linting mschiaff/cl-forge against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmschiaff%2Fcl-forge" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mschiaff/cl-forge [INFO] finished tweaking git repo https://github.com/mschiaff/cl-forge [INFO] tweaked toml for git repo https://github.com/mschiaff/cl-forge written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mschiaff/cl-forge on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mschiaff/cl-forge already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pyo3-macros v0.27.2 [INFO] [stderr] Downloaded pyo3-ffi v0.27.2 [INFO] [stderr] Downloaded target-lexicon v0.13.4 [INFO] [stderr] Downloaded pyo3-build-config v0.27.2 [INFO] [stderr] Downloaded pyo3-macros-backend v0.27.2 [INFO] [stderr] Downloaded reqwest v0.13.1 [INFO] [stderr] Downloaded webpki-root-certs v1.0.5 [INFO] [stderr] Downloaded aws-lc-rs v1.15.3 [INFO] [stderr] Downloaded pyo3 v0.27.2 [INFO] [stderr] Downloaded aws-lc-sys v0.36.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f751040d339853ccd0729b313885cc7f67610d48bc734f456d4c1515b596bf89 [INFO] running `Command { std: "docker" "start" "-a" "f751040d339853ccd0729b313885cc7f67610d48bc734f456d4c1515b596bf89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f751040d339853ccd0729b313885cc7f67610d48bc734f456d4c1515b596bf89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f751040d339853ccd0729b313885cc7f67610d48bc734f456d4c1515b596bf89", kill_on_drop: false }` [INFO] [stdout] f751040d339853ccd0729b313885cc7f67610d48bc734f456d4c1515b596bf89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 496517ac98655d2d44e3cef10423a18ac524e8a997449f4fbcdc4511e4353e24 [INFO] running `Command { std: "docker" "start" "-a" "496517ac98655d2d44e3cef10423a18ac524e8a997449f4fbcdc4511e4353e24", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.13.4 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling aws-lc-rs v1.15.3 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling pyo3-build-config v0.27.2 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking unindent v0.2.4 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Compiling cc v1.2.52 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling pyo3-ffi v0.27.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.27.2 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Compiling pyo3 v0.27.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Compiling aws-lc-sys v0.36.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Compiling pyo3-macros v0.27.2 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking verify v1.0.1 (/opt/rustwide/workdir/rust/verify) [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> rust/verify/src/constants.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | pub const DIGRAPH_MAP: [(&str, &str); 582] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 25 | | ("AA", "001"), [INFO] [stdout] 26 | | ("EA" ,"004"), [INFO] [stdout] 27 | | ("HA", "007"), [INFO] [stdout] ... | [INFO] [stdout] 606 | | ("DW", "582") [INFO] [stdout] 607 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] = note: `#[warn(clippy::large_const_arrays)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | /// one of the supported formats. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | /// expected to be a single-character string. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | /// `LETTER_MAP`. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> rust/verify/src/utils.rs:247:5 [INFO] [stdout] | [INFO] [stdout] 247 | / LETTER_MAP [INFO] [stdout] 248 | | .iter() [INFO] [stdout] 249 | | .find(|(k, _)| *k == letter) [INFO] [stdout] 250 | | .map(|(_, value)| *value) [INFO] [stdout] 251 | | .ok_or_else(|| PpuError::UnknownLetter { letter }) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 251 - .ok_or_else(|| PpuError::UnknownLetter { letter }) [INFO] [stdout] 251 + .ok_or(PpuError::UnknownLetter { letter }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | /// value needs to be retrieved. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> rust/verify/src/utils.rs:302:5 [INFO] [stdout] | [INFO] [stdout] 302 | / DIGRAPH_MAP [INFO] [stdout] 303 | | .iter() [INFO] [stdout] 304 | | .find(|(k, _)| *k == letters) [INFO] [stdout] 305 | | .map(|(_, v)| *v) [INFO] [stdout] 306 | | .ok_or_else(|| PpuError::UnknownDigraph { letters }) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 306 - .ok_or_else(|| PpuError::UnknownDigraph { letters }) [INFO] [stdout] 306 + .ok_or(PpuError::UnknownDigraph { letters }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:405:5 [INFO] [stdout] | [INFO] [stdout] 405 | /// (`'0'` to `'9'`) or the character `'K'`. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/verify/src/utils.rs:596:8 [INFO] [stdout] | [INFO] [stdout] 596 | if !seed.is_none() && seed.unwrap() < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `seed.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `seed` after checking its variant with `is_none` [INFO] [stdout] --> rust/verify/src/utils.rs:599:78 [INFO] [stdout] | [INFO] [stdout] 596 | if !seed.is_none() && seed.unwrap() < 0 { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 599 | msg: format!("`seed` must be non-negative: '{}' was given.", seed.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/verify/src/lib.rs:142:47 [INFO] [stdout] | [INFO] [stdout] 142 | let normalized = utils::normalize_ppu(&raw)?; [INFO] [stdout] | ^^^^ help: change this to: `raw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/verify/src/lib.rs:143:44 [INFO] [stdout] | [INFO] [stdout] 143 | let format = utils::get_ppu_format(&raw).unwrap(); [INFO] [stdout] | ^^^^ help: change this to: `raw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> rust/verify/src/constants.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | pub const DIGRAPH_MAP: [(&str, &str); 582] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 25 | | ("AA", "001"), [INFO] [stdout] 26 | | ("EA" ,"004"), [INFO] [stdout] 27 | | ("HA", "007"), [INFO] [stdout] ... | [INFO] [stdout] 606 | | ("DW", "582") [INFO] [stdout] 607 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] = note: `#[warn(clippy::large_const_arrays)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | /// one of the supported formats. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | /// expected to be a single-character string. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | /// `LETTER_MAP`. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> rust/verify/src/utils.rs:247:5 [INFO] [stdout] | [INFO] [stdout] 247 | / LETTER_MAP [INFO] [stdout] 248 | | .iter() [INFO] [stdout] 249 | | .find(|(k, _)| *k == letter) [INFO] [stdout] 250 | | .map(|(_, value)| *value) [INFO] [stdout] 251 | | .ok_or_else(|| PpuError::UnknownLetter { letter }) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 251 - .ok_or_else(|| PpuError::UnknownLetter { letter }) [INFO] [stdout] 251 + .ok_or(PpuError::UnknownLetter { letter }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | /// value needs to be retrieved. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> rust/verify/src/utils.rs:302:5 [INFO] [stdout] | [INFO] [stdout] 302 | / DIGRAPH_MAP [INFO] [stdout] 303 | | .iter() [INFO] [stdout] 304 | | .find(|(k, _)| *k == letters) [INFO] [stdout] 305 | | .map(|(_, v)| *v) [INFO] [stdout] 306 | | .ok_or_else(|| PpuError::UnknownDigraph { letters }) [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 306 - .ok_or_else(|| PpuError::UnknownDigraph { letters }) [INFO] [stdout] 306 + .ok_or(PpuError::UnknownDigraph { letters }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> rust/verify/src/utils.rs:405:5 [INFO] [stdout] | [INFO] [stdout] 405 | /// (`'0'` to `'9'`) or the character `'K'`. [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/verify/src/utils.rs:596:8 [INFO] [stdout] | [INFO] [stdout] 596 | if !seed.is_none() && seed.unwrap() < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `seed.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `seed` after checking its variant with `is_none` [INFO] [stdout] --> rust/verify/src/utils.rs:599:78 [INFO] [stdout] | [INFO] [stdout] 596 | if !seed.is_none() && seed.unwrap() < 0 { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 599 | msg: format!("`seed` must be non-negative: '{}' was given.", seed.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/verify/src/lib.rs:142:47 [INFO] [stdout] | [INFO] [stdout] 142 | let normalized = utils::normalize_ppu(&raw)?; [INFO] [stdout] | ^^^^ help: change this to: `raw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/verify/src/lib.rs:143:44 [INFO] [stdout] | [INFO] [stdout] 143 | let format = utils::get_ppu_format(&raw).unwrap(); [INFO] [stdout] | ^^^^ help: change this to: `raw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.1 [INFO] [stderr] Checking base v1.0.1 (/opt/rustwide/workdir/rust/base) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> rust/base/src/enums.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | / impl Default for ResponseFormat { [INFO] [stdout] 37 | | fn default() -> Self { [INFO] [stdout] 38 | | ResponseFormat::Json [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Default)] [INFO] [stdout] 6 | pub enum ResponseFormat { [INFO] [stdout] 7 ~ #[default] [INFO] [stdout] 8 ~ Json, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> rust/base/src/lib.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | |e| PyImportError::new_err(e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyImportError::new_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> rust/base/src/lib.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | |e| PyValueError::new_err(e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyValueError::new_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> rust/base/src/enums.rs:36:1 [INFO] [stdout] | [INFO] [stdout] 36 | / impl Default for ResponseFormat { [INFO] [stdout] 37 | | fn default() -> Self { [INFO] [stdout] 38 | | ResponseFormat::Json [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 5 + #[derive(Default)] [INFO] [stdout] 6 | pub enum ResponseFormat { [INFO] [stdout] 7 ~ #[default] [INFO] [stdout] 8 ~ Json, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> rust/base/src/lib.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | |e| PyImportError::new_err(e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyImportError::new_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> rust/base/src/lib.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | |e| PyValueError::new_err(e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PyValueError::new_err` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking market v1.0.1 (/opt/rustwide/workdir/rust/market) [INFO] [stderr] Checking cmf v1.0.1 (/opt/rustwide/workdir/rust/cmf) [INFO] [stderr] Checking cl_forge v1.0.1 (/opt/rustwide/workdir/rust/cl_forge) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 10s [INFO] running `Command { std: "docker" "inspect" "496517ac98655d2d44e3cef10423a18ac524e8a997449f4fbcdc4511e4353e24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "496517ac98655d2d44e3cef10423a18ac524e8a997449f4fbcdc4511e4353e24", kill_on_drop: false }` [INFO] [stdout] 496517ac98655d2d44e3cef10423a18ac524e8a997449f4fbcdc4511e4353e24