[INFO] cloning repository https://github.com/mredlek/rs-futures-spmc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mredlek/rs-futures-spmc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmredlek%2Frs-futures-spmc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmredlek%2Frs-futures-spmc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5a7339eb30dc0f62875885b78129a2c5f5b808de [INFO] linting mredlek/rs-futures-spmc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmredlek%2Frs-futures-spmc" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mredlek/rs-futures-spmc [INFO] finished tweaking git repo https://github.com/mredlek/rs-futures-spmc [INFO] tweaked toml for git repo https://github.com/mredlek/rs-futures-spmc written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mredlek/rs-futures-spmc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mredlek/rs-futures-spmc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded futures v0.1.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 765cdcedad53aea493dd37ffa96032132094f3cdccced762f0c0351bacbf5969 [INFO] running `Command { std: "docker" "start" "-a" "765cdcedad53aea493dd37ffa96032132094f3cdccced762f0c0351bacbf5969", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "765cdcedad53aea493dd37ffa96032132094f3cdccced762f0c0351bacbf5969", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "765cdcedad53aea493dd37ffa96032132094f3cdccced762f0c0351bacbf5969", kill_on_drop: false }` [INFO] [stdout] 765cdcedad53aea493dd37ffa96032132094f3cdccced762f0c0351bacbf5969 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16685cc795ed491f464d5164aee1329d7f6a80b9c3169a603f43fe0b2c81c67e [INFO] running `Command { std: "docker" "start" "-a" "16685cc795ed491f464d5164aee1329d7f6a80b9c3169a603f43fe0b2c81c67e", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking futures v0.1.14 [INFO] [stderr] Checking rs-futures-spmc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spmc_lockfree.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | slots: slots, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `slots` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/spmc_lockfree.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | try!(fmt.debug_struct("SharedData") [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spmc_lockfree.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | slots: slots, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `slots` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/spmc_lockfree.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | try!(fmt.debug_struct("SharedData") [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/spmc_lockfree.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | try!(fmt.write_fmt(format_args!("Slot {}: {:?}", data.0, data.1))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spmc_lockfree.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spmc_lockfree.rs:92:85 [INFO] [stdout] | [INFO] [stdout] 92 | let mut newlock = Box::into_raw(Box::new(LocksNode { next: ptr::null_mut(), task: task })); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `task` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/spmc_lockfree.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | try!(fmt.write_fmt(format_args!("Slot {}: {:?}", data.0, data.1))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spmc_lockfree.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spmc_lockfree.rs:92:85 [INFO] [stdout] | [INFO] [stdout] 92 | let mut newlock = Box::into_raw(Box::new(LocksNode { next: ptr::null_mut(), task: task })); [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `task` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spmc_lockfree.rs:390:59 [INFO] [stdout] | [INFO] [stdout] 390 | let sender = Sender { shareddata: shareddata.clone(), data: data }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spmc_lockfree.rs:390:59 [INFO] [stdout] | [INFO] [stdout] 390 | let sender = Sender { shareddata: shareddata.clone(), data: data }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::<*mut T>::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/spmc_lockfree.rs:97:57 [INFO] [stdout] | [INFO] [stdout] 97 | let replacedlock = self.read_interest_locks.compare_and_swap(oldlock, newlock, Ordering::Relaxed); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::<*mut T>::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/spmc_lockfree.rs:97:57 [INFO] [stdout] | [INFO] [stdout] 97 | let replacedlock = self.read_interest_locks.compare_and_swap(oldlock, newlock, Ordering::Relaxed); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/spmc_lockfree.rs:232:23 [INFO] [stdout] | [INFO] [stdout] 232 | (self as &mut Sink).close().map(|_| ()).unwrap_or(()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 232 | (self as &mut dyn Sink).close().map(|_| ()).unwrap_or(()); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/spmc_lockfree.rs:232:23 [INFO] [stdout] | [INFO] [stdout] 232 | (self as &mut Sink).close().map(|_| ()).unwrap_or(()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 232 | (self as &mut dyn Sink).close().map(|_| ()).unwrap_or(()); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> src/spmc_lockfree.rs:27:43 [INFO] [stdout] | [INFO] [stdout] 27 | slots.push(Slot::new(unsafe { dataptr.offset(index as isize) })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 27 - slots.push(Slot::new(unsafe { dataptr.offset(index as isize) })) [INFO] [stdout] 27 + slots.push(Slot::new(unsafe { dataptr.add(index) })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stdout] --> src/spmc_lockfree.rs:27:43 [INFO] [stdout] | [INFO] [stdout] 27 | slots.push(Slot::new(unsafe { dataptr.offset(index as isize) })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stdout] = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default [INFO] [stdout] help: use `add` instead [INFO] [stdout] | [INFO] [stdout] 27 - slots.push(Slot::new(unsafe { dataptr.offset(index as isize) })) [INFO] [stdout] 27 + slots.push(Slot::new(unsafe { dataptr.add(index) })) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/spmc_lockfree.rs:376:27 [INFO] [stdout] | [INFO] [stdout] 376 | readinterest: self.readinterest.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.readinterest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/spmc_lockfree.rs:376:27 [INFO] [stdout] | [INFO] [stdout] 376 | readinterest: self.readinterest.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.readinterest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> tests/spmc.rs:130:58 [INFO] [stdout] | [INFO] [stdout] 130 | let checkstream = CheckStream { inner: receiver, last_was_ready: last_was_ready }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_was_ready` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/spmc.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | assert!(!pollresult.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `pollresult.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/spmc.rs:120:25 [INFO] [stdout] | [INFO] [stdout] 120 | Err(_) => { assert!(false, "Received error")} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/spmc.rs:143:29 [INFO] [stdout] | [INFO] [stdout] 143 | ::futures::stream::iter(vec![Ok(0) as Result, Ok(1), Ok(2), Ok(3), Ok(4), Ok(5)].into_iter()).forward(sender) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/futures-0.1.14/src/stream/iter.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | where J: IntoIterator>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 143 - ::futures::stream::iter(vec![Ok(0) as Result, Ok(1), Ok(2), Ok(3), Ok(4), Ok(5)].into_iter()).forward(sender) [INFO] [stdout] 143 + ::futures::stream::iter(vec![Ok(0) as Result, Ok(1), Ok(2), Ok(3), Ok(4), Ok(5)]).forward(sender) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `futures::stream::Iter` in tuple element 0 that must be used [INFO] [stdout] --> tests/spmc.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / ::futures::stream::iter(vec![Ok(0) as Result, Ok(1), Ok(2), Ok(3), Ok(4), Ok(5)].into_iter()).forward(sender) [INFO] [stdout] 144 | | .wait() [INFO] [stdout] 145 | | .expect("Error forwarding stream to sender"); [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: streams do nothing unless polled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `Command { std: "docker" "inspect" "16685cc795ed491f464d5164aee1329d7f6a80b9c3169a603f43fe0b2c81c67e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16685cc795ed491f464d5164aee1329d7f6a80b9c3169a603f43fe0b2c81c67e", kill_on_drop: false }` [INFO] [stdout] 16685cc795ed491f464d5164aee1329d7f6a80b9c3169a603f43fe0b2c81c67e