[INFO] cloning repository https://github.com/moussetc/letsroll [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/moussetc/letsroll" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmoussetc%2Fletsroll", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmoussetc%2Fletsroll'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3b92da7fbddac891ac8c84c1d40a75a5177f97a3 [INFO] linting moussetc/letsroll against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmoussetc%2Fletsroll" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/moussetc/letsroll [INFO] finished tweaking git repo https://github.com/moussetc/letsroll [INFO] tweaked toml for git repo https://github.com/moussetc/letsroll written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/moussetc/letsroll on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/moussetc/letsroll already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_derive v1.0.84 [INFO] [stderr] Downloaded pest_generator v2.1.0 [INFO] [stderr] Downloaded maplit v1.0.1 [INFO] [stderr] Downloaded byte-tools v0.2.0 [INFO] [stderr] Downloaded utf8-ranges v1.0.2 [INFO] [stderr] Downloaded strsim v0.7.0 [INFO] [stderr] Downloaded digest v0.7.6 [INFO] [stderr] Downloaded arrayref v0.3.5 [INFO] [stderr] Downloaded block-buffer v0.3.3 [INFO] [stderr] Downloaded aho-corasick v0.6.9 [INFO] [stderr] Downloaded memchr v2.1.2 [INFO] [stderr] Downloaded ucd-util v0.1.3 [INFO] [stderr] Downloaded docopt v1.0.2 [INFO] [stderr] Downloaded serde v1.0.84 [INFO] [stderr] Downloaded pest v2.1.0 [INFO] [stderr] Downloaded rand v0.6.3 [INFO] [stderr] Downloaded syn v0.15.24 [INFO] [stderr] Downloaded ucd-trie v0.1.1 [INFO] [stderr] Downloaded typenum v1.10.0 [INFO] [stderr] Downloaded pest_meta v2.1.0 [INFO] [stderr] Downloaded rand_os v0.1.0 [INFO] [stderr] Downloaded generic-array v0.9.0 [INFO] [stderr] Downloaded regex v1.1.0 [INFO] [stderr] Downloaded regex-syntax v0.6.4 [INFO] [stderr] Downloaded fake-simd v0.1.2 [INFO] [stderr] Downloaded sha-1 v0.7.0 [INFO] [stderr] Downloaded libc v0.2.46 [INFO] [stderr] Downloaded pest_derive v2.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c7d3e75faf02a585020486d055ca841f73c0a788cc333bf6c99225bfb24407e [INFO] running `Command { std: "docker" "start" "-a" "5c7d3e75faf02a585020486d055ca841f73c0a788cc333bf6c99225bfb24407e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c7d3e75faf02a585020486d055ca841f73c0a788cc333bf6c99225bfb24407e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c7d3e75faf02a585020486d055ca841f73c0a788cc333bf6c99225bfb24407e", kill_on_drop: false }` [INFO] [stdout] 5c7d3e75faf02a585020486d055ca841f73c0a788cc333bf6c99225bfb24407e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a4d725545871820453115145132d43463e80ad11b95dfc6e15f1fb0eaafd850 [INFO] running `Command { std: "docker" "start" "-a" "5a4d725545871820453115145132d43463e80ad11b95dfc6e15f1fb0eaafd850", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Compiling libc v0.2.46 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Compiling autocfg v0.1.1 [INFO] [stderr] Compiling ucd-trie v0.1.1 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling serde v1.0.84 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling regex v1.1.0 [INFO] [stderr] Compiling maplit v1.0.1 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Compiling memchr v2.1.2 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.4 [INFO] [stderr] Checking pest v2.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.3 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking rand_os v0.1.0 [INFO] [stderr] Compiling syn v0.15.24 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Compiling pest_meta v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.84 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking letsroll v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/actions.rs:466:13 [INFO] [stdout] | [INFO] [stdout] 466 | rolls: rolls, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `rolls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/actions.rs:512:13 [INFO] [stdout] | [INFO] [stdout] 512 | rolls: rolls, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `rolls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/actions.rs:547:13 [INFO] [stdout] | [INFO] [stdout] 547 | rolls: rolls, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `rolls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | requests: requests, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `requests` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/actions.rs:466:13 [INFO] [stdout] | [INFO] [stdout] 466 | rolls: rolls, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `rolls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/actions.rs:512:13 [INFO] [stdout] | [INFO] [stdout] 512 | rolls: rolls, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `rolls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/actions.rs:547:13 [INFO] [stdout] | [INFO] [stdout] 547 | rolls: rolls, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `rolls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:106:29 [INFO] [stdout] | [INFO] [stdout] 106 | fn reroll(&self, dice: &Roll, t: &Vec) -> Rolls { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 106 | fn reroll(&self, dice: &dyn Roll, t: &Vec) -> Rolls { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:102:29 [INFO] [stdout] | [INFO] [stdout] 102 | fn reroll(&self, dice: &Roll, t: &Vec) -> Rolls; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 102 | fn reroll(&self, dice: &dyn Roll, t: &Vec) -> Rolls; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:284:30 [INFO] [stdout] | [INFO] [stdout] 284 | fn explode(&self, dice: &Roll, explosion_values: &Vec) -> Rolls { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 284 | fn explode(&self, dice: &dyn Roll, explosion_values: &Vec) -> Rolls { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:280:30 [INFO] [stdout] | [INFO] [stdout] 280 | fn explode(&self, dice: &Roll, explosion_values: &Vec) -> Rolls; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 280 | fn explode(&self, dice: &dyn Roll, explosion_values: &Vec) -> Rolls; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 303 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:448:16 [INFO] [stdout] | [INFO] [stdout] 448 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 448 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:405:16 [INFO] [stdout] | [INFO] [stdout] 405 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 405 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:493:16 [INFO] [stdout] | [INFO] [stdout] 493 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 493 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:485:16 [INFO] [stdout] | [INFO] [stdout] 485 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 485 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:560:16 [INFO] [stdout] | [INFO] [stdout] 560 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 560 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:553:45 [INFO] [stdout] | [INFO] [stdout] 553 | fn apply(&self, action: &Action, dice: &Roll) -> Result, Error>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 553 | fn apply(&self, action: &Action, dice: &dyn Roll) -> Result, Error>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:587:16 [INFO] [stdout] | [INFO] [stdout] 587 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 587 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | requests: requests, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `requests` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/dice.rs:176:46 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn roll(&self, dice: &Roll) -> Result, Error> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 176 | pub fn roll(&self, dice: &dyn Roll) -> Result, Error> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/dice.rs:196:53 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn new(dice_request: RollRequest, dice: &Roll) -> Rolls { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 196 | pub fn new(dice_request: RollRequest, dice: &dyn Roll) -> Rolls { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:106:29 [INFO] [stdout] | [INFO] [stdout] 106 | fn reroll(&self, dice: &Roll, t: &Vec) -> Rolls { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 106 | fn reroll(&self, dice: &dyn Roll, t: &Vec) -> Rolls { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:102:29 [INFO] [stdout] | [INFO] [stdout] 102 | fn reroll(&self, dice: &Roll, t: &Vec) -> Rolls; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 102 | fn reroll(&self, dice: &dyn Roll, t: &Vec) -> Rolls; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:284:30 [INFO] [stdout] | [INFO] [stdout] 284 | fn explode(&self, dice: &Roll, explosion_values: &Vec) -> Rolls { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 284 | fn explode(&self, dice: &dyn Roll, explosion_values: &Vec) -> Rolls { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:280:30 [INFO] [stdout] | [INFO] [stdout] 280 | fn explode(&self, dice: &Roll, explosion_values: &Vec) -> Rolls; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 280 | fn explode(&self, dice: &dyn Roll, explosion_values: &Vec) -> Rolls; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 303 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:448:16 [INFO] [stdout] | [INFO] [stdout] 448 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 448 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:405:16 [INFO] [stdout] | [INFO] [stdout] 405 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 405 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:493:16 [INFO] [stdout] | [INFO] [stdout] 493 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 493 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:485:16 [INFO] [stdout] | [INFO] [stdout] 485 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 485 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:560:16 [INFO] [stdout] | [INFO] [stdout] 560 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 560 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:553:45 [INFO] [stdout] | [INFO] [stdout] 553 | fn apply(&self, action: &Action, dice: &Roll) -> Result, Error>; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 553 | fn apply(&self, action: &Action, dice: &dyn Roll) -> Result, Error>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/actions.rs:587:16 [INFO] [stdout] | [INFO] [stdout] 587 | dice: &Roll, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 587 | dice: &dyn Roll, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/dice.rs:176:46 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn roll(&self, dice: &Roll) -> Result, Error> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 176 | pub fn roll(&self, dice: &dyn Roll) -> Result, Error> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/dice.rs:196:53 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn new(dice_request: RollRequest, dice: &Roll) -> Rolls { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 196 | pub fn new(dice_request: RollRequest, dice: &dyn Roll) -> Rolls { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `requests` is never read [INFO] [stdout] --> src/lib.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct TypedRollSession { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 17 | pub(crate) requests: Vec>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TypedRollSession` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/actions.rs:102:44 [INFO] [stdout] | [INFO] [stdout] 102 | fn reroll(&self, dice: &Roll, t: &Vec) -> Rolls; [INFO] [stdout] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/actions.rs:280:60 [INFO] [stdout] | [INFO] [stdout] 280 | fn explode(&self, dice: &Roll, explosion_values: &Vec) -> Rolls; [INFO] [stdout] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/actions.rs:302:12 [INFO] [stdout] | [INFO] [stdout] 302 | rolls: &Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 302 ~ rolls: &[T], [INFO] [stdout] 303 | dice: &Roll, [INFO] [stdout] ... [INFO] [stdout] 306 | ) -> Vec { [INFO] [stdout] 307 ~ let mut rolls = rolls.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/actions.rs:308:8 [INFO] [stdout] | [INFO] [stdout] 308 | if rolls.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rolls.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/actions.rs:102:44 [INFO] [stdout] | [INFO] [stdout] 102 | fn reroll(&self, dice: &Roll, t: &Vec) -> Rolls; [INFO] [stdout] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/actions.rs:343:30 [INFO] [stdout] | [INFO] [stdout] 343 | _ => self.iter().map(|roll| roll.rolls.clone()).flatten().sum(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|roll| roll.rolls.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/actions.rs:280:60 [INFO] [stdout] | [INFO] [stdout] 280 | fn explode(&self, dice: &Roll, explosion_values: &Vec) -> Rolls; [INFO] [stdout] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/actions.rs:302:12 [INFO] [stdout] | [INFO] [stdout] 302 | rolls: &Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 302 ~ rolls: &[T], [INFO] [stdout] 303 | dice: &Roll, [INFO] [stdout] ... [INFO] [stdout] 306 | ) -> Vec { [INFO] [stdout] 307 ~ let mut rolls = rolls.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/actions.rs:308:8 [INFO] [stdout] | [INFO] [stdout] 308 | if rolls.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rolls.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/actions.rs:530:43 [INFO] [stdout] | [INFO] [stdout] 530 | let all_rolls = self.rolls.iter().map(|rolls| &rolls.rolls).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|rolls| &rolls.rolls)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:532:23 [INFO] [stdout] | [INFO] [stdout] 532 | set.entry(&roll) [INFO] [stdout] | ^^^^^ help: change this to: `roll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/actions.rs:343:30 [INFO] [stdout] | [INFO] [stdout] 343 | _ => self.iter().map(|roll| roll.rolls.clone()).flatten().sum(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|roll| roll.rolls.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/actions.rs:570:17 [INFO] [stdout] | [INFO] [stdout] 570 | / return Err(Error::incompatible( [INFO] [stdout] 571 | | &action.to_string(), [INFO] [stdout] 572 | | &String::from("numeric roll"), [INFO] [stdout] 573 | | )); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 570 ~ Err(Error::incompatible( [INFO] [stdout] 571 + &action.to_string(), [INFO] [stdout] 572 + &String::from("numeric roll"), [INFO] [stdout] 573 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:566:71 [INFO] [stdout] | [INFO] [stdout] 566 | Action::Explode(explosion_value) => Ok(self.explode(dice, &explosion_value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `explosion_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:568:77 [INFO] [stdout] | [INFO] [stdout] 568 | Action::RerollNumeric(values_to_reroll) => Ok(self.reroll(dice, &values_to_reroll)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `values_to_reroll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:590:76 [INFO] [stdout] | [INFO] [stdout] 590 | Action::ExplodeFudge(explosion_value) => Ok(self.explode(dice, &explosion_value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `explosion_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:591:75 [INFO] [stdout] | [INFO] [stdout] 591 | Action::RerollFudge(values_to_reroll) => Ok(self.reroll(dice, &values_to_reroll)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `values_to_reroll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/actions.rs:530:43 [INFO] [stdout] | [INFO] [stdout] 530 | let all_rolls = self.rolls.iter().map(|rolls| &rolls.rolls).flatten(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|rolls| &rolls.rolls)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:532:23 [INFO] [stdout] | [INFO] [stdout] 532 | set.entry(&roll) [INFO] [stdout] | ^^^^^ help: change this to: `roll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/actions.rs:570:17 [INFO] [stdout] | [INFO] [stdout] 570 | / return Err(Error::incompatible( [INFO] [stdout] 571 | | &action.to_string(), [INFO] [stdout] 572 | | &String::from("numeric roll"), [INFO] [stdout] 573 | | )); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 570 ~ Err(Error::incompatible( [INFO] [stdout] 571 + &action.to_string(), [INFO] [stdout] 572 + &String::from("numeric roll"), [INFO] [stdout] 573 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:566:71 [INFO] [stdout] | [INFO] [stdout] 566 | Action::Explode(explosion_value) => Ok(self.explode(dice, &explosion_value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `explosion_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:568:77 [INFO] [stdout] | [INFO] [stdout] 568 | Action::RerollNumeric(values_to_reroll) => Ok(self.reroll(dice, &values_to_reroll)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `values_to_reroll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:590:76 [INFO] [stdout] | [INFO] [stdout] 590 | Action::ExplodeFudge(explosion_value) => Ok(self.explode(dice, &explosion_value)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `explosion_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/actions.rs:591:75 [INFO] [stdout] | [INFO] [stdout] 591 | Action::RerollFudge(values_to_reroll) => Ok(self.reroll(dice, &values_to_reroll)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `values_to_reroll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DiceGenerator` [INFO] [stdout] --> src/dice.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | / pub fn new() -> DiceGenerator { [INFO] [stdout] 97 | | DiceGenerator { [INFO] [stdout] 98 | | rng_ref: RefCell::new(rand::thread_rng()), [INFO] [stdout] 99 | | } [INFO] [stdout] 100 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 95 + impl Default for DiceGenerator { [INFO] [stdout] 96 + fn default() -> Self { [INFO] [stdout] 97 + Self::new() [INFO] [stdout] 98 + } [INFO] [stdout] 99 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `expected` [INFO] [stdout] --> src/actions.rs:629:18 [INFO] [stdout] | [INFO] [stdout] 629 | for i in 0..expected.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 629 - for i in 0..expected.len() - 1 { [INFO] [stdout] 629 + for (i, ) in expected.iter().enumerate().take(expected.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/dice.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | repeating_values: &Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 105 ~ repeating_values: &[T], [INFO] [stdout] 106 | ) -> Vec { [INFO] [stdout] 107 ~ let mut repeat_values = repeating_values.to_owned(); [INFO] [stdout] 108 | for _ in 0..(n as usize / repeating_values.len()) { [INFO] [stdout] 109 ~ repeat_values.append(&mut repeating_values.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `T` which implements the `Copy` trait [INFO] [stdout] --> src/dice.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 115 | (1..n + 1).map(|_| const_value.clone()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*const_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/errors.rs:41:49 [INFO] [stdout] | [INFO] [stdout] 41 | pub(crate) fn bad_action_parameter(message: &String) -> Error { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 ~ pub(crate) fn bad_action_parameter(message: &str) -> Error { [INFO] [stdout] 42 | Error { [INFO] [stdout] 43 ~ kind: ErrorKind::BadActionParameter(message.to_owned()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/actions.rs:716:17 [INFO] [stdout] | [INFO] [stdout] 716 | assert!(!rolls.keep_best(8).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rolls.keep_best(8).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/actions.rs:732:17 [INFO] [stdout] | [INFO] [stdout] 732 | assert!(!rolls.keep_worst(8).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rolls.keep_worst(8).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/actions.rs:766:17 [INFO] [stdout] | [INFO] [stdout] 766 | assert!(!rolls.keep_best(8).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rolls.keep_best(8).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/actions.rs:800:17 [INFO] [stdout] | [INFO] [stdout] 800 | assert!(!rolls.reroll_worst(&dice, 8).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rolls.reroll_worst(&dice, 8).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/io/read.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | x if x == "+" => Ok(FudgeRoll::Plus), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 - x if x == "+" => Ok(FudgeRoll::Plus), [INFO] [stdout] 19 + "+" => Ok(FudgeRoll::Plus), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/io/read.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | x if x == "-" => Ok(FudgeRoll::Minus), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 20 - x if x == "-" => Ok(FudgeRoll::Minus), [INFO] [stdout] 20 + "-" => Ok(FudgeRoll::Minus), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/io/read.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 21 | x if x == "0" => Ok(FudgeRoll::Blank), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 - x if x == "0" => Ok(FudgeRoll::Blank), [INFO] [stdout] 21 + "0" => Ok(FudgeRoll::Blank), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/io/read.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | /// This is allows users not to have to specify the Sum action each time they do a classic roll requiring the total. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 58 | /// This is allows users not to have to specify the Sum action each time they do a classic roll requiring the total. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `aggregation` after checking its variant with `is_some` [INFO] [stdout] --> src/io/read.rs:145:50 [INFO] [stdout] | [INFO] [stdout] 144 | if aggregation.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = aggregation` [INFO] [stdout] 145 | session = session.aggregate(&aggregation.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `aggregation` after checking its variant with `is_some` [INFO] [stdout] --> src/io/read.rs:155:62 [INFO] [stdout] | [INFO] [stdout] 154 | if aggregation.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = aggregation` [INFO] [stdout] 155 | let mut num_session = session.aggregate(&aggregation.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res_mut.numeric_session` after checking its variant with `is_some` [INFO] [stdout] --> src/io/read.rs:158:25 [INFO] [stdout] | [INFO] [stdout] 157 | if res_mut.numeric_session.is_some() { [INFO] [stdout] | ------------------------------------ help: try: `if let Some() = &mut res_mut.numeric_session` [INFO] [stdout] 158 | / res_mut [INFO] [stdout] 159 | | .numeric_session [INFO] [stdout] 160 | | .as_mut() [INFO] [stdout] 161 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DiceGenerator` [INFO] [stdout] --> src/dice.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | / pub fn new() -> DiceGenerator { [INFO] [stdout] 97 | | DiceGenerator { [INFO] [stdout] 98 | | rng_ref: RefCell::new(rand::thread_rng()), [INFO] [stdout] 99 | | } [INFO] [stdout] 100 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 95 + impl Default for DiceGenerator { [INFO] [stdout] 96 + fn default() -> Self { [INFO] [stdout] 97 + Self::new() [INFO] [stdout] 98 + } [INFO] [stdout] 99 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/io/read.rs:141:16 [INFO] [stdout] | [INFO] [stdout] 141 | if num_request_dice.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!num_request_dice.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/dice.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | repeating_values: &Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 105 ~ repeating_values: &[T], [INFO] [stdout] 106 | ) -> Vec { [INFO] [stdout] 107 ~ let mut repeat_values = repeating_values.to_owned(); [INFO] [stdout] 108 | for _ in 0..(n as usize / repeating_values.len()) { [INFO] [stdout] 109 ~ repeat_values.append(&mut repeating_values.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/io/read.rs:146:69 [INFO] [stdout] | [INFO] [stdout] 146 | } else if default_total && aggregation.is_none() && actions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `actions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/io/read.rs:151:16 [INFO] [stdout] | [INFO] [stdout] 151 | if fudge_request_dice.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!fudge_request_dice.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `T` which implements the `Copy` trait [INFO] [stdout] --> src/dice.rs:115:28 [INFO] [stdout] | [INFO] [stdout] 115 | (1..n + 1).map(|_| const_value.clone()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*const_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/io/read.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | let const_value: NumericRoll; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `const_value` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 211 ~ [INFO] [stdout] 212 | let rule = dice.into_inner().next().unwrap(); [INFO] [stdout] 213 ~ let const_value: NumericRoll = match rule.as_rule() { [INFO] [stdout] 214 | Rule::dice_sides => { [INFO] [stdout] 215 ~ rule.as_str().parse::().unwrap() [INFO] [stdout] 216 | } [INFO] [stdout] 217 | _ => unreachable!(), [INFO] [stdout] 218 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/io/write.rs:26:82 [INFO] [stdout] | [INFO] [stdout] 26 | NumericDice::ConstDice(const_value) => format!("+{}", const_value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/io/write.rs:67:55 [INFO] [stdout] | [INFO] [stdout] 67 | write!(f, "{}{}{}", id, self.number, self.dice.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/io/write.rs:86:1 [INFO] [stdout] | [INFO] [stdout] 86 | / impl ToString for TypedRollSession { [INFO] [stdout] 87 | | fn to_string(&self) -> String { [INFO] [stdout] 88 | | self.rolls [INFO] [stdout] 89 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/errors.rs:41:49 [INFO] [stdout] | [INFO] [stdout] 41 | pub(crate) fn bad_action_parameter(message: &String) -> Error { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 ~ pub(crate) fn bad_action_parameter(message: &str) -> Error { [INFO] [stdout] 42 | Error { [INFO] [stdout] 43 ~ kind: ErrorKind::BadActionParameter(message.to_owned()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/io/write.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | / impl ToString for MultiTypeSession { [INFO] [stdout] 97 | | fn to_string(&self) -> String { [INFO] [stdout] 98 | | let mut subresults: Vec = vec![]; [INFO] [stdout] 99 | | if let Some(session) = &self.numeric_session { [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/io/read.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | x if x == "+" => Ok(FudgeRoll::Plus), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] = note: `#[warn(clippy::redundant_guards)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 - x if x == "+" => Ok(FudgeRoll::Plus), [INFO] [stdout] 19 + "+" => Ok(FudgeRoll::Plus), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/io/read.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | x if x == "-" => Ok(FudgeRoll::Minus), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 20 - x if x == "-" => Ok(FudgeRoll::Minus), [INFO] [stdout] 20 + "-" => Ok(FudgeRoll::Minus), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant guard [INFO] [stdout] --> src/io/read.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 21 | x if x == "0" => Ok(FudgeRoll::Blank), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 - x if x == "0" => Ok(FudgeRoll::Blank), [INFO] [stdout] 21 + "0" => Ok(FudgeRoll::Blank), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/io/read.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | /// This is allows users not to have to specify the Sum action each time they do a classic roll requiring the total. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 58 | /// This is allows users not to have to specify the Sum action each time they do a classic roll requiring the total. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `aggregation` after checking its variant with `is_some` [INFO] [stdout] --> src/io/read.rs:145:50 [INFO] [stdout] | [INFO] [stdout] 144 | if aggregation.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = aggregation` [INFO] [stdout] 145 | session = session.aggregate(&aggregation.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `aggregation` after checking its variant with `is_some` [INFO] [stdout] --> src/io/read.rs:155:62 [INFO] [stdout] | [INFO] [stdout] 154 | if aggregation.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = aggregation` [INFO] [stdout] 155 | let mut num_session = session.aggregate(&aggregation.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res_mut.numeric_session` after checking its variant with `is_some` [INFO] [stdout] --> src/io/read.rs:158:25 [INFO] [stdout] | [INFO] [stdout] 157 | if res_mut.numeric_session.is_some() { [INFO] [stdout] | ------------------------------------ help: try: `if let Some() = &mut res_mut.numeric_session` [INFO] [stdout] 158 | / res_mut [INFO] [stdout] 159 | | .numeric_session [INFO] [stdout] 160 | | .as_mut() [INFO] [stdout] 161 | | .unwrap() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/io/read.rs:141:16 [INFO] [stdout] | [INFO] [stdout] 141 | if num_request_dice.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!num_request_dice.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/io/read.rs:146:69 [INFO] [stdout] | [INFO] [stdout] 146 | } else if default_total && aggregation.is_none() && actions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `actions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/io/read.rs:151:16 [INFO] [stdout] | [INFO] [stdout] 151 | if fudge_request_dice.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!fudge_request_dice.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/io/read.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | let const_value: NumericRoll; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `const_value` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 211 ~ [INFO] [stdout] 212 | let rule = dice.into_inner().next().unwrap(); [INFO] [stdout] 213 ~ let const_value: NumericRoll = match rule.as_rule() { [INFO] [stdout] 214 | Rule::dice_sides => { [INFO] [stdout] 215 ~ rule.as_str().parse::().unwrap() [INFO] [stdout] 216 | } [INFO] [stdout] 217 | _ => unreachable!(), [INFO] [stdout] 218 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/io/write.rs:26:82 [INFO] [stdout] | [INFO] [stdout] 26 | NumericDice::ConstDice(const_value) => format!("+{}", const_value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args [INFO] [stdout] --> src/io/write.rs:67:55 [INFO] [stdout] | [INFO] [stdout] 67 | write!(f, "{}{}{}", id, self.number, self.dice.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/io/write.rs:86:1 [INFO] [stdout] | [INFO] [stdout] 86 | / impl ToString for TypedRollSession { [INFO] [stdout] 87 | | fn to_string(&self) -> String { [INFO] [stdout] 88 | | self.rolls [INFO] [stdout] 89 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/io/write.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | / impl ToString for MultiTypeSession { [INFO] [stdout] 97 | | fn to_string(&self) -> String { [INFO] [stdout] 98 | | let mut subresults: Vec = vec![]; [INFO] [stdout] 99 | | if let Some(session) = &self.numeric_session { [INFO] [stdout] ... | [INFO] [stdout] 107 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use letsroll; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | const USAGE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | Err(msg) => return Err(msg), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - Err(msg) => return Err(msg), [INFO] [stdout] 53 + Err(msg) => Err(msg), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:62:33 [INFO] [stdout] | [INFO] [stdout] 62 | Err(msg) => return Err(Error::from(msg)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - Err(msg) => return Err(Error::from(msg)), [INFO] [stdout] 62 + Err(msg) => Err(Error::from(msg)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:57:75 [INFO] [stdout] | [INFO] [stdout] 57 | Some(save_path) => match write_to_file(&request_to_parse, &save_path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `save_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:73:33 [INFO] [stdout] | [INFO] [stdout] 73 | let mut file = File::create(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Args` [INFO] [stdout] 26 | struct Args { [INFO] [stdout] | ---- `Args` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use letsroll; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:14:15 [INFO] [stdout] | [INFO] [stdout] 14 | const USAGE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 53 | Err(msg) => return Err(msg), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - Err(msg) => return Err(msg), [INFO] [stdout] 53 + Err(msg) => Err(msg), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:62:33 [INFO] [stdout] | [INFO] [stdout] 62 | Err(msg) => return Err(Error::from(msg)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - Err(msg) => return Err(Error::from(msg)), [INFO] [stdout] 62 + Err(msg) => Err(Error::from(msg)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:57:75 [INFO] [stdout] | [INFO] [stdout] 57 | Some(save_path) => match write_to_file(&request_to_parse, &save_path) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `save_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:73:33 [INFO] [stdout] | [INFO] [stdout] 73 | let mut file = File::create(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/main.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | #[derive(Debug, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Args` [INFO] [stdout] 26 | struct Args { [INFO] [stdout] | ---- `Args` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.37s [INFO] running `Command { std: "docker" "inspect" "5a4d725545871820453115145132d43463e80ad11b95dfc6e15f1fb0eaafd850", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a4d725545871820453115145132d43463e80ad11b95dfc6e15f1fb0eaafd850", kill_on_drop: false }` [INFO] [stdout] 5a4d725545871820453115145132d43463e80ad11b95dfc6e15f1fb0eaafd850