[INFO] cloning repository https://github.com/mostafasadeghi97/auto-pilot-computer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mostafasadeghi97/auto-pilot-computer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmostafasadeghi97%2Fauto-pilot-computer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmostafasadeghi97%2Fauto-pilot-computer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 309ceebe25cf3cffd4f5e15c065cf0ae465666a4 [INFO] linting mostafasadeghi97/auto-pilot-computer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmostafasadeghi97%2Fauto-pilot-computer" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mostafasadeghi97/auto-pilot-computer [INFO] finished tweaking git repo https://github.com/mostafasadeghi97/auto-pilot-computer [INFO] tweaked toml for git repo https://github.com/mostafasadeghi97/auto-pilot-computer written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mostafasadeghi97/auto-pilot-computer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mostafasadeghi97/auto-pilot-computer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libwayshot v0.2.0 [INFO] [stderr] Downloaded screenshots v0.8.6 [INFO] [stderr] Downloaded display-info v0.4.3 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.1.0 [INFO] [stderr] Downloaded eventsource-stream v0.2.3 [INFO] [stderr] Downloaded async-convert v1.0.0 [INFO] [stderr] Downloaded wayland-scanner v0.30.1 [INFO] [stderr] Downloaded anstream v0.6.5 [INFO] [stderr] Downloaded backoff v0.4.0 [INFO] [stderr] Downloaded async-openai v0.17.1 [INFO] [stderr] Downloaded enigo v0.1.3 [INFO] [stderr] Downloaded simba v0.7.3 [INFO] [stderr] Downloaded wayland-backend v0.1.2 [INFO] [stderr] Downloaded wayland-protocols v0.30.1 [INFO] [stderr] Downloaded owned_ttf_parser v0.15.2 [INFO] [stderr] Downloaded dbus v0.9.7 [INFO] [stderr] Downloaded reqwest-eventsource v0.4.0 [INFO] [stderr] Downloaded rusttype v0.9.3 [INFO] [stderr] Downloaded xcb v1.3.0 [INFO] [stderr] Downloaded wayland-client v0.30.2 [INFO] [stderr] Downloaded nalgebra v0.30.1 [INFO] [stderr] Downloaded tokio v1.35.0 [INFO] [stderr] Downloaded libdbus-sys v0.2.5 [INFO] [stderr] Downloaded imageproc v0.23.0 [INFO] [stderr] Downloaded ring v0.17.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c7679a1b97d12cb8ddbf1b6e128a7368c24a780493aaae2d361352c90f0a1e3b [INFO] running `Command { std: "docker" "start" "-a" "c7679a1b97d12cb8ddbf1b6e128a7368c24a780493aaae2d361352c90f0a1e3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c7679a1b97d12cb8ddbf1b6e128a7368c24a780493aaae2d361352c90f0a1e3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7679a1b97d12cb8ddbf1b6e128a7368c24a780493aaae2d361352c90f0a1e3b", kill_on_drop: false }` [INFO] [stdout] c7679a1b97d12cb8ddbf1b6e128a7368c24a780493aaae2d361352c90f0a1e3b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e735f28097425d951129ac8e173cd1cab5490ed0cf00f0c64f6a5c1c6779d382 [INFO] running `Command { std: "docker" "start" "-a" "e735f28097425d951129ac8e173cd1cab5490ed0cf00f0c64f6a5c1c6779d382", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.17 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Compiling openssl v0.10.61 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling quick-xml v0.28.2 [INFO] [stderr] Compiling thiserror v1.0.51 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling quick-xml v0.30.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking fdeflate v0.3.1 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-epoch v0.9.16 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking exr v1.71.0 [INFO] [stderr] Compiling xcb v1.3.0 [INFO] [stderr] Compiling wayland-scanner v0.30.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling async-trait v0.1.74 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking wide v0.7.13 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling openssl-sys v0.9.97 [INFO] [stderr] Compiling wayland-backend v0.1.2 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Compiling enigo v0.1.3 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking clap_builder v4.4.11 [INFO] [stderr] Checking eventsource-stream v0.2.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking owned_ttf_parser v0.15.2 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.51 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tokio v1.35.0 [INFO] [stderr] Checking tiff v0.9.0 [INFO] [stderr] Checking wayland-client v0.30.2 [INFO] [stderr] Checking async-convert v1.0.0 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Checking wayland-protocols v0.30.1 [INFO] [stderr] Checking clap v4.4.11 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Checking nalgebra v0.30.1 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.1.0 [INFO] [stderr] Checking display-info v0.4.3 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking libwayshot v0.2.0 [INFO] [stderr] Checking h2 v0.3.22 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking screenshots v0.8.6 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking imageproc v0.23.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stderr] Checking reqwest-eventsource v0.4.0 [INFO] [stderr] Checking async-openai v0.17.1 [INFO] [stderr] Checking auto-pilot v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the function `format_vision_prompt` doesn't need a mutable reference [INFO] [stdout] --> src/action.rs:44:57 [INFO] [stdout] | [INFO] [stdout] 44 | let vision_prompt = format_vision_prompt(objective, &mut previous_action); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 44 - let vision_prompt = format_vision_prompt(objective, &mut previous_action); [INFO] [stdout] 44 + let vision_prompt = format_vision_prompt(objective, &previous_action); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operations.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return format!("Open program: {}", text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return format!("Open program: {}", text); [INFO] [stdout] 35 + format!("Open program: {}", text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/operations.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | let x_decimal = match convert_percent_to_decimal(x_percentage) { [INFO] [stdout] | _____________________^ [INFO] [stdout] 40 | | Ok(x_decimal) => x_decimal, [INFO] [stdout] 41 | | Err(_) => 0.0, [INFO] [stdout] 42 | | }; [INFO] [stdout] | |_____^ help: replace with: `convert_percent_to_decimal(x_percentage).unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/operations.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 44 | let y_decimal = match convert_percent_to_decimal(y_percentage) { [INFO] [stdout] | _____________________^ [INFO] [stdout] 45 | | Ok(y_decimal) => y_decimal, [INFO] [stdout] 46 | | Err(_) => 0.0, [INFO] [stdout] 47 | | }; [INFO] [stdout] | |_____^ help: replace with: `convert_percent_to_decimal(y_percentage).unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/parsers.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn from_str(s: &str) -> Self { [INFO] [stdout] 17 | | match s { [INFO] [stdout] 18 | | "DONE" => ActionType::Done, [INFO] [stdout] 19 | | s if s.starts_with("CLICK") => ActionType::Click, [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parsers.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | format!("{}", SUMMARY_PROMPT.replace("{objective}", objective)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `SUMMARY_PROMPT.replace("{objective}", objective).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parsers.rs:108:45 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn get_last_assistant_message(messages: &mut Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 108 - pub fn get_last_assistant_message(messages: &mut Vec) -> String { [INFO] [stdout] 108 + pub fn get_last_assistant_message(messages: &mut [Message]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `screens.get(0)` [INFO] [stdout] --> src/screen.rs:12:30 [INFO] [stdout] | [INFO] [stdout] 12 | Ok(screens) => match screens.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `screens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `screens.get(0)` [INFO] [stdout] --> src/screen.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | let screen = screens.get(0).ok_or("No screens found")?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `screens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `format_vision_prompt` doesn't need a mutable reference [INFO] [stdout] --> src/action.rs:44:57 [INFO] [stdout] | [INFO] [stdout] 44 | let vision_prompt = format_vision_prompt(objective, &mut previous_action); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 44 - let vision_prompt = format_vision_prompt(objective, &mut previous_action); [INFO] [stdout] 44 + let vision_prompt = format_vision_prompt(objective, &previous_action); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/operations.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | return format!("Open program: {}", text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return format!("Open program: {}", text); [INFO] [stdout] 35 + format!("Open program: {}", text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/operations.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | let x_decimal = match convert_percent_to_decimal(x_percentage) { [INFO] [stdout] | _____________________^ [INFO] [stdout] 40 | | Ok(x_decimal) => x_decimal, [INFO] [stdout] 41 | | Err(_) => 0.0, [INFO] [stdout] 42 | | }; [INFO] [stdout] | |_____^ help: replace with: `convert_percent_to_decimal(x_percentage).unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/operations.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 44 | let y_decimal = match convert_percent_to_decimal(y_percentage) { [INFO] [stdout] | _____________________^ [INFO] [stdout] 45 | | Ok(y_decimal) => y_decimal, [INFO] [stdout] 46 | | Err(_) => 0.0, [INFO] [stdout] 47 | | }; [INFO] [stdout] | |_____^ help: replace with: `convert_percent_to_decimal(y_percentage).unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/parsers.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn from_str(s: &str) -> Self { [INFO] [stdout] 17 | | match s { [INFO] [stdout] 18 | | "DONE" => ActionType::Done, [INFO] [stdout] 19 | | s if s.starts_with("CLICK") => ActionType::Click, [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parsers.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | format!("{}", SUMMARY_PROMPT.replace("{objective}", objective)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `SUMMARY_PROMPT.replace("{objective}", objective).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/parsers.rs:108:45 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn get_last_assistant_message(messages: &mut Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 108 - pub fn get_last_assistant_message(messages: &mut Vec) -> String { [INFO] [stdout] 108 + pub fn get_last_assistant_message(messages: &mut [Message]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `screens.get(0)` [INFO] [stdout] --> src/screen.rs:12:30 [INFO] [stdout] | [INFO] [stdout] 12 | Ok(screens) => match screens.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `screens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `screens.get(0)` [INFO] [stdout] --> src/screen.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | let screen = screens.get(0).ok_or("No screens found")?; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `screens.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 06s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: screenshots v0.8.6 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "e735f28097425d951129ac8e173cd1cab5490ed0cf00f0c64f6a5c1c6779d382", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e735f28097425d951129ac8e173cd1cab5490ed0cf00f0c64f6a5c1c6779d382", kill_on_drop: false }` [INFO] [stdout] e735f28097425d951129ac8e173cd1cab5490ed0cf00f0c64f6a5c1c6779d382