[INFO] cloning repository https://github.com/mohsinrashid64/clash-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mohsinrashid64/clash-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmohsinrashid64%2Fclash-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmohsinrashid64%2Fclash-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 03c546f1240b03cfafaa242c06e39c46d42b0442 [INFO] linting mohsinrashid64/clash-cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmohsinrashid64%2Fclash-cli" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mohsinrashid64/clash-cli [INFO] finished tweaking git repo https://github.com/mohsinrashid64/clash-cli [INFO] tweaked toml for git repo https://github.com/mohsinrashid64/clash-cli written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mohsinrashid64/clash-cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mohsinrashid64/clash-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.58 [INFO] [stderr] Downloaded clap_builder v4.5.58 [INFO] [stderr] Downloaded comfy-table v7.2.2 [INFO] [stderr] Downloaded objc2-io-kit v0.3.1 [INFO] [stderr] Downloaded sysinfo v0.38.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 321294e9e5f78deba0ff95ed72bb846ffa604e65721cbb3ba2516aad784e725c [INFO] running `Command { std: "docker" "start" "-a" "321294e9e5f78deba0ff95ed72bb846ffa604e65721cbb3ba2516aad784e725c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "321294e9e5f78deba0ff95ed72bb846ffa604e65721cbb3ba2516aad784e725c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "321294e9e5f78deba0ff95ed72bb846ffa604e65721cbb3ba2516aad784e725c", kill_on_drop: false }` [INFO] [stdout] 321294e9e5f78deba0ff95ed72bb846ffa604e65721cbb3ba2516aad784e725c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba40bb80bed7c5031b926b412f77f00cf5c2da232d056d8d4f2d289830b3696e [INFO] running `Command { std: "docker" "start" "-a" "ba40bb80bed7c5031b926b412f77f00cf5c2da232d056d8d4f2d289830b3696e", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.23 [INFO] [stderr] Compiling owo-colors v4.2.3 [INFO] [stderr] Checking console v0.16.2 [INFO] [stderr] Checking clap_builder v4.5.58 [INFO] [stderr] Checking unit-prefix v0.5.2 [INFO] [stderr] Checking sysinfo v0.38.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking comfy-table v7.2.2 [INFO] [stderr] Checking indicatif v0.18.4 [INFO] [stderr] Compiling syn v2.0.115 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking clap v4.5.58 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking clash v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/output.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | / if let Some(tc) = time_comp { [INFO] [stdout] 245 | | if tc.ratio > 1.01 { [INFO] [stdout] 246 | | parts.push(format!( [INFO] [stdout] 247 | | "{} wins on speed ({:.2}x)", [INFO] [stdout] ... | [INFO] [stdout] 251 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 244 ~ if let Some(tc) = time_comp [INFO] [stdout] 245 ~ && tc.ratio > 1.01 { [INFO] [stdout] 246 | parts.push(format!( [INFO] [stdout] ... [INFO] [stdout] 249 | )); [INFO] [stdout] 250 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/output.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | / if let Some(mc) = mem_comp { [INFO] [stdout] 254 | | if mc.ratio > 1.01 { [INFO] [stdout] 255 | | parts.push(format!( [INFO] [stdout] 256 | | "{} wins on memory ({:.2}x)", [INFO] [stdout] ... | [INFO] [stdout] 260 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 253 ~ if let Some(mc) = mem_comp [INFO] [stdout] 254 ~ && mc.ratio > 1.01 { [INFO] [stdout] 255 | parts.push(format!( [INFO] [stdout] ... [INFO] [stdout] 258 | )); [INFO] [stdout] 259 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/runner.rs:140:21 [INFO] [stdout] | [INFO] [stdout] 140 | '\\' if in_double_quote || (!in_single_quote && !in_double_quote) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 140 - '\\' if in_double_quote || (!in_single_quote && !in_double_quote) => { [INFO] [stdout] 140 + '\\' if !(!in_double_quote && in_single_quote) => { [INFO] [stdout] | [INFO] [stdout] 140 - '\\' if in_double_quote || (!in_single_quote && !in_double_quote) => { [INFO] [stdout] 140 + '\\' if in_double_quote || !in_single_quote => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/stats.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if mems.iter().any(|&m| m == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mems.contains(&0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/output.rs:244:5 [INFO] [stdout] | [INFO] [stdout] 244 | / if let Some(tc) = time_comp { [INFO] [stdout] 245 | | if tc.ratio > 1.01 { [INFO] [stdout] 246 | | parts.push(format!( [INFO] [stdout] 247 | | "{} wins on speed ({:.2}x)", [INFO] [stdout] ... | [INFO] [stdout] 251 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 244 ~ if let Some(tc) = time_comp [INFO] [stdout] 245 ~ && tc.ratio > 1.01 { [INFO] [stdout] 246 | parts.push(format!( [INFO] [stdout] ... [INFO] [stdout] 249 | )); [INFO] [stdout] 250 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/output.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | / if let Some(mc) = mem_comp { [INFO] [stdout] 254 | | if mc.ratio > 1.01 { [INFO] [stdout] 255 | | parts.push(format!( [INFO] [stdout] 256 | | "{} wins on memory ({:.2}x)", [INFO] [stdout] ... | [INFO] [stdout] 260 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 253 ~ if let Some(mc) = mem_comp [INFO] [stdout] 254 ~ && mc.ratio > 1.01 { [INFO] [stdout] 255 | parts.push(format!( [INFO] [stdout] ... [INFO] [stdout] 258 | )); [INFO] [stdout] 259 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/runner.rs:140:21 [INFO] [stdout] | [INFO] [stdout] 140 | '\\' if in_double_quote || (!in_single_quote && !in_double_quote) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 140 - '\\' if in_double_quote || (!in_single_quote && !in_double_quote) => { [INFO] [stdout] 140 + '\\' if !(!in_double_quote && in_single_quote) => { [INFO] [stdout] | [INFO] [stdout] 140 - '\\' if in_double_quote || (!in_single_quote && !in_double_quote) => { [INFO] [stdout] 140 + '\\' if in_double_quote || !in_single_quote => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/stats.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if mems.iter().any(|&m| m == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mems.contains(&0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.39s [INFO] running `Command { std: "docker" "inspect" "ba40bb80bed7c5031b926b412f77f00cf5c2da232d056d8d4f2d289830b3696e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba40bb80bed7c5031b926b412f77f00cf5c2da232d056d8d4f2d289830b3696e", kill_on_drop: false }` [INFO] [stdout] ba40bb80bed7c5031b926b412f77f00cf5c2da232d056d8d4f2d289830b3696e