[INFO] cloning repository https://github.com/modeverv/fistRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/modeverv/fistRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmodeverv%2FfistRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmodeverv%2FfistRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c765ac8acb46eeb4f16615c30403e35bb5e915d3 [INFO] linting modeverv/fistRust/c765ac8acb46eeb4f16615c30403e35bb5e915d3 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmodeverv%2FfistRust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/modeverv/fistRust [INFO] finished tweaking git repo https://github.com/modeverv/fistRust [INFO] tweaked toml for git repo https://github.com/modeverv/fistRust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/modeverv/fistRust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/modeverv/fistRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b21c7e1d5a7c210016f45ae1b79b6c68b6cf10f09020156a5eed987cbf7d291 [INFO] running `Command { std: "docker" "start" "-a" "3b21c7e1d5a7c210016f45ae1b79b6c68b6cf10f09020156a5eed987cbf7d291", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b21c7e1d5a7c210016f45ae1b79b6c68b6cf10f09020156a5eed987cbf7d291", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b21c7e1d5a7c210016f45ae1b79b6c68b6cf10f09020156a5eed987cbf7d291", kill_on_drop: false }` [INFO] [stdout] 3b21c7e1d5a7c210016f45ae1b79b6c68b6cf10f09020156a5eed987cbf7d291 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe20efe4a03a4d21a4e678a636799adf56ded8fe754a50d353e8f20401f2608e [INFO] running `Command { std: "docker" "start" "-a" "fe20efe4a03a4d21a4e678a636799adf56ded8fe754a50d353e8f20401f2608e", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking firstRust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v1` [INFO] [stdout] --> src/main.rs:114:10 [INFO] [stdout] | [INFO] [stdout] 114 | let (v1, v2, answer) = foo(v1, v2); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v2` [INFO] [stdout] --> src/main.rs:114:14 [INFO] [stdout] | [INFO] [stdout] 114 | let (v1, v2, answer) = foo(v1, v2); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/main.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | fn foo2(v: &Vec) -> i32 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let mut y = &mut x; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/main.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let mut y = &mut x; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y1` [INFO] [stdout] --> src/main.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | let y1 = x1.clone(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y2` [INFO] [stdout] --> src/main.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | let y2 = x2.borrow_mut(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | let mut p2 = Point { y: 1, ..point }; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `black` [INFO] [stdout] --> src/main.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | let black = Color(0,0,0); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_black` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m` [INFO] [stdout] --> src/main.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | let m = Message::Write("Hello world".to_string()); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | for x in v1 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:234:17 [INFO] [stdout] | [INFO] [stdout] 234 | fn change_color(x:i32,y:i32,z:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/main.rs:234:23 [INFO] [stdout] | [INFO] [stdout] 234 | fn change_color(x:i32,y:i32,z:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/main.rs:234:29 [INFO] [stdout] | [INFO] [stdout] 234 | fn change_color(x:i32,y:i32,z:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:235:16 [INFO] [stdout] | [INFO] [stdout] 235 | fn move_cursor(x:i32,y:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/main.rs:235:22 [INFO] [stdout] | [INFO] [stdout] 235 | fn move_cursor(x:i32,y:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | let x = 1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/main.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | let y = 2; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/main.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | let r = 3; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `g` [INFO] [stdout] --> src/main.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | let g = 4; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_g` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/main.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | let b = 5; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0`, `1`, and `2` are never read [INFO] [stdout] --> src/main.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 181 | struct Color(i32,i32,i32); [INFO] [stdout] | ----- ^^^ ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Quit`, `ChangeColor`, and `Move` are never constructed [INFO] [stdout] --> src/main.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 202 | enum Message { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] 203 | Quit, [INFO] [stdout] | ^^^^ [INFO] [stdout] 204 | ChangeColor(i32, i32, i32), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 205 | Move { x: i32, y: i32 }, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Missing` is never constructed [INFO] [stdout] --> src/main.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 251 | enum OptionalTuple { [INFO] [stdout] | ------------- variant in this enum [INFO] [stdout] 252 | Value(i32,i32), [INFO] [stdout] 253 | Missing, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x` and `y` are never read [INFO] [stdout] --> src/main.rs:279:5 [INFO] [stdout] | [INFO] [stdout] 278 | struct Circle { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 279 | x: f64, [INFO] [stdout] | ^ [INFO] [stdout] 280 | y: f64, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 130 | fn foo2(v: &Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 130 - fn foo2(v: &Vec) -> i32 { [INFO] [stdout] 130 + fn foo2(v: &[i32]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/main.rs:265:5 [INFO] [stdout] | [INFO] [stdout] 265 | / match ori { [INFO] [stdout] 266 | | Point{x:x1,y:y1} => println!("{},{}",x1,y1), [INFO] [stdout] 267 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 265 ~ let Point{x:x1,y:y1} = ori; [INFO] [stdout] 266 + println!("{},{}",x1,y1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `x:` in this pattern is redundant [INFO] [stdout] --> src/main.rs:245:24 [INFO] [stdout] | [INFO] [stdout] 245 | Message::Move {x:x,y:y} => move_cursor(x,y), [INFO] [stdout] | ^^^ help: use shorthand field pattern: `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_shorthand_field_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `y:` in this pattern is redundant [INFO] [stdout] --> src/main.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 245 | Message::Move {x:x,y:y} => move_cursor(x,y), [INFO] [stdout] | ^^^ help: use shorthand field pattern: `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:293:13 [INFO] [stdout] | [INFO] [stdout] 293 | x: x, [INFO] [stdout] | ^^^^ help: replace it with: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:294:13 [INFO] [stdout] | [INFO] [stdout] 294 | y: y, [INFO] [stdout] | ^^^^ help: replace it with: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v1` [INFO] [stdout] --> src/main.rs:114:10 [INFO] [stdout] | [INFO] [stdout] 114 | let (v1, v2, answer) = foo(v1, v2); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v2` [INFO] [stdout] --> src/main.rs:114:14 [INFO] [stdout] | [INFO] [stdout] 114 | let (v1, v2, answer) = foo(v1, v2); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_v2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/main.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | fn foo2(v: &Vec) -> i32 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let mut y = &mut x; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/main.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let mut y = &mut x; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y1` [INFO] [stdout] --> src/main.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | let y1 = x1.clone(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y2` [INFO] [stdout] --> src/main.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | let y2 = x2.borrow_mut(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | let mut p2 = Point { y: 1, ..point }; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `black` [INFO] [stdout] --> src/main.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | let black = Color(0,0,0); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_black` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m` [INFO] [stdout] --> src/main.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | let m = Message::Write("Hello world".to_string()); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | for x in v1 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:234:17 [INFO] [stdout] | [INFO] [stdout] 234 | fn change_color(x:i32,y:i32,z:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/main.rs:234:23 [INFO] [stdout] | [INFO] [stdout] 234 | fn change_color(x:i32,y:i32,z:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `z` [INFO] [stdout] --> src/main.rs:234:29 [INFO] [stdout] | [INFO] [stdout] 234 | fn change_color(x:i32,y:i32,z:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_z` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:235:16 [INFO] [stdout] | [INFO] [stdout] 235 | fn move_cursor(x:i32,y:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/main.rs:235:22 [INFO] [stdout] | [INFO] [stdout] 235 | fn move_cursor(x:i32,y:i32){} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/main.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | let x = 1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/main.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | let y = 2; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `r` [INFO] [stdout] --> src/main.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | let r = 3; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_r` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `g` [INFO] [stdout] --> src/main.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | let g = 4; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_g` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/main.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | let b = 5; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0`, `1`, and `2` are never read [INFO] [stdout] --> src/main.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 181 | struct Color(i32,i32,i32); [INFO] [stdout] | ----- ^^^ ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Quit`, `ChangeColor`, and `Move` are never constructed [INFO] [stdout] --> src/main.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 202 | enum Message { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] 203 | Quit, [INFO] [stdout] | ^^^^ [INFO] [stdout] 204 | ChangeColor(i32, i32, i32), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 205 | Move { x: i32, y: i32 }, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Missing` is never constructed [INFO] [stdout] --> src/main.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 251 | enum OptionalTuple { [INFO] [stdout] | ------------- variant in this enum [INFO] [stdout] 252 | Value(i32,i32), [INFO] [stdout] 253 | Missing, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x` and `y` are never read [INFO] [stdout] --> src/main.rs:279:5 [INFO] [stdout] | [INFO] [stdout] 278 | struct Circle { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 279 | x: f64, [INFO] [stdout] | ^ [INFO] [stdout] 280 | y: f64, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | i = i + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 130 | fn foo2(v: &Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 130 - fn foo2(v: &Vec) -> i32 { [INFO] [stdout] 130 + fn foo2(v: &[i32]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/main.rs:265:5 [INFO] [stdout] | [INFO] [stdout] 265 | / match ori { [INFO] [stdout] 266 | | Point{x:x1,y:y1} => println!("{},{}",x1,y1), [INFO] [stdout] 267 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 265 ~ let Point{x:x1,y:y1} = ori; [INFO] [stdout] 266 + println!("{},{}",x1,y1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `x:` in this pattern is redundant [INFO] [stdout] --> src/main.rs:245:24 [INFO] [stdout] | [INFO] [stdout] 245 | Message::Move {x:x,y:y} => move_cursor(x,y), [INFO] [stdout] | ^^^ help: use shorthand field pattern: `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_shorthand_field_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `y:` in this pattern is redundant [INFO] [stdout] --> src/main.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 245 | Message::Move {x:x,y:y} => move_cursor(x,y), [INFO] [stdout] | ^^^ help: use shorthand field pattern: `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `Command { std: "docker" "inspect" "fe20efe4a03a4d21a4e678a636799adf56ded8fe754a50d353e8f20401f2608e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe20efe4a03a4d21a4e678a636799adf56ded8fe754a50d353e8f20401f2608e", kill_on_drop: false }` [INFO] [stdout] fe20efe4a03a4d21a4e678a636799adf56ded8fe754a50d353e8f20401f2608e