[INFO] cloning repository https://github.com/mnaphade18/aoc-2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mnaphade18/aoc-2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmnaphade18%2Faoc-2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmnaphade18%2Faoc-2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4c86256813f693a9c60d2ed21155fef5da6bd476 [INFO] linting mnaphade18/aoc-2023 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmnaphade18%2Faoc-2023" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mnaphade18/aoc-2023 [INFO] finished tweaking git repo https://github.com/mnaphade18/aoc-2023 [INFO] tweaked toml for git repo https://github.com/mnaphade18/aoc-2023 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mnaphade18/aoc-2023 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mnaphade18/aoc-2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc843332c6d470cfae66f9caacd4208a59eb2aa59d4faf3bfc0b2a9aa23b696c [INFO] running `Command { std: "docker" "start" "-a" "fc843332c6d470cfae66f9caacd4208a59eb2aa59d4faf3bfc0b2a9aa23b696c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc843332c6d470cfae66f9caacd4208a59eb2aa59d4faf3bfc0b2a9aa23b696c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc843332c6d470cfae66f9caacd4208a59eb2aa59d4faf3bfc0b2a9aa23b696c", kill_on_drop: false }` [INFO] [stdout] fc843332c6d470cfae66f9caacd4208a59eb2aa59d4faf3bfc0b2a9aa23b696c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 53348b347b2b37d920818b1916c90cdba06f4b32e62add05828b869bd782e119 [INFO] running `Command { std: "docker" "start" "-a" "53348b347b2b37d920818b1916c90cdba06f4b32e62add05828b869bd782e119", kill_on_drop: false }` [INFO] [stderr] Checking aoc-2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/day8.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | todo!("implete this part "); [INFO] [stdout] | --------------------------- any code following this expression is unreachable [INFO] [stdout] 118 | / k.iter().fold(0, |acc, v| { [INFO] [stdout] 119 | | if v.chars().rev().next().unwrap() == 'Z' { [INFO] [stdout] ... | [INFO] [stdout] 123 | | }); [INFO] [stdout] | |___________^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day6.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let mut distance_line = iter.next().unwrap().split(' ').filter(|x| *x != empty_string).skip(1); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day6.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | let mut result = 1; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `keys` is never read [INFO] [stdout] --> src/day8.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | keys = k; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `total` is never read [INFO] [stdout] --> src/day8.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | total = total + t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `done` is never read [INFO] [stdout] --> src/day8.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | done = d; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `depth` is assigned to, but never used [INFO] [stdout] --> src/day9.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | let mut depth = 2; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_depth` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `depth` is never read [INFO] [stdout] --> src/day9.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | depth += 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `depth` is assigned to, but never used [INFO] [stdout] --> src/day9.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut depth = 2; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_depth` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `depth` is never read [INFO] [stdout] --> src/day9.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | depth += 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/day8.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | todo!("implete this part "); [INFO] [stdout] | --------------------------- any code following this expression is unreachable [INFO] [stdout] 118 | / k.iter().fold(0, |acc, v| { [INFO] [stdout] 119 | | if v.chars().rev().next().unwrap() == 'Z' { [INFO] [stdout] ... | [INFO] [stdout] 123 | | }); [INFO] [stdout] | |___________^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/day10.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | let x = self.curr.0 - 1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/day10.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let y = self.curr.1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev` is assigned to, but never used [INFO] [stdout] --> src/day10.rs:138:17 [INFO] [stdout] | [INFO] [stdout] 138 | let mut prev = None; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_prev` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `prev` is never read [INFO] [stdout] --> src/day10.rs:158:29 [INFO] [stdout] | [INFO] [stdout] 158 | ... prev = p.sides.iter().find(|s| s != &&Side::Right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day11.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | let mut space: Space = ip.lines().map(|l| l.chars().collect()).collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tower` [INFO] [stdout] --> src/day22.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | let tower = Brick::from_str(input); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line` is never used [INFO] [stdout] --> src/day1.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse_line(line: &str) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT2T` is never used [INFO] [stdout] --> src/day1.rs:108:7 [INFO] [stdout] | [INFO] [stdout] 108 | const INPUT2T: &str = "two1nine [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day1.rs:116:7 [INFO] [stdout] | [INFO] [stdout] 116 | const INPUT: &str = "1abc2 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Balls` is never constructed [INFO] [stdout] --> src/day2.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | struct Balls { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day2.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line` is never used [INFO] [stdout] --> src/day2.rs:24:4 [INFO] [stdout] | [INFO] [stdout] 24 | fn parse_line(line: &str) -> (usize, bool) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line2` is never used [INFO] [stdout] --> src/day2.rs:42:4 [INFO] [stdout] | [INFO] [stdout] 42 | fn parse_line2(line: &str) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_game` is never used [INFO] [stdout] --> src/day2.rs:66:4 [INFO] [stdout] | [INFO] [stdout] 66 | fn parse_game(game: &str) -> Balls { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT1T` is never used [INFO] [stdout] --> src/day2.rs:87:7 [INFO] [stdout] | [INFO] [stdout] 87 | const INPUT1T: &str = "Game 1: 3 blue, 4 red; 1 red, 2 green, 6 blue; 2 green [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT1` is never used [INFO] [stdout] --> src/day2.rs:93:7 [INFO] [stdout] | [INFO] [stdout] 93 | const INPUT1: &str = "Game 1: 1 green, 2 blue; 13 red, 2 blue, 3 green; 4 green, 14 red [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NumLine` is never constructed [INFO] [stdout] --> src/day3.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct NumLine { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day3.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line` is never used [INFO] [stdout] --> src/day3.rs:37:4 [INFO] [stdout] | [INFO] [stdout] 37 | fn parse_line(line: &str) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_num_line` is never used [INFO] [stdout] --> src/day3.rs:65:4 [INFO] [stdout] | [INFO] [stdout] 65 | fn get_num_line(num_str: String, end: usize) -> NumLine { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_part_numbers` is never used [INFO] [stdout] --> src/day3.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | fn get_part_numbers( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_total` is never used [INFO] [stdout] --> src/day3.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | fn get_total(num_lines: &Vec, index: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day3.rs:120:7 [INFO] [stdout] | [INFO] [stdout] 120 | const INPUTT: &str = "467..114.. [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day3.rs:131:7 [INFO] [stdout] | [INFO] [stdout] 131 | const INPUT: &str = ".....613...................................439............498.........................438......617....343........ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Card` is never constructed [INFO] [stdout] --> src/day4.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Card { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day4.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve1` is never used [INFO] [stdout] --> src/day4.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn solve1() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line` is never used [INFO] [stdout] --> src/day4.rs:52:4 [INFO] [stdout] | [INFO] [stdout] 52 | fn parse_line(line: &str) -> Card { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_matches` is never used [INFO] [stdout] --> src/day4.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | fn find_matches(card: &Card) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day4.rs:88:7 [INFO] [stdout] | [INFO] [stdout] 88 | const INPUTT: &str = "Card 1: 41 48 83 86 17 | 83 86 6 31 17 9 48 53 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day4.rs:95:7 [INFO] [stdout] | [INFO] [stdout] 95 | const INPUT: &str = "Card 1: 30 51 48 31 36 33 49 83 86 17 | 17 33 31 70 90 37 86 45 58 21 83 52 59 68 55 32 20 43 48 75 30 42 80 ... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Mapper` is never constructed [INFO] [stdout] --> src/day5.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct Mapper { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MapItem` is never constructed [INFO] [stdout] --> src/day5.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct MapItem { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `find`, `new`, and `parse_line` are never used [INFO] [stdout] --> src/day5.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl Mapper { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 12 | fn find(&self, num: u64) -> u64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | fn new(section: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | fn parse_line(line: &str) -> MapItem { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day5.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part_2_seeds` is never used [INFO] [stdout] --> src/day5.rs:74:4 [INFO] [stdout] | [INFO] [stdout] 74 | fn part_2_seeds(line: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_seeds` is never used [INFO] [stdout] --> src/day5.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn update_seeds(seeds: &Vec, map: Mapper) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day5.rs:98:7 [INFO] [stdout] | [INFO] [stdout] 98 | const INPUTT: &str = "seeds: 79 14 55 13 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day5.rs:132:7 [INFO] [stdout] | [INFO] [stdout] 132 | const INPUT: &str = "seeds: 3169137700 271717609 3522125441 23376095 1233948799 811833837 280549587 703867355 166086528 44766996 23... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Target` is never constructed [INFO] [stdout] --> src/day6.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | struct Target { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day6.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_valid_outcomes` is never used [INFO] [stdout] --> src/day6.rs:44:4 [INFO] [stdout] | [INFO] [stdout] 44 | fn get_valid_outcomes(target: &Target) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day6.rs:56:7 [INFO] [stdout] | [INFO] [stdout] 56 | const INPUTT: &str = "Time: 7 15 30 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day6.rs:59:7 [INFO] [stdout] | [INFO] [stdout] 59 | const INPUT: &str = "Time: 58 99 64 69 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Hand` is never constructed [INFO] [stdout] --> src/day7.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct Hand { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParseError` is never constructed [INFO] [stdout] --> src/day7.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct ParseError; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `rank` and `cmp` are never used [INFO] [stdout] --> src/day7.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 53 | impl Hand { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] 54 | fn rank(&self) -> u8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | fn cmp(&self, other: &Hand) -> Ordering { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day7.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day7.rs:126:7 [INFO] [stdout] | [INFO] [stdout] 126 | const INPUTT: &str = "32T3K 765 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day7.rs:132:7 [INFO] [stdout] | [INFO] [stdout] 132 | const INPUT: &str = "K8KK6 75 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Hand` is never constructed [INFO] [stdout] --> src/day7_2.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct Hand { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParseError` is never constructed [INFO] [stdout] --> src/day7_2.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct ParseError; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `rank` and `cmp` are never used [INFO] [stdout] --> src/day7_2.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 73 | impl Hand { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] 74 | fn rank(&self) -> u8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 97 | fn cmp(&self, other: &Hand) -> Ordering { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day7_2.rs:125:8 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day7_2.rs:145:7 [INFO] [stdout] | [INFO] [stdout] 145 | const INPUTT: &str = "32T3K 765 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day7_2.rs:151:7 [INFO] [stdout] | [INFO] [stdout] 151 | const INPUT: &str = "K8KK6 75 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Postition` is never constructed [INFO] [stdout] --> src/day8.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Postition { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PositionParseError` is never constructed [INFO] [stdout] --> src/day8.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct PositionParseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day8.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_path` is never used [INFO] [stdout] --> src/day8.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 68 | fn find_path(seq: &str, start_key: &str, postions: &HashMap) -> (String, usize) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve2` is never used [INFO] [stdout] --> src/day8.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn solve2() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_paths` is never used [INFO] [stdout] --> src/day8.rs:134:4 [INFO] [stdout] | [INFO] [stdout] 134 | fn find_paths(seq: &str, mut start_keys: Vec, postions: &HashMap) -> (Vec, usize, bool) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day8.rs:168:7 [INFO] [stdout] | [INFO] [stdout] 168 | const INPUTT: &str = "RL [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT2` is never used [INFO] [stdout] --> src/day8.rs:178:7 [INFO] [stdout] | [INFO] [stdout] 178 | const INPUTT2: &str = "LLR [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT3` is never used [INFO] [stdout] --> src/day8.rs:184:7 [INFO] [stdout] | [INFO] [stdout] 184 | const INPUTT3: &str = "LR [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day8.rs:195:7 [INFO] [stdout] | [INFO] [stdout] 195 | const INPUT: &str = "LRLRLRLRRLRRRLRLRLRRRLLRRLRRLRRLLRRLRRLRLRRRLRRLLRRLRRRLRRLRRRLRRRLLLRRLLRLLRRRLLRRLRLLRLLRRRLLRRLRRLRRRLRRLRL... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Sequence` is never used [INFO] [stdout] --> src/day9.rs:2:6 [INFO] [stdout] | [INFO] [stdout] 2 | enum Sequence { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `first`, `last`, `get_diff`, `get_depth`, and `get_depth2` are never used [INFO] [stdout] --> src/day9.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 6 | impl Sequence { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 7 | fn first(&self) -> i64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | fn last(&self) -> i64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 17 | fn get_diff(&self) -> (Sequence, bool) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | fn get_depth(&self) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | fn get_depth2(&self) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_sequence` is never used [INFO] [stdout] --> src/day9.rs:88:4 [INFO] [stdout] | [INFO] [stdout] 88 | fn get_sequence(input: &str) -> Sequence { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day9.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day9.rs:105:7 [INFO] [stdout] | [INFO] [stdout] 105 | const INPUTT: &str = "0 3 6 9 12 15 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day9.rs:109:7 [INFO] [stdout] | [INFO] [stdout] 109 | const INPUT: &str = "27 49 92 176 327 586 1039 1879 3511 6711 12850 24194 44291 78456 134365 222769 358339 560653 855336 1275364 18... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Side` is never used [INFO] [stdout] --> src/day10.rs:4:6 [INFO] [stdout] | [INFO] [stdout] 4 | enum Side { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Direction` is never constructed [INFO] [stdout] --> src/day10.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct Direction { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Map` is never used [INFO] [stdout] --> src/day10.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | type Map = HashMap; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Tunnel` is never constructed [INFO] [stdout] --> src/day10.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | struct Tunnel { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `move_start`, `set_position`, `next`, `traverse`, and `find_enclosed_area` are never used [INFO] [stdout] --> src/day10.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 28 | impl Tunnel { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] 29 | fn move_start(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | fn set_position(&mut self, position: (usize, usize)) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | fn next(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 113 | fn traverse(&mut self) -> usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 133 | fn find_enclosed_area(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_sides` is never used [INFO] [stdout] --> src/day10.rs:171:4 [INFO] [stdout] | [INFO] [stdout] 171 | fn get_sides(c: char) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `create_map` is never used [INFO] [stdout] --> src/day10.rs:185:4 [INFO] [stdout] | [INFO] [stdout] 185 | fn create_map(ip: &str) -> Tunnel { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day10.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day10.rs:224:7 [INFO] [stdout] | [INFO] [stdout] 224 | const INPUTT: &str = "..F7. [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT2` is never used [INFO] [stdout] --> src/day10.rs:230:7 [INFO] [stdout] | [INFO] [stdout] 230 | const INPUTT2: &str = "-L|F7 [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day10.rs:236:7 [INFO] [stdout] | [INFO] [stdout] 236 | const INPUT: &str = "FJ77.F7F.FF.F..7-J.7F|7-7-7-7FJJ-7J-LL-7FL.F-7.F-F77F7F7-77-F--7-FF|-F-L7-|.F7|7.F-77..-FF|--F.J7..|7FFL-JJ7-F... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Space` is never used [INFO] [stdout] --> src/day11.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | type Space = Vec>; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `expand` is never used [INFO] [stdout] --> src/day11.rs:5:4 [INFO] [stdout] | [INFO] [stdout] 5 | fn expand(space: &mut Space) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_expansions` is never used [INFO] [stdout] --> src/day11.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | fn get_expansions(space: &Space) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_galaxies` is never used [INFO] [stdout] --> src/day11.rs:89:4 [INFO] [stdout] | [INFO] [stdout] 89 | fn get_galaxies(space: &Space) -> Vec<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_distances` is never used [INFO] [stdout] --> src/day11.rs:103:4 [INFO] [stdout] | [INFO] [stdout] 103 | fn find_distances(p: &Vec<(usize,usize)>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_distances_with_expansions` is never used [INFO] [stdout] --> src/day11.rs:118:4 [INFO] [stdout] | [INFO] [stdout] 118 | fn find_distances_with_expansions(p: &Vec<(usize,usize)>, ex: (Vec, Vec)) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day11.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day11.rs:153:7 [INFO] [stdout] | [INFO] [stdout] 153 | const INPUTT: &str = "...#...... [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day11.rs:164:7 [INFO] [stdout] | [INFO] [stdout] 164 | const INPUT: &str = "...........#..........................#..................................................................#....... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Map` is never used [INFO] [stdout] --> src/day21.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | type Map = Vec>; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day21.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x`, `y`, and `z` are never read [INFO] [stdout] --> src/day22.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | struct CoOrd { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 2 | x: usize, [INFO] [stdout] | ^ [INFO] [stdout] 3 | y: usize, [INFO] [stdout] | ^ [INFO] [stdout] 4 | z: usize, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `start` and `end` are never read [INFO] [stdout] --> src/day22.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | struct Brick { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 7 | start: CoOrd, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 8 | end: CoOrd, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get` and `touching` are never used [INFO] [stdout] --> src/day22.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Brick { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn get(&self, direction: char) -> std::ops::Range { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn touching(&self, other: &Brick) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return first * 10 + last; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return first * 10 + last; [INFO] [stdout] 38 + first * 10 + last [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day1.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | return first * 10 + last; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return first * 10 + last; [INFO] [stdout] 79 + first * 10 + last [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day1.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/day1.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | for ch in iter { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `for (index, ch) in iter.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/day1.rs:59:33 [INFO] [stdout] | [INFO] [stdout] 59 | first = num.into(); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/day1.rs:60:32 [INFO] [stdout] | [INFO] [stdout] 60 | last = num.into(); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/day1.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | last = num.into(); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return 1; [INFO] [stdout] 86 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return 2; [INFO] [stdout] 88 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return 3; [INFO] [stdout] 90 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return 4; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return 4; [INFO] [stdout] 92 + 4 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | return 5; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return 5; [INFO] [stdout] 94 + 5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return 6; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return 6; [INFO] [stdout] 96 + 6 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return 7; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return 7; [INFO] [stdout] 98 + 7 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return 8; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return 8; [INFO] [stdout] 100 + 8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return 9; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return 9; [INFO] [stdout] 102 + 9 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return -1; [INFO] [stdout] 104 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day2.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return (id, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return (id, true); [INFO] [stdout] 39 + (id, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return least_balls.red * least_balls.green * least_balls.blue; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return least_balls.red * least_balls.green * least_balls.blue; [INFO] [stdout] 63 + least_balls.red * least_balls.green * least_balls.blue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | return balls; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return balls; [INFO] [stdout] 84 + balls [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day3.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | total = total + get_part_numbers(&symbols, &num_lines, i - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += get_part_numbers(&symbols, &num_lines, i - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day3.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | total = total + get_part_numbers(&symbols, &num_lines, num_lines.len() - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += get_part_numbers(&symbols, &num_lines, num_lines.len() - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day3.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return (num_lines, symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return (num_lines, symbols); [INFO] [stdout] 62 + (num_lines, symbols) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/day3.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | if ch.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `ch.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day3.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if num_string.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!num_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day3.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if num_string.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!num_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day3.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / return NumLine { [INFO] [stdout] 69 | | num, [INFO] [stdout] 70 | | start: end - num_str.len(), [INFO] [stdout] 71 | | end: end - 1, [INFO] [stdout] 72 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 ~ NumLine { [INFO] [stdout] 69 + num, [INFO] [stdout] 70 + start: end - num_str.len(), [INFO] [stdout] 71 + end: end - 1, [INFO] [stdout] 72 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day3.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | return parts; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return parts; [INFO] [stdout] 99 + parts [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day3.rs:76:14 [INFO] [stdout] | [INFO] [stdout] 76 | symbols: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - symbols: &Vec>, [INFO] [stdout] 76 + symbols: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day3.rs:77:16 [INFO] [stdout] | [INFO] [stdout] 77 | num_lines: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 77 - num_lines: &Vec>, [INFO] [stdout] 77 + num_lines: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day3.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return total; [INFO] [stdout] 117 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day3.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | fn get_total(num_lines: &Vec, index: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 102 - fn get_total(num_lines: &Vec, index: usize) -> usize { [INFO] [stdout] 102 + fn get_total(num_lines: &[NumLine], index: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/day4.rs:45:35 [INFO] [stdout] | [INFO] [stdout] 45 | total += if matches > 0 { (2 as u32).pow(matches - 1) } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day4.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return Card { id, winning, all }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Card { id, winning, all }; [INFO] [stdout] 72 + Card { id, winning, all } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day4.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if nums.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!nums.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day4.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if nums.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!nums.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day4.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | return matches; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return matches; [INFO] [stdout] 85 + matches [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/day4.rs:77:80 [INFO] [stdout] | [INFO] [stdout] 77 | let win_map: HashMap = card.winning.iter().map(move |num| (*num, 0 as u32)).collect(); [INFO] [stdout] | ^^^^^^^^ help: try: `0_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/day4.rs:80:16 [INFO] [stdout] | [INFO] [stdout] 80 | if let Some(_) = win_map.get(&num) { [INFO] [stdout] | -------^^^^^^^-------------------- help: try: `if win_map.get(&num).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day4.rs:80:38 [INFO] [stdout] | [INFO] [stdout] 80 | if let Some(_) = win_map.get(&num) { [INFO] [stdout] | ^^^^ help: change this to: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return value.destination + diff [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return value.destination + diff [INFO] [stdout] 20 + value.destination + diff [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/day5.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | let value = self.maps.iter() [INFO] [stdout] | _____________________^ [INFO] [stdout] 15 | | .find(|m| m.source <= num && m.source + m.range >= num) [INFO] [stdout] 16 | | .unwrap_or_else(|| &default); [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 16 - .unwrap_or_else(|| &default); [INFO] [stdout] 16 + .unwrap_or(&default); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return Mapper { maps }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return Mapper { maps }; [INFO] [stdout] 31 + Mapper { maps } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / return MapItem { [INFO] [stdout] 42 | | source, [INFO] [stdout] 43 | | destination, [INFO] [stdout] 44 | | range, [INFO] [stdout] 45 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 ~ MapItem { [INFO] [stdout] 42 + source, [INFO] [stdout] 43 + destination, [INFO] [stdout] 44 + range, [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return seeds; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return seeds; [INFO] [stdout] 90 + seeds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | return seeds.iter().map(|n| map.find(*n)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return seeds.iter().map(|n| map.find(*n)).collect(); [INFO] [stdout] 94 + seeds.iter().map(|n| map.find(*n)).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day5.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | fn update_seeds(seeds: &Vec, map: Mapper) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 93 - fn update_seeds(seeds: &Vec, map: Mapper) -> Vec { [INFO] [stdout] 93 + fn update_seeds(seeds: &[u64], map: Mapper) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day6.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return count; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return count; [INFO] [stdout] 53 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(Self { cards: set, points, ids: ids.iter().collect() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(Self { cards: set, points, ids: ids.iter().collect() }); [INFO] [stdout] 49 + Ok(Self { cards: set, points, ids: ids.iter().collect() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | return 7; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return 7; [INFO] [stdout] 56 + 7 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | return 5; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return 5; [INFO] [stdout] 62 + 5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return 3; [INFO] [stdout] 69 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return 2; [INFO] [stdout] 71 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 73 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return 1; [INFO] [stdout] 73 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Ordering::Greater; [INFO] [stdout] 83 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return Ordering::Less; [INFO] [stdout] 85 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return Ordering::Equal; [INFO] [stdout] 100 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | return h1.cmp(h2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return h1.cmp(h2) [INFO] [stdout] 113 + h1.cmp(h2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | return acc + ((i+1)* h.points) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return acc + ((i+1)* h.points) [INFO] [stdout] 119 + acc + ((i+1)* h.points) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(Self { cards: set, points, ids: ids.iter().collect() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(Self { cards: set, points, ids: ids.iter().collect() }); [INFO] [stdout] 69 + Ok(Self { cards: set, points, ids: ids.iter().collect() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | return 7; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return 7; [INFO] [stdout] 76 + 7 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | return 5; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return 5; [INFO] [stdout] 82 + 5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return 3; [INFO] [stdout] 89 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return 2; [INFO] [stdout] 91 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 93 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return 1; [INFO] [stdout] 93 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return Ordering::Greater; [INFO] [stdout] 103 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Ordering::Less; [INFO] [stdout] 105 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return Ordering::Equal; [INFO] [stdout] 120 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | return h1.cmp(h2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 - return h1.cmp(h2) [INFO] [stdout] 133 + h1.cmp(h2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return acc + ((i+1)* h.points) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return acc + ((i+1)* h.points) [INFO] [stdout] 138 + acc + ((i+1)* h.points) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return Ok(Self { l, r, k }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return Ok(Self { l, r, k }); [INFO] [stdout] 28 + Ok(Self { l, r, k }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return (p.k.to_owned(), p); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return (p.k.to_owned(), p); [INFO] [stdout] 49 + (p.k.to_owned(), p) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/day8.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | while key != "PPP".to_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `"PPP"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day8.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | total = total + t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `total += t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return (key, count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return (key, count); [INFO] [stdout] 82 + (key, count) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return (p.k.to_owned(), p); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return (p.k.to_owned(), p); [INFO] [stdout] 103 + (p.k.to_owned(), p) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day8.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | total = total + t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `total += t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | return acc; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return acc; [INFO] [stdout] 122 + acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual backwards iteration [INFO] [stdout] --> src/day8.rs:119:25 [INFO] [stdout] | [INFO] [stdout] 119 | if v.chars().rev().next().unwrap() == 'Z' { [INFO] [stdout] | ^^^^^^^^^^^^^ help: use: `.next_back()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_next_back [INFO] [stdout] = note: `#[warn(clippy::manual_next_back)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return (start_keys, count, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return (start_keys, count, false); [INFO] [stdout] 165 + (start_keys, count, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day6.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let mut distance_line = iter.next().unwrap().split(' ').filter(|x| *x != empty_string).skip(1); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day6.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | let mut result = 1; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return v.first().unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return v.first().unwrap().to_owned(); [INFO] [stdout] 9 + v.first().unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return v.last().unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return v.last().unwrap().to_owned(); [INFO] [stdout] 14 + v.last().unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return (Sequence::V(diff_sequence), is_same); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return (Sequence::V(diff_sequence), is_same); [INFO] [stdout] 34 + (Sequence::V(diff_sequence), is_same) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return last_nums.iter().fold(0, |acc, x| acc + x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return last_nums.iter().fold(0, |acc, x| acc + x); [INFO] [stdout] 59 + last_nums.iter().fold(0, |acc, x| acc + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/day9.rs:59:33 [INFO] [stdout] | [INFO] [stdout] 59 | return last_nums.iter().fold(0, |acc, x| acc + x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return last_nums.iter().rev().fold(0, |acc, x| x - acc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return last_nums.iter().rev().fold(0, |acc, x| x - acc); [INFO] [stdout] 84 + last_nums.iter().rev().fold(0, |acc, x| x - acc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | return Sequence::V(v) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return Sequence::V(v) [INFO] [stdout] 92 + Sequence::V(v) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/day9.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | let t = s.iter().fold(0, |acc, x| acc + x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day10.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return count; [INFO] [stdout] 130 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day10.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 167 - return 0; [INFO] [stdout] 167 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&(i,j)).is_none()` [INFO] [stdout] --> src/day10.rs:142:50 [INFO] [stdout] | [INFO] [stdout] 142 | let is_non_loop = self.positions.get(&(i,j)).is_none(); [INFO] [stdout] | ---------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.positions.contains_key(&(i,j))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day10.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | return v; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return v; [INFO] [stdout] 182 + v [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day10.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / return Tunnel { [INFO] [stdout] 202 | | start: s, [INFO] [stdout] 203 | | len: 0, [INFO] [stdout] 204 | | positions: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 207 | | size: (x_len, y_len), [INFO] [stdout] 208 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 ~ Tunnel { [INFO] [stdout] 202 + start: s, [INFO] [stdout] 203 + len: 0, [INFO] [stdout] 204 + positions: HashMap::new(), [INFO] [stdout] 205 + map, [INFO] [stdout] 206 + curr: (s.0, s.1, Side::Down), // random side [INFO] [stdout] 207 + size: (x_len, y_len), [INFO] [stdout] 208 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `keys` is never read [INFO] [stdout] --> src/day8.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | keys = k; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `total` is never read [INFO] [stdout] --> src/day8.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | total = total + t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `done` is never read [INFO] [stdout] --> src/day8.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | done = d; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | return *c == '#' || acc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return *c == '#' || acc; [INFO] [stdout] 15 + *c == '#' || acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `space` [INFO] [stdout] --> src/day11.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 35 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 35 - for i in 0..len { [INFO] [stdout] 35 + for (i, ) in space.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `space` [INFO] [stdout] --> src/day11.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | for j in 0..vert_len { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 37 - for j in 0..vert_len { [INFO] [stdout] 37 + for in space.iter().take(vert_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return (rows, cols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return (rows, cols); [INFO] [stdout] 86 + (rows, cols) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | return *c == '#' || acc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return *c == '#' || acc; [INFO] [stdout] 63 + *c == '#' || acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `space` [INFO] [stdout] --> src/day11.rs:76:14 [INFO] [stdout] | [INFO] [stdout] 76 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 76 - for i in 0..len { [INFO] [stdout] 76 + for (i, ) in space.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `depth` is assigned to, but never used [INFO] [stdout] --> src/day9.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | let mut depth = 2; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_depth` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `depth` is never read [INFO] [stdout] --> src/day9.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | depth += 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `depth` is assigned to, but never used [INFO] [stdout] --> src/day9.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | let mut depth = 2; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_depth` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `depth` is never read [INFO] [stdout] --> src/day9.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | depth += 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `space` [INFO] [stdout] --> src/day11.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | for j in 0..vert_len { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 78 - for j in 0..vert_len { [INFO] [stdout] 78 + for in space.iter().take(vert_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return result; [INFO] [stdout] 100 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return result; [INFO] [stdout] 115 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day11.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | fn find_distances(p: &Vec<(usize,usize)>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - fn find_distances(p: &Vec<(usize,usize)>) -> Vec { [INFO] [stdout] 103 + fn find_distances(p: &[(usize,usize)]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `p` [INFO] [stdout] --> src/day11.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | for j in (i + 1)..p.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 107 - for j in (i + 1)..p.len() { [INFO] [stdout] 107 + for in p.iter().skip((i + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return result; [INFO] [stdout] 135 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day11.rs:118:38 [INFO] [stdout] | [INFO] [stdout] 118 | fn find_distances_with_expansions(p: &Vec<(usize,usize)>, ex: (Vec, Vec)) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 118 - fn find_distances_with_expansions(p: &Vec<(usize,usize)>, ex: (Vec, Vec)) -> Vec { [INFO] [stdout] 118 + fn find_distances_with_expansions(p: &[(usize,usize)], ex: (Vec, Vec)) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `p` [INFO] [stdout] --> src/day11.rs:122:18 [INFO] [stdout] | [INFO] [stdout] 122 | for j in (i + 1)..p.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 122 - for j in (i + 1)..p.len() { [INFO] [stdout] 122 + for in p.iter().skip((i + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/day10.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | let x = self.curr.0 - 1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/day10.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | let y = self.curr.1; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/day21.rs:135:1 [INFO] [stdout] | [INFO] [stdout] 135 | mod test { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 150 | const TEST_INPUT: &str = "........... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 162 | const INPUT: &str = "................................................................................................................. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/day21.rs:1:73 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::{HashMap, HashSet}, sync::Arc, time::SystemTime, usize}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait [INFO] [stdout] --> src/day21.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | let pos = pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day21.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | return r; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return r; [INFO] [stdout] 30 + r [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `prev` is assigned to, but never used [INFO] [stdout] --> src/day10.rs:138:17 [INFO] [stdout] | [INFO] [stdout] 138 | let mut prev = None; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_prev` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day21.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | return valid_states; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return valid_states; [INFO] [stdout] 98 + valid_states [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `prev` is never read [INFO] [stdout] --> src/day10.rs:158:29 [INFO] [stdout] | [INFO] [stdout] 158 | ... prev = p.sides.iter().find(|s| s != &&Side::Right); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day21.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | fn travel(pos: Pos, map: &Vec>, pos_cache: &mut HashMap>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - fn travel(pos: Pos, map: &Vec>, pos_cache: &mut HashMap>) -> Vec { [INFO] [stdout] 51 + fn travel(pos: Pos, map: &[Vec], pos_cache: &mut HashMap>) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day21.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | return (map, start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return (map, start); [INFO] [stdout] 131 + (map, start) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/day21.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | for l in lines { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `for (i, l) in lines.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `j` is used as a loop counter [INFO] [stdout] --> src/day21.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | for c in l.chars() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, c) in l.chars().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/day11.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | let mut space: Space = ip.lines().map(|l| l.chars().collect()).collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day22.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / return Brick { [INFO] [stdout] 30 | | start: start_coord, [INFO] [stdout] 31 | | end: end_coord, [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Brick { [INFO] [stdout] 30 + start: start_coord, [INFO] [stdout] 31 + end: end_coord, [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day22.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 - return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] 58 + return !(!y_match || !x_match && !z_match) || (z_match && x_match); [INFO] [stdout] | [INFO] [stdout] 58 - return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] 58 + return (z_match || x_match) && y_match || (z_match && x_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day22.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] 58 + (x_match && y_match) || (y_match && z_match) || (z_match && x_match) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tower` [INFO] [stdout] --> src/day22.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | let tower = Brick::from_str(input); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_tower` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line` is never used [INFO] [stdout] --> src/day1.rs:14:4 [INFO] [stdout] | [INFO] [stdout] 14 | fn parse_line(line: &str) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT2T` is never used [INFO] [stdout] --> src/day1.rs:108:7 [INFO] [stdout] | [INFO] [stdout] 108 | const INPUT2T: &str = "two1nine [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day1.rs:116:7 [INFO] [stdout] | [INFO] [stdout] 116 | const INPUT: &str = "1abc2 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Balls` is never constructed [INFO] [stdout] --> src/day2.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | struct Balls { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day2.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line` is never used [INFO] [stdout] --> src/day2.rs:24:4 [INFO] [stdout] | [INFO] [stdout] 24 | fn parse_line(line: &str) -> (usize, bool) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line2` is never used [INFO] [stdout] --> src/day2.rs:42:4 [INFO] [stdout] | [INFO] [stdout] 42 | fn parse_line2(line: &str) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_game` is never used [INFO] [stdout] --> src/day2.rs:66:4 [INFO] [stdout] | [INFO] [stdout] 66 | fn parse_game(game: &str) -> Balls { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT1T` is never used [INFO] [stdout] --> src/day2.rs:87:7 [INFO] [stdout] | [INFO] [stdout] 87 | const INPUT1T: &str = "Game 1: 3 blue, 4 red; 1 red, 2 green, 6 blue; 2 green [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT1` is never used [INFO] [stdout] --> src/day2.rs:93:7 [INFO] [stdout] | [INFO] [stdout] 93 | const INPUT1: &str = "Game 1: 1 green, 2 blue; 13 red, 2 blue, 3 green; 4 green, 14 red [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NumLine` is never constructed [INFO] [stdout] --> src/day3.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | struct NumLine { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day3.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line` is never used [INFO] [stdout] --> src/day3.rs:37:4 [INFO] [stdout] | [INFO] [stdout] 37 | fn parse_line(line: &str) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_num_line` is never used [INFO] [stdout] --> src/day3.rs:65:4 [INFO] [stdout] | [INFO] [stdout] 65 | fn get_num_line(num_str: String, end: usize) -> NumLine { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_part_numbers` is never used [INFO] [stdout] --> src/day3.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | fn get_part_numbers( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_total` is never used [INFO] [stdout] --> src/day3.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | fn get_total(num_lines: &Vec, index: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day3.rs:120:7 [INFO] [stdout] | [INFO] [stdout] 120 | const INPUTT: &str = "467..114.. [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day3.rs:131:7 [INFO] [stdout] | [INFO] [stdout] 131 | const INPUT: &str = ".....613...................................439............498.........................438......617....343........ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Card` is never constructed [INFO] [stdout] --> src/day4.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Card { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day4.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve1` is never used [INFO] [stdout] --> src/day4.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn solve1() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_line` is never used [INFO] [stdout] --> src/day4.rs:52:4 [INFO] [stdout] | [INFO] [stdout] 52 | fn parse_line(line: &str) -> Card { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_matches` is never used [INFO] [stdout] --> src/day4.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | fn find_matches(card: &Card) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day4.rs:88:7 [INFO] [stdout] | [INFO] [stdout] 88 | const INPUTT: &str = "Card 1: 41 48 83 86 17 | 83 86 6 31 17 9 48 53 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day4.rs:95:7 [INFO] [stdout] | [INFO] [stdout] 95 | const INPUT: &str = "Card 1: 30 51 48 31 36 33 49 83 86 17 | 17 33 31 70 90 37 86 45 58 21 83 52 59 68 55 32 20 43 48 75 30 42 80 ... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Mapper` is never constructed [INFO] [stdout] --> src/day5.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct Mapper { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MapItem` is never constructed [INFO] [stdout] --> src/day5.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct MapItem { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `find`, `new`, and `parse_line` are never used [INFO] [stdout] --> src/day5.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | impl Mapper { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 12 | fn find(&self, num: u64) -> u64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | fn new(section: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | fn parse_line(line: &str) -> MapItem { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day5.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part_2_seeds` is never used [INFO] [stdout] --> src/day5.rs:74:4 [INFO] [stdout] | [INFO] [stdout] 74 | fn part_2_seeds(line: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `update_seeds` is never used [INFO] [stdout] --> src/day5.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn update_seeds(seeds: &Vec, map: Mapper) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day5.rs:98:7 [INFO] [stdout] | [INFO] [stdout] 98 | const INPUTT: &str = "seeds: 79 14 55 13 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day5.rs:132:7 [INFO] [stdout] | [INFO] [stdout] 132 | const INPUT: &str = "seeds: 3169137700 271717609 3522125441 23376095 1233948799 811833837 280549587 703867355 166086528 44766996 23... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Target` is never constructed [INFO] [stdout] --> src/day6.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | struct Target { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day6.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_valid_outcomes` is never used [INFO] [stdout] --> src/day6.rs:44:4 [INFO] [stdout] | [INFO] [stdout] 44 | fn get_valid_outcomes(target: &Target) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day6.rs:56:7 [INFO] [stdout] | [INFO] [stdout] 56 | const INPUTT: &str = "Time: 7 15 30 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day6.rs:59:7 [INFO] [stdout] | [INFO] [stdout] 59 | const INPUT: &str = "Time: 58 99 64 69 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Hand` is never constructed [INFO] [stdout] --> src/day7.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct Hand { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParseError` is never constructed [INFO] [stdout] --> src/day7.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct ParseError; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `rank` and `cmp` are never used [INFO] [stdout] --> src/day7.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 53 | impl Hand { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] 54 | fn rank(&self) -> u8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | fn cmp(&self, other: &Hand) -> Ordering { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day7.rs:105:8 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day7.rs:126:7 [INFO] [stdout] | [INFO] [stdout] 126 | const INPUTT: &str = "32T3K 765 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day7.rs:132:7 [INFO] [stdout] | [INFO] [stdout] 132 | const INPUT: &str = "K8KK6 75 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Hand` is never constructed [INFO] [stdout] --> src/day7_2.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct Hand { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ParseError` is never constructed [INFO] [stdout] --> src/day7_2.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct ParseError; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `rank` and `cmp` are never used [INFO] [stdout] --> src/day7_2.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 73 | impl Hand { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] 74 | fn rank(&self) -> u8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 97 | fn cmp(&self, other: &Hand) -> Ordering { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day7_2.rs:125:8 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day7_2.rs:145:7 [INFO] [stdout] | [INFO] [stdout] 145 | const INPUTT: &str = "32T3K 765 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day7_2.rs:151:7 [INFO] [stdout] | [INFO] [stdout] 151 | const INPUT: &str = "K8KK6 75 [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Postition` is never constructed [INFO] [stdout] --> src/day8.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Postition { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PositionParseError` is never constructed [INFO] [stdout] --> src/day8.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct PositionParseError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day8.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_path` is never used [INFO] [stdout] --> src/day8.rs:68:4 [INFO] [stdout] | [INFO] [stdout] 68 | fn find_path(seq: &str, start_key: &str, postions: &HashMap) -> (String, usize) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve2` is never used [INFO] [stdout] --> src/day8.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn solve2() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_paths` is never used [INFO] [stdout] --> src/day8.rs:134:4 [INFO] [stdout] | [INFO] [stdout] 134 | fn find_paths(seq: &str, mut start_keys: Vec, postions: &HashMap) -> (Vec, usize, bool) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day8.rs:168:7 [INFO] [stdout] | [INFO] [stdout] 168 | const INPUTT: &str = "RL [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT2` is never used [INFO] [stdout] --> src/day8.rs:178:7 [INFO] [stdout] | [INFO] [stdout] 178 | const INPUTT2: &str = "LLR [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT3` is never used [INFO] [stdout] --> src/day8.rs:184:7 [INFO] [stdout] | [INFO] [stdout] 184 | const INPUTT3: &str = "LR [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day8.rs:195:7 [INFO] [stdout] | [INFO] [stdout] 195 | const INPUT: &str = "LRLRLRLRRLRRRLRLRLRRRLLRRLRRLRRLLRRLRRLRLRRRLRRLLRRLRRRLRRLRRRLRRRLLLRRLLRLLRRRLLRRLRLLRLLRRRLLRRLRRLRRRLRRLRL... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Sequence` is never used [INFO] [stdout] --> src/day9.rs:2:6 [INFO] [stdout] | [INFO] [stdout] 2 | enum Sequence { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `first`, `last`, `get_diff`, `get_depth`, and `get_depth2` are never used [INFO] [stdout] --> src/day9.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 6 | impl Sequence { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] 7 | fn first(&self) -> i64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | fn last(&self) -> i64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 17 | fn get_diff(&self) -> (Sequence, bool) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | fn get_depth(&self) -> i64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | fn get_depth2(&self) -> i64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_sequence` is never used [INFO] [stdout] --> src/day9.rs:88:4 [INFO] [stdout] | [INFO] [stdout] 88 | fn get_sequence(input: &str) -> Sequence { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day9.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day9.rs:105:7 [INFO] [stdout] | [INFO] [stdout] 105 | const INPUTT: &str = "0 3 6 9 12 15 [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day9.rs:109:7 [INFO] [stdout] | [INFO] [stdout] 109 | const INPUT: &str = "27 49 92 176 327 586 1039 1879 3511 6711 12850 24194 44291 78456 134365 222769 358339 560653 855336 1275364 18... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Side` is never used [INFO] [stdout] --> src/day10.rs:4:6 [INFO] [stdout] | [INFO] [stdout] 4 | enum Side { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Direction` is never constructed [INFO] [stdout] --> src/day10.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | struct Direction { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Map` is never used [INFO] [stdout] --> src/day10.rs:16:6 [INFO] [stdout] | [INFO] [stdout] 16 | type Map = HashMap; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Tunnel` is never constructed [INFO] [stdout] --> src/day10.rs:19:8 [INFO] [stdout] | [INFO] [stdout] 19 | struct Tunnel { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `move_start`, `set_position`, `next`, `traverse`, and `find_enclosed_area` are never used [INFO] [stdout] --> src/day10.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 28 | impl Tunnel { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] 29 | fn move_start(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | fn set_position(&mut self, position: (usize, usize)) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | fn next(&mut self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 113 | fn traverse(&mut self) -> usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 133 | fn find_enclosed_area(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_sides` is never used [INFO] [stdout] --> src/day10.rs:171:4 [INFO] [stdout] | [INFO] [stdout] 171 | fn get_sides(c: char) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `create_map` is never used [INFO] [stdout] --> src/day10.rs:185:4 [INFO] [stdout] | [INFO] [stdout] 185 | fn create_map(ip: &str) -> Tunnel { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day10.rs:211:8 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day10.rs:224:7 [INFO] [stdout] | [INFO] [stdout] 224 | const INPUTT: &str = "..F7. [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT2` is never used [INFO] [stdout] --> src/day10.rs:230:7 [INFO] [stdout] | [INFO] [stdout] 230 | const INPUTT2: &str = "-L|F7 [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day10.rs:236:7 [INFO] [stdout] | [INFO] [stdout] 236 | const INPUT: &str = "FJ77.F7F.FF.F..7-J.7F|7-7-7-7FJJ-7J-LL-7FL.F-7.F-F77F7F7-77-F--7-FF|-F-L7-|.F7|7.F-77..-FF|--F.J7..|7FFL-JJ7-F... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Space` is never used [INFO] [stdout] --> src/day11.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | type Space = Vec>; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `expand` is never used [INFO] [stdout] --> src/day11.rs:5:4 [INFO] [stdout] | [INFO] [stdout] 5 | fn expand(space: &mut Space) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_expansions` is never used [INFO] [stdout] --> src/day11.rs:53:4 [INFO] [stdout] | [INFO] [stdout] 53 | fn get_expansions(space: &Space) -> (Vec, Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_galaxies` is never used [INFO] [stdout] --> src/day11.rs:89:4 [INFO] [stdout] | [INFO] [stdout] 89 | fn get_galaxies(space: &Space) -> Vec<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_distances` is never used [INFO] [stdout] --> src/day11.rs:103:4 [INFO] [stdout] | [INFO] [stdout] 103 | fn find_distances(p: &Vec<(usize,usize)>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_distances_with_expansions` is never used [INFO] [stdout] --> src/day11.rs:118:4 [INFO] [stdout] | [INFO] [stdout] 118 | fn find_distances_with_expansions(p: &Vec<(usize,usize)>, ex: (Vec, Vec)) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day11.rs:138:8 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUTT` is never used [INFO] [stdout] --> src/day11.rs:153:7 [INFO] [stdout] | [INFO] [stdout] 153 | const INPUTT: &str = "...#...... [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day11.rs:164:7 [INFO] [stdout] | [INFO] [stdout] 164 | const INPUT: &str = "...........#..........................#..................................................................#....... [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Tile` is never used [INFO] [stdout] --> src/day21.rs:5:6 [INFO] [stdout] | [INFO] [stdout] 5 | enum Tile { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Map` is never used [INFO] [stdout] --> src/day21.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | type Map = Vec>; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Pos` is never used [INFO] [stdout] --> src/day21.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 10 | type Pos = (i32, i32); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solve` is never used [INFO] [stdout] --> src/day21.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn solve() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `travel` is never used [INFO] [stdout] --> src/day21.rs:51:4 [INFO] [stdout] | [INFO] [stdout] 51 | fn travel(pos: Pos, map: &Vec>, pos_cache: &mut HashMap>) -> Vec { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse` is never used [INFO] [stdout] --> src/day21.rs:101:4 [INFO] [stdout] | [INFO] [stdout] 101 | fn parse() -> (Vec>, Pos) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `TEST_INPUT` is never used [INFO] [stdout] --> src/day21.rs:150:7 [INFO] [stdout] | [INFO] [stdout] 150 | const TEST_INPUT: &str = "........... [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INPUT` is never used [INFO] [stdout] --> src/day21.rs:162:7 [INFO] [stdout] | [INFO] [stdout] 162 | const INPUT: &str = "................................................................................................................. [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `x`, `y`, and `z` are never read [INFO] [stdout] --> src/day22.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | struct CoOrd { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 2 | x: usize, [INFO] [stdout] | ^ [INFO] [stdout] 3 | y: usize, [INFO] [stdout] | ^ [INFO] [stdout] 4 | z: usize, [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `start` and `end` are never read [INFO] [stdout] --> src/day22.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | struct Brick { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 7 | start: CoOrd, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 8 | end: CoOrd, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get` and `touching` are never used [INFO] [stdout] --> src/day22.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl Brick { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn get(&self, direction: char) -> std::ops::Range { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn touching(&self, other: &Brick) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return first * 10 + last; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return first * 10 + last; [INFO] [stdout] 38 + first * 10 + last [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day1.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | return first * 10 + last; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return first * 10 + last; [INFO] [stdout] 79 + first * 10 + last [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day1.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/day1.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | for ch in iter { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `for (index, ch) in iter.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/day1.rs:59:33 [INFO] [stdout] | [INFO] [stdout] 59 | first = num.into(); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/day1.rs:60:32 [INFO] [stdout] | [INFO] [stdout] 60 | last = num.into(); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i64` [INFO] [stdout] --> src/day1.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | last = num.into(); [INFO] [stdout] | ^^^^^^^^^^ help: consider removing `.into()`: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return 1; [INFO] [stdout] 86 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return 2; [INFO] [stdout] 88 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return 3; [INFO] [stdout] 90 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return 4; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return 4; [INFO] [stdout] 92 + 4 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | return 5; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return 5; [INFO] [stdout] 94 + 5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return 6; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return 6; [INFO] [stdout] 96 + 6 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return 7; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return 7; [INFO] [stdout] 98 + 7 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return 8; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return 8; [INFO] [stdout] 100 + 8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return 9; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return 9; [INFO] [stdout] 102 + 9 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day1.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return -1; [INFO] [stdout] 104 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day2.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return (id, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return (id, true); [INFO] [stdout] 39 + (id, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return least_balls.red * least_balls.green * least_balls.blue; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return least_balls.red * least_balls.green * least_balls.blue; [INFO] [stdout] 63 + least_balls.red * least_balls.green * least_balls.blue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | return balls; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return balls; [INFO] [stdout] 84 + balls [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day3.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | total = total + get_part_numbers(&symbols, &num_lines, i - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += get_part_numbers(&symbols, &num_lines, i - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day3.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | total = total + get_part_numbers(&symbols, &num_lines, num_lines.len() - 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += get_part_numbers(&symbols, &num_lines, num_lines.len() - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day3.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return (num_lines, symbols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return (num_lines, symbols); [INFO] [stdout] 62 + (num_lines, symbols) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/day3.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | if ch.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `ch.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day3.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if num_string.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!num_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day3.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if num_string.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!num_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day3.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / return NumLine { [INFO] [stdout] 69 | | num, [INFO] [stdout] 70 | | start: end - num_str.len(), [INFO] [stdout] 71 | | end: end - 1, [INFO] [stdout] 72 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 ~ NumLine { [INFO] [stdout] 69 + num, [INFO] [stdout] 70 + start: end - num_str.len(), [INFO] [stdout] 71 + end: end - 1, [INFO] [stdout] 72 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day3.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | return parts; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return parts; [INFO] [stdout] 99 + parts [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day3.rs:76:14 [INFO] [stdout] | [INFO] [stdout] 76 | symbols: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - symbols: &Vec>, [INFO] [stdout] 76 + symbols: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day3.rs:77:16 [INFO] [stdout] | [INFO] [stdout] 77 | num_lines: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 77 - num_lines: &Vec>, [INFO] [stdout] 77 + num_lines: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day3.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return total; [INFO] [stdout] 117 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day3.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 102 | fn get_total(num_lines: &Vec, index: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 102 - fn get_total(num_lines: &Vec, index: usize) -> usize { [INFO] [stdout] 102 + fn get_total(num_lines: &[NumLine], index: usize) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/day4.rs:45:35 [INFO] [stdout] | [INFO] [stdout] 45 | total += if matches > 0 { (2 as u32).pow(matches - 1) } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day4.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return Card { id, winning, all }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Card { id, winning, all }; [INFO] [stdout] 72 + Card { id, winning, all } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day4.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if nums.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!nums.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day4.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if nums.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!nums.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day4.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | return matches; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return matches; [INFO] [stdout] 85 + matches [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u32` is unnecessary [INFO] [stdout] --> src/day4.rs:77:80 [INFO] [stdout] | [INFO] [stdout] 77 | let win_map: HashMap = card.winning.iter().map(move |num| (*num, 0 as u32)).collect(); [INFO] [stdout] | ^^^^^^^^ help: try: `0_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/day4.rs:80:16 [INFO] [stdout] | [INFO] [stdout] 80 | if let Some(_) = win_map.get(&num) { [INFO] [stdout] | -------^^^^^^^-------------------- help: try: `if win_map.get(&num).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day4.rs:80:38 [INFO] [stdout] | [INFO] [stdout] 80 | if let Some(_) = win_map.get(&num) { [INFO] [stdout] | ^^^^ help: change this to: `num` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return value.destination + diff [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return value.destination + diff [INFO] [stdout] 20 + value.destination + diff [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/day5.rs:14:21 [INFO] [stdout] | [INFO] [stdout] 14 | let value = self.maps.iter() [INFO] [stdout] | _____________________^ [INFO] [stdout] 15 | | .find(|m| m.source <= num && m.source + m.range >= num) [INFO] [stdout] 16 | | .unwrap_or_else(|| &default); [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 16 - .unwrap_or_else(|| &default); [INFO] [stdout] 16 + .unwrap_or(&default); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return Mapper { maps }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return Mapper { maps }; [INFO] [stdout] 31 + Mapper { maps } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / return MapItem { [INFO] [stdout] 42 | | source, [INFO] [stdout] 43 | | destination, [INFO] [stdout] 44 | | range, [INFO] [stdout] 45 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 ~ MapItem { [INFO] [stdout] 42 + source, [INFO] [stdout] 43 + destination, [INFO] [stdout] 44 + range, [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return seeds; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return seeds; [INFO] [stdout] 90 + seeds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | return seeds.iter().map(|n| map.find(*n)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return seeds.iter().map(|n| map.find(*n)).collect(); [INFO] [stdout] 94 + seeds.iter().map(|n| map.find(*n)).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day5.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | fn update_seeds(seeds: &Vec, map: Mapper) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 93 - fn update_seeds(seeds: &Vec, map: Mapper) -> Vec { [INFO] [stdout] 93 + fn update_seeds(seeds: &[u64], map: Mapper) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day6.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | return count; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return count; [INFO] [stdout] 53 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(Self { cards: set, points, ids: ids.iter().collect() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(Self { cards: set, points, ids: ids.iter().collect() }); [INFO] [stdout] 49 + Ok(Self { cards: set, points, ids: ids.iter().collect() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | return 7; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return 7; [INFO] [stdout] 56 + 7 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | return 5; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return 5; [INFO] [stdout] 62 + 5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return 3; [INFO] [stdout] 69 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return 2; [INFO] [stdout] 71 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:73:14 [INFO] [stdout] | [INFO] [stdout] 73 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return 1; [INFO] [stdout] 73 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Ordering::Greater; [INFO] [stdout] 83 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return Ordering::Less; [INFO] [stdout] 85 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return Ordering::Equal; [INFO] [stdout] 100 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | return h1.cmp(h2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return h1.cmp(h2) [INFO] [stdout] 113 + h1.cmp(h2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | return acc + ((i+1)* h.points) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return acc + ((i+1)* h.points) [INFO] [stdout] 119 + acc + ((i+1)* h.points) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return Ok(Self { cards: set, points, ids: ids.iter().collect() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(Self { cards: set, points, ids: ids.iter().collect() }); [INFO] [stdout] 69 + Ok(Self { cards: set, points, ids: ids.iter().collect() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | return 7; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return 7; [INFO] [stdout] 76 + 7 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | return 5; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return 5; [INFO] [stdout] 82 + 5 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return 3; [INFO] [stdout] 89 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return 2; [INFO] [stdout] 91 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 93 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return 1; [INFO] [stdout] 93 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:103:13 [INFO] [stdout] | [INFO] [stdout] 103 | return Ordering::Greater; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return Ordering::Greater; [INFO] [stdout] 103 + Ordering::Greater [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | return Ordering::Less; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Ordering::Less; [INFO] [stdout] 105 + Ordering::Less [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | return Ordering::Equal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return Ordering::Equal; [INFO] [stdout] 120 + Ordering::Equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | return h1.cmp(h2) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 - return h1.cmp(h2) [INFO] [stdout] 133 + h1.cmp(h2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day7_2.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return acc + ((i+1)* h.points) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return acc + ((i+1)* h.points) [INFO] [stdout] 138 + acc + ((i+1)* h.points) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return Ok(Self { l, r, k }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return Ok(Self { l, r, k }); [INFO] [stdout] 28 + Ok(Self { l, r, k }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return (p.k.to_owned(), p); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return (p.k.to_owned(), p); [INFO] [stdout] 49 + (p.k.to_owned(), p) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/day8.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 54 | while key != "PPP".to_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `"PPP"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day8.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | total = total + t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `total += t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return (key, count); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return (key, count); [INFO] [stdout] 82 + (key, count) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return (p.k.to_owned(), p); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return (p.k.to_owned(), p); [INFO] [stdout] 103 + (p.k.to_owned(), p) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day8.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | total = total + t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `total += t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | return acc; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return acc; [INFO] [stdout] 122 + acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual backwards iteration [INFO] [stdout] --> src/day8.rs:119:25 [INFO] [stdout] | [INFO] [stdout] 119 | if v.chars().rev().next().unwrap() == 'Z' { [INFO] [stdout] | ^^^^^^^^^^^^^ help: use: `.next_back()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_next_back [INFO] [stdout] = note: `#[warn(clippy::manual_next_back)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day8.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return (start_keys, count, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return (start_keys, count, false); [INFO] [stdout] 165 + (start_keys, count, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return v.first().unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return v.first().unwrap().to_owned(); [INFO] [stdout] 9 + v.first().unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return v.last().unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return v.last().unwrap().to_owned(); [INFO] [stdout] 14 + v.last().unwrap().to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return (Sequence::V(diff_sequence), is_same); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return (Sequence::V(diff_sequence), is_same); [INFO] [stdout] 34 + (Sequence::V(diff_sequence), is_same) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return last_nums.iter().fold(0, |acc, x| acc + x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return last_nums.iter().fold(0, |acc, x| acc + x); [INFO] [stdout] 59 + last_nums.iter().fold(0, |acc, x| acc + x) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/day9.rs:59:33 [INFO] [stdout] | [INFO] [stdout] 59 | return last_nums.iter().fold(0, |acc, x| acc + x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return last_nums.iter().rev().fold(0, |acc, x| x - acc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return last_nums.iter().rev().fold(0, |acc, x| x - acc); [INFO] [stdout] 84 + last_nums.iter().rev().fold(0, |acc, x| x - acc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day9.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | return Sequence::V(v) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return Sequence::V(v) [INFO] [stdout] 92 + Sequence::V(v) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/day9.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | let t = s.iter().fold(0, |acc, x| acc + x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day10.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return count; [INFO] [stdout] 130 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day10.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 167 - return 0; [INFO] [stdout] 167 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&(i,j)).is_none()` [INFO] [stdout] --> src/day10.rs:142:50 [INFO] [stdout] | [INFO] [stdout] 142 | let is_non_loop = self.positions.get(&(i,j)).is_none(); [INFO] [stdout] | ---------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.positions.contains_key(&(i,j))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day10.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 182 | return v; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 182 - return v; [INFO] [stdout] 182 + v [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day10.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / return Tunnel { [INFO] [stdout] 202 | | start: s, [INFO] [stdout] 203 | | len: 0, [INFO] [stdout] 204 | | positions: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 207 | | size: (x_len, y_len), [INFO] [stdout] 208 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 ~ Tunnel { [INFO] [stdout] 202 + start: s, [INFO] [stdout] 203 + len: 0, [INFO] [stdout] 204 + positions: HashMap::new(), [INFO] [stdout] 205 + map, [INFO] [stdout] 206 + curr: (s.0, s.1, Side::Down), // random side [INFO] [stdout] 207 + size: (x_len, y_len), [INFO] [stdout] 208 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | return *c == '#' || acc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return *c == '#' || acc; [INFO] [stdout] 15 + *c == '#' || acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `space` [INFO] [stdout] --> src/day11.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 35 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 35 - for i in 0..len { [INFO] [stdout] 35 + for (i, ) in space.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `space` [INFO] [stdout] --> src/day11.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | for j in 0..vert_len { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 37 - for j in 0..vert_len { [INFO] [stdout] 37 + for in space.iter().take(vert_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return (rows, cols); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return (rows, cols); [INFO] [stdout] 86 + (rows, cols) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | return *c == '#' || acc; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return *c == '#' || acc; [INFO] [stdout] 63 + *c == '#' || acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `space` [INFO] [stdout] --> src/day11.rs:76:14 [INFO] [stdout] | [INFO] [stdout] 76 | for i in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 76 - for i in 0..len { [INFO] [stdout] 76 + for (i, ) in space.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `space` [INFO] [stdout] --> src/day11.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 78 | for j in 0..vert_len { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 78 - for j in 0..vert_len { [INFO] [stdout] 78 + for in space.iter().take(vert_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return result; [INFO] [stdout] 100 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return result; [INFO] [stdout] 115 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day11.rs:103:22 [INFO] [stdout] | [INFO] [stdout] 103 | fn find_distances(p: &Vec<(usize,usize)>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - fn find_distances(p: &Vec<(usize,usize)>) -> Vec { [INFO] [stdout] 103 + fn find_distances(p: &[(usize,usize)]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `p` [INFO] [stdout] --> src/day11.rs:107:18 [INFO] [stdout] | [INFO] [stdout] 107 | for j in (i + 1)..p.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 107 - for j in (i + 1)..p.len() { [INFO] [stdout] 107 + for in p.iter().skip((i + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day11.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return result; [INFO] [stdout] 135 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day11.rs:118:38 [INFO] [stdout] | [INFO] [stdout] 118 | fn find_distances_with_expansions(p: &Vec<(usize,usize)>, ex: (Vec, Vec)) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 118 - fn find_distances_with_expansions(p: &Vec<(usize,usize)>, ex: (Vec, Vec)) -> Vec { [INFO] [stdout] 118 + fn find_distances_with_expansions(p: &[(usize,usize)], ex: (Vec, Vec)) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `p` [INFO] [stdout] --> src/day11.rs:122:18 [INFO] [stdout] | [INFO] [stdout] 122 | for j in (i + 1)..p.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 122 - for j in (i + 1)..p.len() { [INFO] [stdout] 122 + for in p.iter().skip((i + 1)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/day21.rs:1:73 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::{HashMap, HashSet}, sync::Arc, time::SystemTime, usize}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(i32, i32)` which implements the `Copy` trait [INFO] [stdout] --> src/day21.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | let pos = pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day21.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | return r; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return r; [INFO] [stdout] 30 + r [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day21.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | return valid_states; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return valid_states; [INFO] [stdout] 98 + valid_states [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day21.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | fn travel(pos: Pos, map: &Vec>, pos_cache: &mut HashMap>) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - fn travel(pos: Pos, map: &Vec>, pos_cache: &mut HashMap>) -> Vec { [INFO] [stdout] 51 + fn travel(pos: Pos, map: &[Vec], pos_cache: &mut HashMap>) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day21.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | return (map, start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return (map, start); [INFO] [stdout] 131 + (map, start) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/day21.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | for l in lines { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `for (i, l) in lines.enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `j` is used as a loop counter [INFO] [stdout] --> src/day21.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | for c in l.chars() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, c) in l.chars().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day22.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / return Brick { [INFO] [stdout] 30 | | start: start_coord, [INFO] [stdout] 31 | | end: end_coord, [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Brick { [INFO] [stdout] 30 + start: start_coord, [INFO] [stdout] 31 + end: end_coord, [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day22.rs:58:16 [INFO] [stdout] | [INFO] [stdout] 58 | return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 - return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] 58 + return !(!y_match || !x_match && !z_match) || (z_match && x_match); [INFO] [stdout] | [INFO] [stdout] 58 - return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] 58 + return (z_match || x_match) && y_match || (z_match && x_match); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day22.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return (x_match && y_match) || (y_match && z_match) || (z_match && x_match); [INFO] [stdout] 58 + (x_match && y_match) || (y_match && z_match) || (z_match && x_match) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `Command { std: "docker" "inspect" "53348b347b2b37d920818b1916c90cdba06f4b32e62add05828b869bd782e119", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53348b347b2b37d920818b1916c90cdba06f4b32e62add05828b869bd782e119", kill_on_drop: false }` [INFO] [stdout] 53348b347b2b37d920818b1916c90cdba06f4b32e62add05828b869bd782e119