[INFO] cloning repository https://github.com/mjvmroz/dish-scraper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mjvmroz/dish-scraper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmjvmroz%2Fdish-scraper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmjvmroz%2Fdish-scraper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 21de3fdfee84479b947180d11599d46f2b26cd64 [INFO] linting mjvmroz/dish-scraper against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmjvmroz%2Fdish-scraper" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-7-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/mjvmroz/dish-scraper [INFO] finished tweaking git repo https://github.com/mjvmroz/dish-scraper [INFO] tweaked toml for git repo https://github.com/mjvmroz/dish-scraper written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mjvmroz/dish-scraper on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mjvmroz/dish-scraper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dtoa-short v0.3.3 [INFO] [stderr] Downloaded itoa v1.0.5 [INFO] [stderr] Downloaded ego-tree v0.6.2 [INFO] [stderr] Downloaded scraper v0.19.0 [INFO] [stderr] Downloaded futures-task v0.3.26 [INFO] [stderr] Downloaded futures-core v0.3.26 [INFO] [stderr] Downloaded cxxbridge-flags v1.0.91 [INFO] [stderr] Downloaded scratch v1.0.4 [INFO] [stderr] Downloaded futures-sink v0.3.26 [INFO] [stderr] Downloaded ryu v1.0.12 [INFO] [stderr] Downloaded daggy v0.8.0 [INFO] [stderr] Downloaded unicode-bidi v0.3.10 [INFO] [stderr] Downloaded cxxbridge-macro v1.0.91 [INFO] [stderr] Downloaded openssl-sys v0.9.80 [INFO] [stderr] Downloaded cxx-build v1.0.91 [INFO] [stderr] Downloaded rust_decimal v1.35.0 [INFO] [stderr] Downloaded hyper v1.2.0 [INFO] [stderr] Downloaded futures-util v0.3.26 [INFO] [stderr] Downloaded h2 v0.4.3 [INFO] [stderr] Downloaded cxx v1.0.91 [INFO] [stderr] Downloaded reqwest v0.12.2 [INFO] [stderr] Downloaded quick-xml v0.27.1 [INFO] [stderr] Downloaded openssl v0.10.45 [INFO] [stderr] Downloaded chrono v0.4.37 [INFO] [stderr] Downloaded darling_core v0.14.3 [INFO] [stderr] Downloaded serde_json v1.0.93 [INFO] [stderr] Downloaded derive_builder v0.12.0 [INFO] [stderr] Downloaded rss v2.0.2 [INFO] [stderr] Downloaded serde v1.0.152 [INFO] [stderr] Downloaded dtparse v2.0.0 [INFO] [stderr] Downloaded futures-channel v0.3.26 [INFO] [stderr] Downloaded atom_syndication v0.12.0 [INFO] [stderr] Downloaded darling v0.14.3 [INFO] [stderr] Downloaded derive_builder_core v0.12.0 [INFO] [stderr] Downloaded serde_derive v1.0.152 [INFO] [stderr] Downloaded diligent-date-parser v0.1.4 [INFO] [stderr] Downloaded darling_macro v0.14.3 [INFO] [stderr] Downloaded derive_builder_macro v0.12.0 [INFO] [stderr] Downloaded tokio v1.25.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4707ba1527daffd51d439e0af4e0d524247b4fc7e1dacf4e569f9fd616183a54 [INFO] running `Command { std: "docker" "start" "-a" "4707ba1527daffd51d439e0af4e0d524247b4fc7e1dacf4e569f9fd616183a54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4707ba1527daffd51d439e0af4e0d524247b4fc7e1dacf4e569f9fd616183a54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4707ba1527daffd51d439e0af4e0d524247b4fc7e1dacf4e569f9fd616183a54", kill_on_drop: false }` [INFO] [stdout] 4707ba1527daffd51d439e0af4e0d524247b4fc7e1dacf4e569f9fd616183a54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55663a00faed2a1a55bef367e0723158f9b09e1d63dde3446db3de2934199311 [INFO] running `Command { std: "docker" "start" "-a" "55663a00faed2a1a55bef367e0723158f9b09e1d63dde3446db3de2934199311", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling serde_derive v1.0.152 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Checking itoa v1.0.5 [INFO] [stderr] Compiling futures-core v0.3.26 [INFO] [stderr] Compiling tokio v1.25.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling futures-task v0.3.26 [INFO] [stderr] Compiling openssl-sys v0.9.80 [INFO] [stderr] Checking tracing-core v0.1.30 [INFO] [stderr] Compiling futures-util v0.3.26 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking futures-sink v0.3.26 [INFO] [stderr] Compiling futures-channel v0.3.26 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling openssl v0.10.45 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking unicode-bidi v0.3.10 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking ryu v1.0.12 [INFO] [stderr] Compiling serde_json v1.0.93 [INFO] [stderr] Checking dtoa-short v0.3.3 [INFO] [stderr] Compiling rust_decimal v1.35.0 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking indexmap v1.9.2 [INFO] [stderr] Checking quick-xml v0.27.1 [INFO] [stderr] Checking parking_lot_core v0.9.7 [INFO] [stderr] Checking mio v0.8.6 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking getrandom v0.2.8 [INFO] [stderr] Checking never v0.1.0 [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Checking base64 v0.21.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking petgraph v0.6.3 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking ipnet v2.7.1 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Checking daggy v0.8.0 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Compiling darling_core v0.14.3 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling darling_macro v0.14.3 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Compiling darling v0.14.3 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking tokio-util v0.7.7 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.3 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking string_cache v0.8.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking diligent-date-parser v0.1.4 [INFO] [stderr] Checking dtparse v2.0.0 [INFO] [stderr] Checking atom_syndication v0.12.0 [INFO] [stderr] Checking rss v2.0.2 [INFO] [stderr] Checking scraper v0.19.0 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.2 [INFO] [stderr] Checking dish-graph v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/dish/edge_filter.rs:17:19 [INFO] [stdout] | [INFO] [stdout] 17 | sorted_links: &Vec<(usize, HashSet)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - sorted_links: &Vec<(usize, HashSet)>, [INFO] [stdout] 17 + sorted_links: &[(usize, HashSet)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/dish/edge_filter.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | let idx = visited [INFO] [stdout] | _______________________^ [INFO] [stdout] 105 | | .get(&source) [INFO] [stdout] 106 | | .or_else(|| visited.get(&target)) [INFO] [stdout] 107 | | .map(|i| *i); [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 104 ~ let idx = visited [INFO] [stdout] 105 + .get(&source) [INFO] [stdout] 106 ~ .or_else(|| visited.get(&target)).copied(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/dish/edge_filter.rs:129:28 [INFO] [stdout] | [INFO] [stdout] 129 | Subnetworks::from_iter(tred.into_iter()).networks [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:152:20 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 129 - Subnetworks::from_iter(tred.into_iter()).networks [INFO] [stdout] 129 + Subnetworks::from_iter(tred).networks [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !fs::metadata("output").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("output").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/dish/edge_filter.rs:17:19 [INFO] [stdout] | [INFO] [stdout] 17 | sorted_links: &Vec<(usize, HashSet)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - sorted_links: &Vec<(usize, HashSet)>, [INFO] [stdout] 17 + sorted_links: &[(usize, HashSet)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/dish/edge_filter.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | let idx = visited [INFO] [stdout] | _______________________^ [INFO] [stdout] 105 | | .get(&source) [INFO] [stdout] 106 | | .or_else(|| visited.get(&target)) [INFO] [stdout] 107 | | .map(|i| *i); [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 104 ~ let idx = visited [INFO] [stdout] 105 + .get(&source) [INFO] [stdout] 106 ~ .or_else(|| visited.get(&target)).copied(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/dish/edge_filter.rs:129:28 [INFO] [stdout] | [INFO] [stdout] 129 | Subnetworks::from_iter(tred.into_iter()).networks [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:152:20 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 129 - Subnetworks::from_iter(tred.into_iter()).networks [INFO] [stdout] 129 + Subnetworks::from_iter(tred).networks [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !fs::metadata("output").await.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("output").await.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.80s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.45 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "55663a00faed2a1a55bef367e0723158f9b09e1d63dde3446db3de2934199311", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55663a00faed2a1a55bef367e0723158f9b09e1d63dde3446db3de2934199311", kill_on_drop: false }` [INFO] [stdout] 55663a00faed2a1a55bef367e0723158f9b09e1d63dde3446db3de2934199311