[INFO] cloning repository https://github.com/milen-denev/audio-player-android [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/milen-denev/audio-player-android" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmilen-denev%2Faudio-player-android", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmilen-denev%2Faudio-player-android'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 431bfe15afc38c838fe1ddbd7d0a15d909510376 [INFO] linting milen-denev/audio-player-android against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmilen-denev%2Faudio-player-android" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/milen-denev/audio-player-android [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/milen-denev/audio-player-android [INFO] tweaked toml for git repo https://github.com/milen-denev/audio-player-android written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/milen-denev/audio-player-android on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/milen-denev/audio-player-android already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded symphonia v0.5.4 [INFO] [stderr] Downloaded symphonia-metadata v0.5.4 [INFO] [stderr] Downloaded symphonia-format-caf v0.5.4 [INFO] [stderr] Downloaded symphonia-format-mkv v0.5.4 [INFO] [stderr] Downloaded symphonia-format-isomp4 v0.5.4 [INFO] [stderr] Downloaded symphonia-codec-adpcm v0.5.4 [INFO] [stderr] Downloaded zvariant_derive v5.7.0 [INFO] [stderr] Downloaded symphonia-codec-alac v0.5.4 [INFO] [stderr] Downloaded windows-implement v0.60.1 [INFO] [stderr] Downloaded windows-interface v0.59.2 [INFO] [stderr] Downloaded symphonia-codec-pcm v0.5.4 [INFO] [stderr] Downloaded symphonia-utils-xiph v0.5.4 [INFO] [stderr] Downloaded dwrote v0.11.4 [INFO] [stderr] Downloaded toml_writer v1.0.3 [INFO] [stderr] Downloaded zbus_macros v5.11.0 [INFO] [stderr] Downloaded slint-build v1.13.1 [INFO] [stderr] Downloaded i-slint-backend-linuxkms v1.13.1 [INFO] [stderr] Downloaded skia-bindings v0.87.0 [INFO] [stderr] Downloaded i-slint-renderer-skia v1.13.1 [INFO] [stderr] Downloaded i-slint-backend-winit v1.13.1 [INFO] [stderr] Downloaded zvariant v5.7.0 [INFO] [stderr] Downloaded i-slint-backend-selector v1.13.1 [INFO] [stderr] Downloaded zbus v5.11.0 [INFO] [stderr] Downloaded slint v1.13.1 [INFO] [stderr] Downloaded serde v1.0.227 [INFO] [stderr] Downloaded serde_core v1.0.227 [INFO] [stderr] Downloaded symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Downloaded i-slint-renderer-femtovg v1.13.1 [INFO] [stderr] Downloaded femtovg v0.17.0 [INFO] [stderr] Downloaded serde_derive v1.0.227 [INFO] [stderr] Downloaded symphonia-core v0.5.4 [INFO] [stderr] Downloaded i-slint-core v1.13.1 [INFO] [stderr] Downloaded lru v0.16.1 [INFO] [stderr] Downloaded windows-core v0.62.1 [INFO] [stderr] Downloaded i-slint-core-macros v1.13.1 [INFO] [stderr] Downloaded slint-macros v1.13.1 [INFO] [stderr] Downloaded i-slint-common v1.13.1 [INFO] [stderr] Downloaded symphonia-bundle-flac v0.5.4 [INFO] [stderr] Downloaded skia-safe v0.87.0 [INFO] [stderr] Downloaded symphonia-codec-aac v0.5.4 [INFO] [stderr] Downloaded symphonia-codec-vorbis v0.5.4 [INFO] [stderr] Downloaded i-slint-compiler v1.13.1 [INFO] [stderr] Downloaded symphonia-format-ogg v0.5.4 [INFO] [stderr] Downloaded symphonia-format-riff v0.5.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09862bd98437b49b351fb20704d710a93d6e04dcc679db4d5e82391dbd2ce2d8 [INFO] running `Command { std: "docker" "start" "-a" "09862bd98437b49b351fb20704d710a93d6e04dcc679db4d5e82391dbd2ce2d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09862bd98437b49b351fb20704d710a93d6e04dcc679db4d5e82391dbd2ce2d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09862bd98437b49b351fb20704d710a93d6e04dcc679db4d5e82391dbd2ce2d8", kill_on_drop: false }` [INFO] [stdout] 09862bd98437b49b351fb20704d710a93d6e04dcc679db4d5e82391dbd2ce2d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68347f8be0cf3269e677110ecbb8b03a7105f980b40ff889030c9c5eaf87b2c0 [INFO] running `Command { std: "docker" "start" "-a" "68347f8be0cf3269e677110ecbb8b03a7105f980b40ff889030c9c5eaf87b2c0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking critical-section v1.2.0 [INFO] [stderr] Compiling log v0.4.28 [INFO] [stderr] Compiling serde_core v1.0.227 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Compiling cfg-if v1.0.3 [INFO] [stderr] Compiling serde v1.0.227 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Compiling hashbrown v0.16.0 [INFO] [stderr] Compiling toml_parser v1.0.3 [INFO] [stderr] Compiling arrayvec v0.7.6 [INFO] [stderr] Compiling toml_datetime v0.7.2 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling toml_writer v1.0.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling simd-adler32 v0.3.7 [INFO] [stderr] Compiling cc v1.2.39 [INFO] [stderr] Checking core_maths v0.1.1 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling adler2 v2.0.1 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Compiling miniz_oxide v0.8.9 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling indexmap v2.11.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling bytemuck v1.23.2 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-deque v0.8.6 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling roxmltree v0.20.0 [INFO] [stderr] Compiling toml_edit v0.23.6 [INFO] [stderr] Compiling fontconfig-parser v0.5.8 [INFO] [stderr] Compiling tinyvec v1.10.0 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling memmap2 v0.9.8 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Compiling rayon v1.11.0 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling xml-rs v0.8.27 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling num-bigint v0.4.6 [INFO] [stderr] Compiling fdeflate v0.3.7 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling quick-error v2.0.1 [INFO] [stderr] Compiling float-cmp v0.9.0 [INFO] [stderr] Compiling built v0.7.7 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling strict-num v0.1.1 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling zune-core v0.4.12 [INFO] [stderr] Compiling arrayref v0.3.9 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling weezl v0.1.10 [INFO] [stderr] Compiling zune-jpeg v0.4.21 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling tiny-skia-path v0.11.4 [INFO] [stderr] Compiling field-offset v0.3.6 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Compiling euclid v0.22.11 [INFO] [stderr] Compiling rgb v0.8.52 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Compiling kurbo v0.11.3 [INFO] [stderr] Compiling fontdb v0.23.0 [INFO] [stderr] Compiling half v2.6.0 [INFO] [stderr] Compiling num-rational v0.4.2 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling unicode-bidi-mirroring v0.4.0 [INFO] [stderr] Compiling byteorder-lite v0.1.0 [INFO] [stderr] Compiling color_quant v1.1.0 [INFO] [stderr] Compiling bitstream-io v2.6.0 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling maybe-rayon v0.1.1 [INFO] [stderr] Compiling imgref v1.12.0 [INFO] [stderr] Compiling unicode-ccc v0.4.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.0.2 [INFO] [stderr] Checking unicode-properties v0.1.3 [INFO] [stderr] Checking unicode-script v0.5.7 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Compiling loop9 v0.1.5 [INFO] [stderr] Compiling gif v0.13.3 [INFO] [stderr] Compiling lyon_geom v1.0.17 [INFO] [stderr] Compiling image-webp v0.2.4 [INFO] [stderr] Compiling svgtypes v0.15.3 [INFO] [stderr] Compiling pxfm v0.1.24 [INFO] [stderr] Compiling zune-inflate v0.2.54 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling rustybuzz v0.20.1 [INFO] [stderr] Compiling avif-serialize v0.8.6 [INFO] [stderr] Compiling simplecss v0.2.2 [INFO] [stderr] Compiling data-url v0.3.2 [INFO] [stderr] Compiling unicode-vo v0.1.0 [INFO] [stderr] Compiling imagesize v0.13.0 [INFO] [stderr] Compiling bit_field v0.10.3 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling pico-args v0.5.0 [INFO] [stderr] Compiling lebe v0.5.3 [INFO] [stderr] Compiling xmlwriter v0.1.0 [INFO] [stderr] Compiling exr v1.73.0 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling tiny-skia v0.11.4 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking lyon_path v1.0.16 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling bytemuck_derive v1.10.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_derive v1.0.227 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling yoke v0.8.0 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Compiling zerovec v0.11.4 [INFO] [stderr] Compiling zerotrie v0.2.2 [INFO] [stderr] Compiling profiling v1.0.17 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling equator v0.4.2 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling aligned-vec v0.6.4 [INFO] [stderr] Checking moxcms v0.7.5 [INFO] [stderr] Compiling v_frame v0.3.9 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.4 [INFO] [stderr] Compiling av1-grain v0.2.4 [INFO] [stderr] Compiling fax v0.2.6 [INFO] [stderr] Compiling tinystr v0.8.1 [INFO] [stderr] Compiling potential_utf v0.1.3 [INFO] [stderr] Compiling tiff v0.10.3 [INFO] [stderr] Compiling usvg v0.45.1 [INFO] [stderr] Compiling icu_collections v2.0.0 [INFO] [stderr] Compiling num_enum_derive v0.7.4 [INFO] [stderr] Compiling icu_locale_core v2.0.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling const-field-offset-macro v0.1.5 [INFO] [stderr] Compiling icu_provider v2.0.0 [INFO] [stderr] Compiling png v0.18.0 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Compiling icu_properties v2.0.1 [INFO] [stderr] Compiling icu_normalizer v2.0.0 [INFO] [stderr] Compiling qoi v0.4.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling linereader v0.4.0 [INFO] [stderr] Compiling countme v3.0.1 [INFO] [stderr] Compiling text-size v1.1.1 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Compiling codemap v0.1.3 [INFO] [stderr] Compiling i-slint-compiler v1.13.1 [INFO] [stderr] Compiling linked-hash-map v0.5.6 [INFO] [stderr] Compiling zvariant_utils v3.2.1 [INFO] [stderr] Compiling enumflags2 v0.7.12 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling ttf-parser v0.21.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Compiling codemap-diagnostic v0.1.2 [INFO] [stderr] Compiling derive_more v2.0.1 [INFO] [stderr] Checking ab_glyph v0.2.31 [INFO] [stderr] Compiling rowan v0.16.1 [INFO] [stderr] Compiling idna_adapter v1.2.1 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling i-slint-common v1.13.1 [INFO] [stderr] Compiling idna v1.1.0 [INFO] [stderr] Compiling zvariant_derive v5.7.0 [INFO] [stderr] Compiling linked_hash_set v0.1.5 [INFO] [stderr] Compiling resvg v0.45.1 [INFO] [stderr] Compiling polib v0.2.0 [INFO] [stderr] Compiling num_enum v0.7.4 [INFO] [stderr] Compiling strum v0.27.2 [INFO] [stderr] Compiling url v2.5.7 [INFO] [stderr] Checking const-field-offset v0.1.5 [INFO] [stderr] Compiling lyon_extra v1.0.3 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling vtable-macro v0.3.0 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking image v0.25.8 [INFO] [stderr] Compiling derive_utils v0.15.0 [INFO] [stderr] Compiling zvariant v5.7.0 [INFO] [stderr] Compiling fontdue v0.9.3 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Compiling tiny-xlib v0.2.4 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Compiling typed-index-collections v3.3.0 [INFO] [stderr] Compiling by_address v1.2.1 [INFO] [stderr] Compiling smol_str v0.3.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling spin_on v0.1.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Compiling i-slint-core-macros v1.13.1 [INFO] [stderr] Compiling auto_enums v0.8.7 [INFO] [stderr] Checking vtable v0.3.0 [INFO] [stderr] Checking lyon_algorithms v1.0.16 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking integer-sqrt v0.1.5 [INFO] [stderr] Compiling softbuffer v0.4.6 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking scoped-tls-hkt v0.1.5 [INFO] [stderr] Checking lru v0.16.1 [INFO] [stderr] Checking pin-weak v1.1.0 [INFO] [stderr] Checking clru v0.6.2 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking ctor-lite v0.1.0 [INFO] [stderr] Checking femtovg v0.17.0 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking x11-clipboard v0.9.3 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Compiling i-slint-backend-winit v1.13.1 [INFO] [stderr] Compiling i-slint-backend-selector v1.13.1 [INFO] [stderr] Compiling cpal v0.16.0 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Checking symphonia-format-riff v0.5.4 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.4 [INFO] [stderr] Checking symphonia-format-mkv v0.5.4 [INFO] [stderr] Checking symphonia-format-isomp4 v0.5.4 [INFO] [stderr] Checking symphonia-format-ogg v0.5.4 [INFO] [stderr] Checking i-slint-core v1.13.1 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.4 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Checking symphonia-format-caf v0.5.4 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.4 [INFO] [stderr] Checking symphonia-codec-aac v0.5.4 [INFO] [stderr] Checking symphonia-codec-alac v0.5.4 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling zbus_macros v5.11.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling ravif v0.11.20 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking rodio v0.21.1 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking zbus v5.11.0 [INFO] [stderr] Checking copypasta v0.10.2 [INFO] [stderr] Checking i-slint-renderer-femtovg v1.13.1 [INFO] [stderr] Compiling slint-build v1.13.1 [INFO] [stderr] Compiling slint-macros v1.13.1 [INFO] [stderr] Compiling rust-audio-player-android v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking slint v1.13.1 [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/slint_app.rs:333:123 [INFO] [stdout] | [INFO] [stdout] 333 | ... if let Some(idx) = idx { if let Some(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handl... [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] = note: `#[warn(clippy::possible_missing_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/slint_app.rs:362:156 [INFO] [stdout] | [INFO] [stdout] 362 | ...e(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handle.upgrade() { ui.set_selected_index(id... [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/slint_app.rs:333:123 [INFO] [stdout] | [INFO] [stdout] 333 | ... if let Some(idx) = idx { if let Some(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handl... [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] = note: `#[warn(clippy::possible_missing_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/slint_app.rs:362:156 [INFO] [stdout] | [INFO] [stdout] 362 | ...e(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handle.upgrade() { ui.set_selected_index(id... [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/slint_app.rs:128:45 [INFO] [stdout] | [INFO] [stdout] 128 | let sink = rodio::Sink::connect_new(&stream.mixer()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `stream.mixer()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | if resume_paused { if let Some(s) = &self.sink { s.pause(); } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 136 - if resume_paused { if let Some(s) = &self.sink { s.pause(); } } [INFO] [stdout] 136 + if resume_paused && let Some(s) = &self.sink { s.pause(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:141:27 [INFO] [stdout] | [INFO] [stdout] 141 | ... { if let Some(s) = &self.sink { if !s.is_paused() { s.pause(); self.paused_at = Some(self.current_position()); self.start_instant = None; } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 141 - fn pause(&mut self) { if let Some(s) = &self.sink { if !s.is_paused() { s.pause(); self.paused_at = Some(self.current_position()); self.start_instant = None; } } } [INFO] [stdout] 141 + fn pause(&mut self) { if let Some(s) = &self.sink && !s.is_paused() { s.pause(); self.paused_at = Some(self.current_position()); self.start_instant = None; } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:142:28 [INFO] [stdout] | [INFO] [stdout] 142 | ... { if let Some(s) = &self.sink { if s.is_paused() { s.play(); if let Some(p) = self.paused_at.take() { self.position_offset = p; } self.start_instant = Some(Instant::now()); } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 - fn resume(&mut self) { if let Some(s) = &self.sink { if s.is_paused() { s.play(); if let Some(p) = self.paused_at.take() { self.position_offset = p; } self.start_instant = Some(Instant::now()); } } } [INFO] [stdout] 142 + fn resume(&mut self) { if let Some(s) = &self.sink && s.is_paused() { s.play(); if let Some(p) = self.paused_at.take() { self.position_offset = p; } self.start_instant = Some(Instant::now()); } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | / if p.is_file() { [INFO] [stdout] 223 | | if let Some(ext) = p.extension().and_then(|s| s.to_str()) { [INFO] [stdout] 224 | | const EXTS: &[&str] = &["mp3","flac","wav","ogg","opus","aac","m4a","alac","aiff","aif"]; [INFO] [stdout] 225 | | if EXTS.iter().any(|x| x.eq_ignore_ascii_case(ext)) { [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 222 ~ if p.is_file() [INFO] [stdout] 223 ~ && let Some(ext) = p.extension().and_then(|s| s.to_str()) { [INFO] [stdout] 224 | const EXTS: &[&str] = &["mp3","flac","wav","ogg","opus","aac","m4a","alac","aiff","aif"]; [INFO] [stdout] ... [INFO] [stdout] 228 | } [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/slint_app.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 233 | v.sort_by(|a,b| a.title.to_lowercase().cmp(&b.title.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - v.sort_by(|a,b| a.title.to_lowercase().cmp(&b.title.to_lowercase())); [INFO] [stdout] 233 + v.sort_by_key(|a| a.title.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | / if let Ok(mut eng) = engine.lock() { [INFO] [stdout] 266 | | if let Some(cur_idx) = *sel { [INFO] [stdout] 267 | | if let Some(cur_path) = &eng.current_path { if songs.get(cur_idx).map(|s| &s.path) == Some(cur_path) { [INFO] [stdout] 268 | | if eng.is_playing() { eng.pause(); } else { eng.resume(); } [INFO] [stdout] ... | [INFO] [stdout] 280 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 265 ~ if let Ok(mut eng) = engine.lock() [INFO] [stdout] 266 ~ && let Some(cur_idx) = *sel { [INFO] [stdout] 267 | if let Some(cur_path) = &eng.current_path { if songs.get(cur_idx).map(|s| &s.path) == Some(cur_path) { [INFO] [stdout] ... [INFO] [stdout] 278 | } [INFO] [stdout] 279 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:267:21 [INFO] [stdout] | [INFO] [stdout] 267 | / if let Some(cur_path) = &eng.current_path { if songs.get(cur_idx).map(|s| &s.path) == Some(cur_path) { [INFO] [stdout] 268 | | if eng.is_playing() { eng.pause(); } else { eng.resume(); } [INFO] [stdout] 269 | | if let Some(ui) = ui_handle.upgrade() { ui.set_status_text(SharedString::from("Toggled")); } [INFO] [stdout] 270 | | return; [INFO] [stdout] 271 | | }} [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 267 ~ if let Some(cur_path) = &eng.current_path && songs.get(cur_idx).map(|s| &s.path) == Some(cur_path) { [INFO] [stdout] 268 | if eng.is_playing() { eng.pause(); } else { eng.resume(); } [INFO] [stdout] 269 | if let Some(ui) = ui_handle.upgrade() { ui.set_status_text(SharedString::from("Toggled")); } [INFO] [stdout] 270 | return; [INFO] [stdout] 271 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/slint_app.rs:274:107 [INFO] [stdout] | [INFO] [stdout] 274 | ... if let Some(ui) = ui_handle.upgrade() { ui.set_status_text(SharedString::from(format!("{e}"))); } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:295:28 [INFO] [stdout] | [INFO] [stdout] 295 | } else if let Some(&first) = filtered_indices.lock().unwrap().first() { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 296 | | if let Some(item) = songs.get(first) { let _ = eng.play_file(&item.path); } [INFO] [stdout] 297 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 295 ~ } else if let Some(&first) = filtered_indices.lock().unwrap().first() [INFO] [stdout] 296 ~ && let Some(item) = songs.get(first) { let _ = eng.play_file(&item.path); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:320:13 [INFO] [stdout] | [INFO] [stdout] 320 | / if let Some(cur_idx) = cur { [INFO] [stdout] 321 | | if let Ok(mut eng) = engine.lock() { [INFO] [stdout] 322 | | if eng.current_position() > Duration::from_secs(3) { [INFO] [stdout] 323 | | let _ = eng.seek_to(Duration::ZERO); [INFO] [stdout] ... | [INFO] [stdout] 337 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 320 ~ if let Some(cur_idx) = cur [INFO] [stdout] 321 ~ && let Ok(mut eng) = engine.lock() { [INFO] [stdout] 322 | if eng.current_position() > Duration::from_secs(3) { [INFO] [stdout] ... [INFO] [stdout] 335 | if let Some(ui) = ui_handle.upgrade() { ui.set_is_playing(eng.is_playing()); } [INFO] [stdout] 336 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:362:17 [INFO] [stdout] | [INFO] [stdout] 362 | ... if let Some(idx) = idx_opt { if let Ok(mut eng) = engine.lock() { if let Some(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handle.upgrade() { ui.set_selected_index(idx as i32); ui.set_is_playing(eng.is_playing()); } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 362 - if let Some(idx) = idx_opt { if let Ok(mut eng) = engine.lock() { if let Some(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handle.upgrade() { ui.set_selected_index(idx as i32); ui.set_is_playing(eng.is_playing()); } } } [INFO] [stdout] 362 + if let Some(idx) = idx_opt && let Ok(mut eng) = engine.lock() { if let Some(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handle.upgrade() { ui.set_selected_index(idx as i32); ui.set_is_playing(eng.is_playing()); } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:380:13 [INFO] [stdout] | [INFO] [stdout] 380 | / if let Ok(mut eng) = engine.lock() { [INFO] [stdout] 381 | | if let Some(total) = eng.total_duration() { [INFO] [stdout] 382 | | let position = Duration::from_secs_f32(total.as_secs_f32() * value as f32); [INFO] [stdout] 383 | | let _ = eng.seek_to(position); [INFO] [stdout] ... | [INFO] [stdout] 390 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 380 ~ if let Ok(mut eng) = engine.lock() [INFO] [stdout] 381 ~ && let Some(total) = eng.total_duration() { [INFO] [stdout] 382 | let position = Duration::from_secs_f32(total.as_secs_f32() * value as f32); [INFO] [stdout] ... [INFO] [stdout] 388 | } [INFO] [stdout] 389 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/slint_app.rs:382:82 [INFO] [stdout] | [INFO] [stdout] 382 | let position = Duration::from_secs_f32(total.as_secs_f32() * value as f32); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/slint_app.rs:436:41 [INFO] [stdout] | [INFO] [stdout] 436 | ui.set_progress(ratio as f32); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ratio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/slint_app.rs:499:16 [INFO] [stdout] | [INFO] [stdout] 499 | ... if index >= 0 && index < 10 { let idx = index as usize; let mut gains = eq_gains.lock().unwrap(); gains[idx] = (value - 0.5) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..10).contains(&index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/slint_app.rs:128:45 [INFO] [stdout] | [INFO] [stdout] 128 | let sink = rodio::Sink::connect_new(&stream.mixer()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `stream.mixer()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | if resume_paused { if let Some(s) = &self.sink { s.pause(); } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 136 - if resume_paused { if let Some(s) = &self.sink { s.pause(); } } [INFO] [stdout] 136 + if resume_paused && let Some(s) = &self.sink { s.pause(); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:141:27 [INFO] [stdout] | [INFO] [stdout] 141 | ... { if let Some(s) = &self.sink { if !s.is_paused() { s.pause(); self.paused_at = Some(self.current_position()); self.start_instant = None; } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 141 - fn pause(&mut self) { if let Some(s) = &self.sink { if !s.is_paused() { s.pause(); self.paused_at = Some(self.current_position()); self.start_instant = None; } } } [INFO] [stdout] 141 + fn pause(&mut self) { if let Some(s) = &self.sink && !s.is_paused() { s.pause(); self.paused_at = Some(self.current_position()); self.start_instant = None; } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:142:28 [INFO] [stdout] | [INFO] [stdout] 142 | ... { if let Some(s) = &self.sink { if s.is_paused() { s.play(); if let Some(p) = self.paused_at.take() { self.position_offset = p; } self.start_instant = Some(Instant::now()); } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 142 - fn resume(&mut self) { if let Some(s) = &self.sink { if s.is_paused() { s.play(); if let Some(p) = self.paused_at.take() { self.position_offset = p; } self.start_instant = Some(Instant::now()); } } } [INFO] [stdout] 142 + fn resume(&mut self) { if let Some(s) = &self.sink && s.is_paused() { s.play(); if let Some(p) = self.paused_at.take() { self.position_offset = p; } self.start_instant = Some(Instant::now()); } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | / if p.is_file() { [INFO] [stdout] 223 | | if let Some(ext) = p.extension().and_then(|s| s.to_str()) { [INFO] [stdout] 224 | | const EXTS: &[&str] = &["mp3","flac","wav","ogg","opus","aac","m4a","alac","aiff","aif"]; [INFO] [stdout] 225 | | if EXTS.iter().any(|x| x.eq_ignore_ascii_case(ext)) { [INFO] [stdout] ... | [INFO] [stdout] 230 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 222 ~ if p.is_file() [INFO] [stdout] 223 ~ && let Some(ext) = p.extension().and_then(|s| s.to_str()) { [INFO] [stdout] 224 | const EXTS: &[&str] = &["mp3","flac","wav","ogg","opus","aac","m4a","alac","aiff","aif"]; [INFO] [stdout] ... [INFO] [stdout] 228 | } [INFO] [stdout] 229 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/slint_app.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 233 | v.sort_by(|a,b| a.title.to_lowercase().cmp(&b.title.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 233 - v.sort_by(|a,b| a.title.to_lowercase().cmp(&b.title.to_lowercase())); [INFO] [stdout] 233 + v.sort_by_key(|a| a.title.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:265:13 [INFO] [stdout] | [INFO] [stdout] 265 | / if let Ok(mut eng) = engine.lock() { [INFO] [stdout] 266 | | if let Some(cur_idx) = *sel { [INFO] [stdout] 267 | | if let Some(cur_path) = &eng.current_path { if songs.get(cur_idx).map(|s| &s.path) == Some(cur_path) { [INFO] [stdout] 268 | | if eng.is_playing() { eng.pause(); } else { eng.resume(); } [INFO] [stdout] ... | [INFO] [stdout] 280 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 265 ~ if let Ok(mut eng) = engine.lock() [INFO] [stdout] 266 ~ && let Some(cur_idx) = *sel { [INFO] [stdout] 267 | if let Some(cur_path) = &eng.current_path { if songs.get(cur_idx).map(|s| &s.path) == Some(cur_path) { [INFO] [stdout] ... [INFO] [stdout] 278 | } [INFO] [stdout] 279 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:267:21 [INFO] [stdout] | [INFO] [stdout] 267 | / if let Some(cur_path) = &eng.current_path { if songs.get(cur_idx).map(|s| &s.path) == Some(cur_path) { [INFO] [stdout] 268 | | if eng.is_playing() { eng.pause(); } else { eng.resume(); } [INFO] [stdout] 269 | | if let Some(ui) = ui_handle.upgrade() { ui.set_status_text(SharedString::from("Toggled")); } [INFO] [stdout] 270 | | return; [INFO] [stdout] 271 | | }} [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 267 ~ if let Some(cur_path) = &eng.current_path && songs.get(cur_idx).map(|s| &s.path) == Some(cur_path) { [INFO] [stdout] 268 | if eng.is_playing() { eng.pause(); } else { eng.resume(); } [INFO] [stdout] 269 | if let Some(ui) = ui_handle.upgrade() { ui.set_status_text(SharedString::from("Toggled")); } [INFO] [stdout] 270 | return; [INFO] [stdout] 271 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/slint_app.rs:274:107 [INFO] [stdout] | [INFO] [stdout] 274 | ... if let Some(ui) = ui_handle.upgrade() { ui.set_status_text(SharedString::from(format!("{e}"))); } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:295:28 [INFO] [stdout] | [INFO] [stdout] 295 | } else if let Some(&first) = filtered_indices.lock().unwrap().first() { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 296 | | if let Some(item) = songs.get(first) { let _ = eng.play_file(&item.path); } [INFO] [stdout] 297 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 295 ~ } else if let Some(&first) = filtered_indices.lock().unwrap().first() [INFO] [stdout] 296 ~ && let Some(item) = songs.get(first) { let _ = eng.play_file(&item.path); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:320:13 [INFO] [stdout] | [INFO] [stdout] 320 | / if let Some(cur_idx) = cur { [INFO] [stdout] 321 | | if let Ok(mut eng) = engine.lock() { [INFO] [stdout] 322 | | if eng.current_position() > Duration::from_secs(3) { [INFO] [stdout] 323 | | let _ = eng.seek_to(Duration::ZERO); [INFO] [stdout] ... | [INFO] [stdout] 337 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 320 ~ if let Some(cur_idx) = cur [INFO] [stdout] 321 ~ && let Ok(mut eng) = engine.lock() { [INFO] [stdout] 322 | if eng.current_position() > Duration::from_secs(3) { [INFO] [stdout] ... [INFO] [stdout] 335 | if let Some(ui) = ui_handle.upgrade() { ui.set_is_playing(eng.is_playing()); } [INFO] [stdout] 336 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:362:17 [INFO] [stdout] | [INFO] [stdout] 362 | ... if let Some(idx) = idx_opt { if let Ok(mut eng) = engine.lock() { if let Some(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handle.upgrade() { ui.set_selected_index(idx as i32); ui.set_is_playing(eng.is_playing()); } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 362 - if let Some(idx) = idx_opt { if let Ok(mut eng) = engine.lock() { if let Some(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handle.upgrade() { ui.set_selected_index(idx as i32); ui.set_is_playing(eng.is_playing()); } } } [INFO] [stdout] 362 + if let Some(idx) = idx_opt && let Ok(mut eng) = engine.lock() { if let Some(item) = songs.get(idx) { let _ = eng.play_file(&item.path); } if let Some(ui) = ui_handle.upgrade() { ui.set_selected_index(idx as i32); ui.set_is_playing(eng.is_playing()); } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/slint_app.rs:380:13 [INFO] [stdout] | [INFO] [stdout] 380 | / if let Ok(mut eng) = engine.lock() { [INFO] [stdout] 381 | | if let Some(total) = eng.total_duration() { [INFO] [stdout] 382 | | let position = Duration::from_secs_f32(total.as_secs_f32() * value as f32); [INFO] [stdout] 383 | | let _ = eng.seek_to(position); [INFO] [stdout] ... | [INFO] [stdout] 390 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 380 ~ if let Ok(mut eng) = engine.lock() [INFO] [stdout] 381 ~ && let Some(total) = eng.total_duration() { [INFO] [stdout] 382 | let position = Duration::from_secs_f32(total.as_secs_f32() * value as f32); [INFO] [stdout] ... [INFO] [stdout] 388 | } [INFO] [stdout] 389 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/slint_app.rs:382:82 [INFO] [stdout] | [INFO] [stdout] 382 | let position = Duration::from_secs_f32(total.as_secs_f32() * value as f32); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/slint_app.rs:436:41 [INFO] [stdout] | [INFO] [stdout] 436 | ui.set_progress(ratio as f32); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `ratio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/slint_app.rs:499:16 [INFO] [stdout] | [INFO] [stdout] 499 | ... if index >= 0 && index < 10 { let idx = index as usize; let mut gains = eq_gains.lock().unwrap(); gains[idx] = (value - 0.5) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..10).contains(&index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 37s [INFO] running `Command { std: "docker" "inspect" "68347f8be0cf3269e677110ecbb8b03a7105f980b40ff889030c9c5eaf87b2c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68347f8be0cf3269e677110ecbb8b03a7105f980b40ff889030c9c5eaf87b2c0", kill_on_drop: false }` [INFO] [stdout] 68347f8be0cf3269e677110ecbb8b03a7105f980b40ff889030c9c5eaf87b2c0