[INFO] cloning repository https://github.com/mihavlic/testprog [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mihavlic/testprog" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmihavlic%2Ftestprog", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmihavlic%2Ftestprog'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3be1ccc78ace4127a967ee05a06baab859096228 [INFO] linting mihavlic/testprog against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmihavlic%2Ftestprog" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mihavlic/testprog [INFO] finished tweaking git repo https://github.com/mihavlic/testprog [INFO] tweaked toml for git repo https://github.com/mihavlic/testprog written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mihavlic/testprog on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/mihavlic/testprog already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nu-ansi-term v0.49.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.68 [INFO] [stderr] Downloaded bstr v1.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e017768697fe541dea0c4e5429b6796d4440c594e51960d52d28a7acf5cac585 [INFO] running `Command { std: "docker" "start" "-a" "e017768697fe541dea0c4e5429b6796d4440c594e51960d52d28a7acf5cac585", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e017768697fe541dea0c4e5429b6796d4440c594e51960d52d28a7acf5cac585", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e017768697fe541dea0c4e5429b6796d4440c594e51960d52d28a7acf5cac585", kill_on_drop: false }` [INFO] [stdout] e017768697fe541dea0c4e5429b6796d4440c594e51960d52d28a7acf5cac585 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d54dddf62638c858306fd6e5b18f998d78f852e81371b4d297b725a00eb48e6 [INFO] running `Command { std: "docker" "start" "-a" "8d54dddf62638c858306fd6e5b18f998d78f852e81371b4d297b725a00eb48e6", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.68 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking nu-ansi-term v0.49.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking bstr v1.9.0 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Checking testprog v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/main.rs:106:29 [INFO] [stdout] | [INFO] [stdout] 106 | ... () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/main.rs:106:29 [INFO] [stdout] | [INFO] [stdout] 106 | ... () [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/database.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | binary: out_dir.join(&source_file).with_extension(""), [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `source_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/database.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 102 | compile_file(&entry, args)?; [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/database.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 131 | builder.args(&["-std=c++11", "-Wall", "-pedantic"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-std=c++11", "-Wall", "-pedantic"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/fs.rs:172:24 [INFO] [stdout] | [INFO] [stdout] 172 | } else if ty.is_file() { [INFO] [stdout] | ________________________^ [INFO] [stdout] 173 | | if fun(TraversalEvent::File(&path)) == TraversalResponse::Stop { [INFO] [stdout] 174 | | return TraversalResponse::Stop; [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ } else if ty.is_file() [INFO] [stdout] 173 ~ && fun(TraversalEvent::File(&path)) == TraversalResponse::Stop { [INFO] [stdout] 174 | return TraversalResponse::Stop; [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/logger.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | let env = std::env::var("RUST_LOG").unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/samples.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | && !sample_subdirs [INFO] [stdout] | ________________________^ [INFO] [stdout] 64 | | .iter() [INFO] [stdout] 65 | | .find(|s| dir.file_name().unwrap() == s.as_os_str()) [INFO] [stdout] 66 | | .is_some() [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 ~ && sample_subdirs [INFO] [stdout] 64 + .iter() [INFO] [stdout] 65 + .find(|s| dir.file_name().unwrap() == s.as_os_str()).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/samples.rs:140:23 [INFO] [stdout] | [INFO] [stdout] 140 | fs::read_into(&output, &mut buf)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | / if build_options.targets.len() != 1 { [INFO] [stdout] 71 | | bail!("The 'run' subcommand expects a single target"); [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ Command::Run { build_options } [INFO] [stdout] 70 ~ if build_options.targets.len() != 1 => { [INFO] [stdout] 71 | bail!("The 'run' subcommand expects a single target"); [INFO] [stdout] 72 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/database.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | binary: out_dir.join(&source_file).with_extension(""), [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `source_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:103:37 [INFO] [stdout] | [INFO] [stdout] 103 | .build_file(&file, options) [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:148:42 [INFO] [stdout] | [INFO] [stdout] 148 | subcommand_convert(&out_dir, &archive, &output, &args, &sample_subdirs)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `archive` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:148:68 [INFO] [stdout] | [INFO] [stdout] 148 | subcommand_convert(&out_dir, &archive, &output, &args, &sample_subdirs)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `sample_subdirs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/database.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 102 | compile_file(&entry, args)?; [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/database.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 131 | builder.args(&["-std=c++11", "-Wall", "-pedantic"]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-std=c++11", "-Wall", "-pedantic"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:273:1 [INFO] [stdout] | [INFO] [stdout] 273 | / fn test_samples( [INFO] [stdout] 274 | | name: &[u8], [INFO] [stdout] 275 | | input: &[u8], [INFO] [stdout] 276 | | output: &[u8], [INFO] [stdout] ... | [INFO] [stdout] 281 | | args: &Arguments, [INFO] [stdout] 282 | | ) -> Result<(), AlreadyReported> { [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/fs.rs:172:24 [INFO] [stdout] | [INFO] [stdout] 172 | } else if ty.is_file() { [INFO] [stdout] | ________________________^ [INFO] [stdout] 173 | | if fun(TraversalEvent::File(&path)) == TraversalResponse::Stop { [INFO] [stdout] 174 | | return TraversalResponse::Stop; [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ } else if ty.is_file() [INFO] [stdout] 173 ~ && fun(TraversalEvent::File(&path)) == TraversalResponse::Stop { [INFO] [stdout] 174 | return TraversalResponse::Stop; [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/logger.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | let env = std::env::var("RUST_LOG").unwrap_or(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/samples.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | && !sample_subdirs [INFO] [stdout] | ________________________^ [INFO] [stdout] 64 | | .iter() [INFO] [stdout] 65 | | .find(|s| dir.file_name().unwrap() == s.as_os_str()) [INFO] [stdout] 66 | | .is_some() [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 63 ~ && sample_subdirs [INFO] [stdout] 64 + .iter() [INFO] [stdout] 65 + .find(|s| dir.file_name().unwrap() == s.as_os_str()).is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/samples.rs:140:23 [INFO] [stdout] | [INFO] [stdout] 140 | fs::read_into(&output, &mut buf)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | / if build_options.targets.len() != 1 { [INFO] [stdout] 71 | | bail!("The 'run' subcommand expects a single target"); [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ Command::Run { build_options } [INFO] [stdout] 70 ~ if build_options.targets.len() != 1 => { [INFO] [stdout] 71 | bail!("The 'run' subcommand expects a single target"); [INFO] [stdout] 72 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:103:37 [INFO] [stdout] | [INFO] [stdout] 103 | .build_file(&file, options) [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:148:42 [INFO] [stdout] | [INFO] [stdout] 148 | subcommand_convert(&out_dir, &archive, &output, &args, &sample_subdirs)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `archive` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:148:68 [INFO] [stdout] | [INFO] [stdout] 148 | subcommand_convert(&out_dir, &archive, &output, &args, &sample_subdirs)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `sample_subdirs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/main.rs:273:1 [INFO] [stdout] | [INFO] [stdout] 273 | / fn test_samples( [INFO] [stdout] 274 | | name: &[u8], [INFO] [stdout] 275 | | input: &[u8], [INFO] [stdout] 276 | | output: &[u8], [INFO] [stdout] ... | [INFO] [stdout] 281 | | args: &Arguments, [INFO] [stdout] 282 | | ) -> Result<(), AlreadyReported> { [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.24s [INFO] running `Command { std: "docker" "inspect" "8d54dddf62638c858306fd6e5b18f998d78f852e81371b4d297b725a00eb48e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d54dddf62638c858306fd6e5b18f998d78f852e81371b4d297b725a00eb48e6", kill_on_drop: false }` [INFO] [stdout] 8d54dddf62638c858306fd6e5b18f998d78f852e81371b4d297b725a00eb48e6