[INFO] cloning repository https://github.com/midatindex0/graphql-ratelimit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/midatindex0/graphql-ratelimit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmidatindex0%2Fgraphql-ratelimit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmidatindex0%2Fgraphql-ratelimit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 02765e2d2f90f243b454a776e11498b2224116a1 [INFO] linting midatindex0/graphql-ratelimit against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmidatindex0%2Fgraphql-ratelimit" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/midatindex0/graphql-ratelimit [INFO] finished tweaking git repo https://github.com/midatindex0/graphql-ratelimit [INFO] tweaked toml for git repo https://github.com/midatindex0/graphql-ratelimit written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/midatindex0/graphql-ratelimit on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/midatindex0/graphql-ratelimit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded countme v3.0.1 [INFO] [stderr] Downloaded text-size v1.1.1 [INFO] [stderr] Downloaded rowan v0.15.15 [INFO] [stderr] Downloaded zerocopy-derive v0.7.32 [INFO] [stderr] Downloaded seize v0.2.5 [INFO] [stderr] Downloaded zerocopy v0.7.32 [INFO] [stderr] Downloaded flurry v0.5.0 [INFO] [stderr] Downloaded apollo-parser v0.7.7 [INFO] [stderr] Downloaded syn v2.0.58 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d5f13123b13424dedfffbd9a3205293f30834c27c7b88b8db642c0b4bbdc463 [INFO] running `Command { std: "docker" "start" "-a" "4d5f13123b13424dedfffbd9a3205293f30834c27c7b88b8db642c0b4bbdc463", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d5f13123b13424dedfffbd9a3205293f30834c27c7b88b8db642c0b4bbdc463", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d5f13123b13424dedfffbd9a3205293f30834c27c7b88b8db642c0b4bbdc463", kill_on_drop: false }` [INFO] [stdout] 4d5f13123b13424dedfffbd9a3205293f30834c27c7b88b8db642c0b4bbdc463 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 602093d7f94802e561a252bb083501173c42bbbb5875a474ebcbfb7c5ecb7af9 [INFO] running `Command { std: "docker" "start" "-a" "602093d7f94802e561a252bb083501173c42bbbb5875a474ebcbfb7c5ecb7af9", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking seize v0.2.5 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling getrandom v0.2.14 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rowan v0.15.15 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking flurry v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking apollo-parser v0.7.7 [INFO] [stderr] Checking graphql-ratelimit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/lib.rs:199:28 [INFO] [stdout] | [INFO] [stdout] 199 | if let Some(_) = op_type.query_token() { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if op_type.query_token().is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | ... &mut bucket, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/lib.rs:241:28 [INFO] [stdout] | [INFO] [stdout] 241 | if let Some(_) = op_type.mutation_token() { [INFO] [stdout] | -------^^^^^^^--------------------------- help: try: `if op_type.mutation_token().is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:250:37 [INFO] [stdout] | [INFO] [stdout] 250 | ... &mut bucket, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/lib.rs:284:28 [INFO] [stdout] | [INFO] [stdout] 284 | if let Some(_) = op_type.subscription_token() { [INFO] [stdout] | -------^^^^^^^------------------------------- help: try: `if op_type.subscription_token().is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:292:37 [INFO] [stdout] | [INFO] [stdout] 292 | ... &mut bucket, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:527:72 [INFO] [stdout] | [INFO] [stdout] 527 | ... |mut bucket| self.ratelimit_backend.aquire(&mut bucket, f.cost, f.rate), [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:625:56 [INFO] [stdout] | [INFO] [stdout] 625 | let ms = Self::find_max_duration_recursive(&sub_f); [INFO] [stdout] | ^^^^^^ help: change this to: `sub_f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `InMemoryBackend` [INFO] [stdout] --> src/lib.rs:723:5 [INFO] [stdout] | [INFO] [stdout] 723 | / pub fn new() -> Self { [INFO] [stdout] 724 | | Self { [INFO] [stdout] 725 | | map: HashMap::new(), [INFO] [stdout] 726 | | } [INFO] [stdout] 727 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 722 + impl Default for InMemoryBackend { [INFO] [stdout] 723 + fn default() -> Self { [INFO] [stdout] 724 + Self::new() [INFO] [stdout] 725 + } [INFO] [stdout] 726 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:735:20 [INFO] [stdout] | [INFO] [stdout] 735 | |_, f| !(OffsetDateTime::now_utc() - f.last_hit > ttl), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(OffsetDateTime::now_utc() - f.last_hit <= ttl)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Bucket` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:766:38 [INFO] [stdout] | [INFO] [stdout] 766 | let mut bucket = bucket.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.05s [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/lib.rs:199:28 [INFO] [stdout] | [INFO] [stdout] 199 | if let Some(_) = op_type.query_token() { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if op_type.query_token().is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | ... &mut bucket, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/lib.rs:241:28 [INFO] [stdout] | [INFO] [stdout] 241 | if let Some(_) = op_type.mutation_token() { [INFO] [stdout] | -------^^^^^^^--------------------------- help: try: `if op_type.mutation_token().is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:250:37 [INFO] [stdout] | [INFO] [stdout] 250 | ... &mut bucket, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/lib.rs:284:28 [INFO] [stdout] | [INFO] [stdout] 284 | if let Some(_) = op_type.subscription_token() { [INFO] [stdout] | -------^^^^^^^------------------------------- help: try: `if op_type.subscription_token().is_some()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:292:37 [INFO] [stdout] | [INFO] [stdout] 292 | ... &mut bucket, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:527:72 [INFO] [stdout] | [INFO] [stdout] 527 | ... |mut bucket| self.ratelimit_backend.aquire(&mut bucket, f.cost, f.rate), [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:625:56 [INFO] [stdout] | [INFO] [stdout] 625 | let ms = Self::find_max_duration_recursive(&sub_f); [INFO] [stdout] | ^^^^^^ help: change this to: `sub_f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `InMemoryBackend` [INFO] [stdout] --> src/lib.rs:723:5 [INFO] [stdout] | [INFO] [stdout] 723 | / pub fn new() -> Self { [INFO] [stdout] 724 | | Self { [INFO] [stdout] 725 | | map: HashMap::new(), [INFO] [stdout] 726 | | } [INFO] [stdout] 727 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 722 + impl Default for InMemoryBackend { [INFO] [stdout] 723 + fn default() -> Self { [INFO] [stdout] 724 + Self::new() [INFO] [stdout] 725 + } [INFO] [stdout] 726 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:735:20 [INFO] [stdout] | [INFO] [stdout] 735 | |_, f| !(OffsetDateTime::now_utc() - f.last_hit > ttl), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(OffsetDateTime::now_utc() - f.last_hit <= ttl)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Bucket` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:766:38 [INFO] [stdout] | [INFO] [stdout] 766 | let mut bucket = bucket.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*bucket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "602093d7f94802e561a252bb083501173c42bbbb5875a474ebcbfb7c5ecb7af9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "602093d7f94802e561a252bb083501173c42bbbb5875a474ebcbfb7c5ecb7af9", kill_on_drop: false }` [INFO] [stdout] 602093d7f94802e561a252bb083501173c42bbbb5875a474ebcbfb7c5ecb7af9