[INFO] cloning repository https://github.com/microwaveabletoaster/ARGHH [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/microwaveabletoaster/ARGHH" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmicrowaveabletoaster%2FARGHH", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmicrowaveabletoaster%2FARGHH'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f7abc297705a7e06e17a1e39f407ce3c6c04d6d0 [INFO] linting microwaveabletoaster/ARGHH against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmicrowaveabletoaster%2FARGHH" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/microwaveabletoaster/ARGHH [INFO] finished tweaking git repo https://github.com/microwaveabletoaster/ARGHH [INFO] tweaked toml for git repo https://github.com/microwaveabletoaster/ARGHH written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/microwaveabletoaster/ARGHH on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/microwaveabletoaster/ARGHH already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lazy_static v0.1.15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56542d91cf73fddf31a249908428e37d6edfb220fb32d0d8cc5973642b7f53a5 [INFO] running `Command { std: "docker" "start" "-a" "56542d91cf73fddf31a249908428e37d6edfb220fb32d0d8cc5973642b7f53a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56542d91cf73fddf31a249908428e37d6edfb220fb32d0d8cc5973642b7f53a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56542d91cf73fddf31a249908428e37d6edfb220fb32d0d8cc5973642b7f53a5", kill_on_drop: false }` [INFO] [stdout] 56542d91cf73fddf31a249908428e37d6edfb220fb32d0d8cc5973642b7f53a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d565950de4a4530ad5ac0e2d6fd92fa979b0ef145ae39289b20edcf1fc7dbc9 [INFO] running `Command { std: "docker" "start" "-a" "8d565950de4a4530ad5ac0e2d6fd92fa979b0ef145ae39289b20edcf1fc7dbc9", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking lazy_static v0.1.15 [INFO] [stderr] Checking ARGHH v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | let filepath: &str = &*args.next().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&args.next().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | / if x == "-v"{ [INFO] [stdout] 21 | | verbose = true [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ Some(x) [INFO] [stdout] 20 ~ if x == "-v"=> { [INFO] [stdout] 21 | verbose = true [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / match args.next() { [INFO] [stdout] 19 | | Some(x) => { [INFO] [stdout] 20 | | if x == "-v"{ [INFO] [stdout] 21 | | verbose = true [INFO] [stdout] ... | [INFO] [stdout] 24 | | _ => () [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some(x) = args.next() { [INFO] [stdout] 19 + if x == "-v"{ [INFO] [stdout] 20 + verbose = true [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | if function != "" && function != " "{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!function.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:89:26 [INFO] [stdout] | [INFO] [stdout] 89 | .map(|s| String::from(s)).collect()); // convert from Vec<&str> to Vec [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:138:32 [INFO] [stdout] | [INFO] [stdout] 138 | ... if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 138 - if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] 138 + if !(res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() != "yea") { [INFO] [stdout] | [INFO] [stdout] 138 - if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] 138 + if res == None || self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/main.rs:107:77 [INFO] [stdout] | [INFO] [stdout] 107 | let start_ind = self.functions[&function_name].iter().position(|ref x| x.trim() == format!("{}.",count)); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 - let start_ind = self.functions[&function_name].iter().position(|ref x| x.trim() == format!("{}.",count)); [INFO] [stdout] 107 + let start_ind = self.functions[&function_name].iter().position(|x| x.trim() == format!("{}.",count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/main.rs:109:78 [INFO] [stdout] | [INFO] [stdout] 109 | let finish_ind = self.functions[&function_name].iter().position(|ref x| x.trim() == format!(".{}",count)); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 109 - let finish_ind = self.functions[&function_name].iter().position(|ref x| x.trim() == format!(".{}",count)); [INFO] [stdout] 109 + let finish_ind = self.functions[&function_name].iter().position(|x| x.trim() == format!(".{}",count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | let filepath: &str = &*args.next().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&args.next().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | / if x == "-v"{ [INFO] [stdout] 21 | | verbose = true [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 19 ~ Some(x) [INFO] [stdout] 20 ~ if x == "-v"=> { [INFO] [stdout] 21 | verbose = true [INFO] [stdout] 22 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | / match args.next() { [INFO] [stdout] 19 | | Some(x) => { [INFO] [stdout] 20 | | if x == "-v"{ [INFO] [stdout] 21 | | verbose = true [INFO] [stdout] ... | [INFO] [stdout] 24 | | _ => () [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some(x) = args.next() { [INFO] [stdout] 19 + if x == "-v"{ [INFO] [stdout] 20 + verbose = true [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:132:56 [INFO] [stdout] | [INFO] [stdout] 132 | ... let mut current_operator = String::from(self.functions[&function_name][ind].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.functions[&function_name][ind].clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/main.rs:135:39 [INFO] [stdout] | [INFO] [stdout] 135 | ... _ => {();} [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:138:33 [INFO] [stdout] | [INFO] [stdout] 138 | ... if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_some()` instead: `res.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:138:122 [INFO] [stdout] | [INFO] [stdout] 138 | ... if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_none()` instead: `res.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:141:56 [INFO] [stdout] | [INFO] [stdout] 141 | ... let file = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:142:78 [INFO] [stdout] | [INFO] [stdout] 142 | ... let mut file = File::open(&file).expect(&*format!("error: couldn't import the file {:?}",file)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", *format!("error: couldn't import the file {:?}",file)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:142:85 [INFO] [stdout] | [INFO] [stdout] 142 | ... let mut file = File::open(&file).expect(&*format!("error: couldn't import the file {:?}",file)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("error: couldn't import the file {:?}",file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:156:54 [INFO] [stdout] | [INFO] [stdout] 156 | ... let method = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | if function != "" && function != " "{ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!function.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:89:26 [INFO] [stdout] | [INFO] [stdout] 89 | .map(|s| String::from(s)).collect()); // convert from Vec<&str> to Vec [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:138:32 [INFO] [stdout] | [INFO] [stdout] 138 | ... if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 138 - if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] 138 + if !(res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() != "yea") { [INFO] [stdout] | [INFO] [stdout] 138 - if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] 138 + if res == None || self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea" { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/main.rs:107:77 [INFO] [stdout] | [INFO] [stdout] 107 | let start_ind = self.functions[&function_name].iter().position(|ref x| x.trim() == format!("{}.",count)); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 107 - let start_ind = self.functions[&function_name].iter().position(|ref x| x.trim() == format!("{}.",count)); [INFO] [stdout] 107 + let start_ind = self.functions[&function_name].iter().position(|x| x.trim() == format!("{}.",count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/main.rs:109:78 [INFO] [stdout] | [INFO] [stdout] 109 | let finish_ind = self.functions[&function_name].iter().position(|ref x| x.trim() == format!(".{}",count)); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 109 - let finish_ind = self.functions[&function_name].iter().position(|ref x| x.trim() == format!(".{}",count)); [INFO] [stdout] 109 + let finish_ind = self.functions[&function_name].iter().position(|x| x.trim() == format!(".{}",count)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:285:46 [INFO] [stdout] | [INFO] [stdout] 285 | ... .expect(&*format!("your argument to goto on operation {} was not an integer!",count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", *format!("your argument to goto on operation {} was not an integer!",count)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:285:53 [INFO] [stdout] | [INFO] [stdout] 285 | ... .expect(&*format!("your argument to goto on operation {} was not an integer!",count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("your argument to goto on operation {} was not an integer!",count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:296:57 [INFO] [stdout] | [INFO] [stdout] 296 | ... let val: &str = &*mem.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mem.pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:302:62 [INFO] [stdout] | [INFO] [stdout] 302 | ... let first_mem_name = String::from(self.memory [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 303 | | ... .get_mut(¤t_memory) [INFO] [stdout] 304 | | ... .unwrap() [INFO] [stdout] 305 | | ... .pop() [INFO] [stdout] 306 | | ... .unwrap()); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 302 ~ let first_mem_name = self.memory [INFO] [stdout] 303 + .get_mut(¤t_memory) [INFO] [stdout] 304 + .unwrap() [INFO] [stdout] 305 + .pop() [INFO] [stdout] 306 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:307:63 [INFO] [stdout] | [INFO] [stdout] 307 | ... let second_mem_name = String::from(self.memory [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 308 | | ... .get_mut(¤t_memory) [INFO] [stdout] 309 | | ... .unwrap() [INFO] [stdout] 310 | | ... .pop() [INFO] [stdout] 311 | | ... .unwrap()); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 307 ~ let second_mem_name = self.memory [INFO] [stdout] 308 + .get_mut(¤t_memory) [INFO] [stdout] 309 + .unwrap() [INFO] [stdout] 310 + .pop() [INFO] [stdout] 311 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:321:49 [INFO] [stdout] | [INFO] [stdout] 321 | / ... String::from( [INFO] [stdout] 322 | | ... val [INFO] [stdout] 323 | | ... ) [INFO] [stdout] | |___________________________^ help: consider removing `String::from()`: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:329:63 [INFO] [stdout] | [INFO] [stdout] 329 | ... let second_mem_name = String::from(self.memory [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 330 | | ... .get_mut(¤t_memory) [INFO] [stdout] 331 | | ... .unwrap() [INFO] [stdout] 332 | | ... .pop() [INFO] [stdout] 333 | | ... .unwrap()); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 329 ~ let second_mem_name = self.memory [INFO] [stdout] 330 + .get_mut(¤t_memory) [INFO] [stdout] 331 + .unwrap() [INFO] [stdout] 332 + .pop() [INFO] [stdout] 333 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:334:62 [INFO] [stdout] | [INFO] [stdout] 334 | ... let first_mem_name = String::from(self.memory [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 335 | | ... .get_mut(¤t_memory) [INFO] [stdout] 336 | | ... .unwrap() [INFO] [stdout] 337 | | ... .pop() [INFO] [stdout] 338 | | ... .unwrap()); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 334 ~ let first_mem_name = self.memory [INFO] [stdout] 335 + .get_mut(¤t_memory) [INFO] [stdout] 336 + .unwrap() [INFO] [stdout] 337 + .pop() [INFO] [stdout] 338 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:349:49 [INFO] [stdout] | [INFO] [stdout] 349 | / ... String::from( [INFO] [stdout] 350 | | ... val [INFO] [stdout] 351 | | ... ) [INFO] [stdout] | |___________________________^ help: consider removing `String::from()`: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/main.rs:385:55 [INFO] [stdout] | [INFO] [stdout] 385 | ... Ok(_) => {();}, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:394:52 [INFO] [stdout] | [INFO] [stdout] 394 | ... let val1 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:395:52 [INFO] [stdout] | [INFO] [stdout] 395 | ... let val2 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:132:56 [INFO] [stdout] | [INFO] [stdout] 132 | ... let mut current_operator = String::from(self.functions[&function_name][ind].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.functions[&function_name][ind].clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/main.rs:135:39 [INFO] [stdout] | [INFO] [stdout] 135 | ... _ => {();} [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:138:33 [INFO] [stdout] | [INFO] [stdout] 138 | ... if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_some()` instead: `res.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:138:122 [INFO] [stdout] | [INFO] [stdout] 138 | ... if (res != None && self.memory.get_mut(¤t_memory).unwrap().pop().unwrap() == "yea") || res == None { [INFO] [stdout] | ^^^^^^^^^^^ help: use `Option::is_none()` instead: `res.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:438:52 [INFO] [stdout] | [INFO] [stdout] 438 | ... let val2 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:439:52 [INFO] [stdout] | [INFO] [stdout] 439 | ... let val1 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:141:56 [INFO] [stdout] | [INFO] [stdout] 141 | ... let file = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:142:78 [INFO] [stdout] | [INFO] [stdout] 142 | ... let mut file = File::open(&file).expect(&*format!("error: couldn't import the file {:?}",file)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", *format!("error: couldn't import the file {:?}",file)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:142:85 [INFO] [stdout] | [INFO] [stdout] 142 | ... let mut file = File::open(&file).expect(&*format!("error: couldn't import the file {:?}",file)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("error: couldn't import the file {:?}",file)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:156:54 [INFO] [stdout] | [INFO] [stdout] 156 | ... let method = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:481:52 [INFO] [stdout] | [INFO] [stdout] 481 | ... let val1 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:482:52 [INFO] [stdout] | [INFO] [stdout] 482 | ... let val2 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:285:46 [INFO] [stdout] | [INFO] [stdout] 285 | ... .expect(&*format!("your argument to goto on operation {} was not an integer!",count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{}", *format!("your argument to goto on operation {} was not an integer!",count)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:285:53 [INFO] [stdout] | [INFO] [stdout] 285 | ... .expect(&*format!("your argument to goto on operation {} was not an integer!",count)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&format!("your argument to goto on operation {} was not an integer!",count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:296:57 [INFO] [stdout] | [INFO] [stdout] 296 | ... let val: &str = &*mem.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mem.pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:538:92 [INFO] [stdout] | [INFO] [stdout] 538 | ... self.memory.get_mut(¤t_memory).unwrap().push(String::from(current_operator)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `current_operator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:302:62 [INFO] [stdout] | [INFO] [stdout] 302 | ... let first_mem_name = String::from(self.memory [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 303 | | ... .get_mut(¤t_memory) [INFO] [stdout] 304 | | ... .unwrap() [INFO] [stdout] 305 | | ... .pop() [INFO] [stdout] 306 | | ... .unwrap()); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 302 ~ let first_mem_name = self.memory [INFO] [stdout] 303 + .get_mut(¤t_memory) [INFO] [stdout] 304 + .unwrap() [INFO] [stdout] 305 + .pop() [INFO] [stdout] 306 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:307:63 [INFO] [stdout] | [INFO] [stdout] 307 | ... let second_mem_name = String::from(self.memory [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 308 | | ... .get_mut(¤t_memory) [INFO] [stdout] 309 | | ... .unwrap() [INFO] [stdout] 310 | | ... .pop() [INFO] [stdout] 311 | | ... .unwrap()); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 307 ~ let second_mem_name = self.memory [INFO] [stdout] 308 + .get_mut(¤t_memory) [INFO] [stdout] 309 + .unwrap() [INFO] [stdout] 310 + .pop() [INFO] [stdout] 311 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:321:49 [INFO] [stdout] | [INFO] [stdout] 321 | / ... String::from( [INFO] [stdout] 322 | | ... val [INFO] [stdout] 323 | | ... ) [INFO] [stdout] | |___________________________^ help: consider removing `String::from()`: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:329:63 [INFO] [stdout] | [INFO] [stdout] 329 | ... let second_mem_name = String::from(self.memory [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 330 | | ... .get_mut(¤t_memory) [INFO] [stdout] 331 | | ... .unwrap() [INFO] [stdout] 332 | | ... .pop() [INFO] [stdout] 333 | | ... .unwrap()); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 329 ~ let second_mem_name = self.memory [INFO] [stdout] 330 + .get_mut(¤t_memory) [INFO] [stdout] 331 + .unwrap() [INFO] [stdout] 332 + .pop() [INFO] [stdout] 333 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:334:62 [INFO] [stdout] | [INFO] [stdout] 334 | ... let first_mem_name = String::from(self.memory [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 335 | | ... .get_mut(¤t_memory) [INFO] [stdout] 336 | | ... .unwrap() [INFO] [stdout] 337 | | ... .pop() [INFO] [stdout] 338 | | ... .unwrap()); [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 334 ~ let first_mem_name = self.memory [INFO] [stdout] 335 + .get_mut(¤t_memory) [INFO] [stdout] 336 + .unwrap() [INFO] [stdout] 337 + .pop() [INFO] [stdout] 338 ~ .unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:349:49 [INFO] [stdout] | [INFO] [stdout] 349 | / ... String::from( [INFO] [stdout] 350 | | ... val [INFO] [stdout] 351 | | ... ) [INFO] [stdout] | |___________________________^ help: consider removing `String::from()`: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:372:52 [INFO] [stdout] | [INFO] [stdout] 372 | ... panic!(format!("the alternate stack you specified, {}, doesn't exist! spawn it first.",new)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 372 - panic!(format!("the alternate stack you specified, {}, doesn't exist! spawn it first.",new)); [INFO] [stdout] 372 + panic!("the alternate stack you specified, {}, doesn't exist! spawn it first.",new); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> src/main.rs:385:55 [INFO] [stdout] | [INFO] [stdout] 385 | ... Ok(_) => {();}, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:394:52 [INFO] [stdout] | [INFO] [stdout] 394 | ... let val1 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:395:52 [INFO] [stdout] | [INFO] [stdout] 395 | ... let val2 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:438:52 [INFO] [stdout] | [INFO] [stdout] 438 | ... let val2 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:439:52 [INFO] [stdout] | [INFO] [stdout] 439 | ... let val1 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:481:52 [INFO] [stdout] | [INFO] [stdout] 481 | ... let val1 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:482:52 [INFO] [stdout] | [INFO] [stdout] 482 | ... let val2 = String::from(self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.memory.get_mut(¤t_memory).unwrap().pop().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:538:92 [INFO] [stdout] | [INFO] [stdout] 538 | ... self.memory.get_mut(¤t_memory).unwrap().push(String::from(current_operator)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `current_operator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:372:52 [INFO] [stdout] | [INFO] [stdout] 372 | ... panic!(format!("the alternate stack you specified, {}, doesn't exist! spawn it first.",new)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 372 - panic!(format!("the alternate stack you specified, {}, doesn't exist! spawn it first.",new)); [INFO] [stdout] 372 + panic!("the alternate stack you specified, {}, doesn't exist! spawn it first.",new); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.29s [INFO] running `Command { std: "docker" "inspect" "8d565950de4a4530ad5ac0e2d6fd92fa979b0ef145ae39289b20edcf1fc7dbc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d565950de4a4530ad5ac0e2d6fd92fa979b0ef145ae39289b20edcf1fc7dbc9", kill_on_drop: false }` [INFO] [stdout] 8d565950de4a4530ad5ac0e2d6fd92fa979b0ef145ae39289b20edcf1fc7dbc9