[INFO] cloning repository https://github.com/michaleq44/snak [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/michaleq44/snak" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaleq44%2Fsnak", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaleq44%2Fsnak'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4de602a4d94ff733f23eb5e380c5fcf44586e7a3 [INFO] linting michaleq44/snak against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaleq44%2Fsnak" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/michaleq44/snak [INFO] finished tweaking git repo https://github.com/michaleq44/snak [INFO] tweaked toml for git repo https://github.com/michaleq44/snak written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/michaleq44/snak on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quad-rand v0.2.3 [INFO] [stderr] Downloaded objc-rs v0.2.8 [INFO] [stderr] Downloaded fontdue v0.9.3 [INFO] [stderr] Downloaded macroquad_macro v0.1.8 [INFO] [stderr] Downloaded miniquad v0.4.8 [INFO] [stderr] Downloaded ttf-parser v0.21.1 [INFO] [stderr] Downloaded macroquad v0.4.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 411c7f080fc79e2fae94b33f64abe0d4d3442f93964c2d0b826a0882f5b0e850 [INFO] running `Command { std: "docker" "start" "-a" "411c7f080fc79e2fae94b33f64abe0d4d3442f93964c2d0b826a0882f5b0e850", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "411c7f080fc79e2fae94b33f64abe0d4d3442f93964c2d0b826a0882f5b0e850", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "411c7f080fc79e2fae94b33f64abe0d4d3442f93964c2d0b826a0882f5b0e850", kill_on_drop: false }` [INFO] [stdout] 411c7f080fc79e2fae94b33f64abe0d4d3442f93964c2d0b826a0882f5b0e850 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e53d98e3203877491775b5bad3644aa92406ff6548fa42f97790748877e070e [INFO] running `Command { std: "docker" "start" "-a" "4e53d98e3203877491775b5bad3644aa92406ff6548fa42f97790748877e070e", kill_on_drop: false }` [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling miniquad v0.4.8 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Compiling macroquad_macro v0.1.8 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking quad-rand v0.2.3 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking fontdue v0.9.3 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking macroquad v0.4.14 [INFO] [stderr] Checking snak v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return false; [INFO] [stdout] 20 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(!fs::create_dir(".config").is_err(), "Cannot access filesystem"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::create_dir(".config").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | assert!(!fs::write(".config/conf.json", "{\"tps\": 5}").is_err(), "Cannot access filesystem"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::write(".config/conf.json", "{\"tps\": 5}").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `snaks` [INFO] [stdout] --> src/main.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..snaks.len()-1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..snaks.len()-1 { [INFO] [stdout] 34 + for in snaks.iter().take(snaks.len()-1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return false; [INFO] [stdout] 20 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | assert!(!fs::create_dir(".config").is_err(), "Cannot access filesystem"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::create_dir(".config").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | assert!(!fs::write(".config/conf.json", "{\"tps\": 5}").is_err(), "Cannot access filesystem"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::write(".config/conf.json", "{\"tps\": 5}").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `snaks` [INFO] [stdout] --> src/main.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 34 | for i in 0..snaks.len()-1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 34 - for i in 0..snaks.len()-1 { [INFO] [stdout] 34 + for in snaks.iter().take(snaks.len()-1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.62s [INFO] running `Command { std: "docker" "inspect" "4e53d98e3203877491775b5bad3644aa92406ff6548fa42f97790748877e070e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e53d98e3203877491775b5bad3644aa92406ff6548fa42f97790748877e070e", kill_on_drop: false }` [INFO] [stdout] 4e53d98e3203877491775b5bad3644aa92406ff6548fa42f97790748877e070e