[INFO] cloning repository https://github.com/michaelneale/goose-rust-port [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/michaelneale/goose-rust-port" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaelneale%2Fgoose-rust-port", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaelneale%2Fgoose-rust-port'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b7a94be71074f75601de7e44a05a2eccea9d30f8 [INFO] linting michaelneale/goose-rust-port against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaelneale%2Fgoose-rust-port" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/michaelneale/goose-rust-port [INFO] finished tweaking git repo https://github.com/michaelneale/goose-rust-port [INFO] tweaked toml for git repo https://github.com/michaelneale/goose-rust-port written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/michaelneale/goose-rust-port on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/michaelneale/goose-rust-port already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nibble_vec v0.1.0 [INFO] [stderr] Downloaded fd-lock v3.0.13 [INFO] [stderr] Downloaded ctrlc v3.4.5 [INFO] [stderr] Downloaded yoke-derive v0.7.4 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.45 [INFO] [stderr] Downloaded serde v1.0.214 [INFO] [stderr] Downloaded security-framework-sys v2.12.0 [INFO] [stderr] Downloaded schannel v0.1.26 [INFO] [stderr] Downloaded async-openai v0.17.1 [INFO] [stderr] Downloaded url v2.5.3 [INFO] [stderr] Downloaded tokio-util v0.7.12 [INFO] [stderr] Downloaded rustyline v12.0.0 [INFO] [stderr] Downloaded mio v1.0.2 [INFO] [stderr] Downloaded clap_builder v4.5.20 [INFO] [stderr] Downloaded clap v4.5.20 [INFO] [stderr] Downloaded bytes v1.8.0 [INFO] [stderr] Downloaded serde_json v1.0.132 [INFO] [stderr] Downloaded serde_derive v1.0.214 [INFO] [stderr] Downloaded radix_trie v0.2.1 [INFO] [stderr] Downloaded litemap v0.7.3 [INFO] [stderr] Downloaded yoke v0.7.4 [INFO] [stderr] Downloaded zerofrom-derive v0.1.4 [INFO] [stderr] Downloaded zerofrom v0.1.4 [INFO] [stderr] Downloaded is-terminal v0.4.13 [INFO] [stderr] Downloaded endian-type v0.1.2 [INFO] [stderr] Downloaded clipboard-win v4.5.0 [INFO] [stderr] Downloaded rustix v0.38.39 [INFO] [stderr] Downloaded web-sys v0.3.72 [INFO] [stderr] Downloaded tokio v1.41.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1edc857a88fe1fd30f1687f13c0ff7bf2d19e9c45f462534274eccd915807c3a [INFO] running `Command { std: "docker" "start" "-a" "1edc857a88fe1fd30f1687f13c0ff7bf2d19e9c45f462534274eccd915807c3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1edc857a88fe1fd30f1687f13c0ff7bf2d19e9c45f462534274eccd915807c3a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1edc857a88fe1fd30f1687f13c0ff7bf2d19e9c45f462534274eccd915807c3a", kill_on_drop: false }` [INFO] [stdout] 1edc857a88fe1fd30f1687f13c0ff7bf2d19e9c45f462534274eccd915807c3a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f2102ae481b28c7df9c2ed719fede6d082d93694fb36300a745e53db22728395 [INFO] running `Command { std: "docker" "start" "-a" "f2102ae481b28c7df9c2ed719fede6d082d93694fb36300a745e53db22728395", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Compiling cc v1.1.36 [INFO] [stderr] Checking litemap v0.7.3 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking hashbrown v0.15.1 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling unicase v2.8.0 [INFO] [stderr] Compiling serde_json v1.0.132 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling rustix v0.38.39 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.68 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Checking clap_builder v4.5.20 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking regex-automata v0.4.8 [INFO] [stderr] Checking eventsource-stream v0.2.3 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking rustyline v12.0.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking uuid v1.11.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.214 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.41.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling thiserror-impl v1.0.68 [INFO] [stderr] Checking zerofrom v0.1.4 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking async-convert v1.0.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking clap v4.5.20 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.3 [INFO] [stderr] Checking hyper v0.14.31 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking reqwest-eventsource v0.4.0 [INFO] [stderr] Checking async-openai v0.17.1 [INFO] [stderr] Checking rust-goose v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Config` [INFO] [stdout] --> src/exchange/openai.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | config::{Config, OpenAIConfig}, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/toolkit/default.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Config` [INFO] [stdout] --> src/exchange/openai.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | config::{Config, OpenAIConfig}, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/toolkit/default.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `async_openai::types::ChatCompletionRequestAssistantMessage::function_call` [INFO] [stdout] --> src/exchange/openai.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | function_call: None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `async_openai::types::ChatCompletionRequestAssistantMessage::function_call` [INFO] [stdout] --> src/exchange/openai.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 79 | function_call: None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `provider` [INFO] [stdout] --> src/cli/config.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let provider = RECOMMENDED_DEFAULT_PROVIDER; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_provider` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `processor` [INFO] [stdout] --> src/cli/config.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let processor = "gpt-4"; // TODO: Get from provider [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_processor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `accelerator` [INFO] [stdout] --> src/cli/config.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let accelerator = "none"; // TODO: Get from provider [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_accelerator` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tool` [INFO] [stdout] --> src/exchange/mod.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let tool = Tool::new( [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_tool` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `provider` [INFO] [stdout] --> src/cli/config.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | let provider = RECOMMENDED_DEFAULT_PROVIDER; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_provider` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `processor` [INFO] [stdout] --> src/cli/config.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let processor = "gpt-4"; // TODO: Get from provider [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_processor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `accelerator` [INFO] [stdout] --> src/cli/config.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let accelerator = "none"; // TODO: Get from provider [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_accelerator` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_session` [INFO] [stdout] --> src/session/mod.rs:77:33 [INFO] [stdout] | [INFO] [stdout] 77 | pub async fn run(&mut self, new_session: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_session` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `plan` after checking its variant with `is_some` [INFO] [stdout] --> src/cli/session.rs:74:32 [INFO] [stdout] | [INFO] [stdout] 73 | if session.messages.is_empty() && plan.is_some() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 74 | session.setup_plan(plan.unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cli/session.rs:37:40 [INFO] [stdout] | [INFO] [stdout] 37 | let name = name.unwrap_or_else(|| generate_name()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `generate_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/models/profile.rs:45:29 [INFO] [stdout] | [INFO] [stdout] 45 | for (_, req) in &toolkit.requires { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 45 - for (_, req) in &toolkit.requires { [INFO] [stdout] 45 + for req in toolkit.requires.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/toolkit/base.rs:78:52 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get(&self, requirement: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&dyn Toolkit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/toolkit/tools.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if !params.get(req).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `params.get(req).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultToolkit` [INFO] [stdout] --> src/toolkit/default.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> Self { [INFO] [stdout] 17 | | let tools = vec![ [INFO] [stdout] 18 | | Tool::new( [INFO] [stdout] 19 | | "bash", [INFO] [stdout] ... | [INFO] [stdout] 136 | | Self { tools } [INFO] [stdout] 137 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for DefaultToolkit { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/toolkit/default.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 202 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils/session_file.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | .map(|line| serde_json::from_str(line)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `serde_json::from_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tool` [INFO] [stdout] --> src/exchange/mod.rs:99:21 [INFO] [stdout] | [INFO] [stdout] 99 | let tool = Tool::new( [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_tool` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToolkitResult` [INFO] [stdout] --> tests/toolkit_integration.rs:2:42 [INFO] [stdout] | [INFO] [stdout] 2 | use rust_goose::toolkit::{Tool, Toolkit, ToolkitResult}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_session` [INFO] [stdout] --> src/session/mod.rs:77:33 [INFO] [stdout] | [INFO] [stdout] 77 | pub async fn run(&mut self, new_session: bool) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_session` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/session_integration.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | let mut session = Session::new( [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `plan` after checking its variant with `is_some` [INFO] [stdout] --> src/cli/session.rs:74:32 [INFO] [stdout] | [INFO] [stdout] 73 | if session.messages.is_empty() && plan.is_some() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 74 | session.setup_plan(plan.unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cli/session.rs:37:40 [INFO] [stdout] | [INFO] [stdout] 37 | let name = name.unwrap_or_else(|| generate_name()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `generate_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | let mut session = rust_goose::session::SessionLoop::new( [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `log_level` [INFO] [stdout] --> src/main.rs:138:54 [INFO] [stdout] | [INFO] [stdout] 138 | SessionCommands::Resume { name, profile, log_level } => { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `log_level: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tokens` [INFO] [stdout] --> src/main.rs:150:44 [INFO] [stdout] | [INFO] [stdout] 150 | SessionCommands::Stats { name, tokens, cost, all } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `tokens: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cost` [INFO] [stdout] --> src/main.rs:150:52 [INFO] [stdout] | [INFO] [stdout] 150 | SessionCommands::Stats { name, tokens, cost, all } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `cost: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:141:41 [INFO] [stdout] | [INFO] [stdout] 141 | name.unwrap_or_else(|| rust_goose::utils::generate_name()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rust_goose::utils::generate_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:153:41 [INFO] [stdout] | [INFO] [stdout] 153 | name.unwrap_or_else(|| rust_goose::utils::generate_name()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rust_goose::utils::generate_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | let mut session = rust_goose::session::SessionLoop::new( [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `log_level` [INFO] [stdout] --> src/main.rs:138:54 [INFO] [stdout] | [INFO] [stdout] 138 | SessionCommands::Resume { name, profile, log_level } => { [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `log_level: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tokens` [INFO] [stdout] --> src/main.rs:150:44 [INFO] [stdout] | [INFO] [stdout] 150 | SessionCommands::Stats { name, tokens, cost, all } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `tokens: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cost` [INFO] [stdout] --> src/main.rs:150:52 [INFO] [stdout] | [INFO] [stdout] 150 | SessionCommands::Stats { name, tokens, cost, all } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `cost: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/models/profile.rs:45:29 [INFO] [stdout] | [INFO] [stdout] 45 | for (_, req) in &toolkit.requires { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 45 - for (_, req) in &toolkit.requires { [INFO] [stdout] 45 + for req in toolkit.requires.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/toolkit/base.rs:78:52 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get(&self, requirement: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&dyn Toolkit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/toolkit/tools.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if !params.get(req).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `params.get(req).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `DefaultToolkit` [INFO] [stdout] --> src/toolkit/default.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> Self { [INFO] [stdout] 17 | | let tools = vec![ [INFO] [stdout] 18 | | Tool::new( [INFO] [stdout] 19 | | "bash", [INFO] [stdout] ... | [INFO] [stdout] 136 | | Self { tools } [INFO] [stdout] 137 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for DefaultToolkit { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/toolkit/default.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 202 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:141:41 [INFO] [stdout] | [INFO] [stdout] 141 | name.unwrap_or_else(|| rust_goose::utils::generate_name()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rust_goose::utils::generate_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:153:41 [INFO] [stdout] | [INFO] [stdout] 153 | name.unwrap_or_else(|| rust_goose::utils::generate_name()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `rust_goose::utils::generate_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils/session_file.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | .map(|line| serde_json::from_str(line)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `serde_json::from_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 38s [INFO] running `Command { std: "docker" "inspect" "f2102ae481b28c7df9c2ed719fede6d082d93694fb36300a745e53db22728395", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2102ae481b28c7df9c2ed719fede6d082d93694fb36300a745e53db22728395", kill_on_drop: false }` [INFO] [stdout] f2102ae481b28c7df9c2ed719fede6d082d93694fb36300a745e53db22728395