[INFO] cloning repository https://github.com/michaeleliot/RustChess [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/michaeleliot/RustChess" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaeleliot%2FRustChess", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaeleliot%2FRustChess'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c69893819dcca1e2c2c7b382187dbac54726bb16 [INFO] linting michaeleliot/RustChess against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichaeleliot%2FRustChess" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/michaeleliot/RustChess [INFO] finished tweaking git repo https://github.com/michaeleliot/RustChess [INFO] tweaked toml for git repo https://github.com/michaeleliot/RustChess written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/michaeleliot/RustChess on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/michaeleliot/RustChess already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2070233c3289b875387591eea6c1576e0a4bb809a65f3ee38c308c2c7d6f7f5b [INFO] running `Command { std: "docker" "start" "-a" "2070233c3289b875387591eea6c1576e0a4bb809a65f3ee38c308c2c7d6f7f5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2070233c3289b875387591eea6c1576e0a4bb809a65f3ee38c308c2c7d6f7f5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2070233c3289b875387591eea6c1576e0a4bb809a65f3ee38c308c2c7d6f7f5b", kill_on_drop: false }` [INFO] [stdout] 2070233c3289b875387591eea6c1576e0a4bb809a65f3ee38c308c2c7d6f7f5b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26dbb03c42933f08adb0203ec2cb20d6e7067575fac8d459142bc4d50cc909d2 [INFO] running `Command { std: "docker" "start" "-a" "26dbb03c42933f08adb0203ec2cb20d6e7067575fac8d459142bc4d50cc909d2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hello_world v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `print!` in `Display` impl [INFO] [stdout] --> src/board.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | print!("{}", space_string); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `write!(_f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] = note: `#[warn(clippy::print_in_format_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/board.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | println!(""); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `writeln!(_f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/board.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/board.rs:27:29 [INFO] [stdout] | [INFO] [stdout] 27 | let mut divider = format!("|"); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `"|".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `print!` in `Display` impl [INFO] [stdout] --> src/board.rs:31:11 [INFO] [stdout] | [INFO] [stdout] 31 | print!("{}", divider); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `write!(_f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return Ok(self.check_game_over()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Ok(self.check_game_over()); [INFO] [stdout] 56 + Ok(self.check_game_over()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board.rs:63:7 [INFO] [stdout] | [INFO] [stdout] 63 | return space_indexes[random_space_index] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return space_indexes[random_space_index] [INFO] [stdout] 63 + space_indexes[random_space_index] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/board.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if potential_space_indexes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `potential_space_indexes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `optional_winning_player` after checking its variant with `is_some` [INFO] [stdout] --> src/board.rs:128:43 [INFO] [stdout] | [INFO] [stdout] 126 | if optional_winning_player.is_some() { [INFO] [stdout] | ------------------------------------ help: try: `if let Some() = optional_winning_player` [INFO] [stdout] 127 | println!(); [INFO] [stdout] 128 | println!("Game Over, Winner Is {}", optional_winning_player.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return optional_winning_player; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return optional_winning_player; [INFO] [stdout] 130 + optional_winning_player [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:101:56 [INFO] [stdout] | [INFO] [stdout] 101 | let optional_winner_first_col = check_three_in_row([self.spaces[0], self.spaces[3], self.spaces[6]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:102:57 [INFO] [stdout] | [INFO] [stdout] 102 | let optional_winner_second_col = check_three_in_row([self.spaces[1], self.spaces[4], self.spaces[7]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:103:56 [INFO] [stdout] | [INFO] [stdout] 103 | let optional_winner_third_col = check_three_in_row([self.spaces[2], self.spaces[5], self.spaces[8]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:105:65 [INFO] [stdout] | [INFO] [stdout] 105 | let optional_winner_left_to_right_diag = check_three_in_row([self.spaces[0], self.spaces[4], self.spaces[8]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:106:65 [INFO] [stdout] | [INFO] [stdout] 106 | let optional_winner_right_to_left_diag = check_three_in_row([self.spaces[2], self.spaces[4], self.spaces[6]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | .filter(|&&x| !x.is_none()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `x.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:55:7 [INFO] [stdout] | [INFO] [stdout] 55 | return Some(result) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Some(result) [INFO] [stdout] 55 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:59:7 [INFO] [stdout] | [INFO] [stdout] 59 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return None [INFO] [stdout] 59 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `print!` in `Display` impl [INFO] [stdout] --> src/board.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | print!("{}", space_string); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `write!(_f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] = note: `#[warn(clippy::print_in_format_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `println!` in `Display` impl [INFO] [stdout] --> src/board.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | println!(""); [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `writeln!(_f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/board.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/board.rs:27:29 [INFO] [stdout] | [INFO] [stdout] 27 | let mut divider = format!("|"); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `"|".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `print!` in `Display` impl [INFO] [stdout] --> src/board.rs:31:11 [INFO] [stdout] | [INFO] [stdout] 31 | print!("{}", divider); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `write!(_f, ..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_in_format_impl [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | return Ok(self.check_game_over()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Ok(self.check_game_over()); [INFO] [stdout] 56 + Ok(self.check_game_over()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board.rs:63:7 [INFO] [stdout] | [INFO] [stdout] 63 | return space_indexes[random_space_index] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return space_indexes[random_space_index] [INFO] [stdout] 63 + space_indexes[random_space_index] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/board.rs:77:8 [INFO] [stdout] | [INFO] [stdout] 77 | if potential_space_indexes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `potential_space_indexes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `optional_winning_player` after checking its variant with `is_some` [INFO] [stdout] --> src/board.rs:128:43 [INFO] [stdout] | [INFO] [stdout] 126 | if optional_winning_player.is_some() { [INFO] [stdout] | ------------------------------------ help: try: `if let Some() = optional_winning_player` [INFO] [stdout] 127 | println!(); [INFO] [stdout] 128 | println!("Game Over, Winner Is {}", optional_winning_player.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/board.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return optional_winning_player; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return optional_winning_player; [INFO] [stdout] 130 + optional_winning_player [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:101:56 [INFO] [stdout] | [INFO] [stdout] 101 | let optional_winner_first_col = check_three_in_row([self.spaces[0], self.spaces[3], self.spaces[6]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:102:57 [INFO] [stdout] | [INFO] [stdout] 102 | let optional_winner_second_col = check_three_in_row([self.spaces[1], self.spaces[4], self.spaces[7]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:103:56 [INFO] [stdout] | [INFO] [stdout] 103 | let optional_winner_third_col = check_three_in_row([self.spaces[2], self.spaces[5], self.spaces[8]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:105:65 [INFO] [stdout] | [INFO] [stdout] 105 | let optional_winner_left_to_right_diag = check_three_in_row([self.spaces[0], self.spaces[4], self.spaces[8]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[board_space::BoardSpaceState; 3]` [INFO] [stdout] --> src/board.rs:106:65 [INFO] [stdout] | [INFO] [stdout] 106 | let optional_winner_right_to_left_diag = check_three_in_row([self.spaces[2], self.spaces[4], self.spaces[6]].try_into().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | .filter(|&&x| !x.is_none()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `x.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:55:7 [INFO] [stdout] | [INFO] [stdout] 55 | return Some(result) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Some(result) [INFO] [stdout] 55 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:59:7 [INFO] [stdout] | [INFO] [stdout] 59 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return None [INFO] [stdout] 59 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.89s [INFO] running `Command { std: "docker" "inspect" "26dbb03c42933f08adb0203ec2cb20d6e7067575fac8d459142bc4d50cc909d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26dbb03c42933f08adb0203ec2cb20d6e7067575fac8d459142bc4d50cc909d2", kill_on_drop: false }` [INFO] [stdout] 26dbb03c42933f08adb0203ec2cb20d6e7067575fac8d459142bc4d50cc909d2