[INFO] cloning repository https://github.com/michael-farwell/rust-by-example [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/michael-farwell/rust-by-example" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichael-farwell%2Frust-by-example", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichael-farwell%2Frust-by-example'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] acb3629cb4c083ce0cb82191fb45374047985034 [INFO] linting michael-farwell/rust-by-example against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmichael-farwell%2Frust-by-example" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/michael-farwell/rust-by-example [INFO] finished tweaking git repo https://github.com/michael-farwell/rust-by-example [INFO] tweaked toml for git repo https://github.com/michael-farwell/rust-by-example written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/michael-farwell/rust-by-example on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/michael-farwell/rust-by-example already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e927e0d06f78d1028c310da8ef6cdf422edfb89af469cc88980d4322411d3833 [INFO] running `Command { std: "docker" "start" "-a" "e927e0d06f78d1028c310da8ef6cdf422edfb89af469cc88980d4322411d3833", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e927e0d06f78d1028c310da8ef6cdf422edfb89af469cc88980d4322411d3833", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e927e0d06f78d1028c310da8ef6cdf422edfb89af469cc88980d4322411d3833", kill_on_drop: false }` [INFO] [stdout] e927e0d06f78d1028c310da8ef6cdf422edfb89af469cc88980d4322411d3833 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d10d48a95b16ecf54aefa635593c7b9aac87ba2c41602b6c95fb65153a2438bb [INFO] running `Command { std: "docker" "start" "-a" "d10d48a95b16ecf54aefa635593c7b9aac87ba2c41602b6c95fb65153a2438bb", kill_on_drop: false }` [INFO] [stderr] Checking rust-by-example v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/hello.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | object = "the lazy dog", [INFO] [stdout] | _______________________^ [INFO] [stdout] 17 | | subject = "the quick brown fox", [INFO] [stdout] 18 | | verb = "jumps over"); [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 - println!("{subject} {verb} {object}", [INFO] [stdout] 16 - object = "the lazy dog", [INFO] [stdout] 17 - subject = "the quick brown fox", [INFO] [stdout] 18 - verb = "jumps over"); [INFO] [stdout] 15 + println!("the quick brown fox jumps over the lazy dog"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/hello.rs:21:49 [INFO] [stdout] | [INFO] [stdout] 21 | println!("My name is {0}, {1} {0}", "Bond", "James"); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 - println!("My name is {0}, {1} {0}", "Bond", "James"); [INFO] [stdout] 21 + println!("My name is {0}, James {0}", "Bond"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/hello.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | object = "the lazy dog", [INFO] [stdout] | _______________________^ [INFO] [stdout] 17 | | subject = "the quick brown fox", [INFO] [stdout] 18 | | verb = "jumps over"); [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 - println!("{subject} {verb} {object}", [INFO] [stdout] 16 - object = "the lazy dog", [INFO] [stdout] 17 - subject = "the quick brown fox", [INFO] [stdout] 18 - verb = "jumps over"); [INFO] [stdout] 15 + println!("the quick brown fox jumps over the lazy dog"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/hello.rs:21:49 [INFO] [stdout] | [INFO] [stdout] 21 | println!("My name is {0}, {1} {0}", "Bond", "James"); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 - println!("My name is {0}, {1} {0}", "Bond", "James"); [INFO] [stdout] 21 + println!("My name is {0}, James {0}", "Bond"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/hello.rs:172:37 [INFO] [stdout] | [INFO] [stdout] 172 | City { name: "Dublin", lat: 53.347778, lon: -6.259722 }, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 172 - City { name: "Dublin", lat: 53.347778, lon: -6.259722 }, [INFO] [stdout] 172 + City { name: "Dublin", lat: 53.347_78, lon: -6.259722 }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives.rs:30:38 [INFO] [stdout] | [INFO] [stdout] 30 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives.rs:31:37 [INFO] [stdout] | [INFO] [stdout] 31 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives.rs:32:32 [INFO] [stdout] | [INFO] [stdout] 32 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/hello.rs:172:37 [INFO] [stdout] | [INFO] [stdout] 172 | City { name: "Dublin", lat: 53.347778, lon: -6.259722 }, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 172 - City { name: "Dublin", lat: 53.347778, lon: -6.259722 }, [INFO] [stdout] 172 + City { name: "Dublin", lat: 53.347_78, lon: -6.259722 }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives.rs:30:38 [INFO] [stdout] | [INFO] [stdout] 30 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives.rs:31:37 [INFO] [stdout] | [INFO] [stdout] 31 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/primitives.rs:32:32 [INFO] [stdout] | [INFO] [stdout] 32 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/custom_types.rs:221:17 [INFO] [stdout] | [INFO] [stdout] 221 | format!("Nil") [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Nil".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/custom_types.rs:221:17 [INFO] [stdout] | [INFO] [stdout] 221 | format!("Nil") [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Nil".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.43s [INFO] running `Command { std: "docker" "inspect" "d10d48a95b16ecf54aefa635593c7b9aac87ba2c41602b6c95fb65153a2438bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d10d48a95b16ecf54aefa635593c7b9aac87ba2c41602b6c95fb65153a2438bb", kill_on_drop: false }` [INFO] [stdout] d10d48a95b16ecf54aefa635593c7b9aac87ba2c41602b6c95fb65153a2438bb