[INFO] cloning repository https://github.com/mezeipetister/storaget [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/mezeipetister/storaget" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmezeipetister%2Fstoraget", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmezeipetister%2Fstoraget'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f2e4db5310bdeecc39c166449d449303b38a26e3 [INFO] linting mezeipetister/storaget/f2e4db5310bdeecc39c166449d449303b38a26e3 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmezeipetister%2Fstoraget" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/mezeipetister/storaget [INFO] finished tweaking git repo https://github.com/mezeipetister/storaget [INFO] tweaked toml for git repo https://github.com/mezeipetister/storaget written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/mezeipetister/storaget on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding rand v0.7.3 (available: v0.10.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b60589bd006a04a65864e1ec536b775dbab71aa7b83b20fb31ecce17de1577a [INFO] running `Command { std: "docker" "start" "-a" "3b60589bd006a04a65864e1ec536b775dbab71aa7b83b20fb31ecce17de1577a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b60589bd006a04a65864e1ec536b775dbab71aa7b83b20fb31ecce17de1577a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b60589bd006a04a65864e1ec536b775dbab71aa7b83b20fb31ecce17de1577a", kill_on_drop: false }` [INFO] [stdout] 3b60589bd006a04a65864e1ec536b775dbab71aa7b83b20fb31ecce17de1577a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d0b4d759a69c8b1f3f8d03a4e84a8ac1b89ebf29e0fea6965ea6ed498a8ddb5f [INFO] running `Command { std: "docker" "start" "-a" "d0b4d759a69c8b1f3f8d03a4e84a8ac1b89ebf29e0fea6965ea6ed498a8ddb5f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking storaget v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:233:21 [INFO] [stdout] | [INFO] [stdout] 233 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | data: data, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:233:21 [INFO] [stdout] | [INFO] [stdout] 233 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/lib.rs:212:6 [INFO] [stdout] | [INFO] [stdout] 212 | impl<'a, T> Pack [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:247:19 [INFO] [stdout] | [INFO] [stdout] 247 | path.push(&format!("{}.yml", file_id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.yml", file_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/lib.rs:255:6 [INFO] [stdout] | [INFO] [stdout] 255 | impl<'a, T> Pack [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:268:41 [INFO] [stdout] | [INFO] [stdout] 268 | match serde_yaml::from_str::(&buffer) { [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | path.push(&format!("{}.yml", file_id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.yml", file_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/lib.rs:212:6 [INFO] [stdout] | [INFO] [stdout] 212 | impl<'a, T> Pack [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | &self.data [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:391:9 [INFO] [stdout] | [INFO] [stdout] 391 | &mut self.data [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:406:34 [INFO] [stdout] | [INFO] [stdout] 406 | let _ = save_data_object(&self.path, &self.data); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:247:19 [INFO] [stdout] | [INFO] [stdout] 247 | path.push(&format!("{}.yml", file_id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.yml", file_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/lib.rs:255:6 [INFO] [stdout] | [INFO] [stdout] 255 | impl<'a, T> Pack [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:268:41 [INFO] [stdout] | [INFO] [stdout] 268 | match serde_yaml::from_str::(&buffer) { [INFO] [stdout] | ^^^^^^^ help: change this to: `buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:480:22 [INFO] [stdout] | [INFO] [stdout] 480 | .expect(&format!( [INFO] [stdout] | ______________________^ [INFO] [stdout] 481 | | "Error while adding file to VecPack with ID: {}", [INFO] [stdout] 482 | | (&path).to_str().unwrap() [INFO] [stdout] 483 | | )); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 480 ~ .unwrap_or_else(|_| panic!("Error while adding file to VecPack with ID: {}", [INFO] [stdout] 481 ~ (&path).to_str().unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:473:69 [INFO] [stdout] | [INFO] [stdout] 473 | Pack::::try_load_from_path(path.clone()).expect( [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 474 | | &format!( [INFO] [stdout] 475 | | "Cannot deserialize file with ID: {}", [INFO] [stdout] 476 | | (&path).to_str().unwrap() [INFO] [stdout] 477 | | ), [INFO] [stdout] 478 | | ), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 473 ~ Pack::::try_load_from_path(path.clone()).unwrap_or_else(|_| panic!("Cannot deserialize file with ID: {}", [INFO] [stdout] 474 ~ (&path).to_str().unwrap())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:476:33 [INFO] [stdout] | [INFO] [stdout] 476 | ... (&path).to_str().unwrap() [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:482:25 [INFO] [stdout] | [INFO] [stdout] 482 | (&path).to_str().unwrap() [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | path.push(&format!("{}.yml", file_id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.yml", file_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:569:22 [INFO] [stdout] | [INFO] [stdout] 569 | .expect(&format!( [INFO] [stdout] | ______________________^ [INFO] [stdout] 570 | | "Error while adding file to VecPack with ID: {}", [INFO] [stdout] 571 | | (&path).to_str().unwrap() [INFO] [stdout] 572 | | )); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 569 ~ .unwrap_or_else(|_| panic!("Error while adding file to VecPack with ID: {}", [INFO] [stdout] 570 ~ (&path).to_str().unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:562:65 [INFO] [stdout] | [INFO] [stdout] 562 | Pack::::load_from_path(path.clone()).expect( [INFO] [stdout] | _________________________________________________________________^ [INFO] [stdout] 563 | | &format!( [INFO] [stdout] 564 | | "Cannot deserialize file with ID: {}", [INFO] [stdout] 565 | | (&path).to_str().unwrap() [INFO] [stdout] 566 | | ), [INFO] [stdout] 567 | | ), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 562 ~ Pack::::load_from_path(path.clone()).unwrap_or_else(|_| panic!("Cannot deserialize file with ID: {}", [INFO] [stdout] 563 ~ (&path).to_str().unwrap())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:565:33 [INFO] [stdout] | [INFO] [stdout] 565 | ... (&path).to_str().unwrap() [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | &self.data [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:571:25 [INFO] [stdout] | [INFO] [stdout] 571 | (&path).to_str().unwrap() [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:391:9 [INFO] [stdout] | [INFO] [stdout] 391 | &mut self.data [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:406:34 [INFO] [stdout] | [INFO] [stdout] 406 | let _ = save_data_object(&self.path, &self.data); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/lib.rs:584:21 [INFO] [stdout] | [INFO] [stdout] 584 | let mut p = (&self.path).clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:585:16 [INFO] [stdout] | [INFO] [stdout] 585 | p.push(&format!("{}.yml", item.get_id())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.yml", item.get_id())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:615:27 [INFO] [stdout] | [INFO] [stdout] 615 | Some(p) => Ok(&self.get(p).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.get(p).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/lib.rs:631:9 [INFO] [stdout] | [INFO] [stdout] 631 | / match self.iter().position(|i| i.get_id() == id) { [INFO] [stdout] 632 | | Some(_) => false, [INFO] [stdout] 633 | | None => true, [INFO] [stdout] 634 | | } [INFO] [stdout] | |_________^ help: try: `self.iter().position(|i| i.get_id() == id).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:480:22 [INFO] [stdout] | [INFO] [stdout] 480 | .expect(&format!( [INFO] [stdout] | ______________________^ [INFO] [stdout] 481 | | "Error while adding file to VecPack with ID: {}", [INFO] [stdout] 482 | | (&path).to_str().unwrap() [INFO] [stdout] 483 | | )); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 480 ~ .unwrap_or_else(|_| panic!("Error while adding file to VecPack with ID: {}", [INFO] [stdout] 481 ~ (&path).to_str().unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:649:9 [INFO] [stdout] | [INFO] [stdout] 649 | &self.path.as_path() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.path.as_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:473:69 [INFO] [stdout] | [INFO] [stdout] 473 | Pack::::try_load_from_path(path.clone()).expect( [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 474 | | &format!( [INFO] [stdout] 475 | | "Cannot deserialize file with ID: {}", [INFO] [stdout] 476 | | (&path).to_str().unwrap() [INFO] [stdout] 477 | | ), [INFO] [stdout] 478 | | ), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 473 ~ Pack::::try_load_from_path(path.clone()).unwrap_or_else(|_| panic!("Cannot deserialize file with ID: {}", [INFO] [stdout] 474 ~ (&path).to_str().unwrap())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:476:33 [INFO] [stdout] | [INFO] [stdout] 476 | ... (&path).to_str().unwrap() [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/lib.rs:687:21 [INFO] [stdout] | [INFO] [stdout] 687 | let slice = std::mem::replace(&mut self.data, &mut []); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.data)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:482:25 [INFO] [stdout] | [INFO] [stdout] 482 | (&path).to_str().unwrap() [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:733:9 [INFO] [stdout] | [INFO] [stdout] 733 | &mut self.data [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `test` is declared but not used [INFO] [stdout] --> src/lib.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | #![feature(test)] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:569:22 [INFO] [stdout] | [INFO] [stdout] 569 | .expect(&format!( [INFO] [stdout] | ______________________^ [INFO] [stdout] 570 | | "Error while adding file to VecPack with ID: {}", [INFO] [stdout] 571 | | (&path).to_str().unwrap() [INFO] [stdout] 572 | | )); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 569 ~ .unwrap_or_else(|_| panic!("Error while adding file to VecPack with ID: {}", [INFO] [stdout] 570 ~ (&path).to_str().unwrap())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/lib.rs:562:65 [INFO] [stdout] | [INFO] [stdout] 562 | Pack::::load_from_path(path.clone()).expect( [INFO] [stdout] | _________________________________________________________________^ [INFO] [stdout] 563 | | &format!( [INFO] [stdout] 564 | | "Cannot deserialize file with ID: {}", [INFO] [stdout] 565 | | (&path).to_str().unwrap() [INFO] [stdout] 566 | | ), [INFO] [stdout] 567 | | ), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 562 ~ Pack::::load_from_path(path.clone()).unwrap_or_else(|_| panic!("Cannot deserialize file with ID: {}", [INFO] [stdout] 563 ~ (&path).to_str().unwrap())), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:565:33 [INFO] [stdout] | [INFO] [stdout] 565 | ... (&path).to_str().unwrap() [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:571:25 [INFO] [stdout] | [INFO] [stdout] 571 | (&path).to_str().unwrap() [INFO] [stdout] | ^^^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/lib.rs:584:21 [INFO] [stdout] | [INFO] [stdout] 584 | let mut p = (&self.path).clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:585:16 [INFO] [stdout] | [INFO] [stdout] 585 | p.push(&format!("{}.yml", item.get_id())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.yml", item.get_id())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:615:27 [INFO] [stdout] | [INFO] [stdout] 615 | Some(p) => Ok(&self.get(p).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.get(p).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/lib.rs:631:9 [INFO] [stdout] | [INFO] [stdout] 631 | / match self.iter().position(|i| i.get_id() == id) { [INFO] [stdout] 632 | | Some(_) => false, [INFO] [stdout] 633 | | None => true, [INFO] [stdout] 634 | | } [INFO] [stdout] | |_________^ help: try: `self.iter().position(|i| i.get_id() == id).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:649:9 [INFO] [stdout] | [INFO] [stdout] 649 | &self.path.as_path() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.path.as_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/lib.rs:687:21 [INFO] [stdout] | [INFO] [stdout] 687 | let slice = std::mem::replace(&mut self.data, &mut []); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.data)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:733:9 [INFO] [stdout] | [INFO] [stdout] 733 | &mut self.data [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `self.data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `test` is declared but not used [INFO] [stdout] --> src/lib.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | #![feature(test)] [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/pack_test.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | assert_eq!(meaning_of_life.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 9 - assert_eq!(meaning_of_life.is_ok(), true); [INFO] [stdout] 9 + assert!(meaning_of_life.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> tests/pack_test.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | &mut meaning_of_life.update(|i| *i = 42); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `meaning_of_life.update(|i| *i = 42);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> tests/pack_test.rs:123:40 [INFO] [stdout] | [INFO] [stdout] 123 | assert_eq!(meaning_of_life.get(|i| i.clone()), 42); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> tests/pack_test.rs:147:40 [INFO] [stdout] | [INFO] [stdout] 147 | assert_eq!(meaning_of_life.get(|i| i.clone()), 1000); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> tests/pack_test.rs:160:40 [INFO] [stdout] | [INFO] [stdout] 160 | assert_eq!(meaning_of_life.get(|i| i.clone()), 10000); [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> tests/pack_test.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | &mut meaning_of_life.update(|i| *i = 42); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 20 | let _ = &mut meaning_of_life.update(|i| *i = 42); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/vecpack_test.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | assert_eq!(meaning_of_life.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 51 - assert_eq!(meaning_of_life.is_ok(), true); [INFO] [stdout] 51 + assert!(meaning_of_life.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cars.get(0)` [INFO] [stdout] --> tests/vecpack_test.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 93 | assert_eq!(cars.get(0).unwrap().hp, 1); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `cars.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/vecpack_test.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | assert_eq!(cars.find_id("3").is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 99 - assert_eq!(cars.find_id("3").is_ok(), true); [INFO] [stdout] 99 + assert!(cars.find_id("3").is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/vecpack_test.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | assert_eq!(cars.find_id_mut("4").is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 133 - assert_eq!(cars.find_id_mut("4").is_ok(), false); [INFO] [stdout] 133 + assert!(!cars.find_id_mut("4").is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/vecpack_test.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | assert_eq!(cars.find_id_mut("100").is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 134 - assert_eq!(cars.find_id_mut("100").is_ok(), false); [INFO] [stdout] 134 + assert!(!cars.find_id_mut("100").is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/vecpack_test.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | assert_eq!(robots.find_id("a").is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 157 - assert_eq!(robots.find_id("a").is_ok(), true); [INFO] [stdout] 157 + assert!(robots.find_id("a").is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `robots.get(0)` [INFO] [stdout] --> tests/vecpack_test.rs:175:16 [INFO] [stdout] | [INFO] [stdout] 175 | assert_eq!(robots.get(0).unwrap().name, "Mini Roboto"); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `robots.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.92s [INFO] running `Command { std: "docker" "inspect" "d0b4d759a69c8b1f3f8d03a4e84a8ac1b89ebf29e0fea6965ea6ed498a8ddb5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0b4d759a69c8b1f3f8d03a4e84a8ac1b89ebf29e0fea6965ea6ed498a8ddb5f", kill_on_drop: false }` [INFO] [stdout] d0b4d759a69c8b1f3f8d03a4e84a8ac1b89ebf29e0fea6965ea6ed498a8ddb5f