[INFO] cloning repository https://github.com/methy-dino/conway [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/methy-dino/conway" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmethy-dino%2Fconway", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmethy-dino%2Fconway'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5d924337ba48c9ca82383fb9ba07e4be2f44e0b5 [INFO] linting methy-dino/conway against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmethy-dino%2Fconway" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/methy-dino/conway [INFO] finished tweaking git repo https://github.com/methy-dino/conway [INFO] tweaked toml for git repo https://github.com/methy-dino/conway written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/methy-dino/conway on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/methy-dino/conway already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f632e8a37891e50d2dbd486233c93fcee2a97d963bc24c29312d6139d32952fc [INFO] running `Command { std: "docker" "start" "-a" "f632e8a37891e50d2dbd486233c93fcee2a97d963bc24c29312d6139d32952fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f632e8a37891e50d2dbd486233c93fcee2a97d963bc24c29312d6139d32952fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f632e8a37891e50d2dbd486233c93fcee2a97d963bc24c29312d6139d32952fc", kill_on_drop: false }` [INFO] [stdout] f632e8a37891e50d2dbd486233c93fcee2a97d963bc24c29312d6139d32952fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa793be3c9817b2eab6a867a396a2b085c1681a2d80de3ac326a231686d94379 [INFO] running `Command { std: "docker" "start" "-a" "aa793be3c9817b2eab6a867a396a2b085c1681a2d80de3ac326a231686d94379", kill_on_drop: false }` [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling bindgen v0.70.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling libloading v0.8.9 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling seq-macro v0.3.6 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling raylib-sys v5.5.1 [INFO] [stderr] Checking raylib v5.5.1 [INFO] [stderr] Checking conway v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: value assigned to `j` is never read [INFO] [stdout] --> src/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | let mut j = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `j` is never read [INFO] [stdout] --> src/main.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | let mut j = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 57 | } else if (sum < 2 && game_instance.board[i][j]) || (sum > 3 && game_instance.board[i][j]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 - } else if (sum < 2 && game_instance.board[i][j]) || (sum > 3 && game_instance.board[i][j]) { [INFO] [stdout] 57 + } else if !(!game_instance.board[i][j] || sum >= 2 && sum <= 3) { [INFO] [stdout] | [INFO] [stdout] 57 - } else if (sum < 2 && game_instance.board[i][j]) || (sum > 3 && game_instance.board[i][j]) { [INFO] [stdout] 57 + } else if (sum > 3 || sum < 2) && game_instance.board[i][j] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:57:23 [INFO] [stdout] | [INFO] [stdout] 57 | } else if (sum < 2 && game_instance.board[i][j]) || (sum > 3 && game_instance.board[i][j]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 - } else if (sum < 2 && game_instance.board[i][j]) || (sum > 3 && game_instance.board[i][j]) { [INFO] [stdout] 57 + } else if !(!game_instance.board[i][j] || sum >= 2 && sum <= 3) { [INFO] [stdout] | [INFO] [stdout] 57 - } else if (sum < 2 && game_instance.board[i][j]) || (sum > 3 && game_instance.board[i][j]) { [INFO] [stdout] 57 + } else if (sum > 3 || sum < 2) && game_instance.board[i][j] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 54 | if sum == 3 && game_instance.board[i][j] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!game_instance.board[i][j]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:54:28 [INFO] [stdout] | [INFO] [stdout] 54 | if sum == 3 && game_instance.board[i][j] == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!game_instance.board[i][j]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`bool` -> `bool`) [INFO] [stdout] --> src/main.rs:88:50 [INFO] [stdout] | [INFO] [stdout] 88 | let mut game_instance: Game = Game{board : [[false as bool; largura]; largura], update_queue : Vec::new()}; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`bool` -> `bool`) [INFO] [stdout] --> src/main.rs:88:50 [INFO] [stdout] | [INFO] [stdout] 88 | let mut game_instance: Game = Game{board : [[false as bool; largura]; largura], update_queue : Vec::new()}; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:114:16 [INFO] [stdout] | [INFO] [stdout] 114 | if last_down_p == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `!last_down_p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:114:16 [INFO] [stdout] | [INFO] [stdout] 114 | if last_down_p == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `!last_down_p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `largura` should have an upper case name [INFO] [stdout] --> src/main.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const largura : usize = 72; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 12 - const largura : usize = 72; [INFO] [stdout] 12 + const LARGURA : usize = 72; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `largura` should have an upper case name [INFO] [stdout] --> src/main.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | const largura : usize = 72; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 12 - const largura : usize = 72; [INFO] [stdout] 12 + const LARGURA : usize = 72; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 38.69s [INFO] running `Command { std: "docker" "inspect" "aa793be3c9817b2eab6a867a396a2b085c1681a2d80de3ac326a231686d94379", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa793be3c9817b2eab6a867a396a2b085c1681a2d80de3ac326a231686d94379", kill_on_drop: false }` [INFO] [stdout] aa793be3c9817b2eab6a867a396a2b085c1681a2d80de3ac326a231686d94379