[INFO] cloning repository https://github.com/metalwarrior665/actor-rust-scraper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/metalwarrior665/actor-rust-scraper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmetalwarrior665%2Factor-rust-scraper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmetalwarrior665%2Factor-rust-scraper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ac2df5da457a348485b6f3a051ad280630770d98 [INFO] linting metalwarrior665/actor-rust-scraper against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmetalwarrior665%2Factor-rust-scraper" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/metalwarrior665/actor-rust-scraper [INFO] finished tweaking git repo https://github.com/metalwarrior665/actor-rust-scraper [INFO] tweaked toml for git repo https://github.com/metalwarrior665/actor-rust-scraper written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/metalwarrior665/actor-rust-scraper on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 256 packages to latest compatible versions [INFO] [stderr] Adding async-scoped v0.6.1 (available: v0.9.0) [INFO] [stderr] Adding parking_lot v0.11.2 (available: v0.12.5) [INFO] [stderr] Adding rand v0.3.23 (available: v0.10.0) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] [stderr] Adding scraper v0.12.0 (available: v0.26.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded markup5ever v0.10.1 [INFO] [stderr] Downloaded ego-tree v0.6.3 [INFO] [stderr] Downloaded pin-project v0.4.30 [INFO] [stderr] Downloaded query_params v0.1.0 [INFO] [stderr] Downloaded apify-client v0.2.0 [INFO] [stderr] Downloaded pin-project-internal v0.4.30 [INFO] [stderr] Downloaded async-scoped v0.6.1 [INFO] [stderr] Downloaded html5ever v0.25.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c42e8b600ffac4165368a5ba66a5d8e0527920e49e6bd483beda1e00a81f2535 [INFO] running `Command { std: "docker" "start" "-a" "c42e8b600ffac4165368a5ba66a5d8e0527920e49e6bd483beda1e00a81f2535", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c42e8b600ffac4165368a5ba66a5d8e0527920e49e6bd483beda1e00a81f2535", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c42e8b600ffac4165368a5ba66a5d8e0527920e49e6bd483beda1e00a81f2535", kill_on_drop: false }` [INFO] [stdout] c42e8b600ffac4165368a5ba66a5d8e0527920e49e6bd483beda1e00a81f2535 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8f2c2e597865fceef43de0b3bcb87a35d01fc85067412d7227534046be2f71b [INFO] running `Command { std: "docker" "start" "-a" "a8f2c2e597865fceef43de0b3bcb87a35d01fc85067412d7227534046be2f71b", kill_on_drop: false }` [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Checking compression-core v0.4.31 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking dtoa v1.0.11 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking dtoa-short v0.3.5 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking thin-slice v0.1.1 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking getopts v0.2.24 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking ego-tree v0.6.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking compression-codecs v0.4.37 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Compiling query_params v0.1.0 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling cssparser v0.27.2 [INFO] [stderr] Compiling html5ever v0.25.2 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking async-compression v0.4.41 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Checking async-scoped v0.6.1 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Compiling markup5ever v0.10.1 [INFO] [stderr] Compiling selectors v0.22.0 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking scraper v0.12.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking apify-client v0.2.0 [INFO] [stderr] Checking crawler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/basic_crawler.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | let _ = scope.collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/basic_crawler.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | let _ = scope.collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basic_crawler.rs:237:33 [INFO] [stdout] | [INFO] [stdout] 237 | let html = request_text(&url, &basic_crawler.proxy_client).await?; [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basic_crawler.rs:237:33 [INFO] [stdout] | [INFO] [stdout] 237 | let html = request_text(&url, &basic_crawler.proxy_client).await?; [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basic_crawler.rs:261:80 [INFO] [stdout] | [INFO] [stdout] 261 | ... ExtractType::Attribute(at) => element.value().attr(&at).unwrap().to_owned() [INFO] [stdout] | ^^^ help: change this to: `at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/basic_crawler.rs:261:80 [INFO] [stdout] | [INFO] [stdout] 261 | ... ExtractType::Attribute(at) => element.value().attr(&at).unwrap().to_owned() [INFO] [stdout] | ^^^ help: change this to: `at` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/input.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_options (self) -> BasicCrawlerOptions { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/input.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_options (self) -> BasicCrawlerOptions { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/storage.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / match env::var("APIFY_IS_AT_HOME") { [INFO] [stdout] 9 | | Ok(ref x) if x == "1" => true, [INFO] [stdout] 10 | | _ => false [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 8 - match env::var("APIFY_IS_AT_HOME") { [INFO] [stdout] 9 - Ok(ref x) if x == "1" => true, [INFO] [stdout] 10 - _ => false [INFO] [stdout] 11 - } [INFO] [stdout] 8 + matches!(env::var("APIFY_IS_AT_HOME"), Ok(ref x) if x == "1") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/storage.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | from_str(&json).or_else(|err| Err(Box::new(err) as Box)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_str(&json).map_err(|err| Box::new(err) as Box)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/storage.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | Ok(client.get(url).send().await?.text().await?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 77 - Ok(client.get(url).send().await?.text().await?) [INFO] [stdout] 77 + client.get(url).send().await?.text().await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/storage.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / match env::var("APIFY_IS_AT_HOME") { [INFO] [stdout] 9 | | Ok(ref x) if x == "1" => true, [INFO] [stdout] 10 | | _ => false [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 8 - match env::var("APIFY_IS_AT_HOME") { [INFO] [stdout] 9 - Ok(ref x) if x == "1" => true, [INFO] [stdout] 10 - _ => false [INFO] [stdout] 11 - } [INFO] [stdout] 8 + matches!(env::var("APIFY_IS_AT_HOME"), Ok(ref x) if x == "1") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/actor.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 27 | if force_cloud && !self.client.optional_token.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.client.optional_token.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/storage.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | from_str(&json).or_else(|err| Err(Box::new(err) as Box)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_str(&json).map_err(|err| Box::new(err) as Box)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/utils.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | / match std::env::var("APIFY_IS_AT_HOME") { [INFO] [stdout] 3 | | Ok(ref x) if x == "1" => true, [INFO] [stdout] 4 | | _ => false [INFO] [stdout] 5 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 2 - match std::env::var("APIFY_IS_AT_HOME") { [INFO] [stdout] 3 - Ok(ref x) if x == "1" => true, [INFO] [stdout] 4 - _ => false [INFO] [stdout] 5 - } [INFO] [stdout] 2 + matches!(std::env::var("APIFY_IS_AT_HOME"), Ok(ref x) if x == "1") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/storage.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | Ok(client.get(url).send().await?.text().await?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 77 - Ok(client.get(url).send().await?.text().await?) [INFO] [stdout] 77 + client.get(url).send().await?.text().await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/actor.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 27 | if force_cloud && !self.client.optional_token.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.client.optional_token.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/utils.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | / match std::env::var("APIFY_IS_AT_HOME") { [INFO] [stdout] 3 | | Ok(ref x) if x == "1" => true, [INFO] [stdout] 4 | | _ => false [INFO] [stdout] 5 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 2 - match std::env::var("APIFY_IS_AT_HOME") { [INFO] [stdout] 3 - Ok(ref x) if x == "1" => true, [INFO] [stdout] 4 - _ => false [INFO] [stdout] 5 - } [INFO] [stdout] 2 + matches!(std::env::var("APIFY_IS_AT_HOME"), Ok(ref x) if x == "1") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.66s [INFO] running `Command { std: "docker" "inspect" "a8f2c2e597865fceef43de0b3bcb87a35d01fc85067412d7227534046be2f71b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8f2c2e597865fceef43de0b3bcb87a35d01fc85067412d7227534046be2f71b", kill_on_drop: false }` [INFO] [stdout] a8f2c2e597865fceef43de0b3bcb87a35d01fc85067412d7227534046be2f71b