[INFO] cloning repository https://github.com/melon-masou/kotolive [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/melon-masou/kotolive" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmelon-masou%2Fkotolive", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmelon-masou%2Fkotolive'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9265da37a9c6370e2e729d66dd41b6c4e3a73720 [INFO] linting melon-masou/kotolive against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmelon-masou%2Fkotolive" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/melon-masou/kotolive [INFO] finished tweaking git repo https://github.com/melon-masou/kotolive [INFO] tweaked toml for git repo https://github.com/melon-masou/kotolive written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/melon-masou/kotolive on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/melon-masou/kotolive already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-tungstenite v0.26.2 [INFO] [stderr] Downloaded core-graphics-types v0.2.0 [INFO] [stderr] Downloaded glob v0.3.2 [INFO] [stderr] Downloaded serde_path_to_error v0.1.17 [INFO] [stderr] Downloaded axum-core v0.5.2 [INFO] [stderr] Downloaded core-graphics v0.25.0 [INFO] [stderr] Downloaded iana-time-zone v0.1.63 [INFO] [stderr] Downloaded clap v4.5.42 [INFO] [stderr] Downloaded hyper-util v0.1.16 [INFO] [stderr] Downloaded enigo v0.5.0 [INFO] [stderr] Downloaded nom v8.0.0 [INFO] [stderr] Downloaded pest v2.8.1 [INFO] [stderr] Downloaded axum v0.8.4 [INFO] [stderr] Downloaded clap_builder v4.5.42 [INFO] [stderr] Downloaded deunicode v1.6.2 [INFO] [stderr] Downloaded aws-lc-rs v1.13.3 [INFO] [stderr] Downloaded serde_json v1.0.142 [INFO] [stderr] Downloaded cc v1.2.31 [INFO] [stderr] Downloaded security-framework v3.3.0 [INFO] [stderr] Downloaded rustls v0.23.31 [INFO] [stderr] Downloaded jiff-static v0.2.15 [INFO] [stderr] Downloaded bstr v1.12.0 [INFO] [stderr] Downloaded prettyplease v0.2.36 [INFO] [stderr] Downloaded pest_meta v2.8.1 [INFO] [stderr] Downloaded pest_derive v2.8.1 [INFO] [stderr] Downloaded clap_derive v4.5.41 [INFO] [stderr] Downloaded env_logger v0.11.8 [INFO] [stderr] Downloaded globset v0.4.16 [INFO] [stderr] Downloaded pest_generator v2.8.1 [INFO] [stderr] Downloaded tungstenite v0.26.2 [INFO] [stderr] Downloaded jiff v0.2.15 [INFO] [stderr] Downloaded aws-lc-sys v0.30.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e628143792da78a9b22f4fff3291d1c6af7a79d01eeec3756093853ca974668 [INFO] running `Command { std: "docker" "start" "-a" "7e628143792da78a9b22f4fff3291d1c6af7a79d01eeec3756093853ca974668", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e628143792da78a9b22f4fff3291d1c6af7a79d01eeec3756093853ca974668", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e628143792da78a9b22f4fff3291d1c6af7a79d01eeec3756093853ca974668", kill_on_drop: false }` [INFO] [stdout] 7e628143792da78a9b22f4fff3291d1c6af7a79d01eeec3756093853ca974668 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 85493c6acc5fd7229ef246e6acdda19bd5d790efe5fd2476024a9399512b4294 [INFO] running `Command { std: "docker" "start" "-a" "85493c6acc5fd7229ef246e6acdda19bd5d790efe5fd2476024a9399512b4294", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling siphasher v1.0.1 [INFO] [stderr] Compiling aws-lc-rs v1.13.3 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Compiling rustls v0.23.31 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling cc v1.2.31 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Compiling serde_json v1.0.142 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking rustls-native-certs v0.8.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking memmap2 v0.9.7 [INFO] [stderr] Checking deunicode v1.6.2 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking clap_builder v4.5.42 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking jiff v0.2.15 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking axum-core v0.5.2 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking xkbcommon v0.8.0 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling aws-lc-sys v0.30.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking globset v0.4.16 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking ignore v0.4.23 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking pest v2.8.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking clap v4.5.42 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Compiling pest_meta v2.8.1 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Compiling pest_generator v2.8.1 [INFO] [stderr] Compiling pest_derive v2.8.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.11 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking enigo v0.5.0 [INFO] [stderr] Checking tungstenite v0.26.2 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tokio-tungstenite v0.26.2 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking axum v0.8.4 [INFO] [stderr] Checking kotolive v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | / impl Default for AgentControlMode { [INFO] [stdout] 53 | | fn default() -> Self { [INFO] [stdout] 54 | | Self::Screen [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 47 + #[derive(Default)] [INFO] [stdout] 48 | pub enum AgentControlMode { [INFO] [stdout] 49 ~ #[default] [INFO] [stdout] 50 ~ Screen, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | / impl Default for AgentControlMode { [INFO] [stdout] 53 | | fn default() -> Self { [INFO] [stdout] 54 | | Self::Screen [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 47 + #[derive(Default)] [INFO] [stdout] 48 | pub enum AgentControlMode { [INFO] [stdout] 49 ~ #[default] [INFO] [stdout] 50 ~ Screen, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/protocol.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / match &cmd.payload { [INFO] [stdout] 80 | | RemotePayload::MouseMove { .. } => true, [INFO] [stdout] 81 | | RemotePayload::MouseDown { .. } => true, [INFO] [stdout] 82 | | RemotePayload::MouseUp { .. } => true, [INFO] [stdout] ... | [INFO] [stdout] 86 | | _ => false, [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 79 - match &cmd.payload { [INFO] [stdout] 80 - RemotePayload::MouseMove { .. } => true, [INFO] [stdout] 81 - RemotePayload::MouseDown { .. } => true, [INFO] [stdout] 82 - RemotePayload::MouseUp { .. } => true, [INFO] [stdout] 83 - RemotePayload::Scroll { .. } => true, [INFO] [stdout] 84 - RemotePayload::KeyDown { .. } => true, [INFO] [stdout] 85 - RemotePayload::KeyUp { .. } => true, [INFO] [stdout] 86 - _ => false, [INFO] [stdout] 87 - } [INFO] [stdout] 79 + matches!(&cmd.payload, RemotePayload::MouseMove { .. } | RemotePayload::MouseDown { .. } | RemotePayload::MouseUp { .. } | RemotePayload::Scroll { .. } | RemotePayload::KeyDown { .. } | RemotePayload::KeyUp { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils.rs:21:41 [INFO] [stdout] | [INFO] [stdout] 21 | Some(src) => format!("{}: {}", e.to_string(), detailed_error(src)), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/utils.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn recv_timeout( [INFO] [stdout] 27 | | rt: &Runtime, [INFO] [stdout] 28 | | receiver: &mut Receiver, [INFO] [stdout] 29 | | duration: Duration, [INFO] [stdout] 30 | | ) -> Result, ()> { [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | let tx = match map.get_mut(&key) { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:118:19 [INFO] [stdout] | [INFO] [stdout] 118 | pool: &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:126:36 [INFO] [stdout] | [INFO] [stdout] 126 | let rx = match map.get_mut(&key) { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:137:19 [INFO] [stdout] | [INFO] [stdout] 137 | pool: &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/agent/control.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | state.need_focus_window = matches!(c.agent.control.mode, AgentControlMode::Window); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `agent::event::ControlState { need_focus_window: matches!(c.agent.control.mode, AgentControlMode::Window), cfg: c.agent.control.clone(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/agent/control.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | let mut state = ControlState::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/agent/control.rs:82:16 [INFO] [stdout] | [INFO] [stdout] 82 | if ensure_focus_window(w.handle, state.cfg.window_force_focus).is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 82 ~ if { [INFO] [stdout] 83 + let _: () = w.handle; [INFO] [stdout] 84 + ensure_focus_window((), state.cfg.window_force_focus) [INFO] [stdout] 85 ~ }.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/agent/control.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | if ensure_focus_window(w.handle, state.cfg.window_force_focus).is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 147 ~ if { [INFO] [stdout] 148 + let _: () = w.handle; [INFO] [stdout] 149 + ensure_focus_window((), state.cfg.window_force_focus) [INFO] [stdout] 150 ~ }.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/agent/control.rs:275:11 [INFO] [stdout] | [INFO] [stdout] 275 | koto: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 275 ~ koto: &str, [INFO] [stdout] 276 | control_tx: mpsc::Sender, [INFO] [stdout] ... [INFO] [stdout] 279 | .send_cmd(&RemoteCommand { [INFO] [stdout] 280 ~ payload: RemotePayload::ControlServe { koto: koto.to_owned() }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/protocol.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | / match &cmd.payload { [INFO] [stdout] 80 | | RemotePayload::MouseMove { .. } => true, [INFO] [stdout] 81 | | RemotePayload::MouseDown { .. } => true, [INFO] [stdout] 82 | | RemotePayload::MouseUp { .. } => true, [INFO] [stdout] ... | [INFO] [stdout] 86 | | _ => false, [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 79 - match &cmd.payload { [INFO] [stdout] 80 - RemotePayload::MouseMove { .. } => true, [INFO] [stdout] 81 - RemotePayload::MouseDown { .. } => true, [INFO] [stdout] 82 - RemotePayload::MouseUp { .. } => true, [INFO] [stdout] 83 - RemotePayload::Scroll { .. } => true, [INFO] [stdout] 84 - RemotePayload::KeyDown { .. } => true, [INFO] [stdout] 85 - RemotePayload::KeyUp { .. } => true, [INFO] [stdout] 86 - _ => false, [INFO] [stdout] 87 - } [INFO] [stdout] 79 + matches!(&cmd.payload, RemotePayload::MouseMove { .. } | RemotePayload::MouseDown { .. } | RemotePayload::MouseUp { .. } | RemotePayload::Scroll { .. } | RemotePayload::KeyDown { .. } | RemotePayload::KeyUp { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/agent/control.rs:310:25 [INFO] [stdout] | [INFO] [stdout] 310 | / match &mut cmd.payload { [INFO] [stdout] 311 | | RemotePayload::SessionPing { agent_ts, .. } => { [INFO] [stdout] 312 | | *agent_ts = Some(timestamp_ms()); [INFO] [stdout] 313 | | let _ = transport.send_cmd(&cmd).await; [INFO] [stdout] 314 | | } [INFO] [stdout] 315 | | _ => {} [INFO] [stdout] 316 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 310 ~ if let RemotePayload::SessionPing { agent_ts, .. } = &mut cmd.payload { [INFO] [stdout] 311 + *agent_ts = Some(timestamp_ms()); [INFO] [stdout] 312 + let _ = transport.send_cmd(&cmd).await; [INFO] [stdout] 313 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/agent/event.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_absolute(&self, x_percent: i32, y_percent: i32, percent_base: i32) -> (i32, i32) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils.rs:21:41 [INFO] [stdout] | [INFO] [stdout] 21 | Some(src) => format!("{}: {}", e.to_string(), detailed_error(src)), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/utils.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn recv_timeout( [INFO] [stdout] 27 | | rt: &Runtime, [INFO] [stdout] 28 | | receiver: &mut Receiver, [INFO] [stdout] 29 | | duration: Duration, [INFO] [stdout] 30 | | ) -> Result, ()> { [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/agent/mod.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | mod agent; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:107:36 [INFO] [stdout] | [INFO] [stdout] 107 | let tx = match map.get_mut(&key) { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:118:19 [INFO] [stdout] | [INFO] [stdout] 118 | pool: &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:126:36 [INFO] [stdout] | [INFO] [stdout] 126 | let rx = match map.get_mut(&key) { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:137:19 [INFO] [stdout] | [INFO] [stdout] 137 | pool: &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/agent/control.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | state.need_focus_window = matches!(c.agent.control.mode, AgentControlMode::Window); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `agent::event::ControlState { need_focus_window: matches!(c.agent.control.mode, AgentControlMode::Window), cfg: c.agent.control.clone(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/agent/control.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | let mut state = ControlState::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/agent/control.rs:82:16 [INFO] [stdout] | [INFO] [stdout] 82 | if ensure_focus_window(w.handle, state.cfg.window_force_focus).is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 82 ~ if { [INFO] [stdout] 83 + let _: () = w.handle; [INFO] [stdout] 84 + ensure_focus_window((), state.cfg.window_force_focus) [INFO] [stdout] 85 ~ }.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/agent/control.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 147 | if ensure_focus_window(w.handle, state.cfg.window_force_focus).is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 147 ~ if { [INFO] [stdout] 148 + let _: () = w.handle; [INFO] [stdout] 149 + ensure_focus_window((), state.cfg.window_force_focus) [INFO] [stdout] 150 ~ }.is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/agent/control.rs:275:11 [INFO] [stdout] | [INFO] [stdout] 275 | koto: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 275 ~ koto: &str, [INFO] [stdout] 276 | control_tx: mpsc::Sender, [INFO] [stdout] ... [INFO] [stdout] 279 | .send_cmd(&RemoteCommand { [INFO] [stdout] 280 ~ payload: RemotePayload::ControlServe { koto: koto.to_owned() }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/agent/control.rs:310:25 [INFO] [stdout] | [INFO] [stdout] 310 | / match &mut cmd.payload { [INFO] [stdout] 311 | | RemotePayload::SessionPing { agent_ts, .. } => { [INFO] [stdout] 312 | | *agent_ts = Some(timestamp_ms()); [INFO] [stdout] 313 | | let _ = transport.send_cmd(&cmd).await; [INFO] [stdout] 314 | | } [INFO] [stdout] 315 | | _ => {} [INFO] [stdout] 316 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 310 ~ if let RemotePayload::SessionPing { agent_ts, .. } = &mut cmd.payload { [INFO] [stdout] 311 + *agent_ts = Some(timestamp_ms()); [INFO] [stdout] 312 + let _ = transport.send_cmd(&cmd).await; [INFO] [stdout] 313 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/agent/event.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_absolute(&self, x_percent: i32, y_percent: i32, percent_base: i32) -> (i32, i32) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/agent/mod.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | mod agent; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server/forward.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | / if let Some(ref client_id) = cmd.client_id { [INFO] [stdout] 144 | | if let Some(sess_tx) = sess_tx_map.get(client_id) { [INFO] [stdout] 145 | | let _ = sess_tx.send(cmd).await; [INFO] [stdout] 146 | | } [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 143 ~ if let Some(ref client_id) = cmd.client_id [INFO] [stdout] 144 ~ && let Some(sess_tx) = sess_tx_map.get(client_id) { [INFO] [stdout] 145 | let _ = sess_tx.send(cmd).await; [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/server/forward.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 190 | client_id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 190 ~ client_id: &str, [INFO] [stdout] 191 | sess_tx: mpsc::Sender, [INFO] [stdout] ... [INFO] [stdout] 210 | .send(SessionRequest { [INFO] [stdout] 211 ~ client_id: client_id.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/server/forward.rs:225:20 [INFO] [stdout] | [INFO] [stdout] 225 | if let Some(_) = m.get(koto) { [INFO] [stdout] | -------^^^^^^^-------------- help: try: `if m.get(koto).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/server/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | mod server; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/server/server.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 78 | if c.server.player_template != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!c.server.player_template.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server/forward.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | / if let Some(ref client_id) = cmd.client_id { [INFO] [stdout] 144 | | if let Some(sess_tx) = sess_tx_map.get(client_id) { [INFO] [stdout] 145 | | let _ = sess_tx.send(cmd).await; [INFO] [stdout] 146 | | } [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 143 ~ if let Some(ref client_id) = cmd.client_id [INFO] [stdout] 144 ~ && let Some(sess_tx) = sess_tx_map.get(client_id) { [INFO] [stdout] 145 | let _ = sess_tx.send(cmd).await; [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/server/forward.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 190 | client_id: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 190 ~ client_id: &str, [INFO] [stdout] 191 | sess_tx: mpsc::Sender, [INFO] [stdout] ... [INFO] [stdout] 210 | .send(SessionRequest { [INFO] [stdout] 211 ~ client_id: client_id.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/server/forward.rs:225:20 [INFO] [stdout] | [INFO] [stdout] 225 | if let Some(_) = m.get(koto) { [INFO] [stdout] | -------^^^^^^^-------------- help: try: `if m.get(koto).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/server/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | mod server; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/server/server.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 78 | if c.server.player_template != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!c.server.player_template.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 15s [INFO] running `Command { std: "docker" "inspect" "85493c6acc5fd7229ef246e6acdda19bd5d790efe5fd2476024a9399512b4294", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85493c6acc5fd7229ef246e6acdda19bd5d790efe5fd2476024a9399512b4294", kill_on_drop: false }` [INFO] [stdout] 85493c6acc5fd7229ef246e6acdda19bd5d790efe5fd2476024a9399512b4294